vitaliyf (Vitaliy Filippov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
May 7 2019, 11:24 PM (72 w, 1 d)
Availability
Available

Recent Activity

May 27 2019

vitaliyf added a comment to D21076: ICC Color Correction Effect.

How to wrap it into a custom deleter? It's an internal pointer type of LCMS... Even a custom class with destructor seems simpler...

May 27 2019, 11:25 AM · KWin
vitaliyf added a comment to D21076: ICC Color Correction Effect.

So, can you merge it? :)

May 27 2019, 10:22 AM · KWin

May 16 2019

vitaliyf added a comment to D21076: ICC Color Correction Effect.

It being impossible would certainly be a very compelling reason to do it at this layer instead. I would support something along these lines if that's the case.

Though your comment doesn't match the docs I've seen on the colord site. I'll poke a Mutter dev and see what they're doing.

May 16 2019, 11:45 PM · KWin

May 13 2019

vitaliyf updated the diff for D21076: ICC Color Correction Effect.
May 13 2019, 4:22 PM · KWin
vitaliyf added inline comments to D21076: ICC Color Correction Effect.
May 13 2019, 4:22 PM · KWin
vitaliyf added a comment to D21076: ICC Color Correction Effect.

If we are going to do all windows, what does this offer over xcalib?

May 13 2019, 1:42 PM · KWin
vitaliyf added a comment to D21076: ICC Color Correction Effect.

Yes, I know. I even tested it 5 or 6 years ago. I think that implementation was really clunky because it depended on Oyranos which is unavailable in most distros, and instead of being implemented as an effect it was patching shader code of other effects before compiling them. There was a whole 2 or 3 screen long function that was doing it. My implementation is much simpler and it only depends on LCMS2.

May 13 2019, 10:38 AM · KWin
vitaliyf updated the diff for D21076: ICC Color Correction Effect.

Removed translation, commented code and curly braces style

May 13 2019, 8:45 AM · KWin

May 8 2019

vitaliyf added a comment to D21076: ICC Color Correction Effect.

Thanks! :) OK, I'll remove translated text

May 8 2019, 9:33 AM · KWin

May 7 2019

vitaliyf requested review of D21076: ICC Color Correction Effect.
May 7 2019, 11:28 PM · KWin