siddharthasahu (Siddhartha Sahu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Apr 18 2015, 4:44 AM (235 w, 1 d)
Availability
Available

Recent Activity

Jul 19 2019

siddharthasahu added a comment to D21002: Remove kde4 migration agent completely.

Do I have to reset something on my machine after this?

Jul 19 2019, 5:21 AM · Frameworks

Jun 23 2019

siddharthasahu added a comment to D19310: Port to KGlobalAccel.

No problem! I noticed 2 other things:

Jun 23 2019, 7:40 AM · Spectacle
siddharthasahu added a comment to D19310: Port to KGlobalAccel.

Looks like a copy-paste bug.

Jun 23 2019, 1:16 AM · Spectacle

Jun 1 2019

siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

I took another look. As I already mentioned, there seems to be a difference between how onLoginFailed signals work in both.
In the lock screen:

  • the onLoginFailed signal is delivered as soon as the password is detected to be incorrec. I use this signal to selectAll() the password text so the user can start editing.
  • The grace timeout is a separate signal onGraceLockedChanged, which is used to clear the "Login failed" message.

To summarize, the flow is: (enter password) --> (loginFailed) --[authenticator timeout expires]--> (graceLockedChanged).

Jun 1 2019, 6:16 PM · Plasma

May 31 2019

siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

Friendly ping! Since the behaviour is already different, can we merge this one and work on the SDDM part in a later PR?

May 31 2019, 9:35 PM · Plasma

May 13 2019

siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

Hi David!

May 13 2019, 9:59 PM · Plasma
siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

This one was easy enough. I definitely liked the fact that I could edit the qml files directly and test it live without going through a compilation step. I especially enjoyed it after I managed to crash the lock screen with a typo but was able to fix the stuck lock screen by editing the qml file in a tty and killing the lockscreen process to make it reload. On the other hand, a compilation step here would've prevented this in the first place!

May 13 2019, 6:12 PM · Plasma
siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

Cool! Thank you for the pointers to the correct place. It was much easier than I thought once I looked at the code.

May 13 2019, 6:01 PM · Plasma
siddharthasahu added a comment to D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

That's correct. 2 points however:

May 13 2019, 5:47 PM · Plasma
siddharthasahu updated the diff for D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.

Update diff to master.

May 13 2019, 5:32 PM · Plasma
siddharthasahu added a reviewer for D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end: ngraham.
May 13 2019, 5:04 PM · Plasma
siddharthasahu requested review of D21192: Allow user to edit wrong password on lockscreen while waiting for graceLocked period to end.
May 13 2019, 5:01 PM · Plasma

Jul 16 2018

siddharthasahu added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

Thank you for the clarification @bcooksley. I wonder if there is a way to enforce compilation of certain parts single threaded in make. Or some other way to ensure testing these components.

Jul 16 2018, 7:48 PM · Frameworks

Jul 15 2018

siddharthasahu added a comment to D13583: KFormat: Allow usage of quantities beyond bytes and seconds.

Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl

Jul 15 2018, 3:18 PM · Frameworks

Aug 8 2017

siddharthasahu committed R32:c914b99db135: Prevent konsole commands from appearing in the shell history (authored by siddharthasahu).
Prevent konsole commands from appearing in the shell history
Aug 8 2017, 4:53 PM