User Details
User Details
- User Since
- Mar 21 2019, 2:51 AM (265 w, 6 d)
- Availability
- Available
Apr 18 2019
Apr 18 2019
rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Is there something I still need to do here? I was on vacation.
Mar 26 2019
Mar 26 2019
rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Also, I tested with VS2017, and everything seemed to work.
The current patch set reflects changes made since that test.
rboylan updated the diff for D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
I think this responds to most of the first round comments.
VS2017 is now the default choice, although I have not hidden VS2019 as you suggested.
The other oddity I noticed is that the Qt version is lower in my version than yours.
The diff is against 738d01f314235d89691d20f78b0cdd689f059779 refs/remotes/origin/master
with
origin https://github.com/KDE/craft.git (fetch)
Mar 24 2019
Mar 24 2019
rboylan updated the summary of D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
rboylan added a comment to D19933: Add ability to use MSVS 2019 and pre-release versions of MSVS. Fix other nits..
Thank you for your rapid response.
Mar 21 2019
Mar 21 2019