- User Since
- Feb 1 2018, 7:46 PM (19 w, 6 d)
Mar 10 2018
Added my name to the licensing info.
Mar 9 2018
That's great, but could you please push it for me. I don't know how much more development I'll be doing on Krita this time around, as I've got a 110 page comic book waiting for me to pencil and ink, alongside full time employment, which will likely eat up most of my time. I do plan to come more back to Krita once I'm done with the comic, but that will likely be in around a years time or so. :)
Mar 8 2018
Use setLayoutDirection to flip the direction of the whole dialog, instead of adding and removing widgets, this flips both the pages and the buttons, which is perfect, and makes the code much simpler. The arrow keyboard shortcuts are pretty much the same as before.
Mar 6 2018
Fixed the alignment issue, so it now works correctly. The issue was that there was a QImage within a QPushButton, and the image needed to be aligned within the button.
I tried adding addStretch to either end of the surrounding QHBoxLayout that the pages are in, but it seems to not work with the size policy MinimimumExpanding or Expanding. With addStretch on either side, they simply stop expanding when they reach their SizeHint. I've attached a simpler example, which I've used to try out different solutions, but nothing I've done so far has worked correctly.
EPub is mostly used by e-readers, which tend to have small screens, so I would be skeptical doing any thing that adds more margins around the comics page. I've actually bought EPub comic books, that I've wound up running through ImageMagick to get rid of unnecessarily wide margins, to make the pages larger and more readable on my Kobo Aura One.
Mar 5 2018
Yep, when explained, having Conecept makes sense.
Added a first implementation of this in patch D11076
Mar 4 2018
Since I've begun hacking a bit away at the Comic Project reader, I figured it might be a good idea to add some of my thoughts here. I'm pretty close to finishing T8139, just a bit stumped on some layout alignment stuff and a couple of improvements I want to make to it. :)
Mar 3 2018
Feb 4 2018
Yes, I noticed that it was intentional when I read the comments in the code, but I first thought it was a bug when I tried the Comics Manager.