ovichiro (Ovidiu Chi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
May 29 2018, 7:48 PM (97 w, 11 h)
Availability
Available

Recent Activity

Feb 4 2020

ovichiro added a comment to D26895: Introduce an Info Center mode.

Sounds sensible. Would you like to submit a patch?

Feb 4 2020, 2:08 PM · Plasma

Feb 3 2020

ovichiro added inline comments to D26895: Introduce an Info Center mode.
Feb 3 2020, 6:26 PM · Plasma
ovichiro added a comment to D26895: Introduce an Info Center mode.

Not sure it's my place to do so, but I'd like to make a small comment.
Instead of passing mode around and all the if statements, wouldn't it be better to have a single decision point in main.cpp, like a factory class?
Use polymorphism and create something like InfoCenter : CommonParent, SystemSettings : CommonParent, each knowing how to initialize their KAboutData, GUI elements, icons etc.?
And in main.cpp do something like CommonParent * commonParent = new InfoCenter() // or new SystemSettings() and use that instead of mode.
Further down the road, if you need to add something to system settings, you could do it in the SystemSettings class maybe and not have to add another if to remove it from the InfoCenter part. Just a thought, not sure if it fits.

Feb 3 2020, 2:10 PM · Plasma