nkosjar (Nikolai Kosjar)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 2 2019, 1:47 PM (10 w, 3 d)
Availability
Available

Recent Activity

Oct 9 2019

nkosjar updated the test plan for D24506: Fix build with MSVC.
Oct 9 2019, 11:01 AM
nkosjar added a comment to D24506: Fix build with MSVC.

WIP as I still need to test this properly with MSVC.

Oct 9 2019, 8:44 AM
nkosjar requested review of D24506: Fix build with MSVC.
Oct 9 2019, 8:43 AM

Sep 24 2019

nkosjar closed D24017: Fix accepting LLVM_ROOT with cmake >= 3.12.
Sep 24 2019, 9:02 AM

Sep 17 2019

nkosjar requested review of D24017: Fix accepting LLVM_ROOT with cmake >= 3.12.
Sep 17 2019, 7:43 AM
nkosjar requested review of D24016: Fix linking against upcoming llvm/clang 9.0.
Sep 17 2019, 7:43 AM

Sep 13 2019

nkosjar added a comment to D23872: Add '-list-checks' command line option.

Feel free to release 1.6 :)

Sep 13 2019, 2:24 PM
nkosjar committed R74:e0bcef5451fe: Add '-list-checks' command line option (authored by nkosjar).
Add '-list-checks' command line option
Sep 13 2019, 2:23 PM
nkosjar closed D23872: Add '-list-checks' command line option.
Sep 13 2019, 2:23 PM
nkosjar committed R74:f23173b01197: Remove unused parameter (authored by nkosjar).
Remove unused parameter
Sep 13 2019, 2:23 PM
nkosjar closed D23871: Remove unused parameter.
Sep 13 2019, 2:23 PM
nkosjar closed D23680: Add '-supported-checks-json' command line option.
Sep 13 2019, 2:22 PM
nkosjar committed R74:cc9c5da74beb: Add '-supported-checks-json' command line option (authored by nkosjar).
Add '-supported-checks-json' command line option
Sep 13 2019, 2:22 PM
nkosjar added a comment to D23680: Add '-supported-checks-json' command line option.

Looks fine!

Since you're the copyright holder, would you agree to an eventual clazy copyright change to something BSD style ?

Sep 13 2019, 11:38 AM
nkosjar added a comment to D23870: README: Fix old checker name.

do you have commit rights ?

Sep 13 2019, 7:19 AM
nkosjar closed D23870: README: Fix old checker name.
Sep 13 2019, 7:18 AM
nkosjar committed R74:b2cf7f8cf461: README: Fix old checker name (authored by nkosjar).
README: Fix old checker name
Sep 13 2019, 7:18 AM

Sep 11 2019

nkosjar added a dependent revision for D23680: Add '-supported-checks-json' command line option: D23871: Remove unused parameter.
Sep 11 2019, 2:10 PM
nkosjar added a dependency for D23871: Remove unused parameter: D23680: Add '-supported-checks-json' command line option.
Sep 11 2019, 2:10 PM
nkosjar removed a dependent revision for D23680: Add '-supported-checks-json' command line option: D23872: Add '-list-checks' command line option.
Sep 11 2019, 2:10 PM
nkosjar removed a dependency for D23872: Add '-list-checks' command line option: D23680: Add '-supported-checks-json' command line option.
Sep 11 2019, 2:10 PM
nkosjar added a dependent revision for D23871: Remove unused parameter: D23872: Add '-list-checks' command line option.
Sep 11 2019, 2:09 PM
nkosjar added a dependency for D23872: Add '-list-checks' command line option: D23871: Remove unused parameter.
Sep 11 2019, 2:09 PM
nkosjar updated the diff for D23872: Add '-list-checks' command line option.

Also handles the case now where no file is specified on the cmd line.

Sep 11 2019, 2:08 PM
nkosjar updated the diff for D23871: Remove unused parameter.

Rebased only.

Sep 11 2019, 2:08 PM
nkosjar updated the diff for D23680: Add '-supported-checks-json' command line option.

Rebased only.

Sep 11 2019, 2:07 PM
nkosjar added a dependency for D23872: Add '-list-checks' command line option: D23680: Add '-supported-checks-json' command line option.
Sep 11 2019, 9:44 AM
nkosjar added a dependent revision for D23680: Add '-supported-checks-json' command line option: D23872: Add '-list-checks' command line option.
Sep 11 2019, 9:44 AM
nkosjar added a reviewer for D23872: Add '-list-checks' command line option: smartins.
Sep 11 2019, 9:43 AM
nkosjar requested review of D23872: Add '-list-checks' command line option.
Sep 11 2019, 9:43 AM
nkosjar requested review of D23871: Remove unused parameter.
Sep 11 2019, 9:34 AM
nkosjar added a reviewer for D23870: README: Fix old checker name: smartins.
Sep 11 2019, 9:32 AM
nkosjar requested review of D23870: README: Fix old checker name.
Sep 11 2019, 9:32 AM

Sep 10 2019

nkosjar added a comment to D23680: Add '-supported-checks-json' command line option.

Side note: How to tell "arc" to update the commit message, too?

Sep 10 2019, 2:14 PM
nkosjar retitled D23680: Add '-supported-checks-json' command line option from Add '-meta-checks' command line option to Add '-supported-checks-json' command line option.
Sep 10 2019, 2:14 PM
nkosjar updated the diff for D23680: Add '-supported-checks-json' command line option.

Changed the cmd line option name.

Sep 10 2019, 2:13 PM
nkosjar added a comment to D23680: Add '-supported-checks-json' command line option.

Should this option consider the checks provided with "-checks="? That would be in line with clang-tidy and would allow IDEs to query the checks enabled by default (providing -meta-checks but no -checks=).

Honoring -checks= would also mean that available_categories in checks.json needs to be adapted accordingly. That is, this patch would not only dump the compiled in string, but read the json, and filter it.

Maybe rename to -supported-checks-json , doesn't matter if it's too long, it's for IDE consumption only.
And, as the name suggests, it will print all supported checks.

Something that honours -checks can be orthogonal and be in another option. Also note that the CLAZY_CHECKS env var also influences the checks that are used.
Does this second option even need to be json based ? it can just output the list of enabled checks, and then you can cross-reference with the json you already have

Sep 10 2019, 2:13 PM
nkosjar added a comment to D23680: Add '-supported-checks-json' command line option.

I'm not sure whether "-meta-checks" is descriptive enough. Can't come up with a better name right now. Suggestions?

How do I run the tests properly? I've tried running tests/run_tests.py from the build dir, but this results in many errors...

cd tests/ && ./run_tests.py should work
also works in the build dir
maybe it's not finding the plugin for you

Sep 10 2019, 2:03 PM

Sep 3 2019

nkosjar added a comment to D23680: Add '-supported-checks-json' command line option.

Should this option consider the checks provided with "-checks="? That would be in line with clang-tidy and would allow IDEs to query the checks enabled by default (providing -meta-checks but no -checks=).

Sep 3 2019, 7:34 AM

Sep 2 2019

nkosjar added a reviewer for D23680: Add '-supported-checks-json' command line option: smartins.

I'm not sure whether "-meta-checks" is descriptive enough. Can't come up with a better name right now. Suggestions?

Sep 2 2019, 2:02 PM
nkosjar requested review of D23680: Add '-supported-checks-json' command line option.
Sep 2 2019, 1:55 PM