I agree with these changes.
Is it possible to disable warnings for particular folder and does that make sense at all (since the code is still there and compiling)?

Last time I tried playing ksirk over jabber network was during upgrade to Qt5. At that time it was defunct and Gael removed the label from the game selection panel. It looks like there's still a way to chose it trough menu.
Has that changed in the meantime?

Thanks, Christian!

I still can see the mainwindow.cpp, it looks like revision wasn't uploaded, not sure? There are just two revisions - latest from this morning - 10:12 AM.

I agree with all changes here, except mainwindow.cpp for which I assume was uploaded by mistake.

Does this fix issue (crash) on startup?

Once this is completed, I'll proceed with upgrading iris and kopete libs.

In D7044#131173, @kleag wrote:

I must admit that I did not test the xmpp part… And in fact it does not work. There is an error in connecting a socket error signal. That should at least be corrected.

But I just tried too a Jabber based game on the ksirk currently available on KDE Neon and it does not work either. But this time the console output gives useful information.

I propose to correct the evident bug to have a situation in par with the current released version and then to push these changes before trying to make the Jabber work again with the new versions you worked on. In this case, should we remove the Jabber option from the GUI while it is not working ?

At this point, my first attempt to remove kdelibs4support was almost the same. However, I haven't submitted the change. There are two main reasons for this:

1. I haven't tested xmpp part of the game, even everything else worked good
2. Irislib and jabber part are outdated and there are newer versions available