msdobrescu (Mihai Sorin Dobrescu)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Mar 31 2019, 6:31 AM (29 w, 3 d)
Availability
Available

Recent Activity

Jul 9 2019

msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Could it be some threading issue?

Jul 9 2019, 10:06 AM · Plasma

Jul 8 2019

msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Thanks, selecting from any image is useful, to avoid starting always from the top one. But should not enable the button until a check is done.

Jul 8 2019, 9:26 AM · Plasma
msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

I'd say it is some half-implemented feature, probably. Could it be useful to navigate by keyboard and check/uncheck images, by using space, for example?

Jul 8 2019, 9:13 AM · Plasma
msdobrescu added a comment to D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

I guess one drawback is that you have to reindex all the files when the sort mode is changed.

Jul 8 2019, 8:44 AM · Plasma

Jul 7 2019

msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Is it more efficient from the performance point of view to have a QSortFilterProxyModel class per sorting method? I have a 6000 images case, would that be consuming compared to setting the sort class once according to the sorting method?

Jul 7 2019, 6:37 PM · Plasma
msdobrescu added a comment to D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths.

i.e
If I have two paths dirA and dirB and want things sorted by date this patch will have all the images in dirA sorted by date, followed by all the images in dirB sorted by date.

So for those reasons I think the other patch addresses works a bit better handling it dynamically, also allowing us to get rid of one of the model instances.

Jul 7 2019, 6:17 PM · Plasma
msdobrescu updated the test plan for D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.
Jul 7 2019, 4:54 PM · Plasma
msdobrescu updated the test plan for D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.
Jul 7 2019, 4:52 PM · Plasma
msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Besides that, did you know that if there are no wallpapers, could be added one or more by drag and drop?
Image files could be added by drag and drop, but never appear, although they are in the list, where should be folders only IMHO.
They stay there, nothing happens, no background change on the desktop.
Also, if one folder is added, 'Apply' button pressed, then removed, after 'Apply', the background remains set to the last image, although I would have expected to have no image set as wallpaper.

Jul 7 2019, 4:36 PM · Plasma
msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Indeed, at should crash, but when is that string empty?
I can't crash mine, although inherits the same code.

Jul 7 2019, 3:37 PM · Plasma
msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Ha Ha Ha! I know! I have asked you about, remember?
Sometimes the actual build goes bananas and needs a reset.

Jul 7 2019, 1:14 PM · Plasma
msdobrescu added a comment to D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders.

Huh, in a VM everything works for me too. I wonder if there's some subtle issue with the fact that I'm running a custom-compiled Plasma at a different path on bare metal.

Jul 7 2019, 8:04 AM · Plasma

Jul 5 2019

msdobrescu updated the diff for D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.
Jul 5 2019, 10:27 AM · Plasma
msdobrescu updated the diff for D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

Added Reversed, DirsFirst/DirsLast, IgnoreCase, LocaleAware options.

Jul 5 2019, 7:10 AM · Plasma

Jul 4 2019

msdobrescu added a comment to D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.

This is awkward timing.

See D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

Sorry

Jul 4 2019, 8:06 AM · Plasma
msdobrescu added a reviewer for D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC: Plasma.
Jul 4 2019, 5:29 AM · Plasma

Jul 3 2019

msdobrescu updated the summary of D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.
Jul 3 2019, 11:04 PM · Plasma
msdobrescu requested review of D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC.
Jul 3 2019, 11:01 PM · Plasma
msdobrescu updated the title for P423 Test diff for wallpapers slideshow sorting (POC - work in progress) from Test diff for wallpapers slideshow sorting (not working) to Test diff for wallpapers slideshow sorting (POC - work in progress).
Jul 3 2019, 10:48 PM
msdobrescu edited P423 Test diff for wallpapers slideshow sorting (POC - work in progress).
Jul 3 2019, 10:47 PM
msdobrescu edited P423 Test diff for wallpapers slideshow sorting (POC - work in progress).
Jul 3 2019, 9:32 PM
msdobrescu edited P423 Test diff for wallpapers slideshow sorting (POC - work in progress).
Jul 3 2019, 8:28 PM

Jun 29 2019

msdobrescu edited P423 Test diff for wallpapers slideshow sorting (POC - work in progress).
Jun 29 2019, 5:05 AM

Jun 28 2019

msdobrescu updated the title for P423 Test diff for wallpapers slideshow sorting (POC - work in progress) from Test diff for wallpapers slideshow sorting to Test diff for wallpapers slideshow sorting (not working).
Jun 28 2019, 6:41 PM
msdobrescu created P423 Test diff for wallpapers slideshow sorting (POC - work in progress) in the S1 KDE Community space.
Jun 28 2019, 6:40 PM