mikhailnov (Mikhail Novosyolov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Feb 9 2019, 2:58 PM (9 w, 6 d)
Availability
Available

Recent Activity

Feb 13 2019

mikhailnov updated the diff for D18878: Force NT1 protocol when listing smb:// network [work in progress].

Here is a new prototype of the patch. It builds, but the problem is that SMB connection in kio_smb_auth.cpp is initialized before the URL is parsed in kio_smb_browse.cpp, this makes the logic of this patch not work.

Feb 13 2019, 10:27 AM · Frameworks, Dolphin

Feb 12 2019

mikhailnov added a comment to D18878: Force NT1 protocol when listing smb:// network [work in progress].

I've done some tests in a clean virtual environment, and must say that this patch actually does not work, because

kioclient5 ls smb:/

does not detect workgroups without setting

[global]
client max protocol = NT1

in ~/.smb/smb.conf

Feb 12 2019, 12:45 AM · Frameworks, Dolphin

Feb 11 2019

mikhailnov updated the diff for D18878: Force NT1 protocol when listing smb:// network [work in progress].

fixed patch

Feb 11 2019, 9:55 PM · Frameworks, Dolphin
mikhailnov added a comment to D18878: Force NT1 protocol when listing smb:// network [work in progress].

Forgot to write that SMB1 is used to list the network, then, when connection is done, protocol version must be chosen again automatically, SMB3 is default in newest samba.

Feb 11 2019, 5:21 PM · Frameworks, Dolphin
mikhailnov added a comment to D18878: Force NT1 protocol when listing smb:// network [work in progress].

https://blogs.technet.microsoft.com/filecab/2016/09/16/stop-using-smb1/

I cannot approve this. It is opening potential security issues, overrides sysadmin configs, diverges from sound upstream defaults, goes against advise and practises set forth by Microsoft, continues to avoid moving away from a deprecated 30 year old protocol.

Feb 11 2019, 4:51 PM · Frameworks, Dolphin

Feb 10 2019

mikhailnov updated the summary of D18878: Force NT1 protocol when listing smb:// network [work in progress].
Feb 10 2019, 8:08 AM · Frameworks, Dolphin
mikhailnov updated the diff for D18878: Force NT1 protocol when listing smb:// network [work in progress].

smbc_setOptionProtocols() does not edit context. smbc_set_context(nullptr) will not change context, but will only return existing one.

Feb 10 2019, 7:54 AM · Frameworks, Dolphin

Feb 9 2019

mikhailnov added a comment to D18878: Force NT1 protocol when listing smb:// network [work in progress].

How do dependencies work here? Does this force SMB1 to be installed and enabled in Dolphin now? I ask because many companies have disabled and removed version 1 due to the security issues.

Feb 9 2019, 4:24 PM · Frameworks, Dolphin
mikhailnov added a comment to D18878: Force NT1 protocol when listing smb:// network [work in progress].

Samba developers told that currently other methods of browsong network, than using old SMB1 protocol, are not implemented.

Feb 9 2019, 3:08 PM · Frameworks, Dolphin
mikhailnov requested review of D18878: Force NT1 protocol when listing smb:// network [work in progress].
Feb 9 2019, 3:03 PM · Frameworks, Dolphin