mdlubakowski (Marcin Dłubakowski)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jul 11 2019, 7:51 AM (9 w, 4 d)
Availability
Available

Recent Activity

Yesterday

l10n daemon script <scripty@kde.org> committed R241:fad5a11eb5c4: Fixed interaction with DOS/Windows executables in KRun::runUrl (authored by mdlubakowski).
Fixed interaction with DOS/Windows executables in KRun::runUrl
Mon, Sep 16, 8:34 PM
mdlubakowski added a comment to D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl.

I wonder if this should maybe be backported to 5.62, since it represents a regression introduced in that release. Thoughts?

Mon, Sep 16, 4:55 PM · Frameworks
mdlubakowski added inline comments to D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl.
Mon, Sep 16, 2:07 PM · Frameworks
mdlubakowski updated the diff for D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl.
  • Incorporated feedback
Mon, Sep 16, 2:05 PM · Frameworks
mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

This patch breaks running Windows EXE files. Clicking them does nothing now. Right clicking and explicitly choosing "Run with wine program launcher" works.

Mon, Sep 16, 12:51 PM · Frameworks
mdlubakowski added reviewers for D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl: dfaure, Frameworks.
Mon, Sep 16, 12:50 PM · Frameworks
mdlubakowski requested review of D23989: Fixed interaction with DOS/Windows executables in KRun::runUrl.
Mon, Sep 16, 12:47 PM · Frameworks

Tue, Sep 3

mdlubakowski added inline comments to D22510: Added dialog to set execute permission for executable file when trying to run it..
Tue, Sep 3, 10:05 AM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..
  • Reverted change to KRun::isExecutableFile
Tue, Sep 3, 10:01 AM · Frameworks

Mon, Sep 2

mdlubakowski updated the summary of D22510: Added dialog to set execute permission for executable file when trying to run it..
Mon, Sep 2, 6:36 PM · Frameworks
mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

Fixed according to comments, hope I haven't forget anything this time.
Sorry for the API change, I thought it may make sense to add it like this since isExecutableFile and isExecutable are a part of it.
I also added showing the errorString from setExecuteBit to makeServiceExecutable, since it used similar dialog to KRun::runUrl

Mon, Sep 2, 6:26 PM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..
  • Incorporated feedback
Mon, Sep 2, 6:22 PM · Frameworks
mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

Thanks for your guidance!
I don't have developer account, so can't land myself.
Should I fix those two other comments before landing?

Mon, Sep 2, 5:24 PM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..
  • Removed leftover kfileitem.h include
Mon, Sep 2, 4:44 PM · Frameworks
mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

Reversed my changes to isExecutableFile method as per D23660, since my changes aren't needed anymore. Also added hasExecuteBit method.

Mon, Sep 2, 4:42 PM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..
  • Reverse change to KRun::isExeutableFile
  • Incorporated feedback
Mon, Sep 2, 4:36 PM · Frameworks

Thu, Aug 29

mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

First of all, sorry for the mess I made here with Arcanist. My SSD died recently and I lost original repository with those changes, so I used arc patch to pull it back, updated the code and pushed here with arc diff --update. I'm not sure if it affects anything though, I tested on fresh repository and it can be patched with this revision without problem.
In response to the feedback, I ditched my original dialog - it is now shared with that from makeServiceExecutable helper function (the one that shows for .desktop files), and its code is moved to showUntrustedProgramWarning method. Code for setting executable bit is also moved, from makeFileExecutable to setExecuteBit.
Desktop and script files also show another type of dialog, one which ask user whether to open or execute the file, but I decided not to use it here with executables since I don't think anyone needs to open executables with external programs.

Thu, Aug 29, 11:25 AM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..

Incorporated feedback

Thu, Aug 29, 10:58 AM · Frameworks

Mon, Aug 26

mdlubakowski added a comment to D22854: Added support for configurable font styles for syntax highlighting.
In D22854#517776, @apol wrote:

Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.

Mon, Aug 26, 8:22 AM · KDevelop

Jul 31 2019

mdlubakowski requested review of D22854: Added support for configurable font styles for syntax highlighting.
Jul 31 2019, 11:46 AM · KDevelop

Jul 22 2019

mdlubakowski requested review of D22660: Fixed crash when filtering class list.
Jul 22 2019, 6:25 PM · KDevelop

Jul 17 2019

mdlubakowski added a comment to D22510: Added dialog to set execute permission for executable file when trying to run it..

If the use case you're targeting is specifically AppImage files, it might make sense to coordinate with upstream, where they're working on ways to improve this: https://github.com/AppImage/appimaged/issues/30. There's a small helper called AppImageLauncher that can do this automatically, so I'm not sure it makes sense to use KRun for it. @probono?

Jul 17 2019, 3:02 PM · Frameworks
mdlubakowski added a reviewer for D22510: Added dialog to set execute permission for executable file when trying to run it.: Frameworks.
Jul 17 2019, 2:35 PM · Frameworks
mdlubakowski updated the diff for D22510: Added dialog to set execute permission for executable file when trying to run it..

One of the commits did not upload

Jul 17 2019, 2:32 PM · Frameworks
mdlubakowski requested review of D22510: Added dialog to set execute permission for executable file when trying to run it..
Jul 17 2019, 2:30 PM · Frameworks

Jul 15 2019

mdlubakowski added a comment to D22456: Show session name in the Delete Session confirmation dialog.
In D22456#496025, @apol wrote:

LGTM can you land it?

Jul 15 2019, 7:33 PM · KDevelop
mdlubakowski updated the diff for D22456: Show session name in the Delete Session confirmation dialog.
  • Added missing header for column with session name
Jul 15 2019, 5:25 AM · KDevelop

Jul 14 2019

mdlubakowski added a reviewer for D22456: Show session name in the Delete Session confirmation dialog: KDevelop.
Jul 14 2019, 5:09 PM · KDevelop
mdlubakowski retitled D22456: Show session name in the Delete Session confirmation dialog from Show session name in the Delete Session confimration dialog to Show session name in the Delete Session confirmation dialog.
Jul 14 2019, 5:07 PM · KDevelop
mdlubakowski requested review of D22456: Show session name in the Delete Session confirmation dialog.
Jul 14 2019, 5:04 PM · KDevelop