- User Since
- Jul 30 2018, 5:00 PM (42 w, 3 d)
Apr 23 2019
Feb 14 2019
Aug 2 2018
Aug 1 2018
Okay, so should I wait for someone else to reply before committing it to the 5.12 and 5.13 branches?
Jul 31 2018
It would indeed, but I will wait for input before pushing it as I'm not entirely sure how it's decided what release a patch goes in to.
Either one is fine by me as well, so pick whichever one you fancy :)
Grammatical fixes ;)
Well, it's sort of a daemon, but it doesn't run until the user logs out - there's a built-in timeout of 30 seconds that will check for any connected clients and if none are found it will kill itself. The KCM communicates with the fontinst daemon via dbus :)
Use a QEventLoopLocker instead of completely disabling the quit lock functionality.
Okay, that makes sense. kfontinst doesn't actually display a UI at all, instead it just receives dbus commands from kcm - so there is no real GUI class, it just uses QCoreApplication. I could add a QEventLoopLocker to KFI::FontInst though, but, from reading the code it seems as though there's no way to actually cancel the running kjob (nor the running fontinst). That might be a cleaner approach than completely disabling the quit lock, however.
It does indeed fix both of those bugs. I have added that in the summary now, sorry about that.