Jan 23 2018

martinletacek added a comment to D9041: Ability to ignore defined files and directories from search results.

Hi,
Sorry i was not able to do much with the change here lately :-(.
I have checked out the @martinkostolny change, it works as i would expect, thanks.
I was originaly a little suprised with the amount of changes i have done (i was mostly copying some parts as they were done for another feature on the search screen) so it's good it's simplified like this.

Jan 23 2018, 11:02 PM · Krusader

Dec 28 2017

martinletacek updated the diff for D9041: Ability to ignore defined files and directories from search results.

Hi,
So i have updated the diff using your suggestion.
It is now in the search dialog only but as it doesn't remember the text itself when app is restarted (it is only in the history) the checkbox is disabled by default.
If you can think of any standard way to remember this over restart i would like to have it there, but this may be fine anyway (will test if i will remember to turn this on)...
Let me know :)

Dec 28 2017, 8:55 PM · Krusader

Dec 19 2017

martinletacek updated the diff for D9041: Ability to ignore defined files and directories from search results.

Hi,
Sorry it took so long, but hopefully i added all the changes to the patch now.
The feature is now called Exclude Folder Names, changed throughout the code,
The crash in Synchronizer should be fixed (i have moved the inspecting of the checkbox into the correct condition in the getSettings function).
Still the same behavior: checkbox is always in the search dialog and the directories are in the configuration.
Let me know what you think

Dec 19 2017, 9:42 PM · Krusader

Nov 30 2017

martinletacek added a comment to D9041: Ability to ignore defined files and directories from search results.

Hi abilka.
RE: Naming suggestions: the Exclude folder names looks like a better idea, will change the code in this way in the evening.
RE: Search dialog input box: Currently from my tests the search dialog doesn't remember much (over app restart), it might be good idea to have a history for it, but i would much more like that i don't have to remember to change that field at all.
Also as i was saying i don't want to make the search dialog bigger and even thinking about hiding this checkbox when it doesn't have any settings. on the other hand people won't know about this feature if the checkbox would be hidden. Not sure what would be better here...

Nov 30 2017, 7:59 AM · Krusader

Nov 29 2017

martinletacek added a comment to D9041: Ability to ignore defined files and directories from search results.

Hi,
Yep these seems good for me, i'm more a PHP developer :).
I have just checked the Synchronizer and it seem to be working for me, let me know if i can help...
Also not sure if the search dialog wouldn't get too much crowded, should i hide the checkbox when there's nothing set in the settings?

Nov 29 2017, 7:45 PM · Krusader