martellini (Jacopo Martellini)
Engineering

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Oct 22 2019, 7:19 PM (234 w, 2 d)
Availability
Available

Recent Activity

Jun 8 2020

martellini added a comment to D29603: Adds custom spacing between task manager icons.

Done
Adjustable spacing between taskmanager icons

Jun 8 2020, 9:17 PM · Plasma

May 31 2020

martellini updated the diff for D29603: Adds custom spacing between task manager icons.

Changed the input field from SpinBox to ComboBox and the options are:

  • Narrow: 0 px
  • Medium: 8 px
  • Wide: 16 px
  • Extra wide: 24 px
May 31 2020, 2:50 AM · Plasma

May 29 2020

martellini added a comment to D29603: Adds custom spacing between task manager icons.

Thanks! And sorry for the long delay before reviewing. However this doesn't seem to be working for me; no matter what value I enter, my vertical icons-only-task manager's icon spacing does not change.

Also, instead of allowing the user to specify a pixel value, what do you think about using more general terminology and a combobox? For example:

  • "Narrow" => 2px spacing
  • "Medium" => 4px spacing
  • "Wide" => 8 px spacing
  • "Extra wide" => 12 px spacing

    (numbers are totally random, just for example purposes)

    What do you think?
May 29 2020, 12:50 AM · Plasma

May 16 2020

martellini added a comment to D29603: Adds custom spacing between task manager icons.

It should be a little better now, but I left out 2 of the things we said:

  • I didn't remove the icon size setting from the configuration of the vertical task manager because maybe someone likes small icons when the panel is by the side
  • I left the spacing setting in pixels because I don't know how wide should the wide setting be and I imagined people asking for wider or narrower spacing
May 16 2020, 1:51 AM · Plasma
martellini updated the diff for D29603: Adds custom spacing between task manager icons.
  • Separates the Spacing setting from the others
May 16 2020, 1:50 AM · Plasma
martellini updated the diff for D29603: Adds custom spacing between task manager icons.
  • Makes icon scale linearly to the size of the taksbar
  • Improved the spacing configuration of the taskbar icons
May 16 2020, 1:05 AM · Plasma

May 12 2020

martellini added a comment to D29603: Adds custom spacing between task manager icons.

Sounds cool. I'll be working on it.
I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so?

Not sure I fully understahd, but it should ideally be visible for both vertical and horizontal panels.

May 12 2020, 8:41 PM · Plasma

May 11 2020

martellini added a comment to D29603: Adds custom spacing between task manager icons.

Sounds cool. I'll be working on it.
I must that the iconSize setting is only visibile if the panel is vertical, why do you think it is so?

May 11 2020, 7:06 PM · Plasma
martellini added a comment to D29603: Adds custom spacing between task manager icons.

Are we really sure this is worth exposing to the user?

May 11 2020, 3:03 PM · Plasma

May 10 2020

martellini updated the test plan for D29603: Adds custom spacing between task manager icons.
May 10 2020, 11:26 PM · Plasma
martellini requested review of D29603: Adds custom spacing between task manager icons.
May 10 2020, 4:52 PM · Plasma