konstantinshtepa (Konstantin Shtepa)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Jan 12 2017, 11:17 AM (379 w, 22 h)
Availability
Available

Recent Activity

Jan 26 2017

konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Though really any max > min on the client is undefined behaviour, so it's hard to say any is "right".

Jan 26 2017, 4:37 PM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Fixed littke bug which would happend with code

plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 130
plasmoid.Layout.maximumHeight = 150

Bug led to maximumHeight = 150 when minimumHeight would still be = 130

Jan 26 2017, 4:33 PM · Plasma
konstantinshtepa updated D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 26 2017, 3:16 PM · Plasma
konstantinshtepa added inline comments to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 26 2017, 3:09 PM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Removed Bindings

Jan 26 2017, 3:04 PM · Plasma

Jan 25 2017

konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
In D4204#80142, @mart wrote:

what i would like to have logically splitted is the management of the floating property (and having positionItem()/releasePosition used around)

and on the other hand the signal handlers of minimumWidthChanged/widthChanged etc in Appletappearance, that's the biggest part

Jan 25 2017, 5:56 PM · Plasma
konstantinshtepa added inline comments to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 25 2017, 5:16 PM · Plasma
konstantinshtepa added inline comments to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 25 2017, 1:20 PM · Plasma
konstantinshtepa added inline comments to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 25 2017, 1:16 PM · Plasma
konstantinshtepa updated D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 25 2017, 12:01 PM · Plasma
konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
In D4204#80106, @mart wrote:

can this be splitted in multiple reviews/commits?

Jan 25 2017, 12:00 PM · Plasma

Jan 23 2017

konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Rewrited some code to better understanding
Fixed background-handle animation in plasmoidBackground. It was a little bug, but I don't see any sense to report it now when patch are ready. Fixed it by changing it to animate only handle-width instead of animation of full plasmoidBackground width.

Jan 23 2017, 1:16 PM · Plasma
konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Before anything else I'd like to explain why I need this patch. At winter holidays I had a free time and decided to rewrite plasma-simplemonitor(maded by dhabyx) - port it to plasma5 and improve it. As one of new features I added "skins" - posibility to change UI looks. Let's describe one skin as "row" and other as "column". Skins had different default sizes and different minimum sizes. As behaviour it sugges that when user change one skin to another plasmoid size supposed to change to default size of new skin. In plasma5 there is no resize function in plasmoid anymore. Instead docs pointed to use Layout properties. And so I tried to set maximum sizes in Layout. It doesn't work. When researching this problem it was occurred that there is no such functionality in plasmoids despite that plasmoid already uses Layout minimum sizes. And so I made this patch to fix that. When debugging this patch I found other bugs and fixed them alongside.

Jan 23 2017, 11:49 AM · Plasma
konstantinshtepa updated D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 23 2017, 10:13 AM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Fix commit message

Jan 23 2017, 10:13 AM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Turn on background width animation again.

Jan 23 2017, 10:11 AM · Plasma

Jan 21 2017

konstantinshtepa moved T5144: Plasmoid mechanics improvement from To Do to Work in Progress on the Plasma board.
Jan 21 2017, 12:58 PM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Rewrited commit message in according to kde commit polititcs

Jan 21 2017, 11:00 AM · Plasma
konstantinshtepa updated D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 21 2017, 10:34 AM · Plasma
konstantinshtepa created T5144: Plasmoid mechanics improvement.
Jan 21 2017, 10:33 AM · Plasma
konstantinshtepa updated the diff for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

Summary: reworked set of patches to plasma-desktop/containments/desktop to fix bugs in plasmoid.
Fix for

  • plasmoid applet missing maximum size handler
  • plasmoid can't be set to declared minimumWidth
  • plasmoid don't release space in layoutManager.properly due to size animations
Jan 21 2017, 9:38 AM · Plasma

Jan 20 2017

konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 20 2017, 10:30 AM · Plasma

Jan 19 2017

konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

That's quite a huge patch.
Can you give a much bigger explanation on exactly what it's doing and why.
"Fixes bug N" doesn't really explain what the original problem was.

Jan 19 2017, 8:31 PM · Plasma
konstantinshtepa changed the visibility for D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 19 2017, 6:33 PM · Plasma
konstantinshtepa retitled D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop from Patch for plasmoid subsystem(containment/desktop) in plasma-desktop to Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 19 2017, 6:32 PM · Plasma
konstantinshtepa added a comment to D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.

It was not supposed to go there, but. sigh... arc...
I will try to make it better.

Jan 19 2017, 6:24 PM · Plasma
konstantinshtepa updated D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop.
Jan 19 2017, 6:19 PM · Plasma
konstantinshtepa retitled D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop from Added max size restrictions handlers for plasmoids to Patch for plasmoid subsystem(containment/desktop) in plasma-desktop.
Jan 19 2017, 6:10 PM · Plasma
konstantinshtepa retitled D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop from to Added max size restrictions handlers for plasmoids.
Jan 19 2017, 6:07 PM · Plasma