kiroma (Krzysztof Kurek)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 13 2018, 8:10 PM (288 w, 3 d)
Availability
Available

Recent Activity

Jun 15 2020

kiroma committed R37:e52fc4c112a9: Merge branch 'TestKisSwatchGroup-fix' into 'master' (authored by kiroma).
Merge branch 'TestKisSwatchGroup-fix' into 'master'
Jun 15 2020, 8:49 PM
kiroma committed R37:c1e98d2627bc: Fix the TestKistSwatchGroup test (authored by kiroma).
Fix the TestKistSwatchGroup test
Jun 15 2020, 8:49 PM
kiroma committed R37:b5cc38977107: Merge branch 'PalletizeFix' into 'master' (authored by kiroma).
Merge branch 'PalletizeFix' into 'master'
Jun 15 2020, 8:49 PM
kiroma committed R37:51693e5df52e: Fix the palletize crash (authored by kiroma).
Fix the palletize crash
Jun 15 2020, 8:49 PM
kiroma committed R37:274977c1f648: Merge branch 'master' into 'master' (authored by kiroma).
Merge branch 'master' into 'master'
Jun 15 2020, 8:49 PM
kiroma committed R37:104297616468: Remove a Qt5.13 function call (authored by kiroma).
Remove a Qt5.13 function call
Jun 15 2020, 8:49 PM
kiroma committed R37:232ac69942a6: Remove a CXX specific flag from other targets (authored by kiroma).
Remove a CXX specific flag from other targets
Jun 15 2020, 8:49 PM
kiroma committed R37:6b71a3cc9b73: Even more deprecation removal work (authored by kiroma).
Even more deprecation removal work
Jun 15 2020, 8:49 PM
kiroma committed R37:9c4972ad9b65: Revert some const-ref changes (authored by kiroma).
Revert some const-ref changes
Jun 15 2020, 8:49 PM
kiroma committed R37:f13ff926eb5f: A bunch more deprecation fixes (authored by kiroma).
A bunch more deprecation fixes
Jun 15 2020, 8:49 PM
kiroma committed R37:35d2f5308633: Simplify KisSwatch class (authored by kiroma).
Simplify KisSwatch class
Jun 15 2020, 8:49 PM
kiroma committed R37:95c1ee1206f5: Get rid of a few implicit deprecation warnings (authored by kiroma).
Get rid of a few implicit deprecation warnings
Jun 15 2020, 8:49 PM

Sep 19 2019

kiroma abandoned D24074: Simplify KisSwatch class.
Sep 19 2019, 4:20 PM · Krita
kiroma added a comment to D24074: Simplify KisSwatch class.

Oh, sure.

Sep 19 2019, 3:35 PM · Krita
kiroma requested review of D24074: Simplify KisSwatch class.
Sep 19 2019, 12:20 PM · Krita

Jan 16 2019

kiroma updated the summary of D16184: Fix compilation on compilers which do not have Atomic built-in.
Jan 16 2019, 12:48 PM · Krita

Jan 12 2019

kiroma added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

Alright well there are unrelated errors but everything else seems to work fine.

Jan 12 2019, 5:41 PM · Krita
kiroma added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

Alright so this patch was long overdue to be fixed, considering how simple the fix turned out to be.
I've tested it out on FreeBSD under KVM and it compiled just fine.
I haven't yet ran all tests, I'll send another message when I deem the patch ready to merge.

Jan 12 2019, 3:57 PM · Krita
kiroma updated the diff for D16184: Fix compilation on compilers which do not have Atomic built-in.

cmake now checks if neither atomic nor atomic64 is compilable without linking in atomics, tested out on FreeBSD, should work on MacOS.

Jan 12 2019, 3:54 PM · Krita

Nov 20 2018

kiroma reopened D16184: Fix compilation on compilers which do not have Atomic built-in.

Oh hey I noticed this patch was reverted, can I get some pointers to where it failed so I can fix it up?

Nov 20 2018, 11:43 AM · Krita

Oct 21 2018

kiroma added a reviewer for D16363: Add Threads library to linkage: Kdenlive.
Oct 21 2018, 9:03 PM
kiroma requested review of D16363: Add Threads library to linkage.
Oct 21 2018, 8:50 PM

Oct 15 2018

kiroma added a comment to D16184: Fix compilation on compilers which do not have Atomic built-in.

Nope, first patch ever.

Oct 15 2018, 3:26 PM · Krita

Oct 14 2018

kiroma retitled D16184: Fix compilation on compilers which do not have Atomic built-in from Fix compilation with clang-7 to Fix compilation on compilers which do not have Atomic built-in.
Oct 14 2018, 9:28 PM · Krita
kiroma added inline comments to D16184: Fix compilation on compilers which do not have Atomic built-in.
Oct 14 2018, 5:25 PM · Krita
kiroma updated the diff for D16184: Fix compilation on compilers which do not have Atomic built-in.

Turns out there is a CheckAtomic.cmake already created, in the LLVM project. I don't know how to handle licensing, I've never done it before, so I included the license in the file copied over from LLVM.

Oct 14 2018, 5:03 PM · Krita
kiroma planned changes to D16184: Fix compilation on compilers which do not have Atomic built-in.

Following Alvin, I don't think there's any CheckAtomic.cmake written yet, so I'll make a new one.

Oct 14 2018, 1:38 PM · Krita

Oct 13 2018

kiroma updated the summary of D16184: Fix compilation on compilers which do not have Atomic built-in.
Oct 13 2018, 8:25 PM · Krita
kiroma requested review of D16184: Fix compilation on compilers which do not have Atomic built-in.
Oct 13 2018, 8:21 PM · Krita