kapillamba4 (Kapil Lamba)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Jun 23 2017, 8:42 AM (24 w, 4 d)
Availability
Available

Recent Activity

Today

kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#178634, @rkflx wrote:

Latest version LGTM. Thanks a lot again for your patch.

Tue, Dec 12, 10:21 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Tue, Dec 12, 10:08 AM · KDE Applications
kapillamba4 added inline comments to D9145: Correct margin for left sidebar.
Tue, Dec 12, 10:04 AM · KDE Applications
kapillamba4 added inline comments to D9145: Correct margin for left sidebar.
Tue, Dec 12, 10:02 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Tue, Dec 12, 6:51 AM · KDE Applications
kapillamba4 added inline comments to D9145: Correct margin for left sidebar.
Tue, Dec 12, 6:31 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Tue, Dec 12, 6:30 AM · KDE Applications

Yesterday

kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Mon, Dec 11, 5:49 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Mon, Dec 11, 11:14 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Mon, Dec 11, 10:41 AM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#178193, @rkflx wrote:
In D9145#178033, @rkflx wrote:

I think I found a way to fix the problem properly.

Here we go, fixes submitted for review in D9281 and D9282.

Backstory how I figured it out:

Looking at the other toolbuttons, I saw they worked fine. Then I added some text to the zoom buttons in the status bar and even wrote a test app with only some buttons in different layouts, all working fine. The only explanation left was that there had to be a bug somewhere, meaning it was not Gwenview's fault. And indeed, switching styles the problem happened only with Breeze and Oxygen. But still all other toolbuttons worked fine, how could that be?

Only by chance I stumbled upon the _kde_toolbutton_alignment property in GammaRay. Tracing this one back was not straightforward, but I ended up in Breeze. Seeing the special casing for Gwenview there was quite a suprise, to say the least. One git blame, some code reading and thorough testing later the patch was ready.

Mon, Dec 11, 10:38 AM · KDE Applications

Sun, Dec 10

kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#178152, @rkflx wrote:

Can we just set left-margin for title to 3 in constructor of sidebargroup, also set container margin to 3 for Image operation, file operation and meta information and set margin 3 inside ui file for semantic information (not whole of the container)

Depending on what you refer to with "container", the title might have double margin now? Just try it, I guess.

If you want to keep the ui file, I would be okay with that. But instead of the margin setter call at least add a comment to that effect at a similar place in the code.

Sun, Dec 10, 6:45 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#178097, @rkflx wrote:

I think the best way would be to try to get rid of semanticinfosidebaritem.ui, i.e. manually create its items in code and essentially have in each sidebar a container (red rectangle) which is then indented at a central place:

Sun, Dec 10, 6:16 PM · KDE Applications
kapillamba4 added a comment to D9117: Add shortcuts for copying screenshots to clipboard..

Does klipper support non-text clipboard data? If so, you might consider storing it there rather than in the X11 clipboard.

Sun, Dec 10, 5:38 PM · Spectacle
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
Sun, Dec 10, 3:21 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Sun, Dec 10, 2:45 PM · KDE Applications
kapillamba4 retitled D9145: Correct margin for left sidebar from Correct margin for Left Sidebar for gwenview. to Correct margin for Left Sidebar and fix icon placement in Sidebar buttons for gwenview..
Sun, Dec 10, 2:25 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#178033, @rkflx wrote:

Can you remove this? I think I found a way to fix the problem properly. Still needs some fiddling, but I'll have it figured out soon™ (sorry for the cliffhanger :)

Sun, Dec 10, 2:24 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Sun, Dec 10, 11:55 AM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#177362, @rkflx wrote:

Ok, then we agree. At least we tried and learned something in the process…

yup

Sun, Dec 10, 11:23 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.

Updated:


Sun, Dec 10, 11:15 AM · KDE Applications

Thu, Dec 7

kapillamba4 added a comment to D9145: Correct margin for left sidebar.

I actually don't think text input widgets look bad with or without margin.

Thu, Dec 7, 7:28 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#177316, @rkflx wrote:

I'm so sorry I have to tell you this, but now it breaks in another place. I'm confident you'll get it right eventually :)

Also, I guess you are still working on the margins of the text input widgets as per my comments?


Edit: Can't edit the inline comment, of course I mean "do NOT remove"…

Thu, Dec 7, 7:18 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
Thu, Dec 7, 9:05 AM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.

For QT_SCALE_FACTOR=1.4 :

Thu, Dec 7, 7:54 AM · KDE Applications

Wed, Dec 6

kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#176942, @rkflx wrote:

Much better, but I think we need one more iteration regarding the spacing (did not yet look at the code in depth).

I still don't know why normal conventional methods like setting stylesheet or setContentsMargin are not working for QToolButton

Sorry, don't know that either. When looking around, you do not seem to be the first to notice this, though.

Wed, Dec 6, 10:43 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#176861, @rkflx wrote:

Thanks, I'll look at your updates in a bit.

Meanwhile, please let us know which email address should be used when landing this patch on your behalf.

Wed, Dec 6, 6:58 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.

Lovely, much better now!

👍

Wed, Dec 6, 4:23 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.

I still don't know why normal conventional methods like setting stylesheet or setContentsMargin are not working for QToolButton

Wed, Dec 6, 4:10 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.
In D9145#176147, @rkflx wrote:

does this look good?

The space between icon and text now looks much narrower than without the patch. I think it was just fine in an unpatched Gwenview, it is only the left margin which needs tweaking. Note that in my screenshot I set the toolbar icon size to "small" to match the sidebar buttons. You can use pixeltool-qt5 or gammaray to make measuring easier.


As for the summary, please don't just repeat the title ;) Write what was wrong (i.e. section header text as well as buttons too close to edge of window when setting window borders to "none") and what fixes this.

Wed, Dec 6, 4:05 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Wed, Dec 6, 3:59 PM · KDE Applications

Tue, Dec 5

kapillamba4 updated the summary of D9117: Add shortcuts for copying screenshots to clipboard..
Tue, Dec 5, 7:05 PM · Spectacle
kapillamba4 updated the summary of D9145: Correct margin for left sidebar.
Tue, Dec 5, 12:13 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.

@ngraham , @rkflx does this look good?

Tue, Dec 5, 12:05 PM · KDE Applications

Sun, Dec 3

This is a test notification, sent at Sun, Dec 3, 6:56 PM.
Sun, Dec 3, 6:56 PM
This is a test notification, sent at Sun, Dec 3, 6:56 PM.
Sun, Dec 3, 6:56 PM
This is a test notification, sent at Sun, Dec 3, 6:55 PM.
Sun, Dec 3, 6:55 PM
This is a test notification, sent at Sun, Dec 3, 6:55 PM.
Sun, Dec 3, 6:55 PM
kapillamba4 retitled D9145: Correct margin for left sidebar from Correct margin for Left Sidebar and fix icon placement in Sidebar buttons in gwenview. to Correct margin for Left Sidebar and fix icon placement in Sidebar buttons for gwenview..
Sun, Dec 3, 6:20 PM · KDE Applications
kapillamba4 retitled D9145: Correct margin for left sidebar from Correct margin for Left Sidebar and fix icon placement in Sidebar buttons to Correct margin for Left Sidebar and fix icon placement in Sidebar buttons in gwenview..
Sun, Dec 3, 6:20 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Sun, Dec 3, 6:12 PM · KDE Applications
kapillamba4 updated the diff for D9145: Correct margin for left sidebar.
Sun, Dec 3, 6:04 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.

I only see margin "3" at 4 places, 3 of which will be added by this patch and
most of the "margin" values seem to be zero.

Sun, Dec 3, 5:28 PM · KDE Applications
kapillamba4 added a comment to D9145: Correct margin for left sidebar.

Seems to work with HiDPI for me as well:

Sun, Dec 3, 5:23 PM · KDE Applications
kapillamba4 created D9145: Correct margin for left sidebar.
Sun, Dec 3, 4:35 PM · KDE Applications
kapillamba4 added a comment to D9117: Add shortcuts for copying screenshots to clipboard..

Copy to Clipboard does not persist after app closes
More information

Sun, Dec 3, 5:35 AM · Spectacle

Sat, Dec 2

kapillamba4 created D9117: Add shortcuts for copying screenshots to clipboard..
Sat, Dec 2, 8:38 PM · Spectacle