User Details
User Details
- User Since
- Apr 27 2019, 1:58 AM (260 w, 4 d)
- Availability
- Available
May 5 2019
May 5 2019
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.
Sorry for the delay... I was finally able to get the crashing machine set up again.
johngehrig updated the diff for D20859: Crash in sddmthemeinstaller invalid use of errorString.
Ordering changed, qWarning first.
job->errorString() displayed for all values of job->error().
A QString object was created, so job is no longer passed to KMessageBox.
Apr 29 2019
Apr 29 2019
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.
Thanks for the clarification! I understand what you are saying :)
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.
The API for errorString() calls out that it should not be called when error() == 0. The code does not explicitly check for this scenario.
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.
@anthonyfieroni Yes, I think there also an issue with KAuth here. This machine never gets to the auth prompt, which works fine on another machine.
Apr 27 2019
Apr 27 2019
johngehrig added a comment to D20859: Crash in sddmthemeinstaller invalid use of errorString.
It looks like my alternate error "unknown error" isn't showing up in the dialog... So this isn't quite right yet.
Restricted Application added a project to D20859: Crash in sddmthemeinstaller invalid use of errorString: Plasma.
johngehrig requested review of D20859: Crash in sddmthemeinstaller invalid use of errorString.