fahadalsaidi (Fahad Al-Saidi)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Feb 12 2018, 8:26 AM (323 w, 1 d)
Availability
Available

Recent Activity

May 16 2018

fahadalsaidi added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@fahadalsaidi, are you able to work on those?

May 16 2018, 6:00 AM · Okular

Mar 17 2018

fahadalsaidi added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@chfanzil , thanks for testing and sharing your findings. The patch doesn't touch search logic , it deals only with inner text layer in okular.

Mar 17 2018, 6:50 AM · Okular

Feb 19 2018

fahadalsaidi added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@aacid Thanks for the feedback.

Feb 19 2018, 5:26 AM · Okular
fahadalsaidi updated the diff for D10455: Add RTL support for search, copy & paste in pdf.
  • use QTRY_COMPARE
Feb 19 2018, 5:19 AM · Okular

Feb 18 2018

fahadalsaidi added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@aacid any feedback?

Feb 18 2018, 5:09 AM · Okular

Feb 13 2018

fahadalsaidi retitled D10455: Add RTL support for search, copy & paste in pdf from add rtl support to textpage to Add RTL support for search, copy & paste in pdf.
Feb 13 2018, 10:10 AM · Okular
fahadalsaidi updated the diff for D10455: Add RTL support for search, copy & paste in pdf.

add autotest for searching in Arabic

Feb 13 2018, 10:08 AM · Okular
fahadalsaidi added a comment to D10455: Add RTL support for search, copy & paste in pdf.

@aacid I want to write autotest but there is a bug #390357 in cmake test. I will try make autotest smiliar to test311232() but there is a problem, the pdf file doesn't load probably and it give me in an empty m_generator. please have a look on it.

Feb 13 2018, 8:02 AM · Okular
fahadalsaidi updated the diff for D10455: Add RTL support for search, copy & paste in pdf.

Well, I was over-optimistic. This patch is related only to BUG: 207748 & BUG:184399. The other back-ends have many problem not related to this patch as following:

  • xps: okular crash when open arabic xps file and if it can open it, it renders it in wrong way.
  • dejuv: searching & copying Arabic text are fine since dejuv back-end has it own search function.
  • odt: there is broken in LTR or RTL. There is no text to search at all.
  • chm: Although okular can open it but searching is bad for LTR & RTL text, it is basically broken.
Feb 13 2018, 6:48 AM · Okular

Feb 12 2018

fahadalsaidi added reviewers for D10455: Add RTL support for search, copy & paste in pdf: aacid, ltoscano.
Feb 12 2018, 9:25 AM · Okular
fahadalsaidi requested review of D10455: Add RTL support for search, copy & paste in pdf.
Feb 12 2018, 9:23 AM · Okular