ederag (ede rag)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Dec 7 2017, 6:40 PM (332 w, 5 d)
Availability
Available

Recent Activity

Nov 24 2018

ederag added a comment to D9484: Use KTextEditor::Message in KateConsole::slotSync.

I think we should not start to be over-verbose, lets skip this ATM.

Nov 24 2018, 7:55 PM · Kate

Dec 24 2017

ederag added a comment to D9484: Use KTextEditor::Message in KateConsole::slotSync.

What happens, if you edit several remove documents and switch a lot.
Will this "spam" the current view with the info message again and again?

Dec 24 2017, 2:47 PM · Kate

Dec 22 2017

ederag added a comment to D9244: Run in terminal.

Thank you very much for the commit, and for the feedback that improved the patch a lot.
Here is the corresponding diff for SlotSync: D9484

Dec 22 2017, 10:30 PM · Kate
ederag updated the summary of D9484: Use KTextEditor::Message in KateConsole::slotSync.
Dec 22 2017, 10:25 PM · Kate
ederag updated the summary of D9484: Use KTextEditor::Message in KateConsole::slotSync.
Dec 22 2017, 10:24 PM · Kate
ederag updated the test plan for D9484: Use KTextEditor::Message in KateConsole::slotSync.
Dec 22 2017, 10:23 PM · Kate
ederag created D9484: Use KTextEditor::Message in KateConsole::slotSync.
Dec 22 2017, 10:22 PM · Kate
ederag added a comment to D9244: Run in terminal.

For the commit, shall I push?

Dec 22 2017, 11:05 AM · Kate

Dec 21 2017

ederag updated the diff for D9244: Run in terminal.

After reading the doc, and a bit of source code, it does not seem feasible.
But setting a shorter time of 2s, and Immediate autohide
yield a much better behavior.

Dec 21 2017, 8:00 PM · Kate

Dec 20 2017

ederag updated the diff for D9244: Run in terminal.

Done, but running ultimate tests too quickly,
I hit several times F4 before noticing the 'not local file' error.
Then i had to wait for it to disappear, hit somewhere, wait for the error to appear, ...
Would it be possible to catch that the error is still shown (for the same file),
and allow us to do nothing until the error is fixed ?
Or simpler: a way to collapse identical error messages for the same view into one ?
To the minimum, how to allow the user to quickly remove this error message (a delete cross) ?

Dec 20 2017, 9:38 PM · Kate
ederag added a comment to D9244: Run in terminal.

If you would remove that, you would first need to write code that does the download via KIO and stuff.

That might be awesome.
But a simpler use case is when switching between few remote files,
knowing exactly where they are on the server, so that
a simple script can curl the right one (based on its name), and execute it.

Dec 20 2017, 9:59 AM · Kate

Dec 19 2017

ederag added a comment to D9244: Run in terminal.

Thanks you very much for the very enlightening feedback.

Dec 19 2017, 8:46 PM · Kate

Dec 18 2017

ederag updated the diff for D9244: Run in terminal.

A non-valid URL is no local file (and I doubt somebody will ever get one, beside "no" url).
But I can live with two different messages, as long as both are inline via KTextEditor::Message, it makes no sense that one is a messagebox.

To me it still makes sense (shorter code, simpler to maintain, for the very unlikely event)
It would have been nice to explain why (documentation ?) you are so confident
that a file without any valid url
has for sure a valid display (for the error message) nonetheless.

Dec 18 2017, 7:54 PM · Kate

Dec 17 2017

ederag updated the diff for D9244: Run in terminal.

Because I thought that if the url itself was invalid, then things were probably really bad, and it was safer not to rely on the visibility of the document ?

I think the best is to skip that and just warn if no local file, we don't care why it is no one ;=)

Dec 17 2017, 8:35 PM · Kate

Dec 12 2017

ederag added a comment to D9244: Run in terminal.

Intermediate variables like document render the code much cleaner.
Are they OK ?

That is OK ;=)
But I don't understand why the "no valid url" is a message box but the other is a nice overlay message ;=)

Dec 12 2017, 12:35 PM · Kate

Dec 11 2017

ederag updated the diff for D9244: Run in terminal.

The KateConsole::slotRun() function has been reworked,
with separate errors:
KMessageBox::sorry(0, i18n ("Invalid document URL"));
and
KTextEditor::Message(i18n("Not a local file: '%1'", u.path() )...);

Dec 11 2017, 9:11 PM · Kate

Dec 10 2017

ederag added a comment to D9244: Run in terminal.

For the error message: Two different errors would be nice.

Btw., you could use the ktexteditor/message.h to show the error message inline in the view, that will make it easier to spot.

Dec 10 2017, 10:57 PM · Kate

Dec 9 2017

ederag updated the diff for D9244: Run in terminal.

Thanks for the positive feedback.

Dec 9 2017, 10:29 PM · Kate

Dec 7 2017

ederag updated the summary of D9244: Run in terminal.
Dec 7 2017, 7:29 PM · Kate
ederag created D9244: Run in terminal.
Dec 7 2017, 7:27 PM · Kate