dweatherill (Dan Weatherill)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jan 11 2018, 1:51 AM (328 w, 4 h)
Availability
Available

Recent Activity

Jan 15 2018

dweatherill added a comment to D9809: work around bug in kLineEdit.

I don't have commit access so someone will have to merge this for me. Thanks :-)

Jan 15 2018, 4:57 PM · KDevelop
dweatherill added a comment to D9808: fix incorrect emission of signals by kLineEdit.

I don't have commit access but please let me know if anything else is needed before it can be merged.

Jan 15 2018, 4:56 PM · Frameworks, KDevelop

Jan 14 2018

dweatherill added a comment to D9808: fix incorrect emission of signals by kLineEdit.

I have updated the description to tag relevant bugs

Jan 14 2018, 4:52 AM · Frameworks, KDevelop

Jan 12 2018

dweatherill updated the summary of D9808: fix incorrect emission of signals by kLineEdit.
Jan 12 2018, 8:31 PM · Frameworks, KDevelop
dweatherill added a comment to D9808: fix incorrect emission of signals by kLineEdit.

as I don't have a developer account, I will need someone else to push it please :-)

Jan 12 2018, 6:00 PM · Frameworks, KDevelop

Jan 11 2018

dweatherill added a comment to D9809: work around bug in kLineEdit.

in addition, just returning early instead of the assert causes a different bug, which is that compilerEdited gets called when we select out of the compiler, due to the same kLineEdit bug that causes textEdited to be emitted on calling clear().

Jan 11 2018, 4:07 PM · KDevelop
dweatherill added a comment to D9809: work around bug in kLineEdit.

So just remove the assert - instead return early when indexes.isEmpty(). That way we don't need to mess with the signal blocker and the code behaves as intended. And you remove code instead of adding more.

Jan 11 2018, 4:06 PM · KDevelop
dweatherill added a comment to D9809: work around bug in kLineEdit.

improved backtrace with all symbols now attached to the bug report:
https://bugs.kde.org/show_bug.cgi?id=373004

Jan 11 2018, 4:03 PM · KDevelop
dweatherill added a comment to D9808: fix incorrect emission of signals by kLineEdit.

Sorry to be a pain, but can you also update the description, which still talks about textEmitted()?

(FYI using arc diff to upload the patch would also provide context, but OK, I can open the file locally to find out about the context for those unittest changes....)

Jan 11 2018, 3:38 PM · Frameworks, KDevelop
dweatherill updated the summary of D9808: fix incorrect emission of signals by kLineEdit.
Jan 11 2018, 3:38 PM · Frameworks, KDevelop
dweatherill updated the diff for D9809: work around bug in kLineEdit.

as per review, this updated diff uses QSignalBlocker instead of blockSignals()

Jan 11 2018, 3:07 PM · KDevelop
dweatherill added a comment to D9808: fix incorrect emission of signals by kLineEdit.

from the git history I believe this issue has been in place since before 5.0.

Jan 11 2018, 2:56 PM · Frameworks, KDevelop
dweatherill updated the diff for D9808: fix incorrect emission of signals by kLineEdit.

this updated diff removes the rename, just has fixed and extended unit tests and the one line fix for not emitting the textChanged signal spuriously.

Jan 11 2018, 2:50 PM · Frameworks, KDevelop
dweatherill added inline comments to D9808: fix incorrect emission of signals by kLineEdit.
Jan 11 2018, 1:25 PM · Frameworks, KDevelop
dweatherill added inline comments to D9808: fix incorrect emission of signals by kLineEdit.
Jan 11 2018, 1:21 PM · Frameworks, KDevelop
dweatherill added a comment to D9809: work around bug in kLineEdit.

I don't understand how this fixes the crash. Can you extend the bug report with a better backtrace that contains more symbols? Also, the bug report looks like it's due to a queued signal emission. Which signal is that? And it looks like something withing the kdevplatform project library, how is that related to the compiler selection?

Jan 11 2018, 1:11 PM · KDevelop