dvogel (Dorian Vogel)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Apr 10 2017, 11:13 AM (136 w, 3 d)
Availability
Available

Recent Activity

Apr 9 2019

dvogel updated the diff for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Applied changes suggested by @broulik.
Thank you for your help.

Apr 9 2019, 6:49 PM · Plasma

Apr 8 2019

dvogel updated the test plan for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.
Apr 8 2019, 7:00 AM · Plasma

Apr 7 2019

dvogel updated the diff for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Reverted to the "old way" of trying ddcutil compatibility of the detected displays: by trying to read the feature setting. The ddca_get_feature_list_by_dref function was giving inconsistent results when used right after boot... (logging out an in again seemed to help, but not always..).

Apr 7 2019, 4:30 PM · Plasma
dvogel updated the test plan for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.
Apr 7 2019, 9:03 AM · Plasma
dvogel updated the test plan for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.
Apr 7 2019, 8:49 AM · Plasma

Apr 6 2019

dvogel updated the diff for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

I went a bit back to it: it is again in a working state with the current DDCUtil API.
Still, single slider independently of the number of displays supporting ddc connected.
Tested with my dell 2212hm and a Magedok t116 via HDMI on AMD gpu,

Apr 6 2019, 9:41 PM · Plasma

Apr 4 2019

dvogel added a comment to D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Yes it has to be modified. I got it to compile again over lunch on a laptop, however could not test it (has to be on a desktop, since powerdevil picks integrated screens first for brightness).

Apr 4 2019, 1:18 PM · Plasma
dvogel added a comment to D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Probably because @dvogel doesn't have commit access and nobody ever landed the patch on his behalf. :( Feel free to do so now I guess, since @kbroulik has accepted it.

Apr 4 2019, 5:33 AM · Plasma

Apr 25 2018

dvogel updated the diff for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Applied changes to the CMakeList.
Somehow the previous diff was messed-up: downloading it would provide a diff with the wrong folder structure...

Apr 25 2018, 8:43 PM · Plasma

Apr 15 2018

dvogel updated the diff for D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.

Applied changes suggested by broulik.
CMake fixed, using the checkbox for WITH_DDCUTIL in Kdevelop now works.
I must appologise for the long time this is taking. The diff is based on 5.12.4, since 5.12.80 is not available on my system (Arch). I will try to rebase.

Apr 15 2018, 2:56 PM · Plasma

Nov 2 2017

dvogel created D8626: DDCUtil: Improved DDCUtil support for brightness control over DDC/CI channel for supported monitors.
Nov 2 2017, 4:56 PM · Plasma

Oct 30 2017

dvogel updated the diff for D5381: Add brightness control using ddcutil lib.

Reworked for simplification.

Oct 30 2017, 9:43 PM · Plasma

May 26 2017

dvogel updated the diff for D5381: Add brightness control using ddcutil lib.

applied comments from d_ed
fixed brightness jumping to previous position after brightness change: see DDCutilBrightness::brightness()

May 26 2017, 11:42 AM · Plasma

May 25 2017

dvogel updated the diff for D5381: Add brightness control using ddcutil lib.

Absence of ddcutil on the system is now handled:
the ddcbrightness object is still instantiated in powerdevilupowerbackend, however, this is a dummy object, returning isSupported()=FALSE, making powerdevilupowerbackend avoid using ddcutil.

May 25 2017, 2:32 PM · Plasma
dvogel added a comment to D5381: Add brightness control using ddcutil lib.

The final conclusion was that I should figure out some cmake to allow building without ddccontrol. I kind of did it locally (tho it's a bit dirty).
The second big point is that powerdevil only supports one brightness controller at a time. The solution kbroulik suggested, is that powerdevil should be refactored in some sort of plugin architecture. However I personally do not have any idea at all how that should look, and most probably the time to do it.

May 25 2017, 8:22 AM · Plasma

Apr 19 2017

dvogel updated the diff for D5381: Add brightness control using ddcutil lib.

Addition of a QTimer set by default to 1 sec to filter setBrightness calls: the actual DDC communication happens 1 sec after the last setBrightness() call.
This solves brightness flickering when scrolling quickly on the battery icon, and communication failure over DDC when waking the monitor from power-save mode (Dell U2212HM wakes up in less than 1 sec).

Apr 19 2017, 6:29 AM · Plasma

Apr 13 2017

dvogel updated the diff for D5381: Add brightness control using ddcutil lib.

Applied changes suggested by reviewers.
The only issue remaining is brightness restoration when waking up the monitor after shutting it down: we try to set brightness before the monitor is actually ready. Setting then fails, and the monitor wakes up with the last value it was dimmed to before shut down.
TODO: Make ddcutillib optional, for now not having ddcutil installed will most likely result in a crash.

Apr 13 2017, 7:58 PM · Plasma

Apr 11 2017

dvogel added a comment to D5381: Add brightness control using ddcutil lib.

Ok, so there is apparently an issue when the screen gets dimmed.

Apr 11 2017, 9:16 PM · Plasma

Apr 10 2017

dvogel created D5381: Add brightness control using ddcutil lib.
Apr 10 2017, 11:24 AM · Plasma