dklimkin (Danial Klimkin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Sep 30 2017, 1:05 PM (341 w, 5 d)
Availability
Available

Recent Activity

Sep 21 2018

dklimkin added inline comments to D15592: Adjust tests to proper handle ownership.
Sep 21 2018, 5:14 PM

Sep 18 2018

dklimkin requested review of D15593: Split out notificator to allow for testing plus tests.
Sep 18 2018, 6:41 PM
dklimkin requested review of D15592: Adjust tests to proper handle ownership.
Sep 18 2018, 6:40 PM

Jul 22 2018

dklimkin updated the summary of D14279: Quick fix for no end-of-break events.
Jul 22 2018, 6:37 PM
dklimkin requested review of D14279: Quick fix for no end-of-break events.
Jul 22 2018, 6:37 PM
dklimkin added inline comments to D8074: [PATCH 3/3] More tests for Timer.
Jul 22 2018, 6:03 PM
dklimkin updated the diff for D8074: [PATCH 3/3] More tests for Timer.
Jul 22 2018, 6:03 PM

Apr 12 2018

dklimkin added inline comments to D8074: [PATCH 3/3] More tests for Timer.
Apr 12 2018, 9:46 AM

Apr 4 2018

dklimkin added inline comments to D8074: [PATCH 3/3] More tests for Timer.
Apr 4 2018, 11:45 AM

Apr 3 2018

dklimkin added a comment to D8074: [PATCH 3/3] More tests for Timer.

Is there anything blocking this merge?

Apr 3 2018, 6:48 PM

Dec 13 2017

dklimkin added inline comments to D8074: [PATCH 3/3] More tests for Timer.
Dec 13 2017, 1:13 PM

Dec 9 2017

dklimkin updated the diff for D8073: [PATCH 2/3] Adding pause skip threshold..
Dec 9 2017, 5:34 PM
dklimkin updated the diff for D8073: [PATCH 2/3] Adding pause skip threshold..
Dec 9 2017, 5:32 PM
dklimkin added a comment to D8073: [PATCH 2/3] Adding pause skip threshold..

Why is the second "Skip if no activity" 60 minutes? Shouldn't it be 5 minutes?

Dec 9 2017, 5:31 PM

Nov 27 2017

dklimkin added a comment to D8073: [PATCH 2/3] Adding pause skip threshold..

Friendly ping.

Nov 27 2017, 10:36 AM

Nov 12 2017

dklimkin updated the diff for D8074: [PATCH 3/3] More tests for Timer.
Nov 12 2017, 12:11 PM
dklimkin added a comment to D8074: [PATCH 3/3] More tests for Timer.

You probably don't want them to be built and packaged, right? Also, systems like Gentoo shouldn't build them.

Nov 12 2017, 11:59 AM
dklimkin updated the diff for D8073: [PATCH 2/3] Adding pause skip threshold..

Rolled renamings back.

Nov 12 2017, 11:52 AM
dklimkin added inline comments to D8073: [PATCH 2/3] Adding pause skip threshold..
Nov 12 2017, 11:44 AM
dklimkin updated the diff for D8074: [PATCH 3/3] More tests for Timer.

Made tests compilation optional. Run tests with:

Nov 12 2017, 11:37 AM
dklimkin added a comment to T411: Email address not in sync with KDE identity.

Run into this as I also need to update my email address. It's been two years since the issue was logged...

Nov 12 2017, 11:25 AM ยท Phabricator
dklimkin updated the diff for D8073: [PATCH 2/3] Adding pause skip threshold..

Addressed comments.

Nov 12 2017, 11:21 AM
dklimkin added inline comments to D8073: [PATCH 2/3] Adding pause skip threshold..
Nov 12 2017, 11:17 AM
dklimkin added a comment to D8074: [PATCH 3/3] More tests for Timer.

Please hold this, I'd like to touch CMakeLists a tiny bit.

Nov 12 2017, 11:16 AM

Oct 27 2017

dklimkin updated the diff for D8072: [PATCH 1/3] Refactor RSITimer.

Addressed comments.

Oct 27 2017, 7:29 PM
dklimkin added inline comments to D8072: [PATCH 1/3] Refactor RSITimer.
Oct 27 2017, 7:12 PM
dklimkin added a comment to D8072: [PATCH 1/3] Refactor RSITimer.
In D8072#160633, @aacid wrote:

I'm also a bit concerned about those new threshold values you added, they are not configurable so the user may be a bit confused since as you say previously it was (probably wrongly) coupled to a value that was configurable and now it's hardocded to 20 (unless you know which magic file to edit), are you planning on changing that?

Oct 27 2017, 6:47 PM

Oct 5 2017

dklimkin added a comment to D8072: [PATCH 1/3] Refactor RSITimer.

Hi Albert, are there any further details I help with here?

Oct 5 2017, 6:15 PM

Oct 1 2017

dklimkin added a comment to D8072: [PATCH 1/3] Refactor RSITimer.

So can you please explain what you did, you explained why you did it, but what i want is an explanation of all those new classes and enums you added what are they for, what they do, why you needed to write them, etc.

Oct 1 2017, 10:16 AM
dklimkin added a comment to D8072: [PATCH 1/3] Refactor RSITimer.

So can you please explain what you did, you explained why you did it, but what i want is an explanation of all those new classes and enums you added what are they for, what they do, why you needed to write them, etc.

Oct 1 2017, 10:16 AM

Sep 30 2017

dklimkin updated the diff for D8072: [PATCH 1/3] Refactor RSITimer.

Made changes requested.

Sep 30 2017, 7:06 PM
dklimkin added a comment to D8072: [PATCH 1/3] Refactor RSITimer.
In D8072#150976, @aacid wrote:

Can you try to explain what you did? because it seems more a "i rewrote almost everything" than a refactor ๐Ÿ˜„

Sep 30 2017, 7:03 PM
dklimkin added a reviewer for D8072: [PATCH 1/3] Refactor RSITimer: aacid.

Re-submitting PR: https://github.com/KDE/rsibreak/pull/1

Sep 30 2017, 2:04 PM
dklimkin added dependent revisions for D8072: [PATCH 1/3] Refactor RSITimer: D8073: [PATCH 2/3] Adding pause skip threshold., D8074: [PATCH 3/3] More tests for Timer.
Sep 30 2017, 2:03 PM
dklimkin created D8074: [PATCH 3/3] More tests for Timer.
Sep 30 2017, 1:50 PM
dklimkin created D8073: [PATCH 2/3] Adding pause skip threshold..
Sep 30 2017, 1:46 PM
dklimkin created D8072: [PATCH 1/3] Refactor RSITimer.
Sep 30 2017, 1:43 PM