davschul (David Schulz)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Feb 11 2019, 9:22 AM (270 w, 23 h)
Availability
Available

Recent Activity

Feb 28 2019

davschul added a comment to D19286: Add unit test for definitionsForFileName() and definitionsForMimeType().

cool thanks :)

Feb 28 2019, 10:12 AM · Frameworks, Kate

Feb 22 2019

davschul requested review of D19215: Install DefinitionDownloader header.
Feb 22 2019, 7:10 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul updated the diff for D19200: Return sorted definitions for file names and mime types.

Yeah, I just missed to recheck the sorting logic. Before the change we just needed the best match so the partial sort was completely sufficient. Now we need a complete sorted vector, so stable sort is the way to go ;)

Feb 22 2019, 6:37 AM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 21 2019

davschul added a comment to D19200: Return sorted definitions for file names and mime types.

Ah sorry completely missed that part. Unfortunately I'm out of office already, I'll take a look as soon as I'm back tomorrow.

Feb 21 2019, 4:05 PM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Created https://phabricator.kde.org/D19200
That should implement all the latest suggestions/comments

Feb 21 2019, 1:58 PM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D19200: Return sorted definitions for file names and mime types.
Feb 21 2019, 1:56 PM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18996: Fix building with namespaced Qt.

Okay I've tested it with 3.12.2 and there were no issues.
I'm not familiar enough with cmake to tell whether there is a simpler version for what I try to achieve here. I just need the -D QT_NAMESPACE compiler options. Is there someone in the community who might know how to make it in a more elegant way.
If not I do not need that target_link_libraries part in Qt Creator, because we still only support building via qmake or qbs. It was just to be complete here. So it could be removed without breaking our use case, but it would break namespace builds for any one else.

Feb 21 2019, 1:20 PM · Frameworks, Framework: Syntax Highlighting, Kate

Feb 14 2019

davschul added a comment to D18997: Add functions returning all definitions for a mimetype or file name.

Nice respond times here, and thanks for the reviews :)

Feb 14 2019, 9:01 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul updated the diff for D18997: Add functions returning all definitions for a mimetype or file name.
Feb 14 2019, 8:17 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18998: update literate haskell mimetype.

see https://cgit.freedesktop.org/xdg/shared-mime-info/tree/freedesktop.org.xml.in?h=Release-1-12#n6074

Feb 14 2019, 8:12 AM · Frameworks, Kate
davschul requested review of D18998: update literate haskell mimetype.
Feb 14 2019, 8:12 AM · Frameworks, Kate
davschul requested review of D18997: Add functions returning all definitions for a mimetype or file name.
Feb 14 2019, 7:20 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul added a comment to D18982: prevent assertion in regex load.

David Schulz david.schulz@qt.io

Feb 14 2019, 7:15 AM · Frameworks, Kate
davschul added inline comments to D18996: Fix building with namespaced Qt.
Feb 14 2019, 7:00 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul requested review of D18996: Fix building with namespaced Qt.
Feb 14 2019, 6:56 AM · Frameworks, Framework: Syntax Highlighting, Kate
davschul updated the diff for D18982: prevent assertion in regex load.

added additional context to the diff

Feb 14 2019, 6:44 AM · Frameworks, Kate
davschul added inline comments to D18982: prevent assertion in regex load.
Feb 14 2019, 6:41 AM · Frameworks, Kate

Feb 13 2019

davschul requested review of D18982: prevent assertion in regex load.
Feb 13 2019, 2:02 PM · Frameworks, Kate