In D27380#617927, @ngraham wrote:

All fonts tested. :(

In D20189#442515, @ndavis wrote:

I've already made Qt Widget-like tabs for Breeze and Breeze Dark at these repos, so you can just borrow from those:

https://github.com/noahadvs/yakuake-breeze_perfect

https://github.com/noahadvs/yakuake-breeze_perfect_dark

In D20189#442421, @ngraham wrote:

FWIW, the VDG perspective on tabs in apps is generally that they should look tab-like. Konsole already has tab-like tabs and IMO Yakuake should too. @tcanabrava is in the middle of fixing Kate's tabs so they have a conventional appearance IIRC.

In D20189#442051, @broulik wrote:

Can you explain why this change should be done?
There's also a .directory file that shouldn't be there

In D20189#441956, @ndavis wrote:

Does the theme have to use PNGs? It would also be nice if the tabs could look more like Qt tabs like in https://store.kde.org/p/1193435/

I prefer the skin that I proposed in this patch.
Tell me if you think we should provide a more complete skin like this one:

ok I make some cleanup

I don't think I have dev access.
I don't know how to commit from phabricator.

Can someone take a look to this patch ?
Thanks.

Here a wrong skin with a missing file:

As suggested by Aleix Pol Gonzalez, I changed the validateSkin() method in order to check the existence of mandatory files in the filesystem.
This method is called when the skin is installed from kns or from a tar archive.
I changed the validation process in the case of a tar archive: the validation is now done after the tar is extracted.
If the skin is not valid, it is removed from the filesystem. I factored the removal process in the removeSkin() method.
I also fixed a bug in extractKnsSkinIds() line 463: when one skin "my_skin" was installed, it returned QSet("my_skin", "") instead of QSet("my_skin")

In D13335#389573, @apol wrote:

Since the skin is already installed, maybe it would make more sense to check over the file system contents, no?