- User Since
- Jun 4 2018, 2:39 PM (67 w, 3 d)
Apr 3 2019
Apr 2 2019
Apr 1 2019
I prefer the skin that I proposed in this patch.
Tell me if you think we should provide a more complete skin like this one:
I tested many themes from KNS. Most of them seems are unaffected or better aligned
Mar 22 2019
ok I make some cleanup
Mar 18 2019
Mar 17 2019
Mar 7 2019
I don't think I have dev access.
I don't know how to commit from phabricator.
Mar 5 2019
Can someone take a look to this patch ?
Mar 4 2019
Mar 3 2019
Here a wrong skin with a missing file:
It can help to check the validation process in the case of a tar archive.
As suggested by Aleix Pol Gonzalez, I changed the validateSkin() method in order to check the existence of mandatory files in the filesystem.
This method is called when the skin is installed from kns or from a tar archive.
I changed the validation process in the case of a tar archive: the validation is now done after the tar is extracted.
If the skin is not valid, it is removed from the filesystem. I factored the removal process in the removeSkin() method.
I also fixed a bug in extractKnsSkinIds() line 463: when one skin "my_skin" was installed, it returned QSet("my_skin", "") instead of QSet("my_skin")