chauvin (Lionel Chauvin)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Jun 4 2018, 2:39 PM (67 w, 3 d)
Availability
Available

Recent Activity

Apr 3 2019

chauvin added a comment to D20189: Change default Yakuake skin to breeze compact.

I've already made Qt Widget-like tabs for Breeze and Breeze Dark at these repos, so you can just borrow from those:

https://github.com/noahadvs/yakuake-breeze_perfect

https://github.com/noahadvs/yakuake-breeze_perfect_dark

Apr 3 2019, 5:39 PM

Apr 2 2019

chauvin added a comment to D20189: Change default Yakuake skin to breeze compact.

FWIW, the VDG perspective on tabs in apps is generally that they should look tab-like. Konsole already has tab-like tabs and IMO Yakuake should too. @tcanabrava is in the middle of fixing Kate's tabs so they have a conventional appearance IIRC.

Apr 2 2019, 7:08 PM
chauvin added a reviewer for D20189: Change default Yakuake skin to breeze compact: andreask.
Apr 2 2019, 6:25 PM
chauvin added a comment to D20189: Change default Yakuake skin to breeze compact.

Can you explain why this change should be done?
There's also a .directory file that shouldn't be there

Apr 2 2019, 6:01 PM
chauvin added a comment to D20189: Change default Yakuake skin to breeze compact.

Does the theme have to use PNGs? It would also be nice if the tabs could look more like Qt tabs like in https://store.kde.org/p/1193435/

Apr 2 2019, 5:47 PM

Apr 1 2019

chauvin added a comment to D20189: Change default Yakuake skin to breeze compact.

I prefer the skin that I proposed in this patch.
Tell me if you think we should provide a more complete skin like this one:

Apr 1 2019, 10:24 PM
chauvin added a comment to D20190: Remove the additional pixels that make tab's texts not properly verticaly centered.


I tested many themes from KNS. Most of them seems are unaffected or better aligned

Apr 1 2019, 10:07 PM
chauvin requested review of D20190: Remove the additional pixels that make tab's texts not properly verticaly centered.
Apr 1 2019, 9:49 PM
chauvin requested review of D20189: Change default Yakuake skin to breeze compact.
Apr 1 2019, 9:42 PM

Mar 22 2019

chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 11:35 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:59 PM · Yakuake
chauvin added a comment to D19835: [Yakuake] Improve customization.

ok I make some cleanup

Mar 22 2019, 10:51 PM · Yakuake
chauvin updated the diff for D19835: [Yakuake] Improve customization.
Mar 22 2019, 10:18 PM · Yakuake

Mar 18 2019

chauvin added a reviewer for D19833: Remove double scrollbar in appearance settings: Yakuake.
Mar 18 2019, 7:07 PM · Yakuake
chauvin added a reviewer for D19835: [Yakuake] Improve customization: Yakuake.
Mar 18 2019, 7:05 PM · Yakuake

Mar 17 2019

chauvin requested review of D19835: [Yakuake] Improve customization.
Mar 17 2019, 4:59 PM · Yakuake
chauvin requested review of D19833: Remove double scrollbar in appearance settings.
Mar 17 2019, 4:40 PM · Yakuake

Mar 7 2019

chauvin added a comment to D13335: Fix Skin validation when installed from KNS.

I don't think I have dev access.
I don't know how to commit from phabricator.

Mar 7 2019, 7:31 PM · Yakuake

Mar 5 2019

chauvin updated the summary of D13335: Fix Skin validation when installed from KNS.
Mar 5 2019, 7:54 PM · Yakuake
chauvin added a comment to D13335: Fix Skin validation when installed from KNS.

Can someone take a look to this patch ?
Thanks.

Mar 5 2019, 7:53 PM · Yakuake
chauvin updated the test plan for D13335: Fix Skin validation when installed from KNS.
Mar 5 2019, 7:52 PM · Yakuake

Mar 4 2019

chauvin added a reviewer for D13335: Fix Skin validation when installed from KNS: Yakuake.
Mar 4 2019, 7:53 PM · Yakuake

Mar 3 2019

chauvin added a comment to D13335: Fix Skin validation when installed from KNS.

Here a wrong skin with a missing file:


It can help to check the validation process in the case of a tar archive.

Mar 3 2019, 12:02 PM · Yakuake
chauvin added a project to D13335: Fix Skin validation when installed from KNS: Yakuake.
Mar 3 2019, 11:41 AM · Yakuake
chauvin updated the summary of D13335: Fix Skin validation when installed from KNS.
Mar 3 2019, 11:23 AM · Yakuake
chauvin updated the summary of D13335: Fix Skin validation when installed from KNS.
Mar 3 2019, 11:22 AM · Yakuake
chauvin updated the diff for D13335: Fix Skin validation when installed from KNS.

As suggested by Aleix Pol Gonzalez, I changed the validateSkin() method in order to check the existence of mandatory files in the filesystem.
This method is called when the skin is installed from kns or from a tar archive.
I changed the validation process in the case of a tar archive: the validation is now done after the tar is extracted.
If the skin is not valid, it is removed from the filesystem. I factored the removal process in the removeSkin() method.
I also fixed a bug in extractKnsSkinIds() line 463: when one skin "my_skin" was installed, it returned QSet("my_skin", "") instead of QSet("my_skin")

Mar 3 2019, 11:15 AM · Yakuake

Jan 10 2019

chauvin added a comment to D13335: Fix Skin validation when installed from KNS.
In D13335#389573, @apol wrote:

Since the skin is already installed, maybe it would make more sense to check over the file system contents, no?

Jan 10 2019, 7:45 PM · Yakuake

Jun 13 2018

chauvin updated subscribers of D13335: Fix Skin validation when installed from KNS.
Jun 13 2018, 6:49 PM · Yakuake

Jun 4 2018

chauvin added reviewers for D13335: Fix Skin validation when installed from KNS: hein, apol.
Jun 4 2018, 3:51 PM · Yakuake
chauvin updated the summary of D13335: Fix Skin validation when installed from KNS.
Jun 4 2018, 3:06 PM · Yakuake
chauvin requested review of D13335: Fix Skin validation when installed from KNS.
Jun 4 2018, 3:04 PM · Yakuake