cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (186 w, 1 d)
Availability
Available

Recent Activity

Today

cgiboudeaux accepted D19892: Use https for user-accessible links and documentation.
Wed, Mar 20, 7:19 AM · KDE PIM

Yesterday

cgiboudeaux added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

FTR, the fix was pushed, but now the BSD build is unhappy.

Tue, Mar 19, 4:44 PM · KDE PIM
cgiboudeaux committed R44:55918c509494: Fix a race condition. (authored by cgiboudeaux).
Fix a race condition.
Tue, Mar 19, 3:25 PM

Mon, Mar 18

cgiboudeaux added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

Maybe the 'OBJECT'[1] target type could help here, e.g (builds locally, no idea if it could solve your race):

Mon, Mar 18, 8:28 AM · KDE PIM

Tue, Mar 5

cgiboudeaux added a comment to D19527: Remove find modules provided by ECM.

FindSasl2.cmake & FindPulseAudio.cmake also exist in both repo.

Tue, Mar 5, 8:44 AM · Frameworks

Mon, Mar 4

cgiboudeaux committed R240:4c78221d13ee: Fix harmless warnings when creating the doc. (authored by cgiboudeaux).
Fix harmless warnings when creating the doc.
Mon, Mar 4, 12:50 PM
cgiboudeaux committed R240:48d757160b18: Also ignore __pycache__ (authored by cgiboudeaux).
Also ignore __pycache__
Mon, Mar 4, 12:50 PM
cgiboudeaux accepted D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

Thanks.

Mon, Mar 4, 12:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mon, Mar 4, 11:35 AM · Build System, Frameworks
cgiboudeaux requested changes to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.
Mon, Mar 4, 11:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19506: ECMGeneratePkgConfigFile: add variables used by pkg_check_modules.

The autotest has to be fixed as well

Mon, Mar 4, 11:27 AM · Build System, Frameworks

Sun, Mar 3

cgiboudeaux accepted D19499: Restore FindFontconfig backward compatibility for plasma-desktop.
Sun, Mar 3, 9:31 PM · Build System, Frameworks
cgiboudeaux accepted D19486: Add UDev find module.
Sun, Mar 3, 10:53 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Sun, Mar 3, 10:27 AM · Build System, Frameworks
cgiboudeaux added a comment to D19486: Add UDev find module.

We probably need to set uppercase variables for the moment. plasma-desktop and powerdevil include the ECM modules dir before their local copy, so any older release would fail to build with ECM >= 5.57

Sun, Mar 3, 10:18 AM · Build System, Frameworks

Sat, Mar 2

cgiboudeaux accepted D18943: Add Fontconfig find modudle.

LGTM

Sat, Mar 2, 11:57 AM · Build System, Frameworks

Thu, Feb 28

cgiboudeaux added inline comments to D18996: Fix building with namespaced Qt.
Thu, Feb 28, 2:16 PM · Frameworks, Framework: Syntax Highlighting, Kate

Thu, Feb 21

cgiboudeaux committed R240:ae7c84f4ff93: Fix a typo in the compatibility vars. (authored by cgiboudeaux).
Fix a typo in the compatibility vars.
Thu, Feb 21, 9:09 AM

Tue, Feb 19

cgiboudeaux accepted D18952: new find module for Canberra.

Thanks! just a little thing to fix before pushing

Tue, Feb 19, 8:09 AM · Build System, Frameworks

Feb 16 2019

cgiboudeaux accepted D18947: Bring FindUDev.cmake up to ECM standards.
Feb 16 2019, 12:25 PM · Frameworks
cgiboudeaux added inline comments to D18943: Add Fontconfig find modudle.
Feb 16 2019, 11:13 AM · Build System, Frameworks
cgiboudeaux added a comment to D18952: new find module for Canberra.

Yes, imported targets are the future/present :)

Canberra::Canberra sounds good to me as target name

Feb 16 2019, 11:09 AM · Build System, Frameworks
cgiboudeaux added inline comments to D18947: Bring FindUDev.cmake up to ECM standards.
Feb 16 2019, 10:51 AM · Frameworks

Feb 12 2019

cgiboudeaux accepted D18941: Fix build with cmake 3.5.
Feb 12 2019, 9:13 AM · Frameworks, Baloo
cgiboudeaux added a comment to D18943: Add Fontconfig find modudle.

I'm not sure to understand the commit message, does qtbase look for ECM ?

Feb 12 2019, 9:12 AM · Build System, Frameworks

Feb 11 2019

cgiboudeaux accepted D18913: ECMGeneratePkgConfigFile API dox: fix "Since" for DESCRIPTION arg.
Feb 11 2019, 9:12 AM · Build System, Frameworks

Jan 31 2019

cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

Forget that. The syntax is confusing, please remove this HASFLAG

That I'm not going to do. The goal is to both to have useful feedback like below, and to avoid caching issues that would cause on the first query to be performed (if you were to use a single result variable):

-- Performing Test Clang++_ACCEPTS-Wvla
``
Jan 31 2019, 6:53 PM · Frameworks, Build System
cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:18 PM · Frameworks, Build System
cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 3:12 PM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
There are tests for other ECM modules in the **tests** subdir.

That's not the expected answer, so let me rephrase: which existing test can I clone and adapt (which is about the only thing I know how to do in this domain)?

Jan 31 2019, 3:04 PM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 31 2019, 10:47 AM · Frameworks, Build System

Jan 30 2019

cgiboudeaux added inline comments to D16894: [ECM] use a macro to add compiler flags conditionally.
Jan 30 2019, 9:48 AM · Frameworks, Build System
cgiboudeaux added a comment to D16894: [ECM] use a macro to add compiler flags conditionally.

PS: don't forget the unit test for the new module.

Jan 30 2019, 9:03 AM · Frameworks, Build System

Jan 26 2019

cgiboudeaux updated subscribers of D18533: Improve the Notfication Bell Icon by using the KAlarm design.
Jan 26 2019, 9:26 AM · Frameworks

Jan 21 2019

cgiboudeaux abandoned D17015: Fix the Qt doc creation with Qt 5.12..

qhelpgenerator is back in Qt 5.12.1

Jan 21 2019, 12:06 PM · Build System, Frameworks

Jan 18 2019

cgiboudeaux added a reviewer for D18345: Fix python binding generation for classes with deleted copy constructors: lbeltrame.
Jan 18 2019, 9:30 AM · Build System, Frameworks

Jan 17 2019

cgiboudeaux added a comment to D18137: delete copy constructor and assignment operator of some public classes.

This is causing an error when building the python bindings:

Jan 17 2019, 2:13 PM · Frameworks
cgiboudeaux added a comment to D18244: Check for python-cairo.

This breaks NeonKubuntu builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not.

EDIT: seems specific to cmake < 3.12 in Bionic. Kubuntu Cosmic/Disco build with cmake 3.12 finds python3-cairo, but fails on another issue probably related a different recent commit.

https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull

02:43:04 -- The following REQUIRED packages have not been found:
02:43:04
02:43:04 * PythonCairo
02:43:04 Required to render assets

Jan 17 2019, 9:37 AM · Plasma

Jan 16 2019

cgiboudeaux added a comment to D18244: Check for python-cairo.

+1

Jan 16 2019, 1:25 PM · Plasma
cgiboudeaux added inline comments to D18244: Check for python-cairo.
Jan 16 2019, 9:51 AM · Plasma

Jan 14 2019

cgiboudeaux added inline comments to D18244: Check for python-cairo.
Jan 14 2019, 4:41 PM · Plasma
cgiboudeaux added a comment to D17154: Go back to SCSS.

Are there any strong reasons?

It's not installed, so a user can't use it.

That means it's only a build tool. As it's a build tool it's very important to not get stuff from the host system as it makes things less reproducible.

Jan 14 2019, 11:45 AM · Plasma

Dec 31 2018

cgiboudeaux added inline comments to D17154: Go back to SCSS.
Dec 31 2018, 12:58 PM · Plasma
cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

include(ECMCheckLinkerFlags)
[...]
# Check for nodump support
SET(NODUMP_FLAGS "-Wl,-z,nodump")
ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
if (NODUMP_SUPPORTED)
    SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
endif ()

Of course kstars could also just stop adding nodump ever :)

Dec 31 2018, 12:45 PM · Build System, Frameworks

Dec 30 2018

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Dec 30 2018, 11:10 PM · Build System, Frameworks

Dec 21 2018

cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Try to find qmake if qmake-qt5 is not found

Dec 21 2018, 2:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..

Reverted and the version was fixed.

Dec 21 2018, 10:13 AM · Frameworks
cgiboudeaux committed R6:d5cf9284ebe5: Fix the version in the pkgconfig file. (authored by cgiboudeaux).
Fix the version in the pkgconfig file.
Dec 21 2018, 10:12 AM
cgiboudeaux committed R6:a5d904ae6d76: Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file." (authored by cgiboudeaux).
Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file."
Dec 21 2018, 10:12 AM
cgiboudeaux added a reverting change for R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: R6:a5d904ae6d76: Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file.".
Dec 21 2018, 10:12 AM
cgiboudeaux removed a reviewer for D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: alexeymin.
In D17718#380267, @pino wrote:

I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:

prefix=/usr
exec_prefix=bin
libdir=lib/x86_64-linux-gnu
includedir=include

Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
URL: http://www.kde.org
Requires: Qt5Core
Version: 
Libs: -Llib/x86_64-linux-gnu -lKF5Activities
Cflags: -Iinclude

With this, version field is filled in and full paths are specified:

Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
Version: 5.54.0
Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities

This seems wrong to me, the library is called KF5Activities and not libKActivities.

Cflags: -I/usr/include/libKActivities

Ditto.

Dec 21 2018, 10:05 AM · Frameworks
cgiboudeaux committed R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file. (authored by cgiboudeaux).
Use ECMGeneratePkgConfigFile to create the pkgconfig file.
Dec 21 2018, 9:51 AM
cgiboudeaux closed D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..
Dec 21 2018, 9:51 AM · Frameworks
cgiboudeaux added reviewers for D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: cfeck, Build System.
Dec 21 2018, 9:20 AM · Frameworks
cgiboudeaux requested review of D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..
Dec 21 2018, 9:19 AM · Frameworks

Dec 20 2018

cgiboudeaux accepted D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.
Dec 20 2018, 8:43 PM · Build System, Frameworks

Dec 16 2018

cgiboudeaux accepted D17547: Bring FindFontconfig.cmake up to ECM standards.

+1

Dec 16 2018, 9:52 AM · KWin

Dec 15 2018

cgiboudeaux added inline comments to D17547: Bring FindFontconfig.cmake up to ECM standards.
Dec 15 2018, 12:23 PM · KWin

Dec 13 2018

cgiboudeaux added inline comments to D17547: Bring FindFontconfig.cmake up to ECM standards.
Dec 13 2018, 11:51 AM · KWin

Dec 3 2018

cgiboudeaux accepted D16954: Add find module for Google's libphonenumber.
Dec 3 2018, 6:02 PM · Build System, Frameworks
cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)

Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated variants for each purppse? Needs me another round of thinking.

Dec 3 2018, 11:46 AM · Build System, Frameworks
cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Add the reason for looking for the executable

Dec 3 2018, 11:40 AM · Build System, Frameworks

Dec 1 2018

cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:16 PM · Build System, Frameworks
cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:11 PM · Build System, Frameworks

Nov 30 2018

cgiboudeaux committed R260:220449149133: Merge branch 'Applications/18.12' (authored by cgiboudeaux).
Merge branch 'Applications/18.12'
Nov 30 2018, 10:32 AM
cgiboudeaux committed R260:6f4e08953736: Make FindExiv2.cmake work with exiv 0.27. (authored by cgiboudeaux).
Make FindExiv2.cmake work with exiv 0.27.
Nov 30 2018, 10:32 AM
cgiboudeaux closed D17040: Make FindExiv2.cmake work with exiv 0.27..
Nov 30 2018, 10:32 AM · Gwenview

Nov 27 2018

cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Nov 27 2018, 10:32 PM · Frameworks, Dolphin
cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Nov 27 2018, 10:28 PM · Frameworks, Dolphin
cgiboudeaux committed R377:7cc73de75a8c: Fix the maintainer username. (authored by cgiboudeaux).
Fix the maintainer username.
Nov 27 2018, 10:54 AM
cgiboudeaux committed R175:e7c154e2f950: Use the right maintainer username. (authored by cgiboudeaux).
Use the right maintainer username.
Nov 27 2018, 10:51 AM

Nov 24 2018

cgiboudeaux accepted D16929: Remove dead search provider.
Nov 24 2018, 11:42 AM · Frameworks

Nov 21 2018

cgiboudeaux committed R81:0bc68edcbe13: Only build the tests if BUILD_TESTING is ON (authored by cgiboudeaux).
Only build the tests if BUILD_TESTING is ON
Nov 21 2018, 8:12 AM

Nov 20 2018

cgiboudeaux added a comment to D17044: Add FindExiv2.cmake to ECM.

Done. kfilemetadata was also changed to use FindLibExiv2.cmake.

Nov 20 2018, 1:44 PM · Build System, Frameworks
cgiboudeaux committed R286:f32793945692: Adapt to the FindExiv2 -> FindLibExiv2 name change in ECM. (authored by cgiboudeaux).
Adapt to the FindExiv2 -> FindLibExiv2 name change in ECM.
Nov 20 2018, 1:44 PM
cgiboudeaux committed R240:19e6a585a7ae: Rename FindExiv2 to FindLibExiv2. (authored by cgiboudeaux).
Rename FindExiv2 to FindLibExiv2.
Nov 20 2018, 1:38 PM
cgiboudeaux added inline comments to D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 1:29 PM · Build System, Frameworks
cgiboudeaux committed R286:c3cc05f4eee2: Use the new FindExiv2 module from ECM. (authored by cgiboudeaux).
Use the new FindExiv2 module from ECM.
Nov 20 2018, 1:04 PM
cgiboudeaux closed D17046: Use the new FindExiv2 module from ECM..
Nov 20 2018, 1:04 PM · Baloo, Frameworks
cgiboudeaux added a comment to D17046: Use the new FindExiv2 module from ECM..

Please feel free to land this after solving my comment.

Nov 20 2018, 1:04 PM · Baloo, Frameworks
cgiboudeaux requested review of D17046: Use the new FindExiv2 module from ECM..
Nov 20 2018, 12:55 PM · Baloo, Frameworks
cgiboudeaux committed R240:fe22302d2d4d: Add FindExiv2.cmake to ECM (authored by cgiboudeaux).
Add FindExiv2.cmake to ECM
Nov 20 2018, 12:30 PM
cgiboudeaux added a reviewer for D17015: Fix the Qt doc creation with Qt 5.12.: kossebau.
Nov 20 2018, 12:29 PM · Build System, Frameworks
cgiboudeaux closed D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 12:28 PM · Build System, Frameworks
cgiboudeaux requested review of D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 11:42 AM · Build System, Frameworks
cgiboudeaux abandoned D17043: Fix the Qt doc creation with Qt 5.12..
Nov 20 2018, 11:29 AM · Build System, Frameworks
cgiboudeaux requested review of D17043: Fix the Qt doc creation with Qt 5.12..
Nov 20 2018, 11:19 AM · Build System, Frameworks
cgiboudeaux added a comment to D17040: Make FindExiv2.cmake work with exiv 0.27..

Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake

Nov 20 2018, 10:14 AM · Gwenview
cgiboudeaux added a reviewer for D17040: Make FindExiv2.cmake work with exiv 0.27.: kde-frameworks-devel.
Nov 20 2018, 10:06 AM · Gwenview
cgiboudeaux requested review of D17040: Make FindExiv2.cmake work with exiv 0.27..
Nov 20 2018, 10:02 AM · Gwenview

Nov 19 2018

cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

If anyone wonders:

Nov 19 2018, 1:39 PM · Build System, Frameworks
cgiboudeaux requested review of D17015: Fix the Qt doc creation with Qt 5.12..
Nov 19 2018, 1:33 PM · Build System, Frameworks

Nov 16 2018

cgiboudeaux added a comment to D16929: Remove dead search provider.

Remove more dead search providers, just checking for non-resolving domains isn't enough.

Nov 16 2018, 10:23 PM · Frameworks
cgiboudeaux committed R88:80ef694d40da: Merge branch 'Applications/18.12' (authored by cgiboudeaux).
Merge branch 'Applications/18.12'
Nov 16 2018, 8:15 AM
cgiboudeaux committed R88:da4a9705bf09: Remove the shutdown notice. (authored by cgiboudeaux).
Remove the shutdown notice.
Nov 16 2018, 8:15 AM
cgiboudeaux closed D16892: Remove the shutdown notice..
Nov 16 2018, 8:15 AM · KDE PIM

Nov 15 2018

cgiboudeaux updated the diff for D16892: Remove the shutdown notice..

Make test pass

Nov 15 2018, 7:35 PM · KDE PIM
cgiboudeaux requested review of D16892: Remove the shutdown notice..
Nov 15 2018, 10:27 AM · KDE PIM

Nov 13 2018

cgiboudeaux accepted D16862: Fix CMake condition.
Nov 13 2018, 12:27 PM · Frameworks

Nov 9 2018

cgiboudeaux added a reviewer for D9450: Fixed windows.h can cause min/max conflicts: Windows.
Nov 9 2018, 9:20 AM