cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (147 w, 1 d)
Availability
Available

Recent Activity

Tue, Jun 12

cgiboudeaux committed R484:9fc5140791ec: Fix build with Qt 5.11 (authored by cgiboudeaux).
Fix build with Qt 5.11
Tue, Jun 12, 11:51 AM
cgiboudeaux closed D13339: Fix build with Qt 5.11.
Tue, Jun 12, 11:51 AM · KDE Edu
cgiboudeaux added a reviewer for D13329: Fix build with Qt 5.11.: johanneszarl.
Tue, Jun 12, 11:50 AM · KPhotoAlbum

Fri, Jun 8

cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

Fixed autotests

Still -1, the code is now more complicated just for a cosmetic change in a build system file. Are you trying to fix anything ?

Fri, Jun 8, 12:10 PM · Frameworks
cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

Fixed autotests

Fri, Jun 8, 12:09 PM · Frameworks

Thu, Jun 7

cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

-1, this change would break the autotests.

Thu, Jun 7, 2:42 PM · Frameworks

Wed, Jun 6

cgiboudeaux closed T8876: rdf is not generated anymore on store.kde.org as Resolved.

Confirmed. Thanks.

Wed, Jun 6, 12:09 PM · KDE Store, Sysadmin

Tue, Jun 5

cgiboudeaux accepted D13102: Don't include a 64 when building 64bit architectures on flatpak.
Tue, Jun 5, 1:49 PM · Build System, Frameworks

Mon, Jun 4

cgiboudeaux requested review of D13339: Fix build with Qt 5.11.
Mon, Jun 4, 6:42 PM · KDE Edu
cgiboudeaux added inline comments to D13328: A backend is required for kdnssd.
Mon, Jun 4, 11:50 AM · Frameworks
cgiboudeaux requested review of D13329: Fix build with Qt 5.11..
Mon, Jun 4, 11:37 AM · KPhotoAlbum
cgiboudeaux added inline comments to D13328: A backend is required for kdnssd.
Mon, Jun 4, 11:20 AM · Frameworks

Thu, May 31

cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

Status update: freecell-solver-devel can be added to the openSUSE docker files.

Thu, May 31, 6:10 AM · build.kde.org

Wed, May 30

cgiboudeaux added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.

Thanks. +1

Wed, May 30, 2:12 PM · Build System, Frameworks
cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

All the akonadi tests fail because of the assert in my previous comment. The only crash I detected was in kwin but the CI cannot reproduce it :)

Wed, May 30, 10:58 AM · build.kde.org
cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

Tested locally with a crashing test (a real crash, not an assert), the backtrace was displayed in the ctest output.

Wed, May 30, 6:43 AM · build.kde.org

Tue, May 29

cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

That's not a solution yet, but exporting CTEST_OUTPUT_ON_FAILURE would give more hints, eg:

Tue, May 29, 10:17 AM · build.kde.org

Sun, May 27

cgiboudeaux created T8876: rdf is not generated anymore on store.kde.org.
Sun, May 27, 9:56 AM · KDE Store, Sysadmin
cgiboudeaux committed R358:4576a155389a: Only build the tests if BUILD_TESTING is ON. (authored by cgiboudeaux).
Only build the tests if BUILD_TESTING is ON.
Sun, May 27, 7:29 AM

Fri, May 25

cgiboudeaux added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.

Please update the doc above.

Fri, May 25, 6:28 AM · Build System, Frameworks

Thu, May 24

cgiboudeaux added a comment to D13096: Ensure we always reset the external reference override.

+1. Tested with master, I can't reproduce the issue anymore.

Thu, May 24, 1:22 PM · KDE PIM
cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

@cgiboudeaux : please see the patch in this commit - https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876 - i was aware of these warnings, but ignored them because the fix made performance suffer a little.

Thu, May 24, 1:02 PM · build.kde.org
cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

FTR, it's not ready yet for openSUSE, the package doesn't pass the rpmlint check due to missing return in a couple places.

Thu, May 24, 6:49 AM · build.kde.org

May 16 2018

cgiboudeaux added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

https://paste.kde.org/pscug8tik ← the patch I created for our kdebase4-runtime package, maybe you can pick useful things :)

May 16 2018, 8:02 AM

May 14 2018

cgiboudeaux accepted D12867: Fix minor documentation typos.

Please use the GIT_SILENT keyword for typo fixes.

May 14 2018, 9:29 AM · Build System, Frameworks

May 3 2018

cgiboudeaux added inline comments to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
May 3 2018, 8:19 AM · Frameworks

Apr 26 2018

cgiboudeaux updated subscribers of R231:29e3db479fa9: Fix includes..
Apr 26 2018, 12:44 PM
cgiboudeaux added a comment to R231:29e3db479fa9: Fix includes..

Reverting my change is wrong.

Apr 26 2018, 12:18 PM
cgiboudeaux committed R231:86956ebd340a: Fix linking. (authored by cgiboudeaux).
Fix linking.
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:29e3db479fa9: Fix includes. (authored by cgiboudeaux).
Fix includes.
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:23635121328d: --warning (authored by cgiboudeaux).
--warning
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:c93f7880e4d6: Try to get more hints about qwt_plot.h's location. (authored by cgiboudeaux).
Try to get more hints about qwt_plot.h's location.
Apr 26 2018, 9:26 AM

Apr 18 2018

cgiboudeaux committed R838:5b930a734302: Avoid issues if pkgconfig cannot find the libraries. (authored by cgiboudeaux).
Avoid issues if pkgconfig cannot find the libraries.
Apr 18 2018, 11:08 AM
cgiboudeaux committed R838:c1b2cb0ca9ab: Update variables names. (authored by cgiboudeaux).
Update variables names.
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:40ff7a1cdaff: Look for pkgconfig quietly. (authored by cgiboudeaux).
Look for pkgconfig quietly.
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:ceec25ebe647: Update the doc (authored by cgiboudeaux).
Update the doc
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:9231501eeb73: Simplify. (authored by cgiboudeaux).
Simplify.
Apr 18 2018, 11:06 AM
cgiboudeaux accepted D12147: Search properly for pipewire and other libs.

Thanks. Please push, I'll fix the remaining issues

Apr 18 2018, 9:58 AM
cgiboudeaux committed R240:4560590bf806: Include FeatureSummary before calling set_package_properties. (authored by cgiboudeaux).
Include FeatureSummary before calling set_package_properties.
Apr 18 2018, 9:50 AM

Apr 12 2018

cgiboudeaux added inline comments to D12147: Search properly for pipewire and other libs.
Apr 12 2018, 1:41 PM

Apr 7 2018

cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Apr 7 2018, 9:18 AM · Build System, Frameworks
cgiboudeaux committed R249:82d40a309b78: Also let the autotests know where they can find KF5I18NMacros (authored by cgiboudeaux).
Also let the autotests know where they can find KF5I18NMacros
Apr 7 2018, 9:05 AM

Apr 6 2018

cgiboudeaux added inline comments to D11772: AtCoreWidgets.
Apr 6 2018, 1:42 PM · Atelier: AtCore
cgiboudeaux added inline comments to D11772: AtCoreWidgets.
Apr 6 2018, 1:40 PM · Atelier: AtCore

Mar 29 2018

cgiboudeaux committed R282:62668acedad0: Export the NetworkManager include dirs. (authored by cgiboudeaux).
Export the NetworkManager include dirs.
Mar 29 2018, 11:47 PM
cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

The alkimia build system is such a mess that it should be reworked from scratch. I'm not surprised.

Volunteers are always welcome. If you have the necessary foo to do it, go for it. This is what Phabricator is for.

Mar 29 2018, 7:45 PM

Mar 28 2018

cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

This patch is not fixing the issue correctly.
The correct way to populate the interface is to use target_include_directories in the CMakeLists.txt that creates this library (ie: alkimia/src)

There are reasons, why the patch is at is. See D10043 for more details.

The alkimia build system is such a mess that it should be reworked from scratch. I'm not surprised.

Mar 28 2018, 9:45 PM
cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

This patch is not fixing the issue correctly.

Mar 28 2018, 5:17 PM
cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

[...]

Mar 28 2018, 10:25 AM · Build System, Frameworks
cgiboudeaux committed R249:e6d3d6633337: Make sure ki18n can build its own translations. (authored by cgiboudeaux).
Make sure ki18n can build its own translations.
Mar 28 2018, 10:24 AM
cgiboudeaux committed R290:ea92225539ab: Try to fix the FreeBSD build. (authored by cgiboudeaux).
Try to fix the FreeBSD build.
Mar 28 2018, 9:09 AM
cgiboudeaux committed R290:261c9bca4d98: Use Qt5::rcc instead of looking for the executable. (authored by cgiboudeaux).
Use Qt5::rcc instead of looking for the executable.
Mar 28 2018, 9:09 AM

Mar 27 2018

cgiboudeaux committed R249:6c1db934e648: Don't call PythonInterp.cmake in KF5I18NMacros. (authored by cgiboudeaux).
Don't call PythonInterp.cmake in KF5I18NMacros.
Mar 27 2018, 1:55 PM
cgiboudeaux closed D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Mar 27 2018, 1:54 PM · Build System, Frameworks

Mar 26 2018

cgiboudeaux committed R165:a9cd11ceaeeb: Revert "Install akonadicore_debug.h." (authored by cgiboudeaux).
Revert "Install akonadicore_debug.h."
Mar 26 2018, 9:03 AM
cgiboudeaux added a reverting change for R165:0f36015c31ce: Install akonadicore_debug.h.: R165:a9cd11ceaeeb: Revert "Install akonadicore_debug.h.".
Mar 26 2018, 9:03 AM

Mar 25 2018

cgiboudeaux committed R165:0f36015c31ce: Install akonadicore_debug.h. (authored by cgiboudeaux).
Install akonadicore_debug.h.
Mar 25 2018, 10:00 AM

Mar 24 2018

cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

ping. Unless someone objects, I will push this change in a couple days.

Mar 24 2018, 2:10 PM · Build System, Frameworks

Mar 13 2018

cgiboudeaux committed R351:bd52e39a273c: Fix build. (authored by cgiboudeaux).
Fix build.
Mar 13 2018, 9:16 AM

Mar 9 2018

cgiboudeaux committed R163:541aff380509: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Mar 9 2018, 1:24 PM
cgiboudeaux committed R163:a84c183bb252: Also detect fluidsynth 1.1.xx (authored by cgiboudeaux).
Also detect fluidsynth 1.1.xx
Mar 9 2018, 1:23 PM
cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

Disclaimer: I'm not really happy with this solution.

Mar 9 2018, 11:33 AM · Build System, Frameworks
cgiboudeaux updated the test plan for D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Mar 9 2018, 11:30 AM · Build System, Frameworks
cgiboudeaux added a project to D11176: Don't call PythonInterp.cmake in KF5I18NMacros.: Build System.
Mar 9 2018, 11:28 AM · Build System, Frameworks
cgiboudeaux requested review of D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Mar 9 2018, 11:28 AM · Build System, Frameworks
cgiboudeaux renamed T8168: SQL improvements from SQL improvments to SQL improvements.
Mar 9 2018, 10:34 AM · KDE PIM

Mar 7 2018

cgiboudeaux committed R163:966c0336e40c: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Mar 7 2018, 7:49 PM
cgiboudeaux committed R163:78ba12090335: Fix Build when fluidsynth isn't found. (authored by cgiboudeaux).
Fix Build when fluidsynth isn't found.
Mar 7 2018, 7:49 PM
cgiboudeaux committed R163:3e189bb70069: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Mar 7 2018, 5:01 PM
cgiboudeaux committed R163:b49f3bd09d91: Create FindFluidSynth.cmake. (authored by cgiboudeaux).
Create FindFluidSynth.cmake.
Mar 7 2018, 5:00 PM
cgiboudeaux closed D11095: Create FindFluidSynth.cmake..
Mar 7 2018, 5:00 PM · KDE Edu

Mar 6 2018

cgiboudeaux added a comment to D11095: Create FindFluidSynth.cmake..

Note: I would also like to push that to Applications/17.12. It likely fixes the Windows failures.

Mar 6 2018, 1:15 PM · KDE Edu
cgiboudeaux requested review of D11095: Create FindFluidSynth.cmake..
Mar 6 2018, 12:49 PM · KDE Edu
cgiboudeaux committed R163:0d397739f8a8: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Mar 6 2018, 10:52 AM
cgiboudeaux committed R163:f1bab8d022b7: Fix build with fluidsynth 1.1.9. (authored by cgiboudeaux).
Fix build with fluidsynth 1.1.9.
Mar 6 2018, 10:49 AM

Mar 2 2018

cgiboudeaux committed R469:d9577c99c0ad: Fix build #2. (authored by cgiboudeaux).
Fix build #2.
Mar 2 2018, 12:11 PM
cgiboudeaux committed R469:39ab21f4c6c1: Fix build. (authored by cgiboudeaux).
Fix build.
Mar 2 2018, 10:37 AM

Feb 26 2018

cgiboudeaux committed R94:bbbd4bf77058: Typo. (authored by cgiboudeaux).
Typo.
Feb 26 2018, 8:05 AM

Feb 21 2018

cgiboudeaux committed R261:1aeea90b8ecb: Fix build with CMake 3.1. (authored by cgiboudeaux).
Fix build with CMake 3.1.
Feb 21 2018, 11:28 AM

Jan 31 2018

cgiboudeaux accepted D10201: FindQtWaylandScanner.cmake: Use qmake-query for HINT.

Thanks

Jan 31 2018, 3:12 PM · Build System, Frameworks
cgiboudeaux added a comment to D9116: Make sure to search for Qt5-based qmlplugindump.

Want me to fix FindQtWaylandScanner.cmake in the same way?

Jan 31 2018, 2:58 PM · Build System, Frameworks
cgiboudeaux accepted D9116: Make sure to search for Qt5-based qmlplugindump.
Jan 31 2018, 2:46 PM · Build System, Frameworks

Jan 29 2018

cgiboudeaux added a comment to D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings.

These flags are not in the Clang warnings (list for each version here: https://github.com/Barro/compiler-warnings)

Jan 29 2018, 8:03 AM · Build System, Frameworks

Jan 28 2018

cgiboudeaux accepted D8998: Add FindSeccomp to find-modules.
Jan 28 2018, 9:47 AM · Build System, Frameworks

Jan 25 2018

cgiboudeaux committed R172:7c3e7873b63d: Add the patch version to LibIcal_VERSION if available. (authored by cgiboudeaux).
Add the patch version to LibIcal_VERSION if available.
Jan 25 2018, 7:23 PM
cgiboudeaux committed R172:e9c025d88a03: FindLibIcal already defines the description and URL. (authored by cgiboudeaux).
FindLibIcal already defines the description and URL.
Jan 25 2018, 7:23 PM

Jan 24 2018

cgiboudeaux added inline comments to D10075: Make pacakge usefull for cross compilation.
Jan 24 2018, 2:10 PM · Frameworks
cgiboudeaux committed R172:6377808f5b5c: Refresh FindLibIcal.cmake (authored by cgiboudeaux).
Refresh FindLibIcal.cmake
Jan 24 2018, 1:50 PM

Jan 23 2018

cgiboudeaux added inline comments to D10011: make cmake/FindLibIcal.cmake ready for cross compilation..
Jan 23 2018, 3:06 PM · KDE PIM
cgiboudeaux added inline comments to D10011: make cmake/FindLibIcal.cmake ready for cross compilation..
Jan 23 2018, 10:50 AM · KDE PIM
cgiboudeaux added a comment to D10011: make cmake/FindLibIcal.cmake ready for cross compilation..

@cgiboudeaux: did you checked on Windows? Is the whole WIN32 block is still needed, or can it removed completly?

Jan 23 2018, 10:43 AM · KDE PIM

Jan 22 2018

cgiboudeaux added inline comments to D10011: make cmake/FindLibIcal.cmake ready for cross compilation..
Jan 22 2018, 8:55 AM · KDE PIM
cgiboudeaux added inline comments to D10011: make cmake/FindLibIcal.cmake ready for cross compilation..
Jan 22 2018, 8:42 AM · KDE PIM

Jan 10 2018

cgiboudeaux added a comment to D9116: Make sure to search for Qt5-based qmlplugindump.

Can we move forward with this?

Jan 10 2018, 3:13 PM · Build System, Frameworks

Dec 22 2017

cgiboudeaux added inline comments to D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'.
Dec 22 2017, 9:12 PM · Frameworks
cgiboudeaux added a comment to D9476: Fix duplicate authentication.

Tested successfully with 5 different SMTP servers with both SSL and TLS.

Dec 22 2017, 11:00 AM · KDE PIM

Dec 17 2017

cgiboudeaux added a comment to D5175: Fix 'Installed name of kio_http_cache_cleaner conflicts with related KDE4 installation'..

This will have effects on the non-kio users : https://lxr.kde.org/search?_string=kio_http_cache_cleaner

Dec 17 2017, 9:16 PM · Frameworks

Dec 13 2017

cgiboudeaux committed R44:9fe914a176b2: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Dec 13 2017, 12:01 PM
cgiboudeaux committed R44:bd53e95a1207: Add and remove some license files. (authored by cgiboudeaux).
Add and remove some license files.
Dec 13 2017, 11:21 AM
cgiboudeaux added a comment to D9299: Introduce INSTALL_PREFIX_SCRIPT to easily set up prefixes.
In D9299#179032, @kfunk wrote:

If we'd name this file somewhat less generic then it could be even installed by default, no?

I had the scheme of the QNX setup script in my mind: https://github.com/acklinr/qnx660/blob/master/qnx660-env.sh

Thus: Maybe rename prefix.sh to say 'ecm-env.sh' and install the file by default?

Files overwritting each others is a no-go for packagers. +1 for a less generic name however.

Dec 13 2017, 10:22 AM · Build System, Frameworks