cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (177 w, 2 d)
Availability
Available

Recent Activity

Today

cgiboudeaux added a comment to D18137: delete copy constructor and assignment operator of some public classes.

This is causing an error when building the python bindings:

Thu, Jan 17, 2:13 PM · Frameworks
cgiboudeaux added a comment to D18244: Check for python-cairo.

This breaks NeonKubuntu builds, whereas previously the builds were working as I explicitly had added python3-cairo to the build depends. It is there still, but cmake thinks not.

EDIT: seems specific to cmake < 3.12 in Bionic. Kubuntu Cosmic/Disco build with cmake 3.12 finds python3-cairo, but fails on another issue probably related a different recent commit.

https://build.neon.kde.org/job/bionic_unstable_kde_breeze-gtk_bin_amd64/51/consoleFull

02:43:04 -- The following REQUIRED packages have not been found:
02:43:04
02:43:04 * PythonCairo
02:43:04 Required to render assets

Thu, Jan 17, 9:37 AM · Plasma

Yesterday

cgiboudeaux added a comment to D18244: Check for python-cairo.

+1

Wed, Jan 16, 1:25 PM · Plasma
cgiboudeaux added inline comments to D18244: Check for python-cairo.
Wed, Jan 16, 9:51 AM · Plasma

Mon, Jan 14

cgiboudeaux added inline comments to D18244: Check for python-cairo.
Mon, Jan 14, 4:41 PM · Plasma
cgiboudeaux added a comment to D17154: Go back to SCSS.

Are there any strong reasons?

It's not installed, so a user can't use it.

That means it's only a build tool. As it's a build tool it's very important to not get stuff from the host system as it makes things less reproducible.

Mon, Jan 14, 11:45 AM · Plasma

Mon, Dec 31

cgiboudeaux added inline comments to D17154: Go back to SCSS.
Mon, Dec 31, 12:58 PM · Plasma
cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

include(ECMCheckLinkerFlags)
[...]
# Check for nodump support
SET(NODUMP_FLAGS "-Wl,-z,nodump")
ecm_check_linker_flags("${NODUMP_FLAGS}" NODUMP_SUPPORTED)
if (NODUMP_SUPPORTED)
    SET(SEC_LINK_FLAGS "${SEC_LINK_FLAGS} ${NODUMP_FLAGS}")
endif ()

Of course kstars could also just stop adding nodump ever :)

Mon, Dec 31, 12:45 PM · Build System, Frameworks

Sun, Dec 30

cgiboudeaux added a comment to D17863: Add ecm_check_linker_flags function.

Why not fixing kstars instead?

Sun, Dec 30, 11:10 PM · Build System, Frameworks

Fri, Dec 21

cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Try to find qmake if qmake-qt5 is not found

Fri, Dec 21, 2:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..

Reverted and the version was fixed.

Fri, Dec 21, 10:13 AM · Frameworks
cgiboudeaux committed R6:d5cf9284ebe5: Fix the version in the pkgconfig file. (authored by cgiboudeaux).
Fix the version in the pkgconfig file.
Fri, Dec 21, 10:12 AM
cgiboudeaux committed R6:a5d904ae6d76: Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file." (authored by cgiboudeaux).
Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file."
Fri, Dec 21, 10:12 AM
cgiboudeaux added a reverting change for R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: R6:a5d904ae6d76: Revert "Use ECMGeneratePkgConfigFile to create the pkgconfig file.".
Fri, Dec 21, 10:12 AM
cgiboudeaux removed a reviewer for D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: alexeymin.
In D17718#380267, @pino wrote:

I tested this, it indeed fixes 390225
Withoug this patch, generated pkgconfig file was:

prefix=/usr
exec_prefix=bin
libdir=lib/x86_64-linux-gnu
includedir=include

Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
URL: http://www.kde.org
Requires: Qt5Core
Version: 
Libs: -Llib/x86_64-linux-gnu -lKF5Activities
Cflags: -Iinclude

With this, version field is filled in and full paths are specified:

Name: libKActivities
Description: libKActivities is a C++ library for using KDE activities
Version: 5.54.0
Libs: -L/usr/lib/x86_64-linux-gnu -llibKActivities

This seems wrong to me, the library is called KF5Activities and not libKActivities.

Cflags: -I/usr/include/libKActivities

Ditto.

Fri, Dec 21, 10:05 AM · Frameworks
cgiboudeaux committed R6:52267908a1e4: Use ECMGeneratePkgConfigFile to create the pkgconfig file. (authored by cgiboudeaux).
Use ECMGeneratePkgConfigFile to create the pkgconfig file.
Fri, Dec 21, 9:51 AM
cgiboudeaux closed D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..
Fri, Dec 21, 9:51 AM · Frameworks
cgiboudeaux added reviewers for D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file.: cfeck, Build System.
Fri, Dec 21, 9:20 AM · Frameworks
cgiboudeaux requested review of D17718: Use ECMGeneratePkgConfigFile to create the pkgconfig file..
Fri, Dec 21, 9:19 AM · Frameworks

Thu, Dec 20

cgiboudeaux accepted D17714: Clang: don't enable -Wzero-as-null-pointer-constant on 5.0.0.
Thu, Dec 20, 8:43 PM · Build System, Frameworks

Dec 16 2018

cgiboudeaux accepted D17547: Bring FindFontconfig.cmake up to ECM standards.

+1

Dec 16 2018, 9:52 AM · KWin

Dec 15 2018

cgiboudeaux added inline comments to D17547: Bring FindFontconfig.cmake up to ECM standards.
Dec 15 2018, 12:23 PM · KWin

Dec 13 2018

cgiboudeaux added inline comments to D17547: Bring FindFontconfig.cmake up to ECM standards.
Dec 13 2018, 11:51 AM · KWin

Dec 3 2018

cgiboudeaux accepted D16954: Add find module for Google's libphonenumber.
Dec 3 2018, 6:02 PM · Build System, Frameworks
cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

Good to see you caring for ECM documentation not getting broken with Qt 5.12 :)

Any idea how we could perhaps deduplicate the FindQHelpGenerator.cmake with the one from find-modules (which is a helper for runtime with the ECMAddQch macro)? No instant idea yet, perhaps also better to have dedicated variants for each purppse? Needs me another round of thinking.

Dec 3 2018, 11:46 AM · Build System, Frameworks
cgiboudeaux updated the diff for D17015: Fix the Qt doc creation with Qt 5.12..

Add the reason for looking for the executable

Dec 3 2018, 11:40 AM · Build System, Frameworks

Dec 1 2018

cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:16 PM · Build System, Frameworks
cgiboudeaux added inline comments to D16954: Add find module for Google's libphonenumber.
Dec 1 2018, 9:11 PM · Build System, Frameworks

Nov 30 2018

cgiboudeaux committed R260:220449149133: Merge branch 'Applications/18.12' (authored by cgiboudeaux).
Merge branch 'Applications/18.12'
Nov 30 2018, 10:32 AM
cgiboudeaux committed R260:6f4e08953736: Make FindExiv2.cmake work with exiv 0.27. (authored by cgiboudeaux).
Make FindExiv2.cmake work with exiv 0.27.
Nov 30 2018, 10:32 AM
cgiboudeaux closed D17040: Make FindExiv2.cmake work with exiv 0.27..
Nov 30 2018, 10:32 AM · Gwenview

Nov 27 2018

cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Nov 27 2018, 10:32 PM · Frameworks, Dolphin
cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Nov 27 2018, 10:28 PM · Frameworks, Dolphin
cgiboudeaux committed R377:7cc73de75a8c: Fix the maintainer username. (authored by cgiboudeaux).
Fix the maintainer username.
Nov 27 2018, 10:54 AM
cgiboudeaux committed R175:e7c154e2f950: Use the right maintainer username. (authored by cgiboudeaux).
Use the right maintainer username.
Nov 27 2018, 10:51 AM

Nov 24 2018

cgiboudeaux accepted D16929: Remove dead search provider.
Nov 24 2018, 11:42 AM · Frameworks

Nov 21 2018

cgiboudeaux committed R81:0bc68edcbe13: Only build the tests if BUILD_TESTING is ON (authored by cgiboudeaux).
Only build the tests if BUILD_TESTING is ON
Nov 21 2018, 8:12 AM

Nov 20 2018

cgiboudeaux added a comment to D17044: Add FindExiv2.cmake to ECM.

Done. kfilemetadata was also changed to use FindLibExiv2.cmake.

Nov 20 2018, 1:44 PM · Build System, Frameworks
cgiboudeaux committed R286:f32793945692: Adapt to the FindExiv2 -> FindLibExiv2 name change in ECM. (authored by cgiboudeaux).
Adapt to the FindExiv2 -> FindLibExiv2 name change in ECM.
Nov 20 2018, 1:44 PM
cgiboudeaux committed R240:19e6a585a7ae: Rename FindExiv2 to FindLibExiv2. (authored by cgiboudeaux).
Rename FindExiv2 to FindLibExiv2.
Nov 20 2018, 1:38 PM
cgiboudeaux added inline comments to D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 1:29 PM · Build System, Frameworks
cgiboudeaux committed R286:c3cc05f4eee2: Use the new FindExiv2 module from ECM. (authored by cgiboudeaux).
Use the new FindExiv2 module from ECM.
Nov 20 2018, 1:04 PM
cgiboudeaux closed D17046: Use the new FindExiv2 module from ECM..
Nov 20 2018, 1:04 PM · Baloo, Frameworks
cgiboudeaux added a comment to D17046: Use the new FindExiv2 module from ECM..

Please feel free to land this after solving my comment.

Nov 20 2018, 1:04 PM · Baloo, Frameworks
cgiboudeaux requested review of D17046: Use the new FindExiv2 module from ECM..
Nov 20 2018, 12:55 PM · Baloo, Frameworks
cgiboudeaux committed R240:fe22302d2d4d: Add FindExiv2.cmake to ECM (authored by cgiboudeaux).
Add FindExiv2.cmake to ECM
Nov 20 2018, 12:30 PM
cgiboudeaux added a reviewer for D17015: Fix the Qt doc creation with Qt 5.12.: kossebau.
Nov 20 2018, 12:29 PM · Build System, Frameworks
cgiboudeaux closed D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 12:28 PM · Build System, Frameworks
cgiboudeaux requested review of D17044: Add FindExiv2.cmake to ECM.
Nov 20 2018, 11:42 AM · Build System, Frameworks
cgiboudeaux abandoned D17043: Fix the Qt doc creation with Qt 5.12..
Nov 20 2018, 11:29 AM · Build System, Frameworks
cgiboudeaux requested review of D17043: Fix the Qt doc creation with Qt 5.12..
Nov 20 2018, 11:19 AM · Build System, Frameworks
cgiboudeaux added a comment to D17040: Make FindExiv2.cmake work with exiv 0.27..

Hm... I guess this would be good to have in Krita, too, which also has a findExiv2.cmake

Nov 20 2018, 10:14 AM · Gwenview
cgiboudeaux added a reviewer for D17040: Make FindExiv2.cmake work with exiv 0.27.: kde-frameworks-devel.
Nov 20 2018, 10:06 AM · Gwenview
cgiboudeaux requested review of D17040: Make FindExiv2.cmake work with exiv 0.27..
Nov 20 2018, 10:02 AM · Gwenview

Nov 19 2018

cgiboudeaux added a comment to D17015: Fix the Qt doc creation with Qt 5.12..

If anyone wonders:

Nov 19 2018, 1:39 PM · Build System, Frameworks
cgiboudeaux requested review of D17015: Fix the Qt doc creation with Qt 5.12..
Nov 19 2018, 1:33 PM · Build System, Frameworks

Nov 16 2018

cgiboudeaux added a comment to D16929: Remove dead search provider.

Remove more dead search providers, just checking for non-resolving domains isn't enough.

Nov 16 2018, 10:23 PM · Frameworks
cgiboudeaux committed R88:80ef694d40da: Merge branch 'Applications/18.12' (authored by cgiboudeaux).
Merge branch 'Applications/18.12'
Nov 16 2018, 8:15 AM
cgiboudeaux committed R88:da4a9705bf09: Remove the shutdown notice. (authored by cgiboudeaux).
Remove the shutdown notice.
Nov 16 2018, 8:15 AM
cgiboudeaux closed D16892: Remove the shutdown notice..
Nov 16 2018, 8:15 AM · KDE PIM

Nov 15 2018

cgiboudeaux updated the diff for D16892: Remove the shutdown notice..

Make test pass

Nov 15 2018, 7:35 PM · KDE PIM
cgiboudeaux requested review of D16892: Remove the shutdown notice..
Nov 15 2018, 10:27 AM · KDE PIM

Nov 13 2018

cgiboudeaux accepted D16862: Fix CMake condition.
Nov 13 2018, 12:27 PM · Frameworks

Nov 9 2018

cgiboudeaux added a reviewer for D9450: Fixed windows.h can cause min/max conflicts: Windows.
Nov 9 2018, 9:20 AM

Nov 8 2018

cgiboudeaux committed R226:902758705c5e: Fix build with Qt 5.12 (authored by cgiboudeaux).
Fix build with Qt 5.12
Nov 8 2018, 10:25 AM

Oct 24 2018

cgiboudeaux added a comment to D15070: Bindings: Support using sys paths for python install directory.

So, after another week, no reason has been given not to accept this.

  1. It fixes broken behavior on several platforms
  2. It does not break current setups
  3. It is consistent with other config variables
Oct 24 2018, 1:10 PM · Build System, Frameworks

Oct 18 2018

cgiboudeaux added a comment to D15070: Bindings: Support using sys paths for python install directory.

As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future?

No, the empty if must be removed. Code that does nothing is useless.

Its not empty, there is a comment inside. Of course I can add a set(KDE_INSTALL_PYTHON${pyversion}DIR ${KDE_INSTALL_PYTHON${pyversion}DIR}) if you insist ...

And if you restructure it you either end up with a lengthy if condition - if (NOT KDE_INSTALL_PYTHON${pyversion}DIR AND KDE_INSTALL_USE_PYTHON${pyversion}_SYS_PATHS) - or another nesting level. Both are significantly harder to read.

Oct 18 2018, 9:58 AM · Build System, Frameworks

Oct 17 2018

cgiboudeaux added a comment to D15070: Bindings: Support using sys paths for python install directory.

As all the raised concerns have been dealed with, can we give this a try while the next KF release is still somewhat in the future?

Oct 17 2018, 6:39 PM · Build System, Frameworks

Oct 3 2018

cgiboudeaux committed R246:2e364ebbf240: Fix compile failure on Windows targets (authored by zrax).
Fix compile failure on Windows targets
Oct 3 2018, 9:24 PM
cgiboudeaux closed D15909: Fix compile failure on Windows targets.
Oct 3 2018, 9:24 PM · Frameworks

Oct 1 2018

cgiboudeaux added inline comments to D15070: Bindings: Support using sys paths for python install directory.
Oct 1 2018, 7:31 AM · Build System, Frameworks

Sep 14 2018

cgiboudeaux committed R290:b32efcd75710: Move Qt5::DBus to the 'PRIVATE' link targets (authored by cgiboudeaux).
Move Qt5::DBus to the 'PRIVATE' link targets
Sep 14 2018, 12:04 PM

Sep 12 2018

cgiboudeaux added a comment to D15442: Improve DDCUtil handling in CMakeLists.

With the change, you can't tell if powerdevil must use the old or the new api. Suggestion: https://paste.kde.org/powk2bhxm

Sep 12 2018, 10:30 AM · Plasma

Sep 7 2018

cgiboudeaux accepted D15327: Add appmenu-gtk-module as runtime dependency.
Sep 7 2018, 9:40 AM · Plasma
cgiboudeaux added a comment to D15070: Bindings: Support using sys paths for python install directory.

And why isn't it up to the user to set GPB_PYTHON2_SITEARCH when installing out of the usual directories?

Sep 7 2018, 7:33 AM · Build System, Frameworks

Sep 6 2018

cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

Checking that Qt5Core version is initialized

Sep 6 2018, 9:04 AM · Plasma
cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

I have this in my dev setup

PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig

If you had the equivalent, would you need this?

Agreed, that's an issue with your environment not being set correctly.

It does work with PKG_CONFIG_PATH pointing to the custom Qt directory.
However, if the PREFIX is set and works for the rest of the modules, it should be able to work without this additional configuration.

Sep 6 2018, 9:02 AM · Plasma
cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

I have this in my dev setup

PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig

If you had the equivalent, would you need this?

Sep 6 2018, 8:25 AM · Plasma
cgiboudeaux added inline comments to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.
Sep 6 2018, 8:24 AM · Plasma

Sep 4 2018

cgiboudeaux added a comment to D15228: Export install location for DBUS interfaces via CMake.

This did not break the build, but D15229 becoming effective before this one.

Sep 4 2018, 8:10 PM · Plasma
cgiboudeaux added a comment to D15228: Export install location for DBUS interfaces via CMake.
Sep 4 2018, 7:37 AM · Plasma
cgiboudeaux committed R133:36a7e0313b15: Fix the plasma-workspace build. (authored by cgiboudeaux).
Fix the plasma-workspace build.
Sep 4 2018, 7:05 AM

Aug 27 2018

cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

David, Elvis, what's the nicest way to fix this ? (https://phabricator.kde.org/D15076#315803 for the details)

Aug 27 2018, 9:27 PM · KDE Edu
cgiboudeaux updated subscribers of D15076: Build failures with KSyntaxHighlighting 5.49.
Aug 27 2018, 9:25 PM · KDE Edu

Aug 26 2018

cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.
Aug 26 2018, 8:23 PM · KDE Edu
cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM?

Aug 26 2018, 8:11 AM · KDE Edu

Aug 21 2018

cgiboudeaux committed R246:ff828c02b09d: Fix a typo (authored by cgiboudeaux).
Fix a typo
Aug 21 2018, 9:10 AM

Aug 18 2018

cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Aug 18 2018, 10:57 AM · Frameworks, Dolphin

Aug 4 2018

cgiboudeaux added inline comments to D14569: Make it possible for ECM to detect po files at configure time.
Aug 4 2018, 1:35 PM · Build System, Frameworks

Aug 3 2018

cgiboudeaux accepted D14569: Make it possible for ECM to detect po files at configure time.
Aug 3 2018, 8:23 AM · Build System, Frameworks

Jul 24 2018

cgiboudeaux committed R155:8d64aafa893e: Merge remote-tracking branch 'origin/Applications/18.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/18.08'
Jul 24 2018, 8:26 AM
cgiboudeaux committed R155:d5ada00cde8f: Fix FindAccountsFileDir.cmake (authored by cgiboudeaux).
Fix FindAccountsFileDir.cmake
Jul 24 2018, 8:24 AM

Jul 16 2018

cgiboudeaux committed R240:f19f90956b4d: Change the 'since' version. (authored by cgiboudeaux).
Change the 'since' version.
Jul 16 2018, 6:44 AM

Jul 14 2018

l10n daemon script <scripty@kde.org> committed R249:d7914620cbad: Fix the binary-factory builds. (authored by cgiboudeaux).
Fix the binary-factory builds.
Jul 14 2018, 10:08 AM
cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time (and it definitely not on the Binary Factory nodes)
In particular it breaks KGeography - see https://binary-factory.kde.org/job/KGeography_Nightly_win32/112/console

Jul 14 2018, 9:51 AM · Build System, Frameworks
cgiboudeaux committed R249:c5b721dc1753: Fix the binary-factory builds. (authored by cgiboudeaux).
Fix the binary-factory builds.
Jul 14 2018, 9:47 AM

Jul 10 2018

cgiboudeaux added inline comments to D13816: Make KItinerary work as a static library.
Jul 10 2018, 12:52 PM · KDE PIM

Jul 8 2018

cgiboudeaux committed R78:2c86217da538: Don't hardcode link colors. (authored by cgiboudeaux).
Don't hardcode link colors.
Jul 8 2018, 1:00 PM

Jul 6 2018

cgiboudeaux added a comment to D13698: Improve ECMAddAppIconMacro..

The 5.48 release is close. Don't forget to push these changes.

Jul 6 2018, 8:39 AM · Build System, Frameworks

Jul 3 2018

cgiboudeaux accepted D13698: Improve ECMAddAppIconMacro..

Thanks !

Jul 3 2018, 4:22 PM · Build System, Frameworks