cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (203 w, 2 d)
Availability
Available

Recent Activity

Mon, Jul 15

cgiboudeaux committed R79:02a62e05247d: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Mon, Jul 15, 6:33 PM

Sat, Jun 29

cgiboudeaux added a comment to D22156: RFC: Add wayland-protocols find module.

how many users are there?

Sat, Jun 29, 6:34 PM · Build System, Frameworks

Jun 10 2019

cgiboudeaux added a comment to D21695: Add FindTaglib.cmake.

attic/modules/FindTaglib.cmake shall be deleted.

Jun 10 2019, 11:44 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21695: Add FindTaglib.cmake.
Jun 10 2019, 11:41 AM · Build System, Frameworks
cgiboudeaux committed R165:00508264f17e: Fix a typo. (authored by cgiboudeaux).
Fix a typo.
Jun 10 2019, 9:31 AM

Jun 7 2019

cgiboudeaux committed R44:60fff863ae9a: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 7 2019, 8:26 AM
cgiboudeaux committed R44:062f5103e194: Try to fix a race condition. (authored by cgiboudeaux).
Try to fix a race condition.
Jun 7 2019, 8:24 AM

May 31 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

May 31 2019, 8:45 AM · Build System, Frameworks
cgiboudeaux accepted D21313: Create specific directory for Qt logging categories file.
May 31 2019, 8:43 AM · Build System, Frameworks

May 24 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 7:45 AM · Build System, Frameworks

May 21 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

May 21 2019, 7:52 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 7:16 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 6:51 AM · Build System, Frameworks

May 14 2019

cgiboudeaux committed R81:bfa860df4102: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 4:06 PM
cgiboudeaux committed R81:14886286b5bb: Look for KF5ContactEditor before trying to use it (authored by cgiboudeaux).
Look for KF5ContactEditor before trying to use it
May 14 2019, 4:05 PM
cgiboudeaux committed R82:2abe2a37c2eb: Fix the broken merge (authored by cgiboudeaux).
Fix the broken merge
May 14 2019, 3:39 PM
cgiboudeaux added a comment to D21214: Fix the kmime dependencies..

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?

May 14 2019, 3:31 PM · KDE PIM
cgiboudeaux committed R82:89d39d59cb39: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 3:24 PM
cgiboudeaux committed R82:44cca93d8f98: Use the akonadi-contact version for KF5ContactEditor (authored by cgiboudeaux).
Use the akonadi-contact version for KF5ContactEditor
May 14 2019, 3:23 PM
cgiboudeaux requested review of D21214: Fix the kmime dependencies..
May 14 2019, 1:42 PM · KDE PIM
cgiboudeaux committed R82:ac5c8458594f: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 1:32 PM
cgiboudeaux committed R82:f1e5df49e577: Add the missing KF5ContactEditor dependency (authored by cgiboudeaux).
Add the missing KF5ContactEditor dependency
May 14 2019, 1:30 PM
cgiboudeaux committed R459:c9f0980c49ff: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:24 PM
cgiboudeaux committed R459:5b3c2557bac1: Fix the akonadi-contacts dependencies (authored by cgiboudeaux).
Fix the akonadi-contacts dependencies
May 14 2019, 12:22 PM
cgiboudeaux closed D21208: Fix the akonadi-contacts dependencies.
May 14 2019, 12:22 PM · KDE PIM
cgiboudeaux committed R460:38bbacaf75bc: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:21 PM
cgiboudeaux committed R460:0fbe4700cc9a: Fix the akonadi-mime dependencies (authored by cgiboudeaux).
Fix the akonadi-mime dependencies
May 14 2019, 12:17 PM
cgiboudeaux closed D21210: Fix the akonadi-mime dependencies.
May 14 2019, 12:17 PM · KDE PIM
cgiboudeaux committed R461:41d2cf8a3a6d: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:15 PM
cgiboudeaux closed D21211: Fix the akonadi-notes dependencies.
May 14 2019, 12:14 PM · KDE PIM
cgiboudeaux committed R461:bbaa8676daef: Fix the akonadi-notes dependencies (authored by cgiboudeaux).
Fix the akonadi-notes dependencies
May 14 2019, 12:14 PM
cgiboudeaux committed R170:4945abc5d774: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:13 PM
cgiboudeaux committed R170:d18ba909b43e: Fix the akonadi-calendar dependencies (authored by cgiboudeaux).
Fix the akonadi-calendar dependencies
May 14 2019, 12:10 PM
cgiboudeaux closed D21207: Fix the akonadi-calendar dependencies.
May 14 2019, 12:10 PM · KDE PIM
cgiboudeaux committed R165:0cdad4a3a001: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 11:46 AM
cgiboudeaux committed R165:7cc80667611e: Add some missing dependencies in KF5AkonadiConfig.cmake (authored by cgiboudeaux).
Add some missing dependencies in KF5AkonadiConfig.cmake
May 14 2019, 11:44 AM
cgiboudeaux closed D21206: Add some missing dependencies in KF5AkonadiConfig.cmake.
May 14 2019, 11:44 AM · KDE PIM
cgiboudeaux committed R92:66c86d83a4f5: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 11:19 AM
cgiboudeaux closed D21205: Fix a potential build issue when building KMail.
May 14 2019, 11:18 AM · KDE PIM
cgiboudeaux committed R92:cea29406f7a1: Fix a potential build issue when building KMail (authored by cgiboudeaux).
Fix a potential build issue when building KMail
May 14 2019, 11:18 AM
cgiboudeaux updated the diff for D21211: Fix the akonadi-notes dependencies.

Reenable the QT_DISABLE_DEPRECATED_BEFORE line, the mentioned issue was fixed
in Qt 5.13 beta2.

May 14 2019, 10:52 AM · KDE PIM
cgiboudeaux requested review of D21211: Fix the akonadi-notes dependencies.
May 14 2019, 9:34 AM · KDE PIM
cgiboudeaux requested review of D21210: Fix the akonadi-mime dependencies.
May 14 2019, 9:26 AM · KDE PIM
cgiboudeaux requested review of D21208: Fix the akonadi-contacts dependencies.
May 14 2019, 9:13 AM · KDE PIM
cgiboudeaux requested review of D21207: Fix the akonadi-calendar dependencies.
May 14 2019, 8:51 AM · KDE PIM
cgiboudeaux requested review of D21206: Add some missing dependencies in KF5AkonadiConfig.cmake.
May 14 2019, 8:34 AM · KDE PIM
cgiboudeaux added reviewers for D21205: Fix a potential build issue when building KMail: mlaurent, vandenoever.
May 14 2019, 7:49 AM · KDE PIM
cgiboudeaux requested review of D21205: Fix a potential build issue when building KMail.
May 14 2019, 7:44 AM · KDE PIM

Apr 26 2019

cgiboudeaux accepted D20850: Fix option for diff executable: allow plain names, use "" as default.

tested successfully with & without program and when using the 'default' button.

Apr 26 2019, 6:19 PM

Apr 21 2019

cgiboudeaux committed R499:9a496df3b39d: Fix the kdepim-runtime dependencies. (authored by cgiboudeaux).
Fix the kdepim-runtime dependencies.
Apr 21 2019, 6:03 PM

Apr 13 2019

cgiboudeaux added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

cgiboudeaux: the Qt documentation says that foreach is deprecated, what do you suggest Laurent should add to the commit log? Just "it's deprecated", a copy/paste of the Qt docu, or https://www.kdab.com/goodbye-q_foreach/ ?

Apr 13 2019, 10:59 AM · Frameworks

Apr 12 2019

cgiboudeaux added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

what is the problem with title ?

Apr 12 2019, 1:17 PM · Frameworks
cgiboudeaux added a comment to D20489: [KIO] Make it compile without foreach (Step 1).

Please fix the title

Apr 12 2019, 12:57 PM · Frameworks

Apr 7 2019

cgiboudeaux committed R158:55947bf1893d: Fix a typo in the RTTR target name (authored by cgiboudeaux).
Fix a typo in the RTTR target name
Apr 7 2019, 11:35 AM

Apr 6 2019

cgiboudeaux added a comment to D20270: Remove the sortable addressee list, and all its supporting infrastructure.

Kopete needs a build fix:

Apr 6 2019, 9:56 PM · KDE PIM
cgiboudeaux committed R93:3bc0485e3be1: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 9:14 PM
cgiboudeaux committed R93:80f811af8643: Fix the karchive detection with older CMake versions. (authored by cgiboudeaux).
Fix the karchive detection with older CMake versions.
Apr 6 2019, 9:14 PM
cgiboudeaux committed R92:5d9bb1ae2cf2: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 9:08 PM
cgiboudeaux committed R92:584d35b16849: Fix the kcompletion detection with older CMake versions. (authored by cgiboudeaux).
Fix the kcompletion detection with older CMake versions.
Apr 6 2019, 9:08 PM
cgiboudeaux committed R91:a50baae194f5: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 9:05 PM
cgiboudeaux committed R91:a1e623c1e97d: Fix the syntax-highlighting detection with older CMake versions. (authored by cgiboudeaux).
Fix the syntax-highlighting detection with older CMake versions.
Apr 6 2019, 9:05 PM
cgiboudeaux committed R95:50a9d17d8981: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 9:03 PM
cgiboudeaux committed R95:4bf3c9c3f47a: Fix the kconfig detection with older CMake versions. (authored by cgiboudeaux).
Fix the kconfig detection with older CMake versions.
Apr 6 2019, 9:02 PM
cgiboudeaux committed R79:e742079e3b28: Fix the kholidays detection with older CMake versions. (authored by cgiboudeaux).
Fix the kholidays detection with older CMake versions.
Apr 6 2019, 8:58 PM
cgiboudeaux committed R173:aac689e45505: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:56 PM
cgiboudeaux committed R173:7071f1ea22de: Fix the frameworks detection with older CMake versions. (authored by cgiboudeaux).
Fix the frameworks detection with older CMake versions.
Apr 6 2019, 8:55 PM
cgiboudeaux committed R176:eed667ec50e6: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:54 PM
cgiboudeaux committed R176:1a08bdbded8d: Fix the kcoreaddons detection with older CMake versions. (authored by cgiboudeaux).
Fix the kcoreaddons detection with older CMake versions.
Apr 6 2019, 8:54 PM
cgiboudeaux committed R84:f555aa24d020: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:53 PM
cgiboudeaux committed R84:e45cbd1d8786: Fix the kwallet detection with older CMake versions. (authored by cgiboudeaux).
Fix the kwallet detection with older CMake versions.
Apr 6 2019, 8:52 PM
cgiboudeaux committed R733:33b404fc2b97: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:51 PM
cgiboudeaux committed R733:5ac158c5673b: Fix the kcoreAddons detection with older CMake versions. (authored by cgiboudeaux).
Fix the kcoreAddons detection with older CMake versions.
Apr 6 2019, 8:51 PM
cgiboudeaux committed R86:cb7736eb44d9: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:49 PM
cgiboudeaux committed R86:bd99ac561e2c: Fix the ktextwidgets detection with older CMake versions. (authored by cgiboudeaux).
Fix the ktextwidgets detection with older CMake versions.
Apr 6 2019, 8:49 PM
cgiboudeaux committed R177:985281b09aa9: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Apr 6 2019, 8:46 PM
cgiboudeaux committed R177:6b9dffc518f1: Fix the KF5CoreAddons detection with older CMake versions. (authored by cgiboudeaux).
Fix the KF5CoreAddons detection with older CMake versions.
Apr 6 2019, 8:46 PM
cgiboudeaux committed R165:ab251773accd: Fix the Akonadi detection with older CMake versions (authored by cgiboudeaux).
Fix the Akonadi detection with older CMake versions
Apr 6 2019, 8:42 PM

Mar 31 2019

cgiboudeaux added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

correct

Mar 31 2019, 9:41 AM · KDE PIM

Mar 25 2019

cgiboudeaux committed R44:bbbe2905c7d6: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 25 2019, 2:37 PM
cgiboudeaux committed R44:7f6dc78e62d0: Revert the kalarm changes and fix the race condition differently. (authored by cgiboudeaux).
Revert the kalarm changes and fix the race condition differently.
Mar 25 2019, 2:30 PM

Mar 24 2019

cgiboudeaux added a comment to D20005: Report human-readable error if Qt5Widgets is required but is not found.

Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.

Does it? it doesn't here, or you mean "requires Qt5Widgets" because it tries to use Qt5::uic ?

Mar 24 2019, 10:33 AM · Frameworks
cgiboudeaux added a comment to D20005: Report human-readable error if Qt5Widgets is required but is not found.

That not ideal, ki18n should be usable for projects that don't use widgets too.

I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?

Well, KF5I18nConfig.cmake includes KF5I18nMacros.cmake that requires Qt5Widgets.

For a better visibility, I think adding this to KF5I18nConfig.cmake.in is better:

include(CMakeFindDependencyMacro)
find_dependency(Qt5Widgets @REQUIRED_QT_VERSION@)
Mar 24 2019, 8:44 AM · Frameworks
cgiboudeaux added a comment to D20005: Report human-readable error if Qt5Widgets is required but is not found.

That not ideal, ki18n should be usable for projects that don't use widgets too.

I'd say the bug is on the calling cmake side, if it has a ui file it must surely depend on widgets on the calling side, so just add it there?

Mar 24 2019, 8:42 AM · Frameworks

Mar 23 2019

cgiboudeaux committed R44:65f829310a9f: Update the comment. (authored by cgiboudeaux).
Update the comment.
Mar 23 2019, 5:15 PM
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 2:04 PM · Build System, Frameworks
cgiboudeaux added inline comments to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.
Mar 23 2019, 1:46 PM · Build System, Frameworks
cgiboudeaux committed R44:64864cd2c57e: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 23 2019, 8:08 AM
cgiboudeaux committed R44:6960e439fdfd: Allow running the pimkolab tests. (authored by cgiboudeaux).
Allow running the pimkolab tests.
Mar 23 2019, 8:06 AM
cgiboudeaux committed R44:a8176b6859b3: Allow running the pimkolab tests. (authored by cgiboudeaux).
Allow running the pimkolab tests.
Mar 23 2019, 8:06 AM
cgiboudeaux closed D19981: Allow running the pimkolab tests..
Mar 23 2019, 8:06 AM · KDE PIM

Mar 22 2019

cgiboudeaux requested review of D19981: Allow running the pimkolab tests..
Mar 22 2019, 9:42 PM · KDE PIM
cgiboudeaux committed R44:819ce1b3bca9: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Mar 22 2019, 8:48 PM
cgiboudeaux committed R44:25bd6e5cf880: Try to fix the FreeBSD build when ECM_ENABLE_SANITIZERS is enabled. (authored by cgiboudeaux).
Try to fix the FreeBSD build when ECM_ENABLE_SANITIZERS is enabled.
Mar 22 2019, 8:46 PM
cgiboudeaux committed R44:bf3ef5974208: Try to fix the FreeBSD build when ECM_ENABLE_SANITIZERS is enabled. (authored by cgiboudeaux).
Try to fix the FreeBSD build when ECM_ENABLE_SANITIZERS is enabled.
Mar 22 2019, 8:29 PM
cgiboudeaux committed R175:d1f6062a818c: Sort the polish holidays categories. (authored by cgiboudeaux).
Sort the polish holidays categories.
Mar 22 2019, 1:26 PM

Mar 20 2019

cgiboudeaux accepted D19892: Use https for user-accessible links and documentation.
Mar 20 2019, 5:22 PM · KDE PIM
cgiboudeaux accepted D19892: Use https for user-accessible links and documentation.
Mar 20 2019, 7:19 AM · KDE PIM

Mar 19 2019

cgiboudeaux added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

FTR, the fix was pushed, but now the BSD build is unhappy.

Mar 19 2019, 4:44 PM · KDE PIM
cgiboudeaux committed R44:55918c509494: Fix a race condition. (authored by cgiboudeaux).
Fix a race condition.
Mar 19 2019, 3:25 PM

Mar 18 2019

cgiboudeaux added a comment to D19830: Force build order to prevent build happening before ui .h file exists.

Maybe the 'OBJECT'[1] target type could help here, e.g (builds locally, no idea if it could solve your race):

Mar 18 2019, 8:28 AM · KDE PIM