cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (265 w, 1 d)
Availability
Available

Recent Activity

Sat, Sep 12

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Sat, Sep 12, 11:52 AM · KDE PIM
cgiboudeaux moved T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files from Backlog to In Progress on the KDE PIM board.
Sat, Sep 12, 11:47 AM · KDE PIM

Wed, Sep 9

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Wed, Sep 9, 7:08 AM · KDE PIM

Tue, Sep 8

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Tue, Sep 8, 3:15 PM · KDE PIM

Mon, Sep 7

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Mon, Sep 7, 8:25 PM · KDE PIM

Aug 19 2020

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 19 2020, 4:25 PM · KDE PIM

Aug 15 2020

cgiboudeaux added a comment to T12730: Rework COPYING and COPYING.LIB files.

For PIM repositories, I removed the COPYING.DOC files and replaced them with GFDL-1.2-or-later.txt from https://github.com/spdx/license-list-data/tree/master/text.

Aug 15 2020, 1:47 PM · KF6

Aug 14 2020

cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 14 2020, 1:29 PM · KDE PIM
cgiboudeaux updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 14 2020, 11:54 AM · KDE PIM
cgiboudeaux added a comment to T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 14 2020, 11:53 AM · KDE PIM
cgiboudeaux added a comment to T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 14 2020, 11:50 AM · KDE PIM
cgiboudeaux added a watcher for KDE PIM: cgiboudeaux.
Aug 14 2020, 11:40 AM
cgiboudeaux created T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 14 2020, 11:39 AM · KDE PIM

Aug 12 2020

cgiboudeaux added a comment to T12730: Rework COPYING and COPYING.LIB files.

Thirdly, Gitlab suggests to add a file called LICENSE at the main root (which we can fully ignore, if we want).

Aug 12 2020, 12:26 PM · KF6

Aug 11 2020

cgiboudeaux added a comment to T11550: Add SPDX License markers.

I suggest removing kdelibs4support from the list. (converting the other portingaids repositories is probably not needed either)

Aug 11 2020, 7:21 AM · KF6

Jun 23 2020

cgiboudeaux added a comment to D28379: KWidgetsAddons: Convert copyright headers to SPDX expressions.

Can you create an invent MR? I'll look later

Jun 23 2020, 7:23 AM · Frameworks

Jun 4 2020

cgiboudeaux committed R530:4f73ff02b3ef: Fix build with Qt 5.15 (authored by cgiboudeaux).
Fix build with Qt 5.15
Jun 4 2020, 2:16 PM

May 12 2020

cgiboudeaux committed R204:25b5cbf2206a: Add categories to kaddressbook-view.desktop (authored by cgiboudeaux).
Add categories to kaddressbook-view.desktop
May 12 2020, 7:11 AM

May 8 2020

cgiboudeaux accepted D29524: ECMGeneratePriFile: fix for ECM_MKSPECS_INSTALL_DIR being absolute.

tested successfully with the openSUSE package which uses absolute paths

May 8 2020, 10:54 AM · Build System, Frameworks

May 6 2020

cgiboudeaux added a comment to D29223: Update Taiwanese holidays.

If everything is sorted and both of you agree, please accept one of the reviews and we'll happily push it if necessary.

May 6 2020, 10:53 AM · Frameworks, KDE PIM

May 3 2020

cgiboudeaux added a comment to D29372: Taiwan: Use "zh_TW" language code.

D29223 addresses the issue and needs review

May 3 2020, 9:13 AM · Frameworks
cgiboudeaux added a comment to D29223: Update Taiwanese holidays.

@nhiga Please have a look at D29372.

May 3 2020, 9:12 AM · Frameworks, KDE PIM

Apr 27 2020

cgiboudeaux added a comment to D29223: Update Taiwanese holidays.

I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan?

Apr 27 2020, 12:28 PM · Frameworks, KDE PIM
cgiboudeaux added a reviewer for D29223: Update Taiwanese holidays: shrapnel.
Apr 27 2020, 12:27 PM · Frameworks, KDE PIM

Apr 22 2020

cgiboudeaux accepted D29097: Adapt FindKF5 to stricter checks in newer find_package_handle_standard_args.
Apr 22 2020, 1:55 PM · Build System, Frameworks
cgiboudeaux added reviewers for D29088: Properly install Qt module .pri files: vkrause, alistairf.
Apr 22 2020, 11:59 AM

Apr 20 2020

cgiboudeaux committed R79:f29411192506: Merge branch 'release/20.04' (authored by cgiboudeaux).
Merge branch 'release/20.04'
Apr 20 2020, 12:55 PM
cgiboudeaux committed R79:c66d938a8b24: Don't install files twice. (authored by cgiboudeaux).
Don't install files twice.
Apr 20 2020, 12:54 PM

Apr 18 2020

cgiboudeaux committed R175:97139b80e80b: Nicaragua Holidays (authored by carguello).
Nicaragua Holidays
Apr 18 2020, 9:24 AM
cgiboudeaux closed D28891: Nicaragua Holidays.
Apr 18 2020, 9:24 AM · Frameworks
cgiboudeaux committed R175:4d947fa1ca59: Taiwanese holidays (authored by shrapnel).
Taiwanese holidays
Apr 18 2020, 9:21 AM
cgiboudeaux closed D28874: Taiwanese holidays.
Apr 18 2020, 9:21 AM · Frameworks

Mar 28 2020

cgiboudeaux accepted D27245: Ki18n: Convert license headers to SPDX statements.
Mar 28 2020, 4:32 PM · Frameworks

Mar 23 2020

cgiboudeaux accepted D27741: KCodecs: Convert license statements to SPDX expressions.
Mar 23 2020, 9:16 AM · Frameworks

Mar 22 2020

cgiboudeaux accepted D27738: KCoreAddons: Convert license statements to SPDX expressions.
Mar 22 2020, 1:00 PM · Frameworks
cgiboudeaux accepted D27429: ThreadWeaver: Convert license headers to SPDX expressions.
Mar 22 2020, 11:59 AM · Frameworks

Mar 21 2020

cgiboudeaux added inline comments to D27741: KCodecs: Convert license statements to SPDX expressions.
Mar 21 2020, 8:58 PM · Frameworks
cgiboudeaux accepted D27601: KConfig: Convert to SPDX license statements.

LGTM

Mar 21 2020, 8:50 PM · Frameworks
cgiboudeaux added inline comments to D27738: KCoreAddons: Convert license statements to SPDX expressions.
Mar 21 2020, 8:47 PM · Frameworks
cgiboudeaux added a comment to D27245: Ki18n: Convert license headers to SPDX statements.

So, how to move forward with this change? The two open discussion points are:

  • How to handle COPYING files? --> IMO this is a general question that I want to address in a global change when we updated all the license headers. For this I created a task to track this question: https://phabricator.kde.org/T12730
Mar 21 2020, 8:35 PM · Frameworks
cgiboudeaux accepted D27428: KItemViews: Convert license statements to SPDX expressions.

LGTM

Mar 21 2020, 8:30 PM · Frameworks
cgiboudeaux accepted D27742: Solid: Convert license headers to SPDX expressions.

LGTM

Mar 21 2020, 8:28 PM · Frameworks
cgiboudeaux accepted D27429: ThreadWeaver: Convert license headers to SPDX expressions.

LGTM

Mar 21 2020, 8:21 PM · Frameworks

Mar 18 2020

cgiboudeaux committed R320:3a83ddd06829: Merge remote-tracking branch 'origin/release/20.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/20.04'
Mar 18 2020, 10:11 AM
cgiboudeaux committed R320:b8238d176a7f: Fix build. (authored by cgiboudeaux).
Fix build.
Mar 18 2020, 10:09 AM

Mar 17 2020

cgiboudeaux closed D10041: Decode full monitor vendor name from EDID using hwdata.

Closing again. Thanks for fixing.

Mar 17 2020, 2:21 PM · KWin

Mar 11 2020

cgiboudeaux accepted D27753: Add oars content rating.
Mar 11 2020, 8:36 PM

Mar 4 2020

cgiboudeaux added inline comments to D27753: Add oars content rating.
Mar 4 2020, 10:49 PM
cgiboudeaux added inline comments to D27753: Add oars content rating.
Mar 4 2020, 10:37 PM

Feb 28 2020

cgiboudeaux added inline comments to D10041: Decode full monitor vendor name from EDID using hwdata.
Feb 28 2020, 8:22 AM · KWin
cgiboudeaux reopened D10041: Decode full monitor vendor name from EDID using hwdata.
Feb 28 2020, 8:21 AM · KWin
cgiboudeaux added a comment to D10041: Decode full monitor vendor name from EDID using hwdata.

This causes a build failure for me:

/home/nate/kde/src/kwin/plugins/platforms/drm/edid.cpp:149:19: error: expected primary-expression before ‘enum’
  149 |     QFile pnpFile(QStringLiteral(HWDATA_PNPIDS_FILE));
      |                   ^~~~~~~~~~~~~~
Feb 28 2020, 8:21 AM · KWin
cgiboudeaux added inline comments to D10041: Decode full monitor vendor name from EDID using hwdata.
Feb 28 2020, 8:11 AM · KWin

Feb 24 2020

cgiboudeaux added inline comments to D27601: KConfig: Convert to SPDX license statements.
Feb 24 2020, 10:11 AM · Frameworks
cgiboudeaux accepted D27602: KDbusAddons: Convert license statement to SPDX.
Feb 24 2020, 9:52 AM · Frameworks
cgiboudeaux accepted D27603: KDNSSD: Convert license headers to SPDX statements.
Feb 24 2020, 9:49 AM · Frameworks

Feb 15 2020

cgiboudeaux accepted D27419: Update Japanese holidays.
Feb 15 2020, 8:45 AM · Frameworks, KDE PIM

Feb 13 2020

cgiboudeaux accepted D27361: KCalendarCore: Convert license statements to SPDX markers.
Feb 13 2020, 4:57 PM · KDE PIM
cgiboudeaux updated subscribers of D27363: KHolidays: Convert license statements to SPDX expressions.
Feb 13 2020, 1:04 PM · Frameworks
cgiboudeaux added inline comments to D27361: KCalendarCore: Convert license statements to SPDX markers.
Feb 13 2020, 12:53 PM · KDE PIM
cgiboudeaux added inline comments to D27245: Ki18n: Convert license headers to SPDX statements.
Feb 13 2020, 11:34 AM · Frameworks
cgiboudeaux added a comment to D27245: Ki18n: Convert license headers to SPDX statements.

some headers have 3 leading whitespaces, some 4. Can you clarify?

Feb 13 2020, 10:34 AM · Frameworks
cgiboudeaux accepted D27103: KItemModels: Convert license headers to SPDX markers.

Please push after fixing the remaining issues

Feb 13 2020, 8:52 AM · Frameworks
cgiboudeaux added inline comments to D27103: KItemModels: Convert license headers to SPDX markers.
Feb 13 2020, 8:51 AM · Frameworks
cgiboudeaux accepted D27106: Attica: Convert license statements to SPDX markers.
Feb 13 2020, 8:26 AM · Frameworks

Feb 10 2020

cgiboudeaux accepted D27297: KGuiAddons: Convert license headers to SPDX statements.

LGTM

Feb 10 2020, 5:55 PM · Frameworks
cgiboudeaux accepted D27277: Properly search for PipeWire libs.

Just one thing left to fix before pushing

Feb 10 2020, 3:35 PM · Plasma
cgiboudeaux added inline comments to D27277: Properly search for PipeWire libs.
Feb 10 2020, 3:14 PM · Plasma
cgiboudeaux added inline comments to D27277: Properly search for PipeWire libs.
Feb 10 2020, 3:12 PM · Plasma

Feb 8 2020

cgiboudeaux accepted D27234: KPlotting: Convert license statements to SPDX.
Feb 8 2020, 12:28 PM · Frameworks
cgiboudeaux added inline comments to D27234: KPlotting: Convert license statements to SPDX.
Feb 8 2020, 11:46 AM · Frameworks
cgiboudeaux added inline comments to D27234: KPlotting: Convert license statements to SPDX.
Feb 8 2020, 10:41 AM · Frameworks
cgiboudeaux accepted D27092: Prison: Convert license statements to SPDX identifiers.
Feb 8 2020, 10:38 AM · Frameworks
cgiboudeaux accepted D27231: BluezQt: Convert license statements to SPDX.

LGTM once the license file is fixed

Feb 8 2020, 9:52 AM · Frameworks
cgiboudeaux accepted D27104: KArchive: Convert license statements to SPDX headers.
Feb 8 2020, 8:39 AM · Frameworks

Feb 6 2020

cgiboudeaux added inline comments to D27103: KItemModels: Convert license headers to SPDX markers.
Feb 6 2020, 9:32 PM · Frameworks
cgiboudeaux added a comment to D27103: KItemModels: Convert license headers to SPDX markers.

same remark as for D27106. Check if FileContributor is more appropriate.

Feb 6 2020, 9:28 PM · Frameworks
cgiboudeaux accepted D27091: Sonnet: Convert license statements to SPDX.
Feb 6 2020, 9:24 PM · Frameworks

Feb 5 2020

cgiboudeaux added a comment to D27092: Prison: Convert license statements to SPDX identifiers.

+1 LGTM

Feb 5 2020, 9:12 PM · Frameworks
cgiboudeaux added inline comments to D27106: Attica: Convert license statements to SPDX markers.
Feb 5 2020, 8:44 PM · Frameworks

Feb 3 2020

cgiboudeaux added inline comments to D27104: KArchive: Convert license statements to SPDX headers.
Feb 3 2020, 12:07 AM · Frameworks

Feb 1 2020

cgiboudeaux added a comment to D27091: Sonnet: Convert license statements to SPDX.

+1 LGTM

Feb 1 2020, 6:12 PM · Frameworks
cgiboudeaux committed R477:45a87de50895: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Feb 1 2020, 12:46 PM
cgiboudeaux committed R477:17fedad11cba: Handle 410 Gone errors during Calendar sync (authored by gbs).
Handle 410 Gone errors during Calendar sync
Feb 1 2020, 12:44 PM
cgiboudeaux closed D27062: Handle 410 Gone errors during Calendar sync.
Feb 1 2020, 12:44 PM · KDE PIM

Jan 31 2020

cgiboudeaux accepted D26931: KIdleTime: Convert license statements to SPDX.
Jan 31 2020, 1:50 PM · Frameworks

Jan 27 2020

cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

Convert to SPDX-FileCopyrightText tags

some files have <year> by <author>, can I suggest removing this "by"?

Jan 27 2020, 6:03 PM · Frameworks
cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

Convert to SPDX-FileCopyrightText tags

Jan 27 2020, 6:01 PM · Frameworks

Jan 26 2020

cgiboudeaux added a comment to D26931: KIdleTime: Convert license statements to SPDX.

LGTM

Jan 26 2020, 8:46 PM · Frameworks

Jan 22 2020

cgiboudeaux accepted D26819: Fix missing link libraries to CMakeLists.txt.
Jan 22 2020, 11:50 AM · KDE PIM
cgiboudeaux requested changes to D26818: Fix missing link libraries to CMakeLists.txt.

If you need to add KF5::SyntaxHighlighting, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.

Jan 22 2020, 7:40 AM · KDE PIM

Jan 20 2020

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

In Kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.

Jan 20 2020, 9:03 AM · Build System, Frameworks

Jan 19 2020

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Jan 19 2020, 5:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Jan 19 2020, 1:12 PM · Build System, Frameworks
cgiboudeaux added a comment to D26762: Rename library/target to KF5::DAV.

+1 after updating the review title

Jan 19 2020, 1:09 PM · KDE PIM
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform

Jan 19 2020, 12:01 PM · Build System, Frameworks
cgiboudeaux added inline comments to D26762: Rename library/target to KF5::DAV.
Jan 19 2020, 11:46 AM · KDE PIM
cgiboudeaux requested changes to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I object. This warning is for developers. It tells them the icons are missing for some platforms.

Jan 19 2020, 10:00 AM · Build System, Frameworks

Jan 17 2020

cgiboudeaux committed R871:535cc003005d: Merge branch 'Plasma/5.18' (authored by cgiboudeaux).
Merge branch 'Plasma/5.18'
Jan 17 2020, 12:22 PM
cgiboudeaux committed R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content debug to zypper (authored by fvogt).
installdbgsymbols_suse: Pass --plus-content debug to zypper
Jan 17 2020, 12:21 PM