cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (160 w, 5 d)
Availability
Available

Recent Activity

Fri, Sep 14

cgiboudeaux committed R290:b32efcd75710: Move Qt5::DBus to the 'PRIVATE' link targets (authored by cgiboudeaux).
Move Qt5::DBus to the 'PRIVATE' link targets
Fri, Sep 14, 12:04 PM

Wed, Sep 12

cgiboudeaux added a comment to D15442: Improve DDCUtil handling in CMakeLists.

With the change, you can't tell if powerdevil must use the old or the new api. Suggestion: https://paste.kde.org/powk2bhxm

Wed, Sep 12, 10:30 AM · Plasma

Fri, Sep 7

cgiboudeaux accepted D15327: Add appmenu-gtk-module as runtime dependency.
Fri, Sep 7, 9:40 AM · Plasma
cgiboudeaux added a comment to D15070: Bindings: Query the install directory from python.

And why isn't it up to the user to set GPB_PYTHON2_SITEARCH when installing out of the usual directories?

Fri, Sep 7, 7:33 AM · Build System, Frameworks

Thu, Sep 6

cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

Checking that Qt5Core version is initialized

Thu, Sep 6, 9:04 AM · Plasma
cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

I have this in my dev setup

PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig

If you had the equivalent, would you need this?

Agreed, that's an issue with your environment not being set correctly.

It does work with PKG_CONFIG_PATH pointing to the custom Qt directory.
However, if the PREFIX is set and works for the rest of the modules, it should be able to work without this additional configuration.

Thu, Sep 6, 9:02 AM · Plasma
cgiboudeaux added a comment to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.

I have this in my dev setup

PKG_CONFIG_PATH=/opt/qt5/lib/pkgconfig:/opt/kde5/lib64/pkgconfig

If you had the equivalent, would you need this?

Thu, Sep 6, 8:25 AM · Plasma
cgiboudeaux added inline comments to D15310: Search for the Qt5Platform/ThemeSupport in the default includes first.
Thu, Sep 6, 8:24 AM · Plasma

Tue, Sep 4

cgiboudeaux added a comment to D15228: Export install location for DBUS interfaces via CMake.

This did not break the build, but D15229 becoming effective before this one.

Tue, Sep 4, 8:10 PM · Plasma
cgiboudeaux added a comment to D15228: Export install location for DBUS interfaces via CMake.
Tue, Sep 4, 7:37 AM · Plasma
cgiboudeaux committed R133:36a7e0313b15: Fix the plasma-workspace build. (authored by cgiboudeaux).
Fix the plasma-workspace build.
Tue, Sep 4, 7:05 AM

Mon, Aug 27

cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

David, Elvis, what's the nicest way to fix this ? (https://phabricator.kde.org/D15076#315803 for the details)

Mon, Aug 27, 9:27 PM · KDE Edu
cgiboudeaux updated subscribers of D15076: Build failures with KSyntaxHighlighting 5.49.
Mon, Aug 27, 9:25 PM · KDE Edu

Sun, Aug 26

cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.
Sun, Aug 26, 8:23 PM · KDE Edu
cgiboudeaux added a comment to D15076: Build failures with KSyntaxHighlighting 5.49.

I don't know the cause myself but the ECM version works up until 5.38.0 in my own testing. So presumably the change in behavior is something introduced in that release of ECM?

Sun, Aug 26, 8:11 AM · KDE Edu

Aug 21 2018

cgiboudeaux committed R246:ff828c02b09d: Fix a typo (authored by cgiboudeaux).
Fix a typo
Aug 21 2018, 9:10 AM

Aug 18 2018

cgiboudeaux added inline comments to D12761: Allow building kio-nfs against standalone libtirpc.
Aug 18 2018, 10:57 AM

Aug 4 2018

cgiboudeaux added inline comments to D14569: Make it possible for ECM to detect po files at configure time.
Aug 4 2018, 1:35 PM · Build System, Frameworks

Aug 3 2018

cgiboudeaux accepted D14569: Make it possible for ECM to detect po files at configure time.
Aug 3 2018, 8:23 AM · Build System, Frameworks

Jul 24 2018

cgiboudeaux committed R155:8d64aafa893e: Merge remote-tracking branch 'origin/Applications/18.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/18.08'
Jul 24 2018, 8:26 AM
cgiboudeaux committed R155:d5ada00cde8f: Fix FindAccountsFileDir.cmake (authored by cgiboudeaux).
Fix FindAccountsFileDir.cmake
Jul 24 2018, 8:24 AM

Jul 16 2018

cgiboudeaux committed R240:f19f90956b4d: Change the 'since' version. (authored by cgiboudeaux).
Change the 'since' version.
Jul 16 2018, 6:44 AM

Jul 14 2018

l10n daemon script <scripty@kde.org> committed R249:d7914620cbad: Fix the binary-factory builds. (authored by cgiboudeaux).
Fix the binary-factory builds.
Jul 14 2018, 10:08 AM
cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

This change has broken the build of all projects that make use of pmap resources on Windows, as the Python path at build time is not necessarily the path at install time (and it definitely not on the Binary Factory nodes)
In particular it breaks KGeography - see https://binary-factory.kde.org/job/KGeography_Nightly_win32/112/console

Jul 14 2018, 9:51 AM · Build System, Frameworks
cgiboudeaux committed R249:c5b721dc1753: Fix the binary-factory builds. (authored by cgiboudeaux).
Fix the binary-factory builds.
Jul 14 2018, 9:47 AM

Jul 10 2018

cgiboudeaux added inline comments to D13816: Make KItinerary work as a static library.
Jul 10 2018, 12:52 PM · KDE PIM

Jul 8 2018

cgiboudeaux committed R78:2c86217da538: Don't hardcode link colors. (authored by cgiboudeaux).
Don't hardcode link colors.
Jul 8 2018, 1:00 PM

Jul 6 2018

cgiboudeaux added a comment to D13698: Improve ECMAddAppIconMacro..

The 5.48 release is close. Don't forget to push these changes.

Jul 6 2018, 8:39 AM · Build System, Frameworks

Jul 3 2018

cgiboudeaux accepted D13698: Improve ECMAddAppIconMacro..

Thanks !

Jul 3 2018, 4:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D13698: Improve ECMAddAppIconMacro..

from a buildsystem pov, the change looks fine. Maybe someone has comments to add.

Jul 3 2018, 4:12 PM · Build System, Frameworks

Jun 29 2018

cgiboudeaux added inline comments to D13698: Improve ECMAddAppIconMacro..
Jun 29 2018, 12:55 PM · Build System, Frameworks

Jun 28 2018

cgiboudeaux added a comment to D9446: WIP: Allow to autogenerate and install categories file.

IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file.
But it doesn't work as I don't have idea how to reset file when cmake is started...

Do you have an idea ?

No cmake experts on the KF5 team like it was at KDE4?

Jun 28 2018, 8:16 AM · Build System, Frameworks

Jun 27 2018

cgiboudeaux committed R55:bcc16ae0d7d9: Don't reinvent the wheel. (authored by cgiboudeaux).
Don't reinvent the wheel.
Jun 27 2018, 9:01 PM

Jun 26 2018

cgiboudeaux added a comment to D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings.

Thanks, just remove the trailing space before the 2 closing parenthesis.

Jun 26 2018, 2:15 PM · Build System, Frameworks
cgiboudeaux accepted D10166: Add -Wlogical-op -Wzero-as-null-pointer-constant to KF5 warnings.
Jun 26 2018, 2:13 PM · Build System, Frameworks
cgiboudeaux accepted D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.
Jun 26 2018, 9:55 AM · Frameworks
cgiboudeaux added inline comments to D13698: Improve ECMAddAppIconMacro..
Jun 26 2018, 9:44 AM · Build System, Frameworks

Jun 23 2018

cgiboudeaux added inline comments to D13698: Improve ECMAddAppIconMacro..
Jun 23 2018, 2:30 PM · Build System, Frameworks
cgiboudeaux committed R286:b703afc376a4: Don't add -ltag to the public link interface. (authored by cgiboudeaux).
Don't add -ltag to the public link interface.
Jun 23 2018, 7:42 AM

Jun 12 2018

cgiboudeaux committed R484:9fc5140791ec: Fix build with Qt 5.11 (authored by cgiboudeaux).
Fix build with Qt 5.11
Jun 12 2018, 11:51 AM
cgiboudeaux closed D13339: Fix build with Qt 5.11.
Jun 12 2018, 11:51 AM · KDE Edu
cgiboudeaux added a reviewer for D13329: Fix build with Qt 5.11.: johanneszarl.
Jun 12 2018, 11:50 AM · KPhotoAlbum

Jun 8 2018

cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

Fixed autotests

Still -1, the code is now more complicated just for a cosmetic change in a build system file. Are you trying to fix anything ?

Jun 8 2018, 12:10 PM · Frameworks
cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

Fixed autotests

Jun 8 2018, 12:09 PM · Frameworks

Jun 7 2018

cgiboudeaux added a comment to D13406: In cmake macro file use CMAKE_CURRENT_LIST_DIR consequently instead of mixed use with KF5I18n_DIR.

-1, this change would break the autotests.

Jun 7 2018, 2:42 PM · Frameworks

Jun 6 2018

cgiboudeaux closed T8876: rdf is not generated anymore on store.kde.org as Resolved.

Confirmed. Thanks.

Jun 6 2018, 12:09 PM · KDE Store, Sysadmin

Jun 5 2018

cgiboudeaux accepted D13102: Don't include a 64 when building 64bit architectures on flatpak.
Jun 5 2018, 1:49 PM · Build System, Frameworks

Jun 4 2018

cgiboudeaux requested review of D13339: Fix build with Qt 5.11.
Jun 4 2018, 6:42 PM · KDE Edu
cgiboudeaux added inline comments to D13328: A backend is required for kdnssd.
Jun 4 2018, 11:50 AM · Frameworks
cgiboudeaux requested review of D13329: Fix build with Qt 5.11..
Jun 4 2018, 11:37 AM · KPhotoAlbum
cgiboudeaux added inline comments to D13328: A backend is required for kdnssd.
Jun 4 2018, 11:20 AM · Frameworks

May 31 2018

cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

Status update: freecell-solver-devel can be added to the openSUSE docker files.

May 31 2018, 6:10 AM · build.kde.org

May 30 2018

cgiboudeaux added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.

Thanks. +1

May 30 2018, 2:12 PM · Build System, Frameworks
cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

All the akonadi tests fail because of the assert in my previous comment. The only crash I detected was in kwin but the CI cannot reproduce it :)

May 30 2018, 10:58 AM · build.kde.org
cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

Tested locally with a crashing test (a real crash, not an assert), the backtrace was displayed in the ctest output.

May 30 2018, 6:43 AM · build.kde.org

May 29 2018

cgiboudeaux added a comment to T511: Show crash backtraces in the web UI.

That's not a solution yet, but exporting CTEST_OUTPUT_ON_FAILURE would give more hints, eg:

May 29 2018, 10:17 AM · build.kde.org

May 27 2018

cgiboudeaux created T8876: rdf is not generated anymore on store.kde.org.
May 27 2018, 9:56 AM · KDE Store, Sysadmin
cgiboudeaux committed R358:4576a155389a: Only build the tests if BUILD_TESTING is ON. (authored by cgiboudeaux).
Only build the tests if BUILD_TESTING is ON.
May 27 2018, 7:29 AM

May 25 2018

cgiboudeaux added a comment to D13102: Don't include a 64 when building 64bit architectures on flatpak.

Please update the doc above.

May 25 2018, 6:28 AM · Build System, Frameworks

May 24 2018

cgiboudeaux added a comment to D13096: Ensure we always reset the external reference override.

+1. Tested with master, I can't reproduce the issue anymore.

May 24 2018, 1:22 PM · KDE PIM
cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

@cgiboudeaux : please see the patch in this commit - https://github.com/shlomif/fc-solve/commit/9a2917edf0d13bbefef82a39b896ef14f62da876 - i was aware of these warnings, but ignored them because the fix made performance suffer a little.

May 24 2018, 1:02 PM · build.kde.org
cgiboudeaux added a comment to T8802: New dependency for kpat (required for CI).

FTR, it's not ready yet for openSUSE, the package doesn't pass the rpmlint check due to missing return in a couple places.

May 24 2018, 6:49 AM · build.kde.org

May 16 2018

cgiboudeaux added a comment to D12761: Allow building kio-nfs against standalone libtirpc.

https://paste.kde.org/pscug8tik ← the patch I created for our kdebase4-runtime package, maybe you can pick useful things :)

May 16 2018, 8:02 AM

May 14 2018

cgiboudeaux accepted D12867: Fix minor documentation typos.

Please use the GIT_SILENT keyword for typo fixes.

May 14 2018, 9:29 AM · Build System, Frameworks

May 3 2018

cgiboudeaux added inline comments to D12674: Mark `Phonon4Qt5` dependency as optional in CMakeLists file.
May 3 2018, 8:19 AM · Frameworks

Apr 26 2018

cgiboudeaux updated subscribers of R231:29e3db479fa9: Fix includes..
Apr 26 2018, 12:44 PM
cgiboudeaux added a comment to R231:29e3db479fa9: Fix includes..

Reverting my change is wrong.

Apr 26 2018, 12:18 PM
cgiboudeaux committed R231:86956ebd340a: Fix linking. (authored by cgiboudeaux).
Fix linking.
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:29e3db479fa9: Fix includes. (authored by cgiboudeaux).
Fix includes.
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:23635121328d: --warning (authored by cgiboudeaux).
--warning
Apr 26 2018, 9:26 AM
cgiboudeaux committed R231:c93f7880e4d6: Try to get more hints about qwt_plot.h's location. (authored by cgiboudeaux).
Try to get more hints about qwt_plot.h's location.
Apr 26 2018, 9:26 AM

Apr 18 2018

cgiboudeaux committed R838:5b930a734302: Avoid issues if pkgconfig cannot find the libraries. (authored by cgiboudeaux).
Avoid issues if pkgconfig cannot find the libraries.
Apr 18 2018, 11:08 AM
cgiboudeaux committed R838:c1b2cb0ca9ab: Update variables names. (authored by cgiboudeaux).
Update variables names.
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:40ff7a1cdaff: Look for pkgconfig quietly. (authored by cgiboudeaux).
Look for pkgconfig quietly.
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:ceec25ebe647: Update the doc (authored by cgiboudeaux).
Update the doc
Apr 18 2018, 11:06 AM
cgiboudeaux committed R838:9231501eeb73: Simplify. (authored by cgiboudeaux).
Simplify.
Apr 18 2018, 11:06 AM
cgiboudeaux accepted D12147: Search properly for pipewire and other libs.

Thanks. Please push, I'll fix the remaining issues

Apr 18 2018, 9:58 AM
cgiboudeaux committed R240:4560590bf806: Include FeatureSummary before calling set_package_properties. (authored by cgiboudeaux).
Include FeatureSummary before calling set_package_properties.
Apr 18 2018, 9:50 AM

Apr 12 2018

cgiboudeaux added inline comments to D12147: Search properly for pipewire and other libs.
Apr 12 2018, 1:41 PM

Apr 7 2018

cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Apr 7 2018, 9:18 AM · Build System, Frameworks
cgiboudeaux committed R249:82d40a309b78: Also let the autotests know where they can find KF5I18NMacros (authored by cgiboudeaux).
Also let the autotests know where they can find KF5I18NMacros
Apr 7 2018, 9:05 AM

Apr 6 2018

cgiboudeaux added inline comments to D11772: AtCoreWidgets.
Apr 6 2018, 1:42 PM · Atelier: AtCore
cgiboudeaux added inline comments to D11772: AtCoreWidgets.
Apr 6 2018, 1:40 PM · Atelier: AtCore

Mar 29 2018

cgiboudeaux committed R282:62668acedad0: Export the NetworkManager include dirs. (authored by cgiboudeaux).
Export the NetworkManager include dirs.
Mar 29 2018, 11:47 PM
cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

The alkimia build system is such a mess that it should be reworked from scratch. I'm not surprised.

Volunteers are always welcome. If you have the necessary foo to do it, go for it. This is what Phabricator is for.

Mar 29 2018, 7:45 PM

Mar 28 2018

cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

This patch is not fixing the issue correctly.
The correct way to populate the interface is to use target_include_directories in the CMakeLists.txt that creates this library (ie: alkimia/src)

There are reasons, why the patch is at is. See D10043 for more details.

The alkimia build system is such a mess that it should be reworked from scratch. I'm not surprised.

Mar 28 2018, 9:45 PM
cgiboudeaux added a comment to D11539: Add LibAlkimia[5]_INCLUDE_DIR to fix build issues with static libraries.

This patch is not fixing the issue correctly.

Mar 28 2018, 5:17 PM
cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

[...]

Mar 28 2018, 10:25 AM · Build System, Frameworks
cgiboudeaux committed R249:e6d3d6633337: Make sure ki18n can build its own translations. (authored by cgiboudeaux).
Make sure ki18n can build its own translations.
Mar 28 2018, 10:24 AM
cgiboudeaux committed R290:ea92225539ab: Try to fix the FreeBSD build. (authored by cgiboudeaux).
Try to fix the FreeBSD build.
Mar 28 2018, 9:09 AM
cgiboudeaux committed R290:261c9bca4d98: Use Qt5::rcc instead of looking for the executable. (authored by cgiboudeaux).
Use Qt5::rcc instead of looking for the executable.
Mar 28 2018, 9:09 AM

Mar 27 2018

cgiboudeaux committed R249:6c1db934e648: Don't call PythonInterp.cmake in KF5I18NMacros. (authored by cgiboudeaux).
Don't call PythonInterp.cmake in KF5I18NMacros.
Mar 27 2018, 1:55 PM
cgiboudeaux closed D11176: Don't call PythonInterp.cmake in KF5I18NMacros..
Mar 27 2018, 1:54 PM · Build System, Frameworks

Mar 26 2018

cgiboudeaux committed R165:a9cd11ceaeeb: Revert "Install akonadicore_debug.h." (authored by cgiboudeaux).
Revert "Install akonadicore_debug.h."
Mar 26 2018, 9:03 AM
cgiboudeaux added a reverting change for R165:0f36015c31ce: Install akonadicore_debug.h.: R165:a9cd11ceaeeb: Revert "Install akonadicore_debug.h.".
Mar 26 2018, 9:03 AM

Mar 25 2018

cgiboudeaux committed R165:0f36015c31ce: Install akonadicore_debug.h. (authored by cgiboudeaux).
Install akonadicore_debug.h.
Mar 25 2018, 10:00 AM

Mar 24 2018

cgiboudeaux added a comment to D11176: Don't call PythonInterp.cmake in KF5I18NMacros..

ping. Unless someone objects, I will push this change in a couple days.

Mar 24 2018, 2:10 PM · Build System, Frameworks

Mar 13 2018

cgiboudeaux committed R351:bd52e39a273c: Fix build. (authored by cgiboudeaux).
Fix build.
Mar 13 2018, 9:16 AM

Mar 9 2018

cgiboudeaux committed R163:541aff380509: Merge remote-tracking branch 'origin/Applications/17.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/17.12'
Mar 9 2018, 1:24 PM
cgiboudeaux committed R163:a84c183bb252: Also detect fluidsynth 1.1.xx (authored by cgiboudeaux).
Also detect fluidsynth 1.1.xx
Mar 9 2018, 1:23 PM