cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (212 w, 1 d)
Availability
Available

Recent Activity

Yesterday

cgiboudeaux committed R108:265e6367f784: Fix a link error when building kwin. (authored by cgiboudeaux).
Fix a link error when building kwin.
Wed, Sep 18, 9:46 AM

Fri, Sep 13

cgiboudeaux added inline comments to D23908: [WIP] feat(akonadiserver): Add AppArmor profile for akonadiserver.
Fri, Sep 13, 8:56 AM · KDE PIM

Wed, Sep 11

cgiboudeaux committed R487:48b16b8a7b5f: Remove 'phonon' from the include directory (authored by cgiboudeaux).
Remove 'phonon' from the include directory
Wed, Sep 11, 9:59 PM
cgiboudeaux closed D23873: Remove 'phonon' from the include directory.
Wed, Sep 11, 9:59 PM
cgiboudeaux requested review of D23873: Remove 'phonon' from the include directory.
Wed, Sep 11, 9:52 AM

Tue, Sep 10

cgiboudeaux accepted D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.

Thanks

Tue, Sep 10, 8:43 PM · Frameworks

Sun, Sep 8

cgiboudeaux added a comment to D23789: RFC: Add ECMGenerateExportHeaders, for improved handling of deprecated API.

Tests needed :)

Sun, Sep 8, 4:10 PM · Build System, Frameworks
cgiboudeaux committed R104:b4cc4a38db30: Reorder the frameworks requirements (authored by cgiboudeaux).
Reorder the frameworks requirements
Sun, Sep 8, 8:25 AM
cgiboudeaux committed R104:1cb2cec2929b: Add the missing KCMUtils requirement (authored by cgiboudeaux).
Add the missing KCMUtils requirement
Sun, Sep 8, 8:25 AM

Sat, Sep 7

cgiboudeaux added a comment to D22143: Add proper logging using ECMQtDeclareLoggingCategory.

This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong?

Sat, Sep 7, 8:17 AM · Frameworks

Thu, Aug 29

cgiboudeaux added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.

Thu, Aug 29, 5:59 AM · Build System, Frameworks

Sat, Aug 24

cgiboudeaux committed R181:457fbda25a85: Fix a crash when running 'amarok -l /path/to/file' (authored by cgiboudeaux).
Fix a crash when running 'amarok -l /path/to/file'
Sat, Aug 24, 7:05 AM
cgiboudeaux closed D23326: Fix a crash when running 'amarok -l /path/to/file'.
Sat, Aug 24, 7:05 AM

Wed, Aug 21

cgiboudeaux requested review of D23326: Fix a crash when running 'amarok -l /path/to/file'.
Wed, Aug 21, 6:38 PM

Aug 17 2019

cgiboudeaux accepted D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 1:51 PM · Frameworks, Framework: Syntax Highlighting, Kate
cgiboudeaux added inline comments to D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 6:41 AM · Frameworks, Framework: Syntax Highlighting, Kate

Aug 14 2019

cgiboudeaux accepted D22061: Add a logging category for logs warnings.

LGTM

Aug 14 2019, 3:12 PM · Frameworks
cgiboudeaux added a comment to D22805: set autorcc and autouic by default.

@kossebau @vkrause @apol something else to change?

Aug 14 2019, 1:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D22061: Add a logging category for logs warnings.

ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine.

Aug 14 2019, 1:54 PM · Frameworks
cgiboudeaux set the repository for D22699: Support passing target to ecm_qt_declare_logging_category to R240 Extra CMake Modules.
Aug 14 2019, 1:42 PM · Build System, Frameworks
cgiboudeaux added a comment to D22709: Support passing target to ecm_add_app_icon..

This shall be compliant with the minimum ECM version set in the project.

Aug 14 2019, 1:40 PM · Build System, Frameworks
cgiboudeaux added a comment to D18969: Use ECM's Exiv2 find module.

+1 LGTM. Probably needs to be rebased

Aug 14 2019, 1:38 PM
cgiboudeaux committed R116:a1c99fc7cbba: Add some missing includes. (authored by cgiboudeaux).
Add some missing includes.
Aug 14 2019, 7:42 AM

Aug 13 2019

cgiboudeaux committed R120:c574e7850e50: Add a missing include. (authored by cgiboudeaux).
Add a missing include.
Aug 13 2019, 2:54 PM
cgiboudeaux committed R120:465e8a6c550c: Look for libkscreen. (authored by cgiboudeaux).
Look for libkscreen.
Aug 13 2019, 2:54 PM
cgiboudeaux committed R235:134e0290cc2f: Fix the attica pkgconfig file. (authored by cgiboudeaux).
Fix the attica pkgconfig file.
Aug 13 2019, 9:53 AM
cgiboudeaux closed D23029: Fix the attica pkgconfig file..
Aug 13 2019, 9:53 AM · Frameworks

Aug 12 2019

cgiboudeaux added a comment to D23029: Fix the attica pkgconfig file..

Unless someone has objections, I'll push this tomorrow.

Aug 12 2019, 10:16 AM · Frameworks

Aug 9 2019

cgiboudeaux committed R44:30cc6fcd6e83: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Aug 9 2019, 10:57 AM
cgiboudeaux committed R44:4585292dd34f: Fix another race condition found while packaging the 19.08.0 release (authored by cgiboudeaux).
Fix another race condition found while packaging the 19.08.0 release
Aug 9 2019, 10:55 AM

Aug 8 2019

cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:34 PM · Frameworks
cgiboudeaux updated the diff for D23029: Fix the attica pkgconfig file..

use ${prefix} for the exec line.
For the others, it's a bit trickier since you can use either relative or
absolute paths when calling CMake.

Aug 8 2019, 12:32 PM · Frameworks
cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:21 PM · Frameworks
cgiboudeaux updated the diff for D23029: Fix the attica pkgconfig file..

fix path

Aug 8 2019, 12:20 PM · Frameworks
cgiboudeaux added a comment to D23029: Fix the attica pkgconfig file..

Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet)

Aug 8 2019, 12:08 PM · Frameworks
cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:07 PM · Frameworks
cgiboudeaux requested review of D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:06 PM · Frameworks

Jul 30 2019

cgiboudeaux added inline comments to D22061: Add a logging category for logs warnings.
Jul 30 2019, 7:23 AM · Frameworks
cgiboudeaux committed R345:137f812451b4: Fix the 0613aa4 commit. (authored by cgiboudeaux).
Fix the 0613aa4 commit.
Jul 30 2019, 6:58 AM
cgiboudeaux closed D22815: Fix finding (KF5)Plasma.
Jul 30 2019, 6:58 AM

Jul 29 2019

cgiboudeaux committed R81:a42b13dd33e5: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Jul 29 2019, 2:47 PM
cgiboudeaux committed R81:d88e60cf65be: Install the .rc files back into KDE_INSTALL_CONFDIR (authored by cgiboudeaux).
Install the .rc files back into KDE_INSTALL_CONFDIR
Jul 29 2019, 2:45 PM

Jul 27 2019

cgiboudeaux committed R44:f00679f383fa: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Jul 27 2019, 1:51 PM
cgiboudeaux committed R44:9d62d2dbd88d: Fix the license file. (authored by cgiboudeaux).
Fix the license file.
Jul 27 2019, 1:43 PM

Jul 24 2019

cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 11:35 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22698: Support passing target to ki18n_wrap_ui macro.
Jul 24 2019, 7:47 AM · Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 7:45 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 7:44 AM · Build System, Frameworks

Jul 23 2019

cgiboudeaux accepted D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.

LGTM

Jul 23 2019, 1:50 PM · Build System, Frameworks
cgiboudeaux accepted D22667: Make the default build type "Debug" when compiling a git checkout..

Good idea

Jul 23 2019, 10:39 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.
Jul 23 2019, 9:52 AM · Build System, Frameworks

Jul 21 2019

cgiboudeaux added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Jul 21 2019, 9:28 AM · Build System, Frameworks
cgiboudeaux accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 21 2019, 9:12 AM · Build System, Frameworks

Jul 20 2019

cgiboudeaux added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 20 2019, 3:26 PM · Build System, Frameworks

Jul 15 2019

cgiboudeaux committed R79:02a62e05247d: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Jul 15 2019, 6:33 PM

Jun 29 2019

cgiboudeaux added a comment to D22156: RFC: Add wayland-protocols find module.

how many users are there?

Jun 29 2019, 6:34 PM · Build System, Frameworks

Jun 10 2019

cgiboudeaux added a comment to D21695: Add FindTaglib.cmake.

attic/modules/FindTaglib.cmake shall be deleted.

Jun 10 2019, 11:44 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21695: Add FindTaglib.cmake.
Jun 10 2019, 11:41 AM · Build System, Frameworks
cgiboudeaux committed R165:00508264f17e: Fix a typo. (authored by cgiboudeaux).
Fix a typo.
Jun 10 2019, 9:31 AM

Jun 7 2019

cgiboudeaux committed R44:60fff863ae9a: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
Jun 7 2019, 8:26 AM
cgiboudeaux committed R44:062f5103e194: Try to fix a race condition. (authored by cgiboudeaux).
Try to fix a race condition.
Jun 7 2019, 8:24 AM

May 31 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Maybe also update the commit message to 'Create specific directory for Qt logging categories file'

May 31 2019, 8:45 AM · Build System, Frameworks
cgiboudeaux accepted D21313: Create specific directory for Qt logging categories file.
May 31 2019, 8:43 AM · Build System, Frameworks

May 24 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Ping ?

May 24 2019, 7:45 AM · Build System, Frameworks

May 21 2019

cgiboudeaux added a comment to D21313: Create specific directory for Qt logging categories file.

Looks mostly fine safe for the directory name that needs the major version to avoid conflicts when libfoo.categories built using KF5 will have to coexist with KF6.
It needs a '5' in its name.

May 21 2019, 7:52 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 7:16 AM · Build System, Frameworks
cgiboudeaux added inline comments to D21313: Create specific directory for Qt logging categories file.
May 21 2019, 6:51 AM · Build System, Frameworks

May 14 2019

cgiboudeaux committed R81:bfa860df4102: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 4:06 PM
cgiboudeaux committed R81:14886286b5bb: Look for KF5ContactEditor before trying to use it (authored by cgiboudeaux).
Look for KF5ContactEditor before trying to use it
May 14 2019, 4:05 PM
cgiboudeaux committed R82:2abe2a37c2eb: Fix the broken merge (authored by cgiboudeaux).
Fix the broken merge
May 14 2019, 3:39 PM
cgiboudeaux added a comment to D21214: Fix the kmime dependencies..

This was added to fix static builds (for which we also need private link dependencies here too). I guess putting that into an if (NOT @BUILD_SHARED_LIBS@) conditional might be the right solution?

May 14 2019, 3:31 PM · KDE PIM
cgiboudeaux committed R82:89d39d59cb39: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 3:24 PM
cgiboudeaux committed R82:44cca93d8f98: Use the akonadi-contact version for KF5ContactEditor (authored by cgiboudeaux).
Use the akonadi-contact version for KF5ContactEditor
May 14 2019, 3:23 PM
cgiboudeaux requested review of D21214: Fix the kmime dependencies..
May 14 2019, 1:42 PM · KDE PIM
cgiboudeaux committed R82:ac5c8458594f: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 1:32 PM
cgiboudeaux committed R82:f1e5df49e577: Add the missing KF5ContactEditor dependency (authored by cgiboudeaux).
Add the missing KF5ContactEditor dependency
May 14 2019, 1:30 PM
cgiboudeaux committed R459:c9f0980c49ff: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:24 PM
cgiboudeaux committed R459:5b3c2557bac1: Fix the akonadi-contacts dependencies (authored by cgiboudeaux).
Fix the akonadi-contacts dependencies
May 14 2019, 12:22 PM
cgiboudeaux closed D21208: Fix the akonadi-contacts dependencies.
May 14 2019, 12:22 PM · KDE PIM
cgiboudeaux committed R460:38bbacaf75bc: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:21 PM
cgiboudeaux committed R460:0fbe4700cc9a: Fix the akonadi-mime dependencies (authored by cgiboudeaux).
Fix the akonadi-mime dependencies
May 14 2019, 12:17 PM
cgiboudeaux closed D21210: Fix the akonadi-mime dependencies.
May 14 2019, 12:17 PM · KDE PIM
cgiboudeaux committed R461:41d2cf8a3a6d: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:15 PM
cgiboudeaux closed D21211: Fix the akonadi-notes dependencies.
May 14 2019, 12:14 PM · KDE PIM
cgiboudeaux committed R461:bbaa8676daef: Fix the akonadi-notes dependencies (authored by cgiboudeaux).
Fix the akonadi-notes dependencies
May 14 2019, 12:14 PM
cgiboudeaux committed R170:4945abc5d774: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 12:13 PM
cgiboudeaux committed R170:d18ba909b43e: Fix the akonadi-calendar dependencies (authored by cgiboudeaux).
Fix the akonadi-calendar dependencies
May 14 2019, 12:10 PM
cgiboudeaux closed D21207: Fix the akonadi-calendar dependencies.
May 14 2019, 12:10 PM · KDE PIM
cgiboudeaux committed R165:0cdad4a3a001: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 11:46 AM
cgiboudeaux committed R165:7cc80667611e: Add some missing dependencies in KF5AkonadiConfig.cmake (authored by cgiboudeaux).
Add some missing dependencies in KF5AkonadiConfig.cmake
May 14 2019, 11:44 AM
cgiboudeaux closed D21206: Add some missing dependencies in KF5AkonadiConfig.cmake.
May 14 2019, 11:44 AM · KDE PIM
cgiboudeaux committed R92:66c86d83a4f5: Merge remote-tracking branch 'origin/Applications/19.04' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.04'
May 14 2019, 11:19 AM
cgiboudeaux closed D21205: Fix a potential build issue when building KMail.
May 14 2019, 11:18 AM · KDE PIM
cgiboudeaux committed R92:cea29406f7a1: Fix a potential build issue when building KMail (authored by cgiboudeaux).
Fix a potential build issue when building KMail
May 14 2019, 11:18 AM
cgiboudeaux updated the diff for D21211: Fix the akonadi-notes dependencies.

Reenable the QT_DISABLE_DEPRECATED_BEFORE line, the mentioned issue was fixed
in Qt 5.13 beta2.

May 14 2019, 10:52 AM · KDE PIM
cgiboudeaux requested review of D21211: Fix the akonadi-notes dependencies.
May 14 2019, 9:34 AM · KDE PIM
cgiboudeaux requested review of D21210: Fix the akonadi-mime dependencies.
May 14 2019, 9:26 AM · KDE PIM
cgiboudeaux requested review of D21208: Fix the akonadi-contacts dependencies.
May 14 2019, 9:13 AM · KDE PIM
cgiboudeaux requested review of D21207: Fix the akonadi-calendar dependencies.
May 14 2019, 8:51 AM · KDE PIM
cgiboudeaux requested review of D21206: Add some missing dependencies in KF5AkonadiConfig.cmake.
May 14 2019, 8:34 AM · KDE PIM