cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (229 w, 6 d)
Availability
Available

Recent Activity

Yesterday

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?

In Kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.

Mon, Jan 20, 9:03 AM · Build System, Frameworks

Sun, Jan 19

cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
Sun, Jan 19, 5:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

That’s not a developer issue, it’s a packaging issue.

Sun, Jan 19, 1:12 PM · Build System, Frameworks
cgiboudeaux added a comment to D26762: Rename library/target to KF5::DAV.

+1 after updating the review title

Sun, Jan 19, 1:09 PM · KDE PIM
cgiboudeaux added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

You may use Linux to develop software that's intended to be used also on Mac and Windows. You can't expect developers to have build environment for every platform

Sun, Jan 19, 12:01 PM · Build System, Frameworks
cgiboudeaux added inline comments to D26762: Rename library/target to KF5::DAV.
Sun, Jan 19, 11:46 AM · KDE PIM
cgiboudeaux requested changes to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.

I object. This warning is for developers. It tells them the icons are missing for some platforms.

Sun, Jan 19, 10:00 AM · Build System, Frameworks

Fri, Jan 17

cgiboudeaux committed R871:535cc003005d: Merge branch 'Plasma/5.18' (authored by cgiboudeaux).
Merge branch 'Plasma/5.18'
Fri, Jan 17, 12:22 PM
cgiboudeaux committed R871:807d9dccab08: installdbgsymbols_suse: Pass --plus-content debug to zypper (authored by fvogt).
installdbgsymbols_suse: Pass --plus-content debug to zypper
Fri, Jan 17, 12:21 PM
cgiboudeaux closed D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Fri, Jan 17, 12:21 PM · Plasma
cgiboudeaux accepted D24751: installdbgsymbols_suse: Pass --plus-content debug to zypper.
Fri, Jan 17, 10:57 AM · Plasma
cgiboudeaux added a comment to D26202: Refactor KConfigXT .

I Just reverted this and I'm working on a full build of kde using kdesrc-build --refresh-build, I'll reopen this patch when *all* projects build sucessfully, with a unittest for each one that broke.

Fri, Jan 17, 10:35 AM · Frameworks

Mon, Jan 13

cgiboudeaux committed R156:f26e97cfc930: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Mon, Jan 13, 2:58 PM
cgiboudeaux closed D26454: Google provider: limit requested OAuth scopes.

After updating, I'm getting that:

15:42:28 - systemsettings(16291) -  : <Unknown File>:7: TypeError: Cannot read property 'contentX' of null

** (process:16291): WARNING **: 15:42:30.200: _ag_value_from_string: error parsing type "as" ``[
              'https://www.googleapis.com/auth/userinfo.email',
              'https://www.googleapis.com/auth/userinfo.profile',
              'https://www.googleapis.com/auth/calendar',
              'https://www.googleapis.com/auth/tasks',
              'https://www.google.com/m8/feeds/',
              'https://www.googleapis.com/auth/drive',
              'https://www.googleapis.com/auth/youtube.upload',
          ]'': 424:expected value
Mon, Jan 13, 2:57 PM
cgiboudeaux committed R156:5952bf25358b: Remove the extra comma (authored by cgiboudeaux).
Remove the extra comma
Mon, Jan 13, 2:57 PM
cgiboudeaux reopened D26454: Google provider: limit requested OAuth scopes.

After updating, I'm getting that:

Mon, Jan 13, 2:49 PM

Wed, Jan 8

cgiboudeaux added a watcher for KF6: cgiboudeaux.
Wed, Jan 8, 9:24 AM

Dec 20 2019

cgiboudeaux added a comment to D8843: Use URLs in multiget requests as returned by the Server.

@rhaferkamp ping?

Dec 20 2019, 8:10 AM · KDE PIM

Dec 15 2019

cgiboudeaux accepted D26011: Align ECM and Qt setup with Frameworks conventions.
Dec 15 2019, 10:02 AM · Frameworks

Dec 14 2019

cgiboudeaux added inline comments to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:47 AM · Frameworks
cgiboudeaux accepted D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:37 AM · Frameworks
cgiboudeaux added inline comments to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.
Dec 14 2019, 11:05 AM · Frameworks
cgiboudeaux added a comment to D25975: Relicense some files to LGPLv2+ or v2v3, OK by all contributors according to relicensecheck.pl.

Note that you don't have a LGPL-2.0-or-later COPYING file in this repo (there's also no LGPL-2.0-only).

Dec 14 2019, 9:21 AM · Frameworks

Dec 11 2019

cgiboudeaux committed R237:975aaeeff483: kconfig EBN transport protocol cleanup (authored by jhayes).
kconfig EBN transport protocol cleanup
Dec 11 2019, 9:09 AM
cgiboudeaux closed D25829: kconfig EBN transport protocol cleanup.
Dec 11 2019, 9:09 AM · Frameworks
cgiboudeaux committed R296:ab35bc727cb7: kdeclarative EBN spelling cleanup (authored by jhayes).
kdeclarative EBN spelling cleanup
Dec 11 2019, 9:08 AM
cgiboudeaux closed D25864: kdeclarative EBN spelling cleanup.
Dec 11 2019, 9:08 AM · Frameworks
cgiboudeaux accepted D25864: kdeclarative EBN spelling cleanup.
Dec 11 2019, 9:07 AM · Frameworks
cgiboudeaux committed R175:98e731d68581: kholidays EBN transport protocol cleanup (authored by jhayes).
kholidays EBN transport protocol cleanup
Dec 11 2019, 9:04 AM
cgiboudeaux closed D25866: kholidays EBN transport protocol cleanup.
Dec 11 2019, 9:04 AM · Frameworks
cgiboudeaux accepted D25866: kholidays EBN transport protocol cleanup.
Dec 11 2019, 9:03 AM · Frameworks

Dec 10 2019

cgiboudeaux added inline comments to D25848: Fix typo in method name "unknowTagValue".
Dec 10 2019, 2:51 PM · KDE PIM

Dec 6 2019

cgiboudeaux accepted D25790: Make basicobjecttreeparsertest independent of host timezone.

+1. ctest -R mimetreeparser-basicobjecttreeparsertest passes with this change

Dec 6 2019, 5:50 PM · KDE PIM
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Dec 6 2019, 12:17 PM · Build System, Frameworks

Dec 5 2019

cgiboudeaux committed R240:f082ed20e6a8: EBN extra-cmake-modules transport cleanup (authored by jhayes).
EBN extra-cmake-modules transport cleanup
Dec 5 2019, 9:14 PM
cgiboudeaux closed D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:14 PM · Build System, Frameworks
cgiboudeaux accepted D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:12 PM · Build System, Frameworks
cgiboudeaux added a comment to T11933: Debrand KDE Applications as Release Service.

How about this for renaming the variable in Cmake?
https://phabricator.kde.org/D25769

Dec 5 2019, 5:37 PM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

Dec 5 2019, 5:22 PM · Build System, Frameworks
cgiboudeaux added a comment to D19521: Switch from UsePkgConfig to FindPkgConfig.

@asturmlechner ping?

Dec 5 2019, 10:22 AM
cgiboudeaux committed R283:49ed872608fa: Install .pri file for KAuthCore (authored by volkov).
Install .pri file for KAuthCore
Dec 5 2019, 10:14 AM
cgiboudeaux closed D25397: Install .pri file for KAuthCore.
Dec 5 2019, 10:14 AM · Frameworks
cgiboudeaux committed R304:19bbe83f5527: EBN kmoretools cleanup transport protocol (authored by jhayes).
EBN kmoretools cleanup transport protocol
Dec 5 2019, 10:11 AM
cgiboudeaux closed D25493: EBN kmoretools cleanup transport protocol.
Dec 5 2019, 10:11 AM · Frameworks
cgiboudeaux committed R240:9f441190a36a: EBN extra-cmake-modules comments spelling cleanup (authored by jhayes).
EBN extra-cmake-modules comments spelling cleanup
Dec 5 2019, 9:37 AM
cgiboudeaux closed D25752: EBN extra-cmake-modules comments spelling cleanup.
Dec 5 2019, 9:37 AM · Build System, Frameworks
cgiboudeaux committed R267:b86aa2b10f7d: EBN cleanup of autotests transfer protocol (authored by jhayes).
EBN cleanup of autotests transfer protocol
Dec 5 2019, 9:35 AM
cgiboudeaux closed D25448: EBN cleanup of autotests transfer protocol.
Dec 5 2019, 9:35 AM · Frameworks
cgiboudeaux committed R6:8c0352356062: EBN KActivites transfer protocol cleanup (authored by jhayes).
EBN KActivites transfer protocol cleanup
Dec 5 2019, 9:34 AM
cgiboudeaux closed D25719: EBN KActivites transfer protocol cleanup.
Dec 5 2019, 9:34 AM · Frameworks
cgiboudeaux committed R296:342a575c0dd5: EBN kdeclarative transfer protocol cleanup (authored by jhayes).
EBN kdeclarative transfer protocol cleanup
Dec 5 2019, 9:33 AM
cgiboudeaux closed D25721: EBN kdeclarative transfer protocol cleanup.
Dec 5 2019, 9:33 AM · Frameworks
cgiboudeaux added inline comments to D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:28 AM · Build System, Frameworks
cgiboudeaux requested changes to D25753: EBN extra-cmake-modules transport cleanup.
Dec 5 2019, 9:27 AM · Build System, Frameworks

Nov 29 2019

cgiboudeaux added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Sure :)
-1. The Config file is supposed to look for the lowest supported version.

So, which is meant to be the lowest supported version for a built kcoreaddons which was compiled against e.g. Qt 5.13 (and thus uses its additional API)?

Nov 29 2019, 9:12 PM · Frameworks
cgiboudeaux added a comment to D23550: CMake config files: use as min dep version the Qt version we built against.

ping :) No-one any opinion?

Nov 29 2019, 8:54 PM · Frameworks
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Nov 29 2019, 9:16 AM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Nov 29 2019, 9:12 AM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 26 2019

cgiboudeaux committed R55:4723d4c3e5ea: Fix build with Ninja on FreeBSD. (authored by cgiboudeaux).
Fix build with Ninja on FreeBSD.
Nov 26 2019, 10:23 AM
cgiboudeaux committed R44:f91ca2958231: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Nov 26 2019, 8:34 AM
cgiboudeaux committed R44:163968040f4b: IMAP resource: do not prompt for password with GSSAPI auth (authored by lachs).
IMAP resource: do not prompt for password with GSSAPI auth
Nov 26 2019, 8:33 AM
cgiboudeaux closed D25499: IMAP resource: do not prompt for password with GSSAPI auth.
Nov 26 2019, 8:33 AM · KDE PIM

Nov 25 2019

cgiboudeaux added inline comments to D25107: Add install dir for systemd units.
Nov 25 2019, 1:51 PM · Build System, Frameworks

Nov 15 2019

cgiboudeaux committed R208:c1792c726d6c: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Nov 15 2019, 11:04 AM
cgiboudeaux committed R208:90a586324eae: Fix a warning string. (authored by cgiboudeaux).
Fix a warning string.
Nov 15 2019, 10:59 AM

Nov 14 2019

cgiboudeaux abandoned D25304: Fix the OpenEXR >= 2.4 detection.

I applied the patch to our openexr package instead.

Nov 14 2019, 7:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

Nov 14 2019, 5:26 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Nov 14 2019, 5:19 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Nov 14 2019, 1:53 PM · Build System, Frameworks
cgiboudeaux requested review of D25304: Fix the OpenEXR >= 2.4 detection.
Nov 14 2019, 1:42 PM · Build System, Frameworks

Nov 12 2019

cgiboudeaux committed R101:d8bec9e1151f: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Plasma/5.17'
Nov 12 2019, 6:46 PM
cgiboudeaux committed R101:faef67ad1819: Clean up config-X11.h (authored by cgiboudeaux).
Clean up config-X11.h
Nov 12 2019, 6:44 PM
cgiboudeaux committed R101:e52b1c88ee34: Clean up config-X11.h (authored by cgiboudeaux).
Clean up config-X11.h
Nov 12 2019, 6:44 PM
cgiboudeaux closed D25275: Clean up config-X11.h.
Nov 12 2019, 6:44 PM · Plasma
cgiboudeaux added a comment to D25275: Clean up config-X11.h.

Also tested with CMake 3.1 which is the version required by Qt 5.12. It won't report the component, however.

Nov 12 2019, 4:41 PM · Plasma
cgiboudeaux added a comment to D25275: Clean up config-X11.h.

Note: this is 2 different commits.

Nov 12 2019, 4:23 PM · Plasma
cgiboudeaux requested review of D25275: Clean up config-X11.h.
Nov 12 2019, 4:23 PM · Plasma
cgiboudeaux added a comment to T11933: Debrand KDE Applications as Release Service.
Nov 12 2019, 1:07 PM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Nov 12 2019, 10:59 AM · KDE Promo, KDE Applications, Goal: All About the Apps

Nov 11 2019

cgiboudeaux committed R74:912590314219: Merge remote-tracking branch 'origin/1.6' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/1.6'
Nov 11 2019, 10:14 PM
cgiboudeaux committed R74:c6b4e029ddec: Coding style (authored by cgiboudeaux).
Coding style
Nov 11 2019, 10:07 PM
cgiboudeaux closed D25163: Check if clazy should be linked to clang-cpp.
Nov 11 2019, 9:58 PM
cgiboudeaux committed R74:0e295e5a9264: Check if clazy should be linked to clang-cpp (authored by cgiboudeaux).
Check if clazy should be linked to clang-cpp
Nov 11 2019, 9:58 PM
cgiboudeaux added a reviewer for D25163: Check if clazy should be linked to clang-cpp: kde-buildsystem.
Nov 11 2019, 9:32 AM

Nov 10 2019

cgiboudeaux added a comment to D25223: Avoid side effects during menu initialization.

tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray.

Nov 10 2019, 10:57 AM · Plasma

Nov 6 2019

cgiboudeaux added a reviewer for D25163: Check if clazy should be linked to clang-cpp: smartins.
Nov 6 2019, 9:08 AM
cgiboudeaux requested review of D25163: Check if clazy should be linked to clang-cpp.
Nov 6 2019, 9:08 AM

Nov 1 2019

cgiboudeaux accepted D25101: Relicense KDAV to LGPLv2+.

LGTM

Nov 1 2019, 12:05 PM · KDE PIM

Oct 23 2019

cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Oct 23 2019, 11:01 AM · Build System, Frameworks
cgiboudeaux accepted D24882: Don't set C/C++ standards if already set.

Thanks! tested successfully

Oct 23 2019, 9:43 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

Oct 23 2019, 9:17 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

Oct 23 2019, 9:01 AM · Build System, Frameworks

Oct 22 2019

cgiboudeaux updated the summary of D24841: Use modern way to set the C/CXX standard.
Oct 22 2019, 2:53 PM · Build System, Frameworks

Oct 19 2019

cgiboudeaux accepted D24783: Remove unnecessary dependency on KF5::IconThemes.
Oct 19 2019, 6:02 PM · KDE PIM
cgiboudeaux accepted D24784: Remove unneeded KF5::IconThemes dependency.
Oct 19 2019, 5:59 PM · KDE PIM

Oct 10 2019

cgiboudeaux committed R72:be832997d451: Use registered categories in the desktop file. (authored by cgiboudeaux).
Use registered categories in the desktop file.
Oct 10 2019, 9:45 PM
cgiboudeaux closed D24551: Use registered categories in the desktop file..
Oct 10 2019, 9:45 PM · KDE Edu
cgiboudeaux requested review of D24551: Use registered categories in the desktop file..
Oct 10 2019, 9:32 PM · KDE Edu
cgiboudeaux added a comment to D24541: fix(akonadiserver): Use xdg_data_home and xdg_config_home as variable..

I can't test since I don't need these files.

Oct 10 2019, 6:08 PM · KDE PIM

Oct 7 2019

cgiboudeaux added inline comments to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Oct 7 2019, 3:13 PM · KDE PIM