cgiboudeaux (Christophe Giboudeaux)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Aug 25 2015, 2:19 PM (220 w, 3 d)
Availability
Available

Recent Activity

Today

cgiboudeaux committed R208:c1792c726d6c: Merge remote-tracking branch 'origin/release/19.12' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/release/19.12'
Fri, Nov 15, 11:04 AM
cgiboudeaux committed R208:90a586324eae: Fix a warning string. (authored by cgiboudeaux).
Fix a warning string.
Fri, Nov 15, 10:59 AM

Yesterday

cgiboudeaux abandoned D25304: Fix the OpenEXR >= 2.4 detection.

I applied the patch to our openexr package instead.

Thu, Nov 14, 7:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

Thu, Nov 14, 5:26 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 5:19 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Thu, Nov 14, 1:53 PM · Build System, Frameworks
cgiboudeaux requested review of D25304: Fix the OpenEXR >= 2.4 detection.
Thu, Nov 14, 1:42 PM · Build System, Frameworks

Tue, Nov 12

cgiboudeaux committed R101:d8bec9e1151f: Merge remote-tracking branch 'origin/Plasma/5.17' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Plasma/5.17'
Tue, Nov 12, 6:46 PM
cgiboudeaux committed R101:faef67ad1819: Clean up config-X11.h (authored by cgiboudeaux).
Clean up config-X11.h
Tue, Nov 12, 6:44 PM
cgiboudeaux committed R101:e52b1c88ee34: Clean up config-X11.h (authored by cgiboudeaux).
Clean up config-X11.h
Tue, Nov 12, 6:44 PM
cgiboudeaux closed D25275: Clean up config-X11.h.
Tue, Nov 12, 6:44 PM · Plasma
cgiboudeaux added a comment to D25275: Clean up config-X11.h.

Also tested with CMake 3.1 which is the version required by Qt 5.12.

Tue, Nov 12, 4:41 PM · Plasma
cgiboudeaux added a comment to D25275: Clean up config-X11.h.

Note: this is 2 different commits.

Tue, Nov 12, 4:23 PM · Plasma
cgiboudeaux requested review of D25275: Clean up config-X11.h.
Tue, Nov 12, 4:23 PM · Plasma
cgiboudeaux added a comment to T11933: Debrand KDE Applications as Release Service.
Tue, Nov 12, 1:07 PM · KDE Promo, KDE Applications, Goal: All About the Apps
cgiboudeaux updated the task description for T11933: Debrand KDE Applications as Release Service.
Tue, Nov 12, 10:59 AM · KDE Promo, KDE Applications, Goal: All About the Apps

Mon, Nov 11

cgiboudeaux committed R74:912590314219: Merge remote-tracking branch 'origin/1.6' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/1.6'
Mon, Nov 11, 10:14 PM
cgiboudeaux committed R74:c6b4e029ddec: Coding style (authored by cgiboudeaux).
Coding style
Mon, Nov 11, 10:07 PM
cgiboudeaux closed D25163: Check if clazy should be linked to clang-cpp.
Mon, Nov 11, 9:58 PM
cgiboudeaux committed R74:0e295e5a9264: Check if clazy should be linked to clang-cpp (authored by cgiboudeaux).
Check if clazy should be linked to clang-cpp
Mon, Nov 11, 9:58 PM
cgiboudeaux added a reviewer for D25163: Check if clazy should be linked to clang-cpp: kde-buildsystem.
Mon, Nov 11, 9:32 AM

Sun, Nov 10

cgiboudeaux added a comment to D25223: Avoid side effects during menu initialization.

tested successfully locally. I don't see menus opening on the top left corner when running vlc or hp-systray.

Sun, Nov 10, 10:57 AM · Plasma

Wed, Nov 6

cgiboudeaux added a reviewer for D25163: Check if clazy should be linked to clang-cpp: smartins.
Wed, Nov 6, 9:08 AM
cgiboudeaux requested review of D25163: Check if clazy should be linked to clang-cpp.
Wed, Nov 6, 9:08 AM

Fri, Nov 1

cgiboudeaux accepted D25101: Relicense KDAV to LGPLv2+.

LGTM

Fri, Nov 1, 12:05 PM · KDE PIM

Wed, Oct 23

cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Wed, Oct 23, 11:01 AM · Build System, Frameworks
cgiboudeaux accepted D24882: Don't set C/C++ standards if already set.

Thanks! tested successfullly

Wed, Oct 23, 9:43 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

Wed, Oct 23, 9:17 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

Wed, Oct 23, 9:01 AM · Build System, Frameworks

Tue, Oct 22

cgiboudeaux updated the summary of D24841: Use modern way to set the C/CXX standard.
Tue, Oct 22, 2:53 PM · Build System, Frameworks

Sat, Oct 19

cgiboudeaux accepted D24783: Remove unnecessary dependency on KF5::IconThemes.
Sat, Oct 19, 6:02 PM · KDE PIM
cgiboudeaux accepted D24784: Remove unneeded KF5::IconThemes dependency.
Sat, Oct 19, 5:59 PM · KDE PIM

Oct 10 2019

cgiboudeaux committed R72:be832997d451: Use registered categories in the desktop file. (authored by cgiboudeaux).
Use registered categories in the desktop file.
Oct 10 2019, 9:45 PM
cgiboudeaux closed D24551: Use registered categories in the desktop file..
Oct 10 2019, 9:45 PM · KDE Edu
cgiboudeaux requested review of D24551: Use registered categories in the desktop file..
Oct 10 2019, 9:32 PM · KDE Edu
cgiboudeaux added a comment to D24541: fix(akonadiserver): Use xdg_data_home and xdg_config_home as variable..

I can't test since I don't need these files.

Oct 10 2019, 6:08 PM · KDE PIM

Oct 7 2019

cgiboudeaux added inline comments to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Oct 7 2019, 3:13 PM · KDE PIM

Oct 3 2019

cgiboudeaux committed R44:59748aa63f0a: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Oct 3 2019, 8:20 AM
cgiboudeaux committed R44:8ec4db907c40: Fix the dependencies on generated files differently. (authored by cgiboudeaux).
Fix the dependencies on generated files differently.
Oct 3 2019, 8:20 AM

Oct 2 2019

cgiboudeaux added a comment to D24363: Fix several build system errors.

Note: the metainfo file says this framework is tier 3.

Oct 2 2019, 5:43 PM · Plasma

Sep 29 2019

cgiboudeaux committed R74:4ee27e650aab: Merge remote-tracking branch 'origin/1.6' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/1.6'
Sep 29 2019, 7:49 AM
cgiboudeaux committed R74:23c461c059b2: Increase the minimum CMake version. (authored by cgiboudeaux).
Increase the minimum CMake version.
Sep 29 2019, 7:49 AM
cgiboudeaux closed D24229: Increase the minimum CMake version..
Sep 29 2019, 7:49 AM

Sep 27 2019

cgiboudeaux added a reviewer for D24229: Increase the minimum CMake version.: smartins.
Sep 27 2019, 6:07 PM

Sep 25 2019

cgiboudeaux updated the diff for D24229: Increase the minimum CMake version..

Better commit message

Sep 25 2019, 4:24 PM
cgiboudeaux requested review of D24229: Increase the minimum CMake version..
Sep 25 2019, 4:21 PM

Sep 24 2019

cgiboudeaux added an inline comment to M155: KMail revamped.
Sep 24 2019, 9:21 AM

Sep 18 2019

cgiboudeaux committed R108:265e6367f784: Fix a link error when building kwin. (authored by cgiboudeaux).
Fix a link error when building kwin.
Sep 18 2019, 9:46 AM

Sep 13 2019

cgiboudeaux added inline comments to D23908: feat(akonadiserver): Add AppArmor profile for akonadiserver.
Sep 13 2019, 8:56 AM · KDE PIM

Sep 11 2019

cgiboudeaux committed R487:48b16b8a7b5f: Remove 'phonon' from the include directory (authored by cgiboudeaux).
Remove 'phonon' from the include directory
Sep 11 2019, 9:59 PM
cgiboudeaux closed D23873: Remove 'phonon' from the include directory.
Sep 11 2019, 9:59 PM
cgiboudeaux requested review of D23873: Remove 'phonon' from the include directory.
Sep 11 2019, 9:52 AM

Sep 10 2019

cgiboudeaux accepted D23855: Avoid installing log categorie file to KDE_INSTALL_CONFDIR.

Thanks

Sep 10 2019, 8:43 PM · Frameworks

Sep 8 2019

cgiboudeaux added a comment to D23789: Add ECMGenerateExportHeader, for improved handling of deprecated API.

Tests needed :)

Sep 8 2019, 4:10 PM · Build System, Frameworks
cgiboudeaux committed R104:b4cc4a38db30: Reorder the frameworks requirements (authored by cgiboudeaux).
Reorder the frameworks requirements
Sep 8 2019, 8:25 AM
cgiboudeaux committed R104:1cb2cec2929b: Add the missing KCMUtils requirement (authored by cgiboudeaux).
Add the missing KCMUtils requirement
Sep 8 2019, 8:25 AM

Sep 7 2019

cgiboudeaux added a comment to D22143: Add proper logging using ECMQtDeclareLoggingCategory.

This is installing BOTH /etc/xdg/kactivities-stats.categories AND/usr/share/qlogging-categories5/kactivities-stats.categories which is surely wrong?

Sep 7 2019, 8:17 AM · Frameworks

Aug 29 2019

cgiboudeaux added a comment to D23552: ECM: remove set_package_properties from FindCanberra.

I'd do the opposite, remove DESCRIPTION and URL from knotification's CMakeLists.txt and only leave the PURPOSE line.

Aug 29 2019, 5:59 AM · Build System, Frameworks

Aug 24 2019

cgiboudeaux committed R181:457fbda25a85: Fix a crash when running 'amarok -l /path/to/file' (authored by cgiboudeaux).
Fix a crash when running 'amarok -l /path/to/file'
Aug 24 2019, 7:05 AM
cgiboudeaux closed D23326: Fix a crash when running 'amarok -l /path/to/file'.
Aug 24 2019, 7:05 AM

Aug 21 2019

cgiboudeaux requested review of D23326: Fix a crash when running 'amarok -l /path/to/file'.
Aug 21 2019, 6:38 PM

Aug 17 2019

cgiboudeaux accepted D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 1:51 PM · Frameworks, Kate, Framework: Syntax Highlighting
cgiboudeaux added inline comments to D23208: Use CMake find_dependency in CMake config file instead of find_package.
Aug 17 2019, 6:41 AM · Frameworks, Kate, Framework: Syntax Highlighting

Aug 14 2019

cgiboudeaux accepted D22061: Add a logging category for logs warnings.

LGTM

Aug 14 2019, 3:12 PM · Frameworks
cgiboudeaux added a comment to D22805: set autorcc and autouic by default.

@kossebau @vkrause @apol something else to change?

Aug 14 2019, 1:57 PM · Build System, Frameworks
cgiboudeaux added a comment to D22061: Add a logging category for logs warnings.

ok, please change the remaining kconf/KCONF to kconfig/KCONFIG and it should be fine.

Aug 14 2019, 1:54 PM · Frameworks
cgiboudeaux set the repository for D22699: Support passing target to ecm_qt_declare_logging_category to R240 Extra CMake Modules.
Aug 14 2019, 1:42 PM · Build System, Frameworks
cgiboudeaux added a comment to D22709: Support passing target to ecm_add_app_icon..

This shall be compliant with the minimum ECM version set in the project.

Aug 14 2019, 1:40 PM · Build System, Frameworks
cgiboudeaux added a comment to D18969: Use ECM's Exiv2 find module.

+1 LGTM. Probably needs to be rebased

Aug 14 2019, 1:38 PM
cgiboudeaux committed R116:a1c99fc7cbba: Add some missing includes. (authored by cgiboudeaux).
Add some missing includes.
Aug 14 2019, 7:42 AM

Aug 13 2019

cgiboudeaux committed R120:c574e7850e50: Add a missing include. (authored by cgiboudeaux).
Add a missing include.
Aug 13 2019, 2:54 PM
cgiboudeaux committed R120:465e8a6c550c: Look for libkscreen. (authored by cgiboudeaux).
Look for libkscreen.
Aug 13 2019, 2:54 PM
cgiboudeaux committed R235:134e0290cc2f: Fix the attica pkgconfig file. (authored by cgiboudeaux).
Fix the attica pkgconfig file.
Aug 13 2019, 9:53 AM
cgiboudeaux closed D23029: Fix the attica pkgconfig file..
Aug 13 2019, 9:53 AM · Frameworks

Aug 12 2019

cgiboudeaux added a comment to D23029: Fix the attica pkgconfig file..

Unless someone has objections, I'll push this tomorrow.

Aug 12 2019, 10:16 AM · Frameworks

Aug 9 2019

cgiboudeaux committed R44:30cc6fcd6e83: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Aug 9 2019, 10:57 AM
cgiboudeaux committed R44:4585292dd34f: Fix another race condition found while packaging the 19.08.0 release (authored by cgiboudeaux).
Fix another race condition found while packaging the 19.08.0 release
Aug 9 2019, 10:55 AM

Aug 8 2019

cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:34 PM · Frameworks
cgiboudeaux updated the diff for D23029: Fix the attica pkgconfig file..

use ${prefix} for the exec line.
For the others, it's a bit trickier since you can use either relative or
absolute paths when calling CMake.

Aug 8 2019, 12:32 PM · Frameworks
cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:21 PM · Frameworks
cgiboudeaux updated the diff for D23029: Fix the attica pkgconfig file..

fix path

Aug 8 2019, 12:20 PM · Frameworks
cgiboudeaux added a comment to D23029: Fix the attica pkgconfig file..

Note: the ecm_generate_pkgconfig_file macro cannot be used since it doesn't support extra CFLAGS (yet)

Aug 8 2019, 12:08 PM · Frameworks
cgiboudeaux updated the test plan for D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:07 PM · Frameworks
cgiboudeaux requested review of D23029: Fix the attica pkgconfig file..
Aug 8 2019, 12:06 PM · Frameworks

Jul 30 2019

cgiboudeaux added inline comments to D22061: Add a logging category for logs warnings.
Jul 30 2019, 7:23 AM · Frameworks
cgiboudeaux committed R345:137f812451b4: Fix the 0613aa4 commit. (authored by cgiboudeaux).
Fix the 0613aa4 commit.
Jul 30 2019, 6:58 AM
cgiboudeaux closed D22815: Fix finding (KF5)Plasma.
Jul 30 2019, 6:58 AM

Jul 29 2019

cgiboudeaux committed R81:a42b13dd33e5: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Jul 29 2019, 2:47 PM
cgiboudeaux committed R81:d88e60cf65be: Install the .rc files back into KDE_INSTALL_CONFDIR (authored by cgiboudeaux).
Install the .rc files back into KDE_INSTALL_CONFDIR
Jul 29 2019, 2:45 PM

Jul 27 2019

cgiboudeaux committed R44:f00679f383fa: Merge remote-tracking branch 'origin/Applications/19.08' (authored by cgiboudeaux).
Merge remote-tracking branch 'origin/Applications/19.08'
Jul 27 2019, 1:51 PM
cgiboudeaux committed R44:9d62d2dbd88d: Fix the license file. (authored by cgiboudeaux).
Fix the license file.
Jul 27 2019, 1:43 PM

Jul 24 2019

cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 11:35 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22698: Support passing target to ki18n_wrap_ui macro.
Jul 24 2019, 7:47 AM · Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 7:45 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Jul 24 2019, 7:44 AM · Build System, Frameworks

Jul 23 2019

cgiboudeaux accepted D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.

LGTM

Jul 23 2019, 1:50 PM · Build System, Frameworks
cgiboudeaux accepted D22667: Make the default build type "Debug" when compiling a git checkout..

Good idea

Jul 23 2019, 10:39 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.
Jul 23 2019, 9:52 AM · Build System, Frameworks

Jul 21 2019

cgiboudeaux added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Jul 21 2019, 9:28 AM · Build System, Frameworks
cgiboudeaux accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 21 2019, 9:12 AM · Build System, Frameworks