cameronrodgers (Cameron Rodgers)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 26 2019, 11:02 PM (7 w, 5 d)
Availability
Available

Recent Activity

Fri, Oct 11

cameronrodgers added a comment to D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.

@cameronrodgers I think renaming the variable is OK. Please feel free to continue the work on this.

I've been busy with schoolwork, but I did a bit more testing and I think it's pretty clear that blur is interacting with the title bars in a bad way.


As you can see in the pic, the color of the messed up title bar edges (and icons) reflects the color of the background image. Some are greenish, some white, blue, etc.
As well, the visual regression isn't a result of changing any of the highlight code (reverting the highlight stuff doesn't fix it in my patch). It's from moving the title bars over the edges of the windows, so that the blur effect on the edges takes in some of the wallpaper color. The problem is actually there in the code without this patch, it's just not very visible (if at all) because the title bars are centered on the windows.

Fri, Oct 11, 5:58 AM · KWin

Aug 28 2019

cameronrodgers added a comment to D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.

Actually I found a UI regression that happens with this patch. There's now a white/gray line underneath the title:

Good catch. This seems to be related to the Blur effect, as it doesn't occur if Blur is turned off in Desktop Effects. I agree it's a regression for the title bars, but this problem is actually more widespread. The current code (without this patch applied) already has the white/gray/transparent line around icons, and around (some) title bars. Here is a screenshot of the current Present Windows effect:


Do we have any clues on how to prevent this? I'll be looking into it later.

Aug 28 2019, 9:29 PM · KWin

Aug 27 2019

cameronrodgers added a comment to D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.
In D23480#519908, @zzag wrote:

I think people in that discussion may be overthinking it

There's has to be some way to show what currently highlighted client is.

The windows still get bigger when selected/moused over, and if the close button is enabled, that also indicates it.

Aug 27 2019, 4:12 AM · KWin
cameronrodgers added a comment to D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.

In your summery upload screenshots directly here instead of using third party services. Link to other revisions by mentioning DXXXX instead of full http links.

Aug 27 2019, 12:17 AM · KWin
cameronrodgers updated the summary of D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.
Aug 27 2019, 12:16 AM · KWin

Aug 26 2019

cameronrodgers requested review of D23480: [kwin/effects/presentwindows] Remove window dimming and move title bars to bottom.
Aug 26 2019, 11:44 PM · KWin