bdbai (Bob Bai)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Nov 23 2019, 8:07 AM (230 w, 4 d)
Availability
Available

Recent Activity

Dec 3 2019

bdbai abandoned D25484: Enable closing a tab by middle click.

Moved to https://invent.kde.org/kde/okular/merge_requests/69 .

Dec 3 2019, 4:21 AM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.

An MR is drafted at invent, see https://invent.kde.org/kde/okular/merge_requests/69 .

Dec 3 2019, 2:01 AM · Okular

Nov 27 2019

bdbai updated the diff for D25484: Enable closing a tab by middle click.

Fixed code styles

Nov 27 2019, 12:26 AM · Okular

Nov 26 2019

bdbai updated the diff for D25484: Enable closing a tab by middle click.
  • Added "undo tab close"
  • Added a test
Nov 26 2019, 2:05 PM · Okular

Nov 25 2019

bdbai added a comment to D25484: Enable closing a tab by middle click.

Yes this helps the case that @pino brings up, but it handles a different use case. Most of the time a tab won't have unsaved changes because Okular is primarily a reading app. An "Undo last closed tab" feature is for these other cases.

Nov 25 2019, 4:24 PM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.
In D25484#566490, @pino wrote:

...

The solution to accidentally clicks is not disabling it by default and making it configurable, but providing the functionality to "restore" a tab after closing it accidentally. Dolphin and Chrome allow me to restore the last closed tab with Ctrl+Shift+T.

And this "solution" does not always work, for example when a page was the result of a form submission, redirection, or other kind of interactivity.

Nov 25 2019, 8:16 AM · Okular
bdbai added a comment to D25484: Enable closing a tab by middle click.

...
Also please remember to use invent.kde.org and not phabricator for okular merge requests

Nov 25 2019, 1:31 AM · Okular

Nov 24 2019

bdbai added a comment to D25484: Enable closing a tab by middle click.

@bdbai, to move this forward, do you think you could also make tab closing undoable?

Nov 24 2019, 6:03 PM · Okular

Nov 23 2019

bdbai requested review of D25484: Enable closing a tab by middle click.
Nov 23 2019, 8:29 AM · Okular