avaldes (Alejandro Valdes)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Oct 25 2018, 11:51 AM (42 w, 1 d)
Availability
Available

Recent Activity

Jul 1 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

I'd quite like to get this in as I'll end up moving part of this - and we've got too much bikeshedding here.

i18n("While asleep, hibernate after 3 hours")

If you don't know the timeout, don't write it. It's better to be vague than lie.

"Suspend, then hibernate after a period of inactivitiy"

Jul 1 2019, 2:07 PM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Summary:
See bug 399727 for a good description of what this code is for.

Jul 1 2019, 2:06 PM · Plasma

Jun 6 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

I apologize if this is the wrong place to add this comment but I have a laptop where this applies and would benefit me. I am happy to help test this if you find it helpful. Thanks.

Jun 6 2019, 10:25 PM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Summary:
See bug 399727 for a good description of what this code is for.

Jun 6 2019, 3:59 AM · Plasma

Jun 5 2019

avaldes added inline comments to D16425: Added new Suspend then Hibernate option.
Jun 5 2019, 10:02 PM · Plasma
avaldes added a comment to D16425: Added new Suspend then Hibernate option.

Sorry for the constant spam of the original commit message, I cannot make arcanist to pick up a new commit for this differential without deleting the old one.

Jun 5 2019, 3:23 AM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Added new Suspend then Hibernate option

Jun 5 2019, 3:21 AM · Plasma

Jun 1 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

Added changes based on recent comments.

Jun 1 2019, 2:57 AM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Added new Suspend then Hibernate option

Jun 1 2019, 2:50 AM · Plasma

May 19 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

Updated with latest comments.

May 19 2019, 3:11 AM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Added new Suspend then Hibernate option

May 19 2019, 2:20 AM · Plasma

May 17 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

This patch doesn't seem to work for me. I have Arch Linux, powerdevil-5.15.5-1 and your patch applied. After clicking the check-box the "Apply" button doesn't get active. Therefore, this setting is not being saved.

May 17 2019, 1:04 AM · Plasma

May 14 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

UI looks good enough for now. But is this the full diff? It seems like something got lost. The whole patch should include the changes from all commits in your branch, not just the last one.

May 14 2019, 4:13 PM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Added new Suspend then Hibernate option

May 14 2019, 4:11 PM · Plasma
avaldes added a comment to D16425: Added new Suspend then Hibernate option.

This is how it looks now @ngraham :

May 14 2019, 1:50 AM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Improved messages for suspend session

May 14 2019, 1:48 AM · Plasma

May 13 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

This thing's UI really needs to be rewritten in QML. Once we do that and give it a proper FormLayout style, the string can be shorter, but for now, seeing it in context, I feel like the string should be "Hibernate after 3 hours of sleep".

Also I wouldn't mind making the period configurable. If you don't want to do that in this patch though, that's fine.

May 13 2019, 4:19 PM · Plasma

May 12 2019

avaldes added a comment to D21111: Added new option to use GlobalProtect with openconnect.

I can't land it, please merge @jgrulich

May 12 2019, 4:57 PM · Plasma

May 10 2019

avaldes added a comment to D21111: Added new option to use GlobalProtect with openconnect.

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

This was tested in my machine with Plasma 5.15.5 and the lastest networkmanager-openconnect.

The VPN works but I'm having an issue with the existing configuration options:

Unselecting the option "Use only for resources on this connection" in IPv4 > Routes doesn't work, I can access the network resources only available at the VPN but all my internet connections goes to the default internet route. I was able to solve this temporally by modifying the kernel routes. Is this intended?

Do you mean this change didn't apply and when you opened the configuration again was still selected? If the change did apply and after you open the configuration again it was set as it was supposed to be, then it's most likely a NM issue.

I also tried changing the priority of the VPN to 0 and the default network connection to 2 but it didn't work.

It's autoconnect priority, this means that a connection with a higher priority will be automatically activated after restart instead of any other connection with a lower priority if available.

May 10 2019, 1:28 PM · Plasma
avaldes updated the diff for D21111: Added new option to use GlobalProtect with openconnect.
  • Changes based on code review
May 10 2019, 1:27 PM · Plasma
avaldes added a comment to D21111: Added new option to use GlobalProtect with openconnect.

networkmanager-openconnect has added support in master for global protect, so now we can use it from plasma.

May 10 2019, 12:46 AM · Plasma
avaldes requested review of D21111: Added new option to use GlobalProtect with openconnect.
May 10 2019, 12:29 AM · Plasma

Apr 13 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

I applied this patch to v5.15.4 tag and tested with that and it works (my machine is running plasma 5.15.4), I can change the brightness with the keyboard and set the suspend-then-hibernate option.

Very nice.
The position of the checkbox in the settings seems odd to me.
It would be great to align it below the "After" field.
Or perhaps the screenshot just does not justice to the UI.

Apr 13 2019, 5:10 PM · Plasma
avaldes added a comment to D16425: Added new Suspend then Hibernate option.

So is everything now working for you, or not?

No, I can't use my keyboard to change brightness, but it might be related on how I test my changes. I need guidance on how can I test powerdevil changes locally.

It's a plasma component, so this might be helpful: https://community.kde.org/Guidelines_and_HOWTOs/Build_from_source/Test_plasma

Apr 13 2019, 1:56 AM · Plasma

Apr 12 2019

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

So is everything now working for you, or not?

Apr 12 2019, 5:05 PM · Plasma

Apr 11 2019

avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Removed CMakeList change

Apr 11 2019, 10:58 PM · Plasma
avaldes added a comment to D16425: Added new Suspend then Hibernate option.

@ngraham I updated the patch with the comments, I'm not sure if I'm updating it corrrectly, I have tested it on my machine and it can suspend, but for some reason the dedicated keys to change the brightness are not working on my laptop. I'm still checking if this is related on how I build and test locally powerdevil or is related with my changes.

Apr 11 2019, 10:54 PM · Plasma
avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

Rebasing changes to master, adding latest comments

Apr 11 2019, 10:50 PM · Plasma

Jan 4 2019

abalaji awarded D16425: Added new Suspend then Hibernate option a Love token.
Jan 4 2019, 2:59 PM · Plasma

Nov 6 2018

avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

I have changed the message.

Nov 6 2018, 9:00 AM · Plasma

Oct 28 2018

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

We'll need a spinbox to display time options for the amount of delay before hibernating if this is the UI we go with. But I kinda like Martin's idea and present this in the form of an additional control sort of like this:

While suspended, hibernate after: [combobox with some carefully selected intervals, plus "Never", which is the default choice]

Also, how does this handle hardware or distro configurations that don't support hibernation? I might suggest that it would be best to hide the option entirely in such a case. On this subject, the HIG says:

If some of the program’s settings are only applicable in certain contexts, do not hide the inapplicable ones. Instead, disable them and hint to the user why they’re disabled. Exception: it is acceptable to hide settings for non-existent hardware. For example, it’s okay to hide the touchpad configuration when no touchpad is present.

It's not exaaaactly the same thing, but I think the principle applies here.

Oct 28 2018, 5:46 AM · Plasma

Oct 27 2018

avaldes updated the diff for D16425: Added new Suspend then Hibernate option.

I have added a new checkbox inside the suspend session delay and in button event handling.

Oct 27 2018, 9:27 AM · Plasma

Oct 26 2018

avaldes added a comment to D16425: Added new Suspend then Hibernate option.

@ngraham afaik powerdevil asks logind for system capabilites, with the CanSuspend, CanHibernate, etc. defined here. I added a new option if logind reports yes for CanSuspendThenHibernate option.

Oct 26 2018, 5:57 AM · Plasma

Oct 25 2018

avaldes requested review of D16425: Added new Suspend then Hibernate option.
Oct 25 2018, 12:27 PM · Plasma