atulbi (Atul Bisht)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Dec 10 2018, 7:47 AM (31 w, 4 d)
Availability
Available

Recent Activity

Sat, Jun 22

atulbi accepted D21980: Fix ocasional crash on the touchpad kded.

Me too

Sat, Jun 22, 8:39 AM · Plasma

Fri, Jun 21

atulbi added a comment to D21915: Fix crash in the touchpad kded.

The other question is if "enabled" was ever the correct atom to check for

libinput Tapping Enabled

I'm fairly sure we were checking for libinput Tapping Enabled atom in the past, and so does GNOME: https://gitlab.gnome.org/GNOME/gtk/blob/master/gdk/x11/gdkdevicemanager-xi2.c#L410

I can't find any use of that, the current use of "enabled" was added by @atulbi

Fri, Jun 21, 8:56 AM · Plasma

May 20 2019

atulbi committed R119:ab101ca12af2: Merge branch 'Plasma/5.16' (authored by atulbi).
Merge branch 'Plasma/5.16'
May 20 2019, 12:44 PM
atulbi committed R119:ecea8b93d997: [Touchpad KCM] Fix kded crashing at startup (authored by atulbi).
[Touchpad KCM] Fix kded crashing at startup
May 20 2019, 9:47 AM
atulbi closed D21278: [Touchpad KCM] Fix kded crashing at startup.
May 20 2019, 9:47 AM · Plasma

May 19 2019

atulbi updated the diff for D21278: [Touchpad KCM] Fix kded crashing at startup.
  • Now we have separate m_touchpadOffAtom for synaptics and Libinput. On Libinput, used m_enabled prop.
  • setTouchpadOff will be ignored on X Libinput.
May 19 2019, 7:29 PM · Plasma
atulbi added a comment to D21278: [Touchpad KCM] Fix kded crashing at startup.

by kded on key press other than Kded Keyboard shortcuts

Do you mean it's sent on shortcut or not? Just wondering why I couldn't replicate the issue in my testing.

kded5 did not crash until I pressed some key which is not Kded Keyboard shortcuts. Like Ctrl+Alt+T did not crash it, but just pressing any other key crashed it.
Sending patch for it in a while.

May 19 2019, 10:04 AM · Plasma
atulbi added a comment to D21278: [Touchpad KCM] Fix kded crashing at startup.

m_connection seems to be having null or 0x0 value.

Which means we're calling XcbAtom::atom after being constructed from the default constructor not the proper one.

That doesn't sound right. If you can explain why we end up in this situation and it's legit, I'll accept, otherwise it looks like we're just treating a symptom.

May 19 2019, 9:47 AM · Plasma

May 18 2019

atulbi updated the summary of D21278: [Touchpad KCM] Fix kded crashing at startup.
May 18 2019, 9:52 PM · Plasma
atulbi added a reviewer for D21278: [Touchpad KCM] Fix kded crashing at startup: romangg.
May 18 2019, 9:31 PM · Plasma
atulbi requested review of D21278: [Touchpad KCM] Fix kded crashing at startup.
May 18 2019, 9:29 PM · Plasma
atulbi committed R119:aeca2f1f7133: Revert project version (authored by atulbi).
Revert project version
May 18 2019, 4:55 PM
atulbi committed R119:0d3375f5c4a5: Merge branch 'Plasma/5.16' (authored by atulbi).
Merge branch 'Plasma/5.16'
May 18 2019, 4:55 PM
atulbi committed R119:3e0fd10ddc27: [Touchpad KCM] Fixed loading of wrong qml file (authored by atulbi).
[Touchpad KCM] Fixed loading of wrong qml file
May 18 2019, 3:33 PM
atulbi closed D21269: [Touchpad KCM] Fixed loading of wrong qml file.
May 18 2019, 3:33 PM · Plasma
atulbi updated the summary of D21269: [Touchpad KCM] Fixed loading of wrong qml file.
May 18 2019, 11:12 AM · Plasma
atulbi added reviewers for D21269: [Touchpad KCM] Fixed loading of wrong qml file: romangg, ngraham.
May 18 2019, 11:08 AM · Plasma
atulbi requested review of D21269: [Touchpad KCM] Fixed loading of wrong qml file.
May 18 2019, 10:58 AM · Plasma

May 16 2019

atulbi added a comment to D21228: [Touchpad KCM] Load previous setting on reboot.

Thank you so much for fixing it.
Wanted it to be on beta.

May 16 2019, 4:02 PM · Plasma

May 15 2019

atulbi added reviewers for D21228: [Touchpad KCM] Load previous setting on reboot: ngraham, romangg.
May 15 2019, 3:43 PM · Plasma
atulbi requested review of D21228: [Touchpad KCM] Load previous setting on reboot.
May 15 2019, 3:43 PM · Plasma
atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Also keep in mind that it's possible to have global config files in /etc/X11/xorg.conf.d/ I have one such file there myself that I made to work around the lack of this feature being implemented yet:

$  cat /etc/X11/xorg.conf.d/99-libinput.conf
Section "InputClass"
        Identifier "libinput touchpad catchall"
        MatchIsTouchpad "on"
        MatchDevicePath "/dev/input/event*"
        Driver "libinput"
        Option "ClickMethod" "clickfinger" # other option is "buttonareas"
        Option "DisableWhileTyping" "false"
        Option "AccelSpeed" "0.2"
        #Option "MiddleEmulation" "true" # Only use this with the "buttonareas" clickmethod
EndSection

Others may have similar settings. If possible, it might be nice to read these config files to determine the default option state in the KCM. Then once the user modifies anything, a new user-specific config file gets written that takes priority.

May 15 2019, 3:41 PM · Plasma
atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file?

EDIT: No, they are not. In X11 + evdev the KCM does this, not the backend. We need to:

  1. add config file write and load functions to the X11-libinput backend
  2. add a hook to kcm_init such that the load function is called on startup.

    @atulbi: Do you have time to try this tomorrow?
May 15 2019, 6:43 AM · Plasma
atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

@atulbi This has caused a failure in the CI:

https://build.kde.org/view/Failing/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/204/console

09:12:41  /home/jenkins/workspace/Plasma/plasma-desktop/kf5-qt5 SUSEQt5.12/kcms/touchpad/src/backends/x11/libinputtouchpad.cpp:28:10: fatal error: libinput-properties.h: No such file or directory
09:12:41   #include <libinput-properties.h>
09:12:41            ^~~~~~~~~~~~~~~~~~~~~~~
09:12:41  compilation terminated.

Looks like we need to make the libinput xorg dev package a mandatory dep (boo) or else not build the x11 Libinput KCM if it isn't found (preferred). I know it's short notice but we branch in two days; do you think you could fix this? Thanks!

May 15 2019, 5:09 AM · Plasma

May 14 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Are you ready for me to land this?

May 14 2019, 2:42 PM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Set visible to false, until accel profiles are not supported.

May 14 2019, 2:37 PM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Finally no more greyed settings there \o/

May 14 2019, 2:20 PM · Plasma

May 12 2019

atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • lmr mapping working now
May 12 2019, 2:54 PM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Added Copyright notice
  • Corrected asterisk placement
May 12 2019, 10:24 AM · Plasma
atulbi added inline comments to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
May 12 2019, 8:31 AM · Plasma

May 9 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
In D20186#462883, @GB_2 wrote:

Ping

May 9 2019, 2:19 PM · Plasma

May 4 2019

atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Remove CMakeLists.txt.user
May 4 2019, 6:27 AM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Added abstract class LibinputCommon.
  • All the Q_PROPERTY are in LibinputCommon.
  • Added Disable Horizontal Support on X11 on Libinput.
May 4 2019, 6:19 AM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Removed last commit
May 4 2019, 6:01 AM · Plasma

May 3 2019

atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Added new abstract class LibinputCommon
  • Add overriding destructor
  • Added support for disable horizontal scrolling on Libinput On X11.
May 3 2019, 7:07 PM · Plasma

Apr 30 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

@atulbi were you able to get in touch with @romangg? Can I help in any way?

The feature freeze for Plasma 5.16 is in a little over two weeks (https://community.kde.org/Schedules/Plasma_5) and it would really nice to finally have full Libinput support in our KCM in that release. Right now we'd still have enough time for testing because of the beta period, but we'll need to get it in within the next two weeks.

Apr 30 2019, 6:19 PM · Plasma

Apr 23 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

@atulbi ping! Does Roman's request make sense? In general I think it does make sense to do code clean-up in a separate patch first.

Apr 23 2019, 2:05 AM · Plasma

Apr 6 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Nice work. Most of the stuff in libinputtouchpad.cpp and its header file are copy-paste from the Wayland backend. It would make sense to have a new abstract parent class such that the code is shared.

Apr 6 2019, 11:40 AM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Resolved issues
Apr 6 2019, 9:33 AM · Plasma

Apr 5 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.

@atulbi Congratulations, you’re now the maintainer of Touchpad KCM. In certain countries, there’s something called “inheritance tax” and you just inherited a few dozen bugs. Don’t despair, many of them should be fixed by now and some will be fixed by this commit.

Apr 5 2019, 2:58 PM · Plasma
atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D

Hey, I would be happy to take that responsibility.

Fantastic.

@ngraham @jriddell Would you let me know the technicalities to make Atul maintainer of Touchpad KCM? I couldn't find a guideline in the wiki/techbase.

Wherever you're currently listed, remove your name and replace it with Atul's. :) The only place I can find it on Bugzilla. I've gone ahead and made @atulbi the default assignee for bugs to the Touchpad-KCM product.

@atulbi is anything special needed to compile the KCM? After compiling plasma-desktop with your patch, no touchpad shared library was produced.

Apr 5 2019, 2:54 PM · Plasma

Apr 3 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Got to Know a lot about how X works with input handling. XD

I happen to be the ‘accidental’ maintainer of the Touchpad KCM. I’d be more than happy to hand that hat over if you wish to maintain this code. :-D

Apr 3 2019, 9:03 PM · Plasma

Apr 2 2019

atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Code Cleanup and resolved unexpected behaviour
Apr 2 2019, 1:29 PM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Avoid Setup Backend two times
Apr 2 2019, 12:05 AM · Plasma

Apr 1 2019

atulbi added a comment to D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.

Thanks so much for this!

Apr 1 2019, 9:17 PM · Plasma
atulbi updated the diff for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
  • Minor changes to optimise code
Apr 1 2019, 9:00 PM · Plasma
atulbi added a reviewer for D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11: ngraham.
Apr 1 2019, 8:25 PM · Plasma
atulbi requested review of D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11.
Apr 1 2019, 8:23 PM · Plasma

Mar 5 2019

atulbi added a comment to D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads.

Thanks. Yes, I'll take this for sure.

Mar 5 2019, 10:27 PM · Plasma

Feb 10 2019

atulbi added a reviewer for D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads: ngraham.
Feb 10 2019, 10:11 PM · Plasma
atulbi requested review of D18912: [libinput-touchpad-kcm-click-method] Add click method Areas and Clickfinger for buttonless touchpads.
Feb 10 2019, 10:09 PM · Plasma

Dec 22 2018

atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
  • fixed warning
Dec 22 2018, 4:10 PM · KWin

Dec 21 2018

atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
  • Changed C-style cast to static cast
  • improve whitespace
Dec 21 2018, 7:27 PM · KWin
atulbi added a comment to D17577: [libinput] Add support for clickfinger and button areas click method.

No , I don't have commit rights

Dec 21 2018, 5:06 PM · KWin
atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
  • added test for defaults
Dec 21 2018, 2:42 PM · KWin
atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
Dec 21 2018, 2:29 PM · KWin
atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
  • Added dbus test for default values
Dec 21 2018, 2:15 PM · KWin
atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.
  • Added dbus test
Dec 21 2018, 7:02 AM · KWin

Dec 20 2018

atulbi added a reviewer for D17577: [libinput] Add support for clickfinger and button areas click method: davidedmundson.
Dec 20 2018, 4:03 PM · KWin

Dec 15 2018

atulbi updated the diff for D17577: [libinput] Add support for clickfinger and button areas click method.

Added unit test

Dec 15 2018, 10:51 PM · KWin
atulbi added a comment to D17577: [libinput] Add support for clickfinger and button areas click method.

Yes Next I'm going to implement unit test once this get finalized

Dec 15 2018, 3:34 PM · KWin

Dec 14 2018

atulbi added a reviewer for D17577: [libinput] Add support for clickfinger and button areas click method: ngraham.
Dec 14 2018, 2:25 PM · KWin
atulbi updated the summary of D17577: [libinput] Add support for clickfinger and button areas click method.
Dec 14 2018, 2:24 PM · KWin
atulbi requested review of D17577: [libinput] Add support for clickfinger and button areas click method.
Dec 14 2018, 2:19 PM · KWin