antonarnold (Anton Arnold)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Sunday

  • Clear sailing ahead.

User Details

User Since
Wed, Oct 23, 9:28 PM (4 w, 1 d)
Availability
Available

Recent Activity

Wed, Oct 30

antonarnold added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Thanks for the review, I'll revert the whitespace changes in the next revision.
I have some questions embedded in the inline code comments.
It would be great if you can provide some answers/information.

Wed, Oct 30, 11:47 AM

Tue, Oct 29

antonarnold requested review of D25052: Optimize support of scanners with different image sources or duplex unit.
Tue, Oct 29, 6:10 PM
antonarnold updated the diff for D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

Cropped scan-area patch (removed option ordering from this diff)
Applied KDE Coding Style (manually and via astyle)
Updated UI element alignment

Tue, Oct 29, 5:57 PM

Sat, Oct 26

antonarnold added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.
In D24904#554068, @sars wrote:

Hi,

Thanks for your review request! :)

Can you split this review request into two separate requests. One for the scan area and one for the reordering of the options list (I'm not yet clear with what the reordering of the options list brings ;)

I have tried to keep the size options out of the UI because I was aiming at the photo scanning not the document scanning, but I guess a separate tab for scan area stuff does not hurt as long as it is possible to disable/hide.

Sat, Oct 26, 8:44 AM

Wed, Oct 23

antonarnold added a comment to D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.

If I understand this correctly, this doesn't add any new features, but it does add an additional method for configuring the scan area. Is that correct?

Wed, Oct 23, 10:26 PM
antonarnold updated the summary of D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.
Wed, Oct 23, 9:59 PM
antonarnold requested review of D24904: Add scan area / paper size configuration to the libksane ksanewidget and thereby to skanlite.
Wed, Oct 23, 9:54 PM