User Details
User Details
- User Since
- Jul 26 2018, 4:22 AM (358 w, 2 d)
- Availability
- Available
Dec 13 2019
Dec 13 2019
andykluger requested review of D25969: No longer vertically flip the shade icon when toggled.
Aug 6 2018
Aug 6 2018
andykluger added a comment to D14389: Invert shade button by same logic as keep-above button.
Is it worth considering to stop vertically flipping the shade icon? I don't care either way, as the visual cue that provides is too subtle for me to notice anyway.
andykluger updated the diff for D14389: Invert shade button by same logic as keep-above button.
- Revert "flip keep-above icon when checked"
Jul 27 2018
Jul 27 2018
andykluger updated the diff for D14389: Invert shade button by same logic as keep-above button.
Invert shade button colors when in checked state; Vertically flip keep-above button in checked state
andykluger updated the diff for D14389: Invert shade button by same logic as keep-above button.
Flip keep-above icon when in checked state, for consistency with shade button
andykluger added a comment to D14389: Invert shade button by same logic as keep-above button.
andykluger added a comment to D14389: Invert shade button by same logic as keep-above button.
I see how the shade button flips while the keep-above doesn't, but I don't see the difference between toggling the shade state and shade/unshade, or toggling the keep-above state and keep-above/don't-keep-above. But I can't argue against consistency here.
Jul 26 2018
Jul 26 2018
andykluger requested review of D14389: Invert shade button by same logic as keep-above button.