• Passing default empty paramters to the call function

I updated the the description of the patch now, sorry about that.

• Changing variables, function names and comments to be more meaningful

In D16285#346944, @aacid wrote:

In D16285#346879, @ahmadosama wrote:

In D16285#346864, @aacid wrote:

If you're not going to save the data, why are you adding it to the docinfo xml?

If this is only for remembering the options while okular is open i don't even think it makes sense storing it into document at all and should just be stored in Part as something like a QMap<Document,PrinterOptions>

I am adding the data to the docinfo xml to remember those data when the file is reopened even after closing Okular the printing data would be remembered for the same file.

But you just said "I reset the printing options when closing the document".

So I'm confused.

Is the plan to remember options between different Okular executions or is it no?

@yurchor
I have reformatted the code to be consistent, sorry for this.

• Reformat other parts of the code

• Reformatting the code to be consistent with other parts

In D16285#346864, @aacid wrote:

If you're not going to save the data, why are you adding it to the docinfo xml?

If this is only for remembering the options while okular is open i don't even think it makes sense storing it into document at all and should just be stored in Part as something like a QMap<Document,PrinterOptions>

In D16285#344990, @ngraham wrote:

This new information is saved/remembered per-document and not globally, right?

• Resetting the printing option to the default options when closing document

I updated the parttest.cpp, the tocreload.pdf file in the data directory reproduced this bug so I used it for the unit test.

• Adding a unit test to check that document doesnot go back to contents view after saving

I agree with what you have said, and I was thinking about some of it.
Closing the feature will not upset me, I have learned a lot from working on it.
I hope that I could make better contributions to Okular later.

I will investigate more to find out why m_rects and m_highlights need different transformation matrices.

I used Okular::buildRotationMatrix to rotate the highlights, the rotation angle is specified in the rotateAt function

As far as I know rotating m_page->m_rects should rotate annotations on the page, the annotations seem to work well when rotating them.

I tried rotating using ( const QTransform matrix = rotationMatrix() ) but it only works when rotating a page from its original orientation, this is why I modified the RotationJob::rotationMatrix in a way similar to Okular::buildRotationMatrix to allow rotating from different orientations.

I added the boolean parameter to either translate or not.

Oh yes this may break it, I am thinking of adding another Boolean parameter to the RotationJob::rotationMatrix function with a default value of false to either translate or not
The function can be:
RotationJob::rotationMatrix( Rotation from, Rotation to, bool translate = false )

Removing white spaces.

I have done the required changes.
I created the EditWidgetsCommand class to undo/redo the reset action of all widgets by a single click, also I moved the core implementation of the reset function to the Document class, and I updated the reset auto test to include the undo/redo and the test is working fine on the created tests.

Regarding the undo/redo stacks, the undo/redo command will not undo the whole reset, it will undo widgets somehow randomly.
RadioButtons in the same page will be in the same undo command, as for TextLineEdit each single widget will be added separately to the undo/redo stack.

yes I am going to cancel this revision.

I added an auto-test for this option, the test is working fine on all the created test cases.

I mistakenly replaced the code with the auto test.
I edited the patch now.

I have created an auto test but it is not working, in the test class I created a page view class that takes a document pointer in its constructor then it calls the reset function in the pageview class.

I implemented the reset option using Okular::FormFields inspired by the comments here:
https://git.reviewboard.kde.org/r/130057/

I have not created an auto test before, I am currently going through current auto tests to understand how it works, then I will try creating an auto test for this bug.

Removing unnecessary comments, add clear widget function for other widgets.