Brush name comes first. If I left only brush name, the text would be 1 line.
For some reason when text is 1 line height, the brush thumbnail in floating message is shown too small.

In D7454#138233, @rempt wrote:

I'm not sure why you changed the structure of the loops, but that's fine. Otherwise, the patch works as advertised :-)

I feel like usage of range-based for-loops makes sence, when counter variable by itself doesn't matter. Since here counter variable is used (not just as index to access element in single container), it makes more sence to use "classic" for loop that have counter variable in it.

Also, I'm not sure how to make "adding rectangle to scene" interface. To define a rectangle, you need to choose 2 vanishing points from same basis and 2 diagonally opposite points of rectangle's corner.

Brief explanation: it's a painting assistant that helps you draw in Panini projection.
Panini projection is a projection that allows you to draw in wide angle without distortion.
See this image, comparing rectilinear and Panini projections: https://raw.githubusercontent.com/shaunlebron/blinky/master/readme-img/old-and-new.jpg (source)

I want to write the code for this assistant, but I'm not sure if I'm right person to singlehandedly decide new architecture of assistant tool and assistants (At least I would need to talk to other developers).

so, I added a scetch for it's interface.

more organized. i hope

Now, tab key presses interpreted as shortcut only when canvas in focus - otherwise it will be handled by widgets to change focus.
Since i coulndn't find documentation about order, in which widgets' event handlers are invoked nor guarantee that qt won't start handling next event before all handlers for previous is called (though it makes sence), i can't really claim it will work perfectly in further versions of qt.

Now KisQtWidgetsTweaker affects QComboBox, Both QSpinBoxes
KisQtWidgetsTweaker now installed on app in main.cc
QAbstratcSliderSpinBox now accept QShortcutOverride event by itself (no need to do that using KisQtWidgetsTweaker).

According to this page: https://bugreports.qt.io/browse/QTBUG-3385 this behavior of QLineEdit

is by design, and not a bug.

almost forgot to put name

@dkazakov This approach using BackgroundRole is way more neat and works as well (on win8.1 at least). So, yeah, we totally should use it.

Hi, @dkazakov!
Thank you for pointing at this flaw! It could be seen on windows too. Now, I believe I fixed it