Joefish (Joseph Winzer)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Sep 13 2016, 1:00 PM (512 w, 4 d)
Availability
Available

Recent Activity

Jul 5 2019

Joefish updated the diff for D22282: Fixes group separated stored constants that would show as nan.

Added const qualifier to decimalPoint, groupSeparator and groupSeparatorEnabled

Jul 5 2019, 4:21 PM
Joefish added reviewers for D22282: Fixes group separated stored constants that would show as nan: teran, martonmiklos.
Jul 5 2019, 1:38 PM
Joefish updated the diff for D22282: Fixes group separated stored constants that would show as nan.

Constants are stored in a C locale way and converted to the current locale
settings before being passed to the KNumber constructor.
Unfortunately, the tooltip doesn't show the stored constant in the active
locale as no locale information is stored with the number so that stored constants
between KCalc instances with different locales could be converted on startup.

Jul 5 2019, 12:15 PM
Joefish added a comment to D22282: Fixes group separated stored constants that would show as nan.

If the constants are stored in localized format, does changing between locales that swap the decimal separators cause issues?

Jul 5 2019, 11:32 AM

Jul 4 2019

Joefish added a comment to D22282: Fixes group separated stored constants that would show as nan.

Another possibility would be to add the removal of the group separators to the KNumber constructor as decimal point conversion is already done there.
I wrote it like this because it is the most non-invasive way and stored constants seem to be the only part affected by it.

Jul 4 2019, 11:07 PM
Joefish updated the diff for D22282: Fixes group separated stored constants that would show as nan.

Checks if group separators are enabled

Jul 4 2019, 10:54 PM
Joefish added a comment to D22263: Fixes group separated stored constants that would show as nan.

new version at D22282

Jul 4 2019, 9:56 PM
Joefish abandoned D22263: Fixes group separated stored constants that would show as nan.
Jul 4 2019, 9:55 PM
Joefish requested review of D22282: Fixes group separated stored constants that would show as nan.
Jul 4 2019, 9:47 PM
Joefish requested review of D22263: Fixes group separated stored constants that would show as nan.
Jul 4 2019, 10:25 AM

Feb 8 2017

Joefish retitled D4506: Fix glLogicOp by using QOpenGLFunctions_3_0 instead of GLES2 + WGL from to Fix glLogicOp by using QOpenGLFunctions_3_0 instead of GLES2 + WGL.
Feb 8 2017, 4:44 PM

Sep 13 2016

Joefish created T3728: Reference Image Docker -- Add rotate and flip.
Sep 13 2016, 9:10 PM · Krita
Joefish added a member for Krita: Abyss: Joefish.
Sep 13 2016, 8:52 PM