Feed Advanced Search

Sat, Feb 15

develoot added a watcher for KDevelop: develoot.
Sat, Feb 15, 6:16 AM

Tue, Feb 4

aaronpuchert added a comment to D18551: clang: Create preamble only on second parse.

Hmm, now I'm thinking: If we parse first without creating a preamble, we still have the Clang AST. Couldn't we create the preamble from the AST without reparsing and use that for subsequent parsing?

Tue, Feb 4, 2:45 AM · KDevelop
aaronpuchert added a comment to D18551: clang: Create preamble only on second parse.

How bad would it be if we don't do that and only provide KTextEditor-completions before the first edit? I think it's pretty rare that code completion is immediately requested, typically one starts with a line break, or by removing code, before new code is written.

Very bad. I can still remember how bad it felt to use KDevelop before @brauch fixed some nasty issues that prevented us from using the PCH properly. It always felt like KDevelop was utterly broken since it took so long to give us completion answers. And I believe I also remember that quite a few of our users complained about it, and in turn praised the improvement after @brauch fixed it.

You're referring to D6905? That contains a lot of other things. I don't think that adding the flag was the core part of that change, and @brauch doesn't think so either:

Tue, Feb 4, 2:41 AM · KDevelop

Mon, Feb 3

rjvbb added a comment to D18551: clang: Create preamble only on second parse.

You don't have control over where those pch files are written, right, other than through setting $TMPDIR?

Mon, Feb 3, 9:44 PM · KDevelop
mwolff added a comment to D18551: clang: Create preamble only on second parse.

To keep this short I didn't reply to the parts I completely agree with.

Now I actually have /tmp as tmpfs, and so these 400 MB don't come for free. This is perfectly fine when I'm actually working on these files, but so far I have only opened KDevelop.

I see. The problem really is that the preamble files shouldn't be written to /tmp then - it would be perfectly fine to move them to a temp dir on the disk I think - it would still be faster than having to redo the work.

There are arguments for both in-memory and on-disk, it depends on how much memory there is. I have another more more generously sized machine where the files are perfectly fine in RAM.

I think /tmp is correct by the FHS and /var/tmp wouldn't be appropriate. I could easily put this on disk if I wanted to. I just wanted to make the argument that resource usage is a concern, and that there is some benefit in limiting ourselves to the preambles that we need.

Mon, Feb 3, 8:37 PM · KDevelop

Sun, Feb 2

aaronpuchert added a comment to D18551: clang: Create preamble only on second parse.

To keep this short I didn't reply to the parts I completely agree with.

Sun, Feb 2, 6:23 PM · KDevelop

Sat, Feb 1

pprkut updated the task description for T6810: PHP 5.6 features.
Sat, Feb 1, 1:20 PM · KDevelop
pprkut updated the task description for T6810: PHP 5.6 features.
Sat, Feb 1, 1:19 PM · KDevelop

Fri, Jan 31

mwolff added a comment to D18551: clang: Create preamble only on second parse.

I still think this is the right change, but if there is no consensus I will implement @mwolff's suggestion. That would certainly be an improvement, but it doesn't really solve my problem. I'm currently working on Clang and have around 6 files open, which is really not a lot. I haven't changed any of them. The result:

aaron:~/src/llvm-project> ls -l /tmp/preamble-*
-rw-r--r-- 1 aaron users 73139496 Okt  9 22:27 /tmp/preamble-0e19f4.pch
-rw-r--r-- 1 aaron users 59327864 Okt  9 22:23 /tmp/preamble-2a515c.pch
-rw-r--r-- 1 aaron users 61885536 Okt  9 22:23 /tmp/preamble-2baca3.pch
-rw-r--r-- 1 aaron users 76913424 Okt  9 22:23 /tmp/preamble-9853df.pch
-rw-r--r-- 1 aaron users 64254872 Okt  9 22:23 /tmp/preamble-cbb035.pch
-rw-r--r-- 1 aaron users 64829792 Okt  9 22:24 /tmp/preamble-dd9bf1.pch
aaron:~/src/llvm-project> du -s /tmp/ 2>/dev/null
391204  /tmp/

Now I actually have /tmp as tmpfs, and so these 400 MB don't come for free. This is perfectly fine when I'm actually working on these files, but so far I have only opened KDevelop.

Fri, Jan 31, 8:38 PM · KDevelop
kossebau closed D26938: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate.
Fri, Jan 31, 7:24 PM · KDevelop

Thu, Jan 30

kossebau added a comment to D26938: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate.

Anyone who takes enough interest in kdev-pg-qt to care for review? :)

Thu, Jan 30, 2:52 PM · KDevelop

Tue, Jan 28

kossebau added a comment to D26938: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate.

To be used then by https://invent.kde.org/kde/kdevelop/merge_requests/97

Tue, Jan 28, 10:48 AM · KDevelop

Mon, Jan 27

kossebau added a comment to D26938: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate.

Plan is to do a 2.2.1 release directly after that (also needed to officially get the Qt 5.14 build-fix out), so this is available to kdevelop 5.5

Mon, Jan 27, 1:18 PM · KDevelop
kossebau requested review of D26938: Add ENFORCE_COMPATIBLE_ERROR_AWARE_CODE flag to kdevpgqt_generate.
Mon, Jan 27, 1:17 PM · KDevelop

Sun, Jan 26

kogiokka added a member for KDevelop: kogiokka.
Sun, Jan 26, 7:28 AM

Fri, Jan 24

lbiaggi abandoned D26856: Removing deprecated warnings messages.
Fri, Jan 24, 5:07 PM · KDevelop
lbiaggi added a comment to D26856: Removing deprecated warnings messages.

Yes, it is

Fri, Jan 24, 5:02 PM · KDevelop
kossebau added a comment to D26856: Removing deprecated warnings messages.

https://invent.kde.org/kde/kdevelop/merge_requests/93 is the replacement of this patch, right?
If so, please also close this review here as discarded :)

Fri, Jan 24, 5:00 PM · KDevelop

Jan 22 2020

kossebau requested changes to D26856: Removing deprecated warnings messages.

Hi @lbiaggi, welcome to contributing to KDevelop, thanks for your first(?) patch proposed here. I agree with your goal to make the code more modern :)

Jan 22 2020, 11:40 PM · KDevelop
lbiaggi requested review of D26856: Removing deprecated warnings messages.
Jan 22 2020, 11:15 PM · KDevelop

Jan 18 2020

pprkut closed D26254: Add support for PHP 7.4's typed properties.
Jan 18 2020, 10:18 PM · KDevelop

Jan 14 2020

aaronpuchert added a comment to D25494: Make tar archives reproducible by setting Pax headers.

This should work fine with a producer GNU-tar >= 1.28

We use the option only when SOURCE_DATE_EPOCH is set, and we assume that a recent enough tar is available then. Basically we say that if reproducible builds are desired, the proper tools should be available.

Jan 14 2020, 1:01 AM · KDevelop

Jan 13 2020

pprkut closed D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Jan 13 2020, 6:44 PM · KDevelop
pprkut added a comment to D26254: Add support for PHP 7.4's typed properties.

I would really like to have this in 5.5, so if there's no review by next weekend I'll merge as is.

Jan 13 2020, 6:02 PM · KDevelop
pprkut accepted D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Jan 13 2020, 5:53 PM · KDevelop
kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

No further need, thanks. I got the assist in your previous reply already I was looking for :)

Jan 13 2020, 7:55 AM · KDevelop
rjvbb added a comment to D15797: [kdev-clazy] : use canonical paths.

So no urgent need for me to revisit the code?

Jan 13 2020, 7:32 AM · KDevelop
bmwiedemann added a comment to D25494: Make tar archives reproducible by setting Pax headers.

This should work fine with a producer GNU-tar >= 1.28 , but what will be the consumer of the tar file?

Jan 13 2020, 2:06 AM · KDevelop

Jan 12 2020

aaronpuchert updated subscribers of D25494: Make tar archives reproducible by setting Pax headers.

No insight myself, but would trust you you know what you are doing here :) and it also matches what I just read on https://reproducible-builds.org/docs/archives/

Jan 12 2020, 9:52 PM · KDevelop
aaronpuchert closed D25494: Make tar archives reproducible by setting Pax headers.
Jan 12 2020, 9:23 PM · KDevelop
kossebau accepted D25494: Make tar archives reproducible by setting Pax headers.

No insight myself, but would trust you you know what you are doing here :) and it also matches what I just read on https://reproducible-builds.org/docs/archives/

Jan 12 2020, 11:28 AM · KDevelop

Jan 9 2020

kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

Thanks for having had a look again, and confirming that I was not seeing things wrongly half-asleep still :) I am about to touch this code in some days anyway, and would twist things then as needed.

Jan 9 2020, 10:10 PM · KDevelop
rjvbb added a comment to D15797: [kdev-clazy] : use canonical paths.

Difficult to wrap my head around this, so much later!

Jan 9 2020, 9:38 PM · KDevelop
kossebau added a comment to D15797: [kdev-clazy] : use canonical paths.

I just came across this logic (for reasons) and wonder if the logic does what you intended with the patch:
given the const auto canonicalPathToCheck = checkPathIsFile ? pathInfo.canonicalFilePath() : QStringLiteral("");, when checkPathIsFile is false, canonicalPathToCheck is an empty string.

Jan 9 2020, 5:13 AM · KDevelop
aaronpuchert added a reviewer for D25494: Make tar archives reproducible by setting Pax headers: KDevelop.
Jan 9 2020, 12:45 AM · KDevelop

Jan 7 2020

hmitonneau updated the diff for D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

add some tests

Jan 7 2020, 12:12 PM · KDevelop

Jan 5 2020

pprkut added a comment to D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

Looks good :)

Jan 5 2020, 11:45 AM · KDevelop

Jan 3 2020

hmitonneau updated the diff for D25956: [KDevelop/PHP] Importing functions and const from other namespaces.

fix: const are case sensitive
improve tests

Jan 3 2020, 12:12 PM · KDevelop

Dec 28 2019

pprkut requested review of D26254: Add support for PHP 7.4's typed properties.
Dec 28 2019, 9:59 AM · KDevelop
pprkut added inline comments to D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Dec 28 2019, 9:48 AM · KDevelop
pprkut closed D25587: [KDevelop/PHP] fix rename of a variable.
Dec 28 2019, 9:25 AM · KDevelop
pprkut accepted D25587: [KDevelop/PHP] fix rename of a variable.

Looks good :)

Dec 28 2019, 9:19 AM · KDevelop

Dec 26 2019

pprkut closed D24921: [KDevelop/PHP] Add support for "array of type".
Dec 26 2019, 11:27 AM · KDevelop
hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

No problem.
You can use hugues@mitonneau.me
Thanks

Dec 26 2019, 8:48 AM · KDevelop

Dec 23 2019

pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Sorry this took so long! I have it ready to merge, just need to know the email you'd like me to use for the commit author

Dec 23 2019, 7:41 AM · KDevelop

Dec 17 2019

hmitonneau updated the diff for D25587: [KDevelop/PHP] fix rename of a variable.

This new patch re-implement KDevelop::BasicRefactoring::applyChangesToDeclarations and KDevelop::BasicRefactoring::applyChanges in Php::Refactoring.

Dec 17 2019, 10:23 AM · KDevelop

Dec 14 2019

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

No, I don't have commit access.

Dec 14 2019, 11:42 AM · KDevelop
pprkut added a comment to D25587: [KDevelop/PHP] fix rename of a variable.

I appreciate the effort, but I think this is the wrong approach. I really think the $ is part of the variable.

Dec 14 2019, 9:51 AM · KDevelop
pprkut accepted D24921: [KDevelop/PHP] Add support for "array of type".
Dec 14 2019, 9:32 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Hi! Sorry, I was just really busy and didn't have time to take a closer look.

Dec 14 2019, 9:32 AM · KDevelop

Dec 13 2019

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Is there something wrong with the second diff ?

Dec 13 2019, 4:20 PM · KDevelop
hmitonneau requested review of D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Dec 13 2019, 3:38 PM · KDevelop

Dec 5 2019

apol closed D21936: Pass the android toolchain file path to CMake as a local file path not as a URI.
Dec 5 2019, 12:30 AM · KDevelop

Dec 1 2019

dfaure closed D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Dec 1 2019, 2:54 AM · KDevelop
apol accepted D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.

Thanks!

Dec 1 2019, 1:18 AM · KDevelop

Nov 30 2019

dfaure requested review of D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Nov 30 2019, 9:42 PM · KDevelop

Nov 28 2019

hmitonneau requested review of D25587: [KDevelop/PHP] fix rename of a variable.
Nov 28 2019, 10:29 AM · KDevelop

Nov 25 2019

yurchor closed D25513: Fix minor typos, use https:// links.
Nov 25 2019, 8:57 AM · KDevelop
pprkut accepted D25513: Fix minor typos, use https:// links.

Looks good to me :)

Nov 25 2019, 8:54 AM · KDevelop
yurchor requested review of D25513: Fix minor typos, use https:// links.
Nov 25 2019, 7:33 AM · KDevelop

Nov 23 2019

aaronpuchert requested review of D25494: Make tar archives reproducible by setting Pax headers.
Nov 23 2019, 6:04 PM · KDevelop
yurchor closed D25342: Mention all fetch project sources in the documentation.
Nov 23 2019, 1:33 PM · Documentation, KDevelop
adrianchavesfernandez added a comment to D25342: Mention all fetch project sources in the documentation.

Can someone else land the patch? I don’t think I have the required permissions.

Nov 23 2019, 11:51 AM · Documentation, KDevelop

Nov 17 2019

apol accepted D25342: Mention all fetch project sources in the documentation.
Nov 17 2019, 6:59 PM · Documentation, KDevelop

Nov 16 2019

yurchor accepted D25342: Mention all fetch project sources in the documentation.

Good enough as for me.

Nov 16 2019, 6:24 PM · Documentation, KDevelop
adrianchavesfernandez requested review of D25342: Mention all fetch project sources in the documentation.
Nov 16 2019, 6:20 PM · Documentation, KDevelop

Nov 8 2019

kossebau moved T11415: Entry for QCH documentation files (for KDevelop & more in the future) from To Do to Work in Progress on the KDE Store board.
Nov 8 2019, 1:11 AM · KDevelop, KDE Store
kossebau added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

@starbuck Thanks. Tried a first link with https://store.kde.org/p/1334948 and adapted the KNSRC file of KDevelop, worked as wanted.
(well, once I added a workaround for some strange KNewStuff behaviour on archive extraction, cmp. 39a8a51d33 ;) )

Nov 8 2019, 1:11 AM · KDevelop, KDE Store

Nov 7 2019

starbuck updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).

I added the new category now here:
https://store.kde.org/browse/cat/606/order/latest/

Nov 7 2019, 7:34 PM · KDevelop, KDE Store
kossebau updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).
Nov 7 2019, 2:20 PM · KDevelop, KDE Store
kossebau added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

Thanks for the reply, sounds good.

Nov 7 2019, 2:19 PM · KDevelop, KDE Store

Nov 6 2019

starbuck added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

We certainly can add a new category = API Documentation QCH Files.
Linking files are possible via "Add url", simply pointing to a file as endpoint.
I'm not sure what needs to be done client-side, so Dan can likely help there.
I just need to know what the category name should be and when to add it.

Nov 6 2019, 9:46 PM · KDevelop, KDE Store
kossebau updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).

@starbuck @leinir H. Please see "Question to store.kde.org managers" (but better to read first whole text to get the context). I would like to sort this out before end of year.

Nov 6 2019, 7:01 PM · KDevelop, KDE Store

Oct 29 2019

hmitonneau updated the diff for D24921: [KDevelop/PHP] Add support for "array of type".

Move variadics from IndexedContainer to ArrayType

Oct 29 2019, 11:29 AM · KDevelop

Oct 27 2019

pprkut added a comment to D22062: Addition of php script output patterns. Initial development..

I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?

Oct 27 2019, 7:54 AM · KDevelop
pprkut added a reviewer for D24921: [KDevelop/PHP] Add support for "array of type": pprkut.
Oct 27 2019, 7:39 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Conceptually, this looks fine. However, like this we end up with two different descriptions of "Array of" types in the navigation popups.
While this shows integer arrays as int[], for variadics it will show array of (int). I think at the very least both should be displayed the same.

Oct 27 2019, 7:39 AM · KDevelop
pprkut updated the task description for T6803: PHP 7.1 features.
Oct 27 2019, 7:10 AM · KDevelop

Oct 24 2019

hmitonneau requested review of D24921: [KDevelop/PHP] Add support for "array of type".
Oct 24 2019, 1:47 PM · KDevelop
alexeymin closed D24914: Fix build with Qt 5.14.
Oct 24 2019, 1:18 PM · KDevelop
apol accepted D24914: Fix build with Qt 5.14.
Oct 24 2019, 12:26 PM · KDevelop
alexeymin requested review of D24914: Fix build with Qt 5.14.
Oct 24 2019, 11:38 AM · KDevelop

Oct 21 2019

rjvbb updated the diff for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Rebased for the 5.4 branch. Still working perfectly for me, without noticeably slower reaction times on local filesystems.

Oct 21 2019, 4:11 PM · KDevelop
rjvbb updated the diff for D4981: patchreview : allow choice of the number of context lines.

Rebased for the 5.4 branch.

Oct 21 2019, 4:04 PM · KDevelop

Oct 10 2019

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
I'm not suggesting to not create a preamble at all, but to create it only when we **know** it is needed.
Oct 10 2019, 8:26 AM · KDevelop

Oct 9 2019

aaronpuchert added a comment to D22217: Pass extra build flags to compiler for parsing..

I've just stumbled into a case where I would need -stdlib=libc++, which this change would solve.

Oct 9 2019, 9:17 PM · KDevelop
aaronpuchert added a comment to D18551: clang: Create preamble only on second parse.

I still think this is the right change, but if there is no consensus I will implement @mwolff's suggestion. That would certainly be an improvement, but it doesn't really solve my problem. I'm currently working on Clang and have around 6 files open, which is really not a lot. I haven't changed any of them. The result:

Oct 9 2019, 9:12 PM · KDevelop

Oct 7 2019

mwolff added a comment to D22158: Navigation context uses theme color..

e.g. look at https://doc.qt.io/archives/qt-4.8/qcolor.html#predefined-colors

Oct 7 2019, 8:14 PM · KDevelop
mwolff added a comment to D22158: Navigation context uses theme color..

hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.

Oct 7 2019, 8:14 PM · KDevelop

Oct 6 2019

tristanp added a comment to D22158: Navigation context uses theme color..

Would it be possible and interesting to reuse code highlighting for the code quote ?

Oct 6 2019, 9:34 AM · KDevelop

Oct 5 2019

tristanp added a comment to D24428: Fix document switcher plugin with multiple splitted view..

With the patch :

Oct 5 2019, 5:36 PM · KDevelop
tristanp added a reviewer for D24428: Fix document switcher plugin with multiple splitted view.: KDevelop.
Oct 5 2019, 5:22 PM · KDevelop
tristanp requested review of D24428: Fix document switcher plugin with multiple splitted view..
Oct 5 2019, 5:22 PM · KDevelop

Oct 1 2019

tristanp added inline comments to D20548: Fix document switcher plugin with multiple splitted view..
Oct 1 2019, 6:12 PM · KDevelop

Sep 26 2019

arrowd retitled D18758: Make Project::open() method use async KIO methods. from Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted. to Make Project::open() method use async KIO methods..
Sep 26 2019, 10:27 AM · KDevelop

Sep 24 2019

avinashg placed T9593: Publish KDevelop in the Microsoft Store up for grabs.
Sep 24 2019, 1:06 PM · KDevelop, Windows

Sep 22 2019

avinashg claimed T9593: Publish KDevelop in the Microsoft Store.
Sep 22 2019, 12:17 PM · KDevelop, Windows

Sep 20 2019

mwolff added a comment to D22660: Fixed crash when filtering class list.

thanks, applied to 5.4

Sep 20 2019, 4:11 AM · KDevelop
mwolff closed D22660: Fixed crash when filtering class list.
Sep 20 2019, 4:11 AM · KDevelop
mwolff closed D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Sep 20 2019, 4:07 AM · KDevelop