Feed Advanced Search

Yesterday

hmitonneau added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Is there something wrong with the second diff ?

Fri, Dec 13, 4:20 PM · KDevelop
hmitonneau requested review of D25956: [KDevelop/PHP] Importing functions and const from other namespaces.
Fri, Dec 13, 3:38 PM · KDevelop

Thu, Dec 5

apol closed D21936: Pass the android toolchain file path to CMake as a local file path not as a URI.
Thu, Dec 5, 12:30 AM · KDevelop

Sun, Dec 1

dfaure closed D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Sun, Dec 1, 2:54 AM · KDevelop
apol accepted D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.

Thanks!

Sun, Dec 1, 1:18 AM · KDevelop

Sat, Nov 30

dfaure requested review of D25639: Fix compilation error with gcc 7.4.1, ambiguous overload.
Sat, Nov 30, 9:42 PM · KDevelop

Thu, Nov 28

hmitonneau requested review of D25587: [KDevelop/PHP] fix rename of a variable.
Thu, Nov 28, 10:29 AM · KDevelop

Mon, Nov 25

yurchor closed D25513: Fix minor typos, use https:// links.
Mon, Nov 25, 8:57 AM · KDevelop
pprkut accepted D25513: Fix minor typos, use https:// links.

Looks good to me :)

Mon, Nov 25, 8:54 AM · KDevelop
yurchor requested review of D25513: Fix minor typos, use https:// links.
Mon, Nov 25, 7:33 AM · KDevelop

Sat, Nov 23

aaronpuchert requested review of D25494: Make tar archives reproducible by setting Pax headers.
Sat, Nov 23, 6:04 PM · KDevelop
yurchor closed D25342: Mention all fetch project sources in the documentation.
Sat, Nov 23, 1:33 PM · Documentation, KDevelop
adrianchavesfernandez added a comment to D25342: Mention all fetch project sources in the documentation.

Can someone else land the patch? I don’t think I have the required permissions.

Sat, Nov 23, 11:51 AM · Documentation, KDevelop

Sun, Nov 17

apol accepted D25342: Mention all fetch project sources in the documentation.
Sun, Nov 17, 6:59 PM · Documentation, KDevelop

Sat, Nov 16

yurchor accepted D25342: Mention all fetch project sources in the documentation.

Good enough as for me.

Sat, Nov 16, 6:24 PM · Documentation, KDevelop
adrianchavesfernandez requested review of D25342: Mention all fetch project sources in the documentation.
Sat, Nov 16, 6:20 PM · Documentation, KDevelop

Nov 8 2019

kossebau moved T11415: Entry for QCH documentation files (for KDevelop & more in the future) from To Do to Work in Progress on the KDE Store board.
Nov 8 2019, 1:11 AM · KDevelop, KDE Store
kossebau added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

@starbuck Thanks. Tried a first link with https://store.kde.org/p/1334948 and adapted the KNSRC file of KDevelop, worked as wanted.
(well, once I added a workaround for some strange KNewStuff behaviour on archive extraction, cmp. 39a8a51d33 ;) )

Nov 8 2019, 1:11 AM · KDevelop, KDE Store

Nov 7 2019

starbuck updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).

I added the new category now here:
https://store.kde.org/browse/cat/606/order/latest/

Nov 7 2019, 7:34 PM · KDevelop, KDE Store
kossebau updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).
Nov 7 2019, 2:20 PM · KDevelop, KDE Store
kossebau added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

Thanks for the reply, sounds good.

Nov 7 2019, 2:19 PM · KDevelop, KDE Store

Nov 6 2019

starbuck added a comment to T11415: Entry for QCH documentation files (for KDevelop & more in the future).

We certainly can add a new category = API Documentation QCH Files.
Linking files are possible via "Add url", simply pointing to a file as endpoint.
I'm not sure what needs to be done client-side, so Dan can likely help there.
I just need to know what the category name should be and when to add it.

Nov 6 2019, 9:46 PM · KDevelop, KDE Store
kossebau updated subscribers of T11415: Entry for QCH documentation files (for KDevelop & more in the future).

@starbuck @leinir H. Please see "Question to store.kde.org managers" (but better to read first whole text to get the context). I would like to sort this out before end of year.

Nov 6 2019, 7:01 PM · KDevelop, KDE Store

Oct 29 2019

hmitonneau updated the diff for D24921: [KDevelop/PHP] Add support for "array of type".

Move variadics from IndexedContainer to ArrayType

Oct 29 2019, 11:29 AM · KDevelop

Oct 27 2019

pprkut added a comment to D22062: Addition of php script output patterns. Initial development..

I agree that conceptually this should be moved to (or supplemented by) the actual language plugins, but also agree that this might be out of scope for this change.
As far as the PHP changes are concerned this is fine with me. However, I'd prefer those patterns to be unit tested and not just documented in comments.
Could you have a look at adding those tests?

Oct 27 2019, 7:54 AM · KDevelop
pprkut added a reviewer for D24921: [KDevelop/PHP] Add support for "array of type": pprkut.
Oct 27 2019, 7:39 AM · KDevelop
pprkut added a comment to D24921: [KDevelop/PHP] Add support for "array of type".

Conceptually, this looks fine. However, like this we end up with two different descriptions of "Array of" types in the navigation popups.
While this shows integer arrays as int[], for variadics it will show array of (int). I think at the very least both should be displayed the same.

Oct 27 2019, 7:39 AM · KDevelop
pprkut updated the task description for T6803: PHP 7.1 features.
Oct 27 2019, 7:10 AM · KDevelop

Oct 24 2019

hmitonneau requested review of D24921: [KDevelop/PHP] Add support for "array of type".
Oct 24 2019, 1:47 PM · KDevelop
alexeymin closed D24914: Fix build with Qt 5.14.
Oct 24 2019, 1:18 PM · KDevelop
apol accepted D24914: Fix build with Qt 5.14.
Oct 24 2019, 12:26 PM · KDevelop
alexeymin requested review of D24914: Fix build with Qt 5.14.
Oct 24 2019, 11:38 AM · KDevelop

Oct 21 2019

rjvbb updated the diff for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Rebased for the 5.4 branch. Still working perfectly for me, without noticeably slower reaction times on local filesystems.

Oct 21 2019, 4:11 PM · KDevelop
rjvbb updated the diff for D4981: patchreview : allow choice of the number of context lines.

Rebased for the 5.4 branch.

Oct 21 2019, 4:04 PM · KDevelop

Oct 10 2019

rjvbb added a comment to D18551: clang: Create preamble only on second parse.
I'm not suggesting to not create a preamble at all, but to create it only when we **know** it is needed.
Oct 10 2019, 8:26 AM · KDevelop

Oct 9 2019

aaronpuchert added a comment to D22217: Pass extra build flags to compiler for parsing..

I've just stumbled into a case where I would need -stdlib=libc++, which this change would solve.

Oct 9 2019, 9:17 PM · KDevelop
aaronpuchert added a comment to D18551: clang: Create preamble only on second parse.

I still think this is the right change, but if there is no consensus I will implement @mwolff's suggestion. That would certainly be an improvement, but it doesn't really solve my problem. I'm currently working on Clang and have around 6 files open, which is really not a lot. I haven't changed any of them. The result:

Oct 9 2019, 9:12 PM · KDevelop

Oct 7 2019

mwolff added a comment to D22158: Navigation context uses theme color..

e.g. look at https://doc.qt.io/archives/qt-4.8/qcolor.html#predefined-colors

Oct 7 2019, 8:14 PM · KDevelop
mwolff added a comment to D22158: Navigation context uses theme color..

hey! can you also show a screenshot of PHP or Qt documentation showing? these can contain arbitrary HTML and sometimes even contain colored text that expects to be shown on bright backgrounds which would break with this patch. At least that was the case years ago when I worked on this the last time.

Oct 7 2019, 8:14 PM · KDevelop

Oct 6 2019

tristanp added a comment to D22158: Navigation context uses theme color..

Would it be possible and interesting to reuse code highlighting for the code quote ?

Oct 6 2019, 9:34 AM · KDevelop

Oct 5 2019

tristanp added a comment to D24428: Fix document switcher plugin with multiple splitted view..

With the patch :

Oct 5 2019, 5:36 PM · KDevelop
tristanp added a reviewer for D24428: Fix document switcher plugin with multiple splitted view.: KDevelop.
Oct 5 2019, 5:22 PM · KDevelop
tristanp requested review of D24428: Fix document switcher plugin with multiple splitted view..
Oct 5 2019, 5:22 PM · KDevelop

Oct 1 2019

tristanp added inline comments to D20548: Fix document switcher plugin with multiple splitted view..
Oct 1 2019, 6:12 PM · KDevelop

Sep 26 2019

arrowd retitled D18758: Make Project::open() method use async KIO methods. from Fix ASan error in test_cmakemanager by catching all signals before objects they are delivered to are deleted. to Make Project::open() method use async KIO methods..
Sep 26 2019, 10:27 AM · KDevelop

Sep 24 2019

avinashg placed T9593: Publish KDevelop in the Microsoft Store up for grabs.
Sep 24 2019, 1:06 PM · KDevelop, Windows

Sep 22 2019

avinashg claimed T9593: Publish KDevelop in the Microsoft Store.
Sep 22 2019, 12:17 PM · KDevelop, Windows

Sep 20 2019

mwolff added a comment to D22660: Fixed crash when filtering class list.

thanks, applied to 5.4

Sep 20 2019, 4:11 AM · KDevelop
mwolff closed D22660: Fixed crash when filtering class list.
Sep 20 2019, 4:11 AM · KDevelop
mwolff closed D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Sep 20 2019, 4:07 AM · KDevelop
mwolff accepted D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

done now, thanks a lot!

Sep 20 2019, 4:07 AM · KDevelop
mwolff added a comment to D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

I'll commit this using QFileInfo instead of going through QDir.

Sep 20 2019, 3:51 AM · KDevelop

Sep 17 2019

mdlubakowski abandoned D22854: Added support for configurable font styles for syntax highlighting.

Scrapping this for now, since I have a few improvements on this, but it needs to be reworked. Ill make a PR with updated version on GitLab instance.

Sep 17 2019, 7:07 AM · KDevelop

Sep 11 2019

mswan added reviewers for D22182: Remove anchorClicked lock which causes deadlock: kfunk, aaronpuchert.

I would like to get this merged in if possible. The work discussed for flushing out future deadlocks should also be done, but deserves its own ticket.

Sep 11 2019, 6:27 PM · KDevelop

Sep 10 2019

dkardarakos abandoned D23834: Add template for Kirigami application development with cmake.

Thanks @kossebau for the review. I will create a review request at the kirigami repo.

Sep 10 2019, 6:04 PM · Plasma: Mobile, Kirigami, KDevelop
kossebau added inline comments to D23834: Add template for Kirigami application development with cmake.
Sep 10 2019, 2:54 PM · Plasma: Mobile, Kirigami, KDevelop
kossebau added a comment to D23834: Add template for Kirigami application development with cmake.

I would propose though to add this template to the kirigami repo though, so it is also available to people using the kapptemplate tool and using a plain text editor (e.g. Kate).
There is the ECM macro kde_package_app_templates from https://api.kde.org/ecm/kde-module/KDEPackageAppTemplates.html for this purpose.

Sep 10 2019, 2:49 PM · Plasma: Mobile, Kirigami, KDevelop
dkardarakos requested review of D23834: Add template for Kirigami application development with cmake.
Sep 10 2019, 1:39 PM · Plasma: Mobile, Kirigami, KDevelop
cullmann closed T6869: Create ktexteditor-addons repo as Wontfix.

Given the big KDevelop & Kate share plugins stuff never took off, I think we shall keep them just in kate.git, this will allow to do even more "experimental" stuff in the future like having some extra interfaces for Kate specific stuff that doesn't need to keep BC.

Sep 10 2019, 12:57 PM · Kile, Kate, KDevelop, KTextEditor

Aug 27 2019

santilin updated the diff for D22062: Addition of php script output patterns. Initial development..
  • outputfilteringstrategies: Removed unused include KDir
Aug 27 2019, 9:59 AM · KDevelop
santilin updated the diff for D22062: Addition of php script output patterns. Initial development..
  • Created private implementation of ScriptErrorFilterStrategy
  • executescript: fix setting working directory to OutputView
Aug 27 2019, 9:03 AM · KDevelop

Aug 26 2019

mdlubakowski added a comment to D22854: Added support for configurable font styles for syntax highlighting.
In D22854#517776, @apol wrote:

Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.

Aug 26 2019, 8:22 AM · KDevelop

Aug 24 2019

apol added a comment to D22854: Added support for configurable font styles for syntax highlighting.

Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.

Aug 24 2019, 12:39 AM · KDevelop

Aug 23 2019

Petross404 added a comment to D22854: Added support for configurable font styles for syntax highlighting.

This functionality would be great.

Aug 23 2019, 8:46 PM · KDevelop
Kvalme updated the summary of D23383: Skip to GDB version string on init.
Aug 23 2019, 6:09 PM · KDevelop
Kvalme requested review of D23383: Skip to GDB version string on init.
Aug 23 2019, 6:04 PM · KDevelop

Aug 22 2019

apol closed D23321: Indicate appsteam the ps desktop file isn't a separate application.

Landed as https://invent.kde.org/kde/kdevelop/commit/12bf83b0abd064f22c0a137b0ec7123f155c3097

Aug 22 2019, 3:01 PM · KDevelop
kossebau accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516037, @apol wrote:
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

The reason there is weird. When you press "launch" on the software center you expect to get the IDE, not an empty list of sessions.

Aug 22 2019, 2:57 PM · KDevelop

Aug 21 2019

mak added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.

This patch looks like it should work as intended to me :)

Aug 21 2019, 6:37 PM · KDevelop
kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516034, @apol wrote:

BUG: 410687

Aug 21 2019, 3:25 PM · KDevelop
apol added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

Aug 21 2019, 3:25 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

BUG: 410687

Aug 21 2019, 3:23 PM · KDevelop
kossebau updated subscribers of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:12 PM · KDevelop
kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

Aug 21 2019, 3:11 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

Don't mention the ps desktop file as the executable

Aug 21 2019, 3:09 PM · KDevelop
kossebau requested changes to D23321: Indicate appsteam the ps desktop file isn't a separate application.

From what I understood, this is effectless, as _ps is referenced by <launchable>. We need to check with @mak here.

Aug 21 2019, 3:05 PM · KDevelop
ngraham updated the summary of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:02 PM · KDevelop
ngraham accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.

Yep, according to @mak, this should work.

Aug 21 2019, 3:02 PM · KDevelop
apol requested review of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:01 PM · KDevelop

Aug 20 2019

akellermann requested review of D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Aug 20 2019, 7:23 PM · KDevelop

Aug 18 2019

aprcela abandoned D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 18 2019, 10:08 AM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

Great! You can Abandon this revision from the Add Action... menu above the comment field if you'd like (you can always re-open it later if need be).

Aug 18 2019, 1:13 AM · KDevelop

Aug 17 2019

aprcela added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

Aug 17 2019, 8:52 PM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

Aug 17 2019, 7:41 PM · KDevelop
ngraham added a reviewer for D23212: [kdevelop] Remove 'Git Stashes' text above separator: KDevelop.
Aug 17 2019, 7:36 PM · KDevelop
kossebau created T11415: Entry for QCH documentation files (for KDevelop & more in the future).
Aug 17 2019, 5:08 PM · KDevelop, KDE Store
aprcela retitled D23212: [kdevelop] Remove 'Git Stashes' text above separator from Remove 'Git Stashes' text above separator to [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:32 AM · KDevelop
aprcela updated the test plan for D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:29 AM · KDevelop
aprcela requested review of D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:28 AM · KDevelop

Aug 14 2019

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I will look into it next week. The used icon is bogus. I was hoping for some input on that :) But i liked the idea of an icon in general.

Aug 14 2019, 5:29 PM · KDevelop

Aug 12 2019

apol added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

Maybe it would make sense to move the whole dialog into git plugin's code.

Aug 12 2019, 11:24 AM · KDevelop

Aug 11 2019

pavelp added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Hi, thank you, I'm happy to be back!

Aug 11 2019, 9:42 PM · KDevelop
pavelp closed D23038: Fix compilation with Kdevelop 5.4.
Aug 11 2019, 9:34 PM · KDevelop
kossebau added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Aug 11 2019, 2:08 PM · KDevelop

Aug 9 2019

pavelp added a reviewer for D23038: Fix compilation with Kdevelop 5.4: KDevelop.
Aug 9 2019, 6:08 AM · KDevelop
pavelp requested review of D23038: Fix compilation with Kdevelop 5.4.
Aug 9 2019, 6:03 AM · KDevelop

Aug 6 2019

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I created some screenshots. Icon ist in the line edit (near the mouse pointer in the first picture).

Aug 6 2019, 10:09 PM · KDevelop
christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I hope it is ok to add you as reviewer directly as you orchestrated the last commit from me in this area.

Aug 6 2019, 10:01 PM · KDevelop
christiant requested review of D22978: Toggle filtering of remote branches in DVCS Branch Manager.
Aug 6 2019, 9:58 PM · KDevelop

Aug 2 2019

tristanp added inline comments to D22158: Navigation context uses theme color..
Aug 2 2019, 6:57 PM · KDevelop