Feed Advanced Search

Today

arrowd requested review of D18463: Workaround the bug found by ASan, which can be seen on FreeBSD CI..
Wed, Jan 23, 6:33 AM · KDevelop

Yesterday

mmrozowski added a comment to D18346: Fix typo in move cursor left action in QtCreator shortcuts theme.

I haven't pushed anything since KDE svn days but my account should be set up I think. One way to find out. Which branches? master and 5.3?

Tue, Jan 22, 12:20 AM · KDevelop

Mon, Jan 21

mwolff closed D18229: Contextbrowser: Ability to show combined problems and decl tooltip.
Mon, Jan 21, 5:08 PM · KDevelop
mwolff added a comment to D18224: Clang Plugin: Report some problems from included files.

without digging into the patch myself (I'll have to see whether I can find time for this), could we solve more of the open TODOs by reporting problems for *all tail* child diagnostics that point at the current file? And then reference the "parent" from them somehow? I.e. I believe currently, we have something like this (bare with me, it was quite some time since I worked on this):

Mon, Jan 21, 4:54 PM · KDevelop
mwolff closed D18218: Properly display argument names of template functions.
Mon, Jan 21, 4:42 PM · KDevelop
frmdstryr added a member for KDevelop: frmdstryr.
Mon, Jan 21, 1:40 PM
mwolff accepted D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

unrelated - but potential future work: does keyboard navigation work across tooltips? I.e. 'ALT + ARROW'?

Mon, Jan 21, 9:51 AM · KDevelop

Sun, Jan 20

thomassc added a comment to D18224: Clang Plugin: Report some problems from included files.

I moved the code into helper functions and added an initial version of the tests. The tests for having the function and the call in the same file, and for having a chain of template functions in the same file include QEXPECT_FAIL(). In principle it would be easy to generate additional problems for these cases, but then a single actual problem would be represented by multiple problems in the same file. Maybe it would be cleaner to make a single problem have multiple ranges.

Sun, Jan 20, 9:07 PM · KDevelop
pino added inline comments to D18224: Clang Plugin: Report some problems from included files.
Sun, Jan 20, 7:35 PM · KDevelop
thomassc updated the diff for D18224: Clang Plugin: Report some problems from included files.

Make helper functions and add tests, as requested by Milian.

Sun, Jan 20, 7:30 PM · KDevelop
narvaez requested review of D18414: Prevent the Extra Arguments ComboBox to Stretch Too Much.
Sun, Jan 20, 7:22 PM · KDevelop
thomassc added a comment to D18218: Properly display argument names of template functions.

I just noticed this old bug: https://bugs.kde.org/show_bug.cgi?id=368460
Should the template parameters be put into a separate context?

Sun, Jan 20, 6:07 PM · KDevelop
volden abandoned D18326: Fix compilation on Windows.

Already fixed.

Sun, Jan 20, 6:01 PM · KDevelop
thomassc added a comment to D18218: Properly display argument names of template functions.

Yes, the behavior of this patch is as described by Milian.

Sun, Jan 20, 3:30 PM · KDevelop
thomassc added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

This is how it looks on my system:

Sun, Jan 20, 2:45 PM · KDevelop
thomassc updated the diff for D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

Cosmetic improvement to combined problems and decl tooltip

Sun, Jan 20, 2:43 PM · KDevelop

Sat, Jan 19

apol accepted D18346: Fix typo in move cursor left action in QtCreator shortcuts theme.

Can you push the change or do you need us to do it for you?

Sat, Jan 19, 8:03 AM · KDevelop

Fri, Jan 18

miroslawstein added a revision to T10373: Support for indent-after-parens astyle option: Unknown Object (Differential Revision).
Fri, Jan 18, 9:40 PM · KDevelop
miroslawstein created T10373: Support for indent-after-parens astyle option.
Fri, Jan 18, 9:14 PM · KDevelop
wcancino updated the diff for D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.
  • Fix testcase
Fri, Jan 18, 10:11 AM · KDevelop
mmrozowski requested review of D18346: Fix typo in move cursor left action in QtCreator shortcuts theme.
Fri, Jan 18, 12:06 AM · KDevelop

Thu, Jan 17

aaronpuchert added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Actually, issues with clang temp files is why I started to think about this kind of change but ultimately I realised it didn't seem such a bad idea at all to put all KDevelop-related temporary files in a dedicated location. I often clean out a bunch of KDevelop's own temp files that were left behind, e.g. after a crash. I just didn't mention them because they're negligible in size (and I purge before their numbers really start to grow).

Thu, Jan 17, 10:11 PM · KDevelop
volden added a reviewer for D18326: Fix compilation on Windows: kdevelop-devel.
Thu, Jan 17, 5:43 PM · KDevelop
volden requested review of D18326: Fix compilation on Windows.
Thu, Jan 17, 5:37 PM · KDevelop
igorkushnir requested review of D18325: Debugger plugin fixes.
Thu, Jan 17, 5:04 PM · KDevelop
rjvbb set the repository for D15797: [kdev-clazy] : use canonical paths to R32 KDevelop.
Thu, Jan 17, 3:10 PM · KDevelop
rjvbb updated the diff for D15797: [kdev-clazy] : use canonical paths.

Updated as requested.

Thu, Jan 17, 3:09 PM · KDevelop
rjvbb added inline comments to D15797: [kdev-clazy] : use canonical paths.
Thu, Jan 17, 3:09 PM · KDevelop
mwolff added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Good point Pino - setting the env var, even temporarily, would induce a race - so we can't do it there.

Thu, Jan 17, 2:33 PM · KDevelop

Wed, Jan 16

aacid added a comment to D18218: Properly display argument names of template functions.

@mwolff he doesn't want me to commit it meanwhile or do we wait for him to get the account?

Wed, Jan 16, 10:54 PM · KDevelop

Tue, Jan 15

mwolff requested changes to D14469: KDevelop: word wrapping the problem text in the Problem Reporter (WIP).

-2, I don't want to have tables with word wrapping. Hover the entry to get a tooltip that shows the full message instead. That would be a much better feature addition btw - I just checked and we don't seem to show the same problem tooltips when hovering an entry in the problems view as we do in the editor. We totally should!

Tue, Jan 15, 7:49 PM · KDevelop
rjvbb closed D17255: KDevelop: support for installing into a non-standard parallel prefix.
Tue, Jan 15, 7:28 PM · KDevelop
dmensinger closed D18202: Meson build options introspection.
Tue, Jan 15, 2:43 PM · KDevelop
mwolff requested changes to D7930: Kdevelop CMake plugin : use canonical paths to build.dir.

please create a test out of the example you have provided

Tue, Jan 15, 1:58 PM · KDevelop
mwolff added a comment to D18218: Properly display argument names of template functions.

btw - do you have commit rights? if not, then feel free to request them, see https://community.kde.org/Infrastructure/Get_a_Developer_Account

Tue, Jan 15, 1:55 PM · KDevelop
mwolff accepted D18218: Properly display argument names of template functions.

so this patch fixes the tooltip to show up like void foo(char b, char c), but we still don't show the template<int a> information anywhere? I guess it's a good step forward, but we should also show the template args somewhere!

Tue, Jan 15, 1:55 PM · KDevelop
mwolff added a comment to D18229: Contextbrowser: Ability to show combined problems and decl tooltip.

could you show a screenshot of this in action? code-wise I like what I'm seeing, good work! Feature-wise, I also agree that we need to do something about the issue you describe.

Tue, Jan 15, 1:51 PM · KDevelop
mwolff requested changes to D18224: Clang Plugin: Report some problems from included files.

can you please also add tests for this feature? Have a look at test_duchain.cpp and in there e.g. TestDUChain::testInclude for how to create multiple files and have them include each other.

Tue, Jan 15, 1:48 PM · KDevelop
mwolff requested changes to D15797: [kdev-clazy] : use canonical paths.
Tue, Jan 15, 1:40 PM · KDevelop
mwolff accepted D17255: KDevelop: support for installing into a non-standard parallel prefix.
Tue, Jan 15, 1:36 PM · KDevelop

Mon, Jan 14

apol added a comment to D18202: Meson build options introspection.

I'll be happy to sponsor you.

Mon, Jan 14, 2:26 PM · KDevelop
dmensinger added a comment to D18202: Meson build options introspection.

Sure, thanks. But how do I do that? Can I just push the commits?

Mon, Jan 14, 1:54 PM · KDevelop
apol accepted D18202: Meson build options introspection.

Looks good to me. In general I'd say you can feel free to develop the plugin and only run it through review if you want feedback on specific bits.

Mon, Jan 14, 1:32 PM · KDevelop
amhndu closed D18216: Scratchpad: Validate actions when opening context menu.
Mon, Jan 14, 9:34 AM · KDevelop
wcancino added a comment to D18122: Fix Xdebug disconnecting after php finished if multiple connections are allowed.

Well, it is true that this plugins dates from the Kdev4 days, and it is unmaintained. Anyways, with these patch, I correct the plugin to behave as described on

Mon, Jan 14, 9:15 AM · KDevelop
arrowd accepted D18216: Scratchpad: Validate actions when opening context menu.

Works great now, thanks!

Mon, Jan 14, 7:06 AM · KDevelop

Sun, Jan 13

rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Sun, Jan 13, 10:30 PM · KDevelop
rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Sun, Jan 13, 10:30 PM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

placeholder text + dropped manpageplugin hunk.

Sun, Jan 13, 10:30 PM · KDevelop
thomassc updated the summary of D18229: Contextbrowser: Ability to show combined problems and decl tooltip.
Sun, Jan 13, 6:00 PM · KDevelop
thomassc added a reviewer for D18229: Contextbrowser: Ability to show combined problems and decl tooltip: KDevelop.
Sun, Jan 13, 5:58 PM · KDevelop
thomassc requested review of D18229: Contextbrowser: Ability to show combined problems and decl tooltip.
Sun, Jan 13, 5:57 PM · KDevelop
thomassc updated the summary of D18218: Properly display argument names of template functions.
Sun, Jan 13, 4:24 PM · KDevelop
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

QString --> const auto (for real)

Sun, Jan 13, 4:07 PM · KDevelop
thomassc added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

I don't think that I have commit rights. Feel free to commit.

Sun, Jan 13, 4:06 PM · KDevelop
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

QString --> const auto

Sun, Jan 13, 4:05 PM · KDevelop
thomassc added a reviewer for D18224: Clang Plugin: Report some problems from included files: KDevelop.
Sun, Jan 13, 2:11 PM · KDevelop
thomassc requested review of D18224: Clang Plugin: Report some problems from included files.
Sun, Jan 13, 2:08 PM · KDevelop
mwolff requested changes to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Sun, Jan 13, 1:24 PM · KDevelop
mwolff accepted D17915: Clang CodeCompletion: No auto-completion for numbers.

I prefer to use AAA, but otherwise lgtm. do you have commit rights, or do you want me to submit this for you?

Sun, Jan 13, 1:20 PM · KDevelop

Sat, Jan 12

thomassc added a reviewer for D18218: Properly display argument names of template functions: KDevelop.
Sat, Jan 12, 9:49 PM · KDevelop
thomassc requested review of D18218: Properly display argument names of template functions.
Sat, Jan 12, 9:48 PM · KDevelop
amhndu added a reviewer for D18216: Scratchpad: Validate actions when opening context menu: arrowd.
Sat, Jan 12, 8:15 PM · KDevelop
amhndu requested review of D18216: Scratchpad: Validate actions when opening context menu.
Sat, Jan 12, 8:12 PM · KDevelop
amhndu closed D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.
Sat, Jan 12, 5:56 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

But these actions are disabled until I open any scratch in the editor.

Sat, Jan 12, 4:37 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

For example, I have 2 scratches: scr1.cpp and scr2.cpp. I left-click on first one and open it, then right-click on second one and select Run. The 2nd scratch gets executed.

Sat, Jan 12, 4:36 PM · KDevelop
thomassc updated the diff for D17915: Clang CodeCompletion: No auto-completion for numbers.

Update according to Milian's comment

Sat, Jan 12, 4:04 PM · KDevelop
thomassc added a comment to D17915: Clang CodeCompletion: No auto-completion for numbers.

You are right, this should be changed. I was under the wrong impression that the original diff worked since it still showed the completion when typing something like "foo1" from the beginning. But actually, if "foo" is already there before and one starts typing at "1", then it failed.

Sat, Jan 12, 4:04 PM · KDevelop
rjvbb added inline comments to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Sat, Jan 12, 3:04 PM · KDevelop
rjvbb set the repository for D17255: KDevelop: support for installing into a non-standard parallel prefix to R32 KDevelop.
Sat, Jan 12, 3:03 PM · KDevelop
rjvbb updated the diff for D17255: KDevelop: support for installing into a non-standard parallel prefix.

Adds tooltip to the import dialog's "Installation Prefix" entrie widget.

Sat, Jan 12, 3:03 PM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

That's intended. The actions are all associated with the selected scratch in the toolview list. Switching the window to a different scratch also changes this selection, while closing a window keeps the selection.

Sat, Jan 12, 2:17 PM · KDevelop
rjvbb added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.
Note that environment variables are per-process, not per-thread.
Sat, Jan 12, 1:40 PM · KDevelop
amhndu added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

When I just started KDevelop and open "Scratchpad" toolview, any action except "New Scratch" are greyed out. Even "Remove Scratch", as well as "Run Scratch". When I open any scratch, it turns back to normal, even if I again close all Sratchpad windows.

Sat, Jan 12, 1:37 PM · KDevelop
rjvbb added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

Milian Wolff wrote on 20190112::12:35:11 re: "D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions"

Sat, Jan 12, 1:30 PM · KDevelop
dmensinger updated the diff for D18202: Meson build options introspection.
  • Fixed build options order
  • Refactored new build dir to avoid duplicate configures
  • More polish for the New build dir dialog
Sat, Jan 12, 12:44 PM · KDevelop
mwolff added inline comments to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.
Sat, Jan 12, 12:35 PM · KDevelop
mwolff requested changes to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.
Sat, Jan 12, 12:34 PM · KDevelop
mwolff requested changes to D17255: KDevelop: support for installing into a non-standard parallel prefix.
Sat, Jan 12, 12:26 PM · KDevelop
pino added a comment to D17289: KDevelop/Shell: set dedicated TMPDIR.

Though probably it's going to be enough for now to set TMPDIR temporarily in the background thread where we launch the parse job via libclang?

Sat, Jan 12, 12:22 PM · KDevelop
mwolff requested changes to D17289: KDevelop/Shell: set dedicated TMPDIR.

-2 from my side - we change the behavior of all (sub)process launched by KDevelop and that's not something I want to do. you've seen it affect a sub-kdevelop process, but what if a user launches his own app through kdevelop? we shouldn't change the temp dir for these apps.

Sat, Jan 12, 12:20 PM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

But that's not related to your change, so please push it. Not sure where to, 5.3, I guess.

Sat, Jan 12, 8:54 AM · KDevelop
arrowd added a comment to D17569: Allow configuring shortcut for Run Scratch action and add to Run menu.

I found the following minor issue:

Sat, Jan 12, 8:50 AM · KDevelop

Fri, Jan 11

dmensinger requested review of D18202: Meson build options introspection.
Fri, Jan 11, 11:10 PM · KDevelop
arrowd added a comment to D14391: Fix random order of plugin's config pages.

The problem with current revision is that pages added in uicontroller.cpp:530 aren't sorted.

Fri, Jan 11, 1:23 PM · KDevelop
kossebau closed D18175: appimage: skip unneeded cp of cmake, removed later again.
Fri, Jan 11, 8:52 AM · KDevelop
kfunk closed D17909: Clang plugin: Handle CUDA files better.
Fri, Jan 11, 8:49 AM · KDevelop
kfunk accepted D18175: appimage: skip unneeded cp of cmake, removed later again.
Fri, Jan 11, 8:47 AM · KDevelop
kossebau requested review of D18175: appimage: skip unneeded cp of cmake, removed later again.
Fri, Jan 11, 7:46 AM · KDevelop

Thu, Jan 10

rjvbb closed D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Thu, Jan 10, 9:52 PM · KDevelop
mwolff accepted D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

thakns, lgtm now! please commit

Thu, Jan 10, 8:33 PM · KDevelop
rjvbb set the repository for D17858: clang: Also detect Clang builtin dirs at runtime on Unix to R32 KDevelop.
Thu, Jan 10, 4:23 PM · KDevelop
rjvbb updated the diff for D17858: clang: Also detect Clang builtin dirs at runtime on Unix.

+++V

Thu, Jan 10, 4:23 PM · KDevelop
mwolff added inline comments to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Thu, Jan 10, 3:23 PM · KDevelop
mwolff closed D18097: Show size and alignment information in tooltips for typedef or alias.
Thu, Jan 10, 3:22 PM · KDevelop
rjvbb added inline comments to D17858: clang: Also detect Clang builtin dirs at runtime on Unix.
Thu, Jan 10, 3:04 PM · KDevelop
arrowd updated the diff for D14391: Fix random order of plugin's config pages.

Fix docs, rename append* methods to add*.

Thu, Jan 10, 3:02 PM · KDevelop
mwolff added inline comments to D14391: Fix random order of plugin's config pages.
Thu, Jan 10, 2:45 PM · KDevelop
mwolff requested changes to D17915: Clang CodeCompletion: No auto-completion for numbers.
Thu, Jan 10, 2:39 PM · KDevelop