Feed Advanced Search

Yesterday

mwolff added a comment to D22660: Fixed crash when filtering class list.

thanks, applied to 5.4

Fri, Sep 20, 4:11 AM · KDevelop
mwolff closed D22660: Fixed crash when filtering class list.
Fri, Sep 20, 4:11 AM · KDevelop
mwolff closed D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Fri, Sep 20, 4:07 AM · KDevelop
mwolff accepted D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

done now, thanks a lot!

Fri, Sep 20, 4:07 AM · KDevelop
mwolff added a comment to D23303: gcclikecompiler: properly resolve include paths containing symbolic links .

I'll commit this using QFileInfo instead of going through QDir.

Fri, Sep 20, 3:51 AM · KDevelop

Tue, Sep 17

mdlubakowski abandoned D22854: Added support for configurable font styles for syntax highlighting.

Scrapping this for now, since I have a few improvements on this, but it needs to be reworked. Ill make a PR with updated version on GitLab instance.

Tue, Sep 17, 7:07 AM · KDevelop

Wed, Sep 11

mswan added reviewers for D22182: Remove anchorClicked lock which causes deadlock: kfunk, aaronpuchert.

I would like to get this merged in if possible. The work discussed for flushing out future deadlocks should also be done, but deserves its own ticket.

Wed, Sep 11, 6:27 PM · KDevelop

Tue, Sep 10

dkardarakos abandoned D23834: Add template for Kirigami application development with cmake.

Thanks @kossebau for the review. I will create a review request at the kirigami repo.

Tue, Sep 10, 6:04 PM · Plasma: Mobile, KDevelop, Kirigami
kossebau added inline comments to D23834: Add template for Kirigami application development with cmake.
Tue, Sep 10, 2:54 PM · Plasma: Mobile, KDevelop, Kirigami
kossebau added a comment to D23834: Add template for Kirigami application development with cmake.

I would propose though to add this template to the kirigami repo though, so it is also available to people using the kapptemplate tool and using a plain text editor (e.g. Kate).
There is the ECM macro kde_package_app_templates from https://api.kde.org/ecm/kde-module/KDEPackageAppTemplates.html for this purpose.

Tue, Sep 10, 2:49 PM · Plasma: Mobile, KDevelop, Kirigami
dkardarakos requested review of D23834: Add template for Kirigami application development with cmake.
Tue, Sep 10, 1:39 PM · Plasma: Mobile, KDevelop, Kirigami
cullmann closed T6869: Create ktexteditor-addons repo as Wontfix.

Given the big KDevelop & Kate share plugins stuff never took off, I think we shall keep them just in kate.git, this will allow to do even more "experimental" stuff in the future like having some extra interfaces for Kate specific stuff that doesn't need to keep BC.

Tue, Sep 10, 12:57 PM · Kile, Kate, KDevelop, KTextEditor

Tue, Aug 27

santilin updated the diff for D22062: Addition of php script output patterns. Initial development..
  • outputfilteringstrategies: Removed unused include KDir
Tue, Aug 27, 9:59 AM · KDevelop
santilin updated the diff for D22062: Addition of php script output patterns. Initial development..
  • Created private implementation of ScriptErrorFilterStrategy
  • executescript: fix setting working directory to OutputView
Tue, Aug 27, 9:03 AM · KDevelop

Mon, Aug 26

mdlubakowski added a comment to D22854: Added support for configurable font styles for syntax highlighting.
In D22854#517776, @apol wrote:

Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.

Mon, Aug 26, 8:22 AM · KDevelop

Sat, Aug 24

apol added a comment to D22854: Added support for configurable font styles for syntax highlighting.

Have you reflected on what users need changing or we're just adding this because it's possible?
I'm not opposing having this, but if something can be improved, I'd improve it for everyone first.

Sat, Aug 24, 12:39 AM · KDevelop

Fri, Aug 23

Petross404 added a comment to D22854: Added support for configurable font styles for syntax highlighting.

This functionality would be great.

Fri, Aug 23, 8:46 PM · KDevelop
Kvalme updated the summary of D23383: Skip to GDB version string on init.
Fri, Aug 23, 6:09 PM · KDevelop
Kvalme requested review of D23383: Skip to GDB version string on init.
Fri, Aug 23, 6:04 PM · KDevelop

Aug 22 2019

apol closed D23321: Indicate appsteam the ps desktop file isn't a separate application.

Landed as https://invent.kde.org/kde/kdevelop/commit/12bf83b0abd064f22c0a137b0ec7123f155c3097

Aug 22 2019, 3:01 PM · KDevelop
kossebau accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516037, @apol wrote:
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

The reason there is weird. When you press "launch" on the software center you expect to get the IDE, not an empty list of sessions.

Aug 22 2019, 2:57 PM · KDevelop

Aug 21 2019

mak added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.

This patch looks like it should work as intended to me :)

Aug 21 2019, 6:37 PM · KDevelop
kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516034, @apol wrote:

BUG: 410687

Aug 21 2019, 3:25 PM · KDevelop
apol added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

It was mentioned on purpose though, cmp. commit message of ab22ca659cf337fc1de01d69b0ced949156f01e5 (result of discussion on KDevelop with @flherne )

Aug 21 2019, 3:25 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

BUG: 410687

Aug 21 2019, 3:23 PM · KDevelop
kossebau updated subscribers of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:12 PM · KDevelop
kossebau added a comment to D23321: Indicate appsteam the ps desktop file isn't a separate application.
In D23321#516020, @apol wrote:

Don't mention the ps desktop file as the executable

Aug 21 2019, 3:11 PM · KDevelop
apol updated the diff for D23321: Indicate appsteam the ps desktop file isn't a separate application.

Don't mention the ps desktop file as the executable

Aug 21 2019, 3:09 PM · KDevelop
kossebau requested changes to D23321: Indicate appsteam the ps desktop file isn't a separate application.

From what I understood, this is effectless, as _ps is referenced by <launchable>. We need to check with @mak here.

Aug 21 2019, 3:05 PM · KDevelop
ngraham updated the summary of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:02 PM · KDevelop
ngraham accepted D23321: Indicate appsteam the ps desktop file isn't a separate application.

Yep, according to @mak, this should work.

Aug 21 2019, 3:02 PM · KDevelop
apol requested review of D23321: Indicate appsteam the ps desktop file isn't a separate application.
Aug 21 2019, 3:01 PM · KDevelop

Aug 20 2019

akellermann requested review of D23303: gcclikecompiler: properly resolve include paths containing symbolic links .
Aug 20 2019, 7:23 PM · KDevelop

Aug 18 2019

aprcela abandoned D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 18 2019, 10:08 AM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

Great! You can Abandon this revision from the Add Action... menu above the comment field if you'd like (you can always re-open it later if need be).

Aug 18 2019, 1:13 AM · KDevelop

Aug 17 2019

aprcela added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

What you're objecting do is actually just the way menu section headers look in the Breeze widget style. I agree that it causes confusion and visual problems, but it should be fixed there, not here in KDevelop.

Here's the applicable Breeze code that draws these headers https://cgit.kde.org/breeze.git/tree/kstyle/breezestyle.cpp#n4741

Would you like to have a go at improving it there?

Aug 17 2019, 8:52 PM · KDevelop
ngraham added a comment to D23212: [kdevelop] Remove 'Git Stashes' text above separator.

result: Git Stashes is visually grouped with Branches... and is not clickable

Aug 17 2019, 7:41 PM · KDevelop
ngraham added a reviewer for D23212: [kdevelop] Remove 'Git Stashes' text above separator: KDevelop.
Aug 17 2019, 7:36 PM · KDevelop
kossebau created T11415: Entry for QCH documentation files (for KDevelop & more in the future).
Aug 17 2019, 5:08 PM · KDevelop, KDE Store
aprcela retitled D23212: [kdevelop] Remove 'Git Stashes' text above separator from Remove 'Git Stashes' text above separator to [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:32 AM · KDevelop
aprcela updated the test plan for D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:29 AM · KDevelop
aprcela requested review of D23212: [kdevelop] Remove 'Git Stashes' text above separator.
Aug 17 2019, 10:28 AM · KDevelop

Aug 14 2019

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I will look into it next week. The used icon is bogus. I was hoping for some input on that :) But i liked the idea of an icon in general.

Aug 14 2019, 5:29 PM · KDevelop

Aug 12 2019

apol added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

Maybe it would make sense to move the whole dialog into git plugin's code.

Aug 12 2019, 11:24 AM · KDevelop

Aug 11 2019

pavelp added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Hi, thank you, I'm happy to be back!

Aug 11 2019, 9:42 PM · KDevelop
pavelp closed D23038: Fix compilation with Kdevelop 5.4.
Aug 11 2019, 9:34 PM · KDevelop
kossebau added a comment to D23038: Fix compilation with Kdevelop 5.4.

@pavelp Hi from a more recent contributor to KDevelop, good to see you back again once more and care for your former work :)

Aug 11 2019, 2:08 PM · KDevelop

Aug 9 2019

pavelp added a reviewer for D23038: Fix compilation with Kdevelop 5.4: KDevelop.
Aug 9 2019, 6:08 AM · KDevelop
pavelp requested review of D23038: Fix compilation with Kdevelop 5.4.
Aug 9 2019, 6:03 AM · KDevelop

Aug 6 2019

christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I created some screenshots. Icon ist in the line edit (near the mouse pointer in the first picture).

Aug 6 2019, 10:09 PM · KDevelop
christiant added a comment to D22978: Toggle filtering of remote branches in DVCS Branch Manager.

I hope it is ok to add you as reviewer directly as you orchestrated the last commit from me in this area.

Aug 6 2019, 10:01 PM · KDevelop
christiant requested review of D22978: Toggle filtering of remote branches in DVCS Branch Manager.
Aug 6 2019, 9:58 PM · KDevelop

Aug 2 2019

tristanp added inline comments to D22158: Navigation context uses theme color..
Aug 2 2019, 6:57 PM · KDevelop
tristanp added inline comments to D20548: Fix document switcher plugin with multiple splitted view..
Aug 2 2019, 6:54 PM · KDevelop

Jul 31 2019

kossebau added a reviewer for D22660: Fixed crash when filtering class list: KDevelop.
Jul 31 2019, 12:40 PM · KDevelop
mdlubakowski requested review of D22854: Added support for configurable font styles for syntax highlighting.
Jul 31 2019, 11:46 AM · KDevelop

Jul 26 2019

mswan added a comment to D22182: Remove anchorClicked lock which causes deadlock.

I have been mega busy for the last while and intend to contribute more to this project when my situation stabilizes in like two weeks. Whenever you have time, I would definitely be interested to hear what sort of challenges you have come across through experimentation. An issue which I have suspected from the onset is actually determining all that needs to be protected by DUChain's lock and those which don't since KDevelop source makes use of these locks so liberally. I'm wondering if in your experimentation there are open questions about the DUChain locking scope.

Jul 26 2019, 7:44 PM · KDevelop

Jul 25 2019

kossebau added a comment to D22455: Fix code completion for nameless structs/unions with the same member.

Work-around pushed as 8a18a08cf17c85000c7082d5192855430a519bab , seems to pass build also with neon ci and the gcc 7.4.0 there.

Jul 25 2019, 12:45 PM · KDevelop

Jul 24 2019

kossebau added a comment to D22455: Fix code completion for nameless structs/unions with the same member.

Seems the introduced QStringLiteral as default argument here in the template method executeCompletionTest() makes ubuntu bionic's GNU 7.4.0 C++ compiler screw up. At least there is some timely coincidence that the KDevelop builds on neon CI started to fail after this commit, with this error:

05:00:37 [100%] Building CXX object plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o
05:00:37 plugins/clang/tests/CMakeFiles/test_codecompletion.dir/build.make:62: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o' failed
05:00:37 make[4]: Leaving directory '/workspace/build/obj-x86_64-linux-gnu'
05:00:37 /tmp/ccrWtnBp.s: Assembler messages:
05:00:37 /tmp/ccrWtnBp.s:65174: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined
05:00:37 /tmp/ccrWtnBp.s:68144: Error: symbol `_ZZNK12_GLOBAL__N_1UlvE_clEvE15qstring_literal' is already defined
05:00:37 make[4]: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/test_codecompletion.cpp.o] Error 1
05:00:37 CMakeFiles/Makefile2:18121: recipe for target 'plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all' failed
05:00:37 make[3]: *** [plugins/clang/tests/CMakeFiles/test_codecompletion.dir/all] Error 2

from https://build.neon.kde.org/job/bionic_unstable_extras_kdevelop_bin_amd64/220/console

Jul 24 2019, 2:01 PM · KDevelop

Jul 22 2019

mdlubakowski requested review of D22660: Fixed crash when filtering class list.
Jul 22 2019, 6:25 PM · KDevelop

Jul 21 2019

kossebau abandoned D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

I do not think bumping versions "just because " has any value.

I kind of agree here. Unless we have features that we know are only available with a certain version, we might needlessly restrict how people can build this. They might assume we have a good reason for choosing that specific version and that older versions can't possibly work. When I package stuff for openSUSE, I would never try decreasing minimum versions of dependencies, because I assume that these are actually the minimum. On the other hand, I regularly stumble across software that doesn't specify minimum versions for dependencies, but assumes it's "reasonably recent".

Jul 21 2019, 12:13 PM · KDevelop

Jul 20 2019

aaronpuchert added a comment to D22182: Remove anchorClicked lock which causes deadlock.

Also, in spite of what I said earlier, I think the explicit DUChain locking should be done and there eventually should be some work done to determine which objects will only interact with one specific DUChain per instance of that object, i.e. an object that should reference a specific DUChain, e.g. ClangSupport. We could make the first pass at this involve replacing all of those DUChainReadLocker lock; lines with DUChainReaderLocker lock(DUChain::lock());, [...]

Jul 20 2019, 8:22 PM · KDevelop
aaronpuchert added a comment to D22217: Pass extra build flags to compiler for parsing..

Overall I think this is a good idea, although we need to figure out some details. Could you either remove commented out flags or add a comment why we have them (commented out)?

Jul 20 2019, 8:18 PM · KDevelop
aaronpuchert closed D22197: Add working directory to clang parser..
Jul 20 2019, 7:37 PM · KDevelop
aaronpuchert added a comment to D22182: Remove anchorClicked lock which causes deadlock.

I don't know what would be required to support multiple DUChains, but it seems plausible that they can be locked separately. In this case it would help to have the explicit argument, I guess. It could even be inevitable, when there is no single global DUChain anymore.

Jul 20 2019, 7:28 PM · KDevelop
aaronpuchert added a comment to D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

I do not think bumping versions "just because " has any value.

Jul 20 2019, 1:06 PM · KDevelop
apol added a comment to D22566: Add basic support for CXType_ExtVector..

Can we have a test for this?

Jul 20 2019, 9:28 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
There is another condition here: `if (lastShownMenu)`. So if the QMenu object instance got deleted
Jul 20 2019, 9:27 AM · KDevelop

Jul 19 2019

bungeman updated the diff for D22217: Pass extra build flags to compiler for parsing..

Add rtti flags since they affect defines.

Jul 19 2019, 10:19 PM · KDevelop
bungeman updated the diff for D22566: Add basic support for CXType_ExtVector..

Prefer not duplicating code.

Jul 19 2019, 8:25 PM · KDevelop
bungeman updated the summary of D22566: Add basic support for CXType_ExtVector..
Jul 19 2019, 8:04 PM · KDevelop
bungeman updated the diff for D22566: Add basic support for CXType_ExtVector..

Just do the simple thing. Copied the one line of code due to
the awkwardness of preprocessor directives inside template lists.

Jul 19 2019, 7:55 PM · KDevelop
bungeman added a reviewer for D22566: Add basic support for CXType_ExtVector.: KDevelop.
Jul 19 2019, 7:34 PM · KDevelop
bungeman requested review of D22566: Add basic support for CXType_ExtVector..
Jul 19 2019, 7:32 PM · KDevelop
buschinski closed D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 5:21 PM · KDevelop
flherne accepted D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

As the person who raised the Debian Stretch issue last time, I don't think it's worth caring about now that Buster is released.

Jul 19 2019, 4:52 PM · KDevelop
buschinski updated the summary of D22455: Fix code completion for nameless structs/unions with the same member.
Jul 19 2019, 4:16 PM · KDevelop
kfunk accepted D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

Sorry for my conservative thinking again: Debian Buster (10) is still /very/ fresh; it was just released a couple days ago. The former "oldest" supported distro was Debian Stretch (9) with Qt 5.7 and KF 5.28. That'll stick around for some time.

Jul 19 2019, 3:12 PM · KDevelop
kossebau added a comment to D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.

(Using phabricator to make sure people are triggered for this central change)

Jul 19 2019, 12:45 PM · KDevelop
kossebau requested review of D22559: Bump min dep versions of Qt & KF to 5.9 & 5.44.
Jul 19 2019, 12:44 PM · KDevelop

Jul 18 2019

kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

I'll activate the debug trace on change of my lastShownMenu though

I'm doing this (in my patch from D16882 which still applies after reverting D22424):

+        if (menu != lastShownMenu.data()) {
+            if (lastShownMenu) {
+                qCWarning(SHELL) << "Added items to new contextmenu" << menu;
+            }
+            lastShownMenu = menu;
+        }

under the assumption that this will print a warning (enabled in qtlogging.ini) when lastShownMenu will be updated but not the 1st time a ctx menu is opened. Is that assumption wrong, because I'm not seeing any warnings after disabling the CTags menu (and restarting KDevelop for good measure).

Jul 18 2019, 3:52 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

I'll activate the debug trace on change of my lastShownMenu though

Jul 18 2019, 3:26 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

In any case there isn't much else you can do; stepping through the code with a debugger is near impossible (the menu about-to-be-opened will already have grabbed mouse and keyboard focus so you'd need to display remotely).

Jul 18 2019, 1:36 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

How do you think I debugged the situation? I did the same thing in Kate too.

Jul 18 2019, 1:23 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
Please add a line

  qDebug() << "Showing context menu" << menu;

to KDevelop::TextDocument::populateContextMenu.
Jul 18 2019, 1:12 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Since we're dealing with "please read/see again": idem for my comment :P which only states that a single QMenu instance is being (re)used. I've never seen it change

Jul 18 2019, 12:38 PM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
>>   > FWIW I got to look at the KTE implementation of the context menu mechanism that is used here. It indeed uses and reuses a single QMenu instance (there's even a comment in the code about that).
>>   
>>   Please give links into the code, as I am lost what you exactly refer to here.
> 
> see the source of `KTextEditor::ViewPrivate::contextMenu()`. The ctx menu is in fact managed by KXMLGUI.

The context menu is queried every time from KXMLGUI that method is called.  So  if KXMLGUI internally decides to recreate the context menu, you get another object the next time. Please see again the description of this very bug.
Jul 18 2019, 12:11 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop.

Erm, aren't you forgetting about my patch which could have been applied to the (EOL!) 5.3 branch? That does the job just as well and would have left time to find a fix for #409858 in time for the next release.

Jul 18 2019, 11:18 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.
The other option would have been to release 5.3.3 without a fix for ctags plugin users, rendering it unusable for people relying on packaged kdevelop.
Jul 18 2019, 11:09 AM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424: TextDocument: remove actions from contextmenu on hide already"

This revision was not accepted when it landed; it landed in state "Needs Review".

Hmm, since when is this acceptable?

Jul 18 2019, 10:43 AM · KDevelop
rjvbb added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Friedrich W. H. Kossebau wrote on 20190717::00:12:44 re: "D22424: TextDocument: remove actions from contextmenu on hide already"

Jul 18 2019, 9:01 AM · KDevelop

Jul 17 2019

kossebau closed D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 17 2019, 12:12 AM · KDevelop
kossebau updated the summary of D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 17 2019, 12:00 AM · KDevelop

Jul 16 2019

kossebau added a comment to D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.

I could try your solution, of course, but what annoys me is that it comes months after I worked on mine.

Jul 16 2019, 11:19 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

However, the patch has a side-effect: I'm getting messages like this each time I switch or open documents:

kdevplatform.shell: Broken text-document:  QUrl("file:///opt/local/var/tmp/kdevelop-tmp-505-%7Bf793a513-f14e-47b9-8448-06ca72900c04%7D/kdevelop_Q27955.patch")

This example is for a file that indeed doesn't exist, but that I also do not have open (so WTH?!) but I also get it for files that open perfectly.

I fail to see an immediate reason for this, so I'm back to running my own patch.

Interesting. Not seen here, but giving this some stress testing now. The kdevelop_xxxxx.patch is coming from the diff review system creating text document objects for displaying the diffs, but I also see no direct relation ship to this patch here. Will poke around a bit,

Jul 16 2019, 2:12 PM · KDevelop
apol closed D22456: Show session name in the Delete Session confirmation dialog.
Jul 16 2019, 11:49 AM · KDevelop
rjvbb added inline comments to D22424: TextDocument: remove actions from contextmenu on hide already.
Jul 16 2019, 8:33 AM · KDevelop

Jul 15 2019

kossebau updated the diff for D22424: TextDocument: remove actions from contextmenu on hide already.

update to first review feedback

Jul 15 2019, 9:33 PM · KDevelop
kossebau added a comment to D22424: TextDocument: remove actions from contextmenu on hide already.

Thanks for first review & testing.

Jul 15 2019, 9:33 PM · KDevelop
mdlubakowski added a comment to D22456: Show session name in the Delete Session confirmation dialog.
In D22456#496025, @apol wrote:

LGTM can you land it?

Jul 15 2019, 7:33 PM · KDevelop