Feed Advanced Search

Today

rjvbb requested review of D16882: [KDevelop/Shell] prevent duplicate added contextmenu actions.
Wed, Nov 14, 6:36 PM · KDevelop
rjvbb set the repository for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC) to R32 KDevelop.
Wed, Nov 14, 4:03 PM · KDevelop
rjvbb updated the diff for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Patch cleaned up, stripped the LevelDB and Kyoto backends that never satisfied me.
I did leave the original file-based storage backend, not because I think it has to be preserved if this ever gets in but to provide a quicker way to compare performance (and behaviour if ever someone testing this runs into issues).

Wed, Nov 14, 3:56 PM · KDevelop
rjvbb set the repository for D16218: [KDevelop/Core]: safe signal-handler implementation to R32 KDevelop.
Wed, Nov 14, 3:08 PM · KDevelop
rjvbb updated the diff for D16218: [KDevelop/Core]: safe signal-handler implementation.

Aaron's last suggestion made me realise I forget a few things when porting the patch back to using QSocketNotifier.
The shutdown procedure was intended to (and now does) include closing the signal pipe, verifying the descriptor before writing to it makes sense. So does handling failure there by re-raising the signal with the default handler.
I thought it would be even more robust to move the actual write into the if and check whether it succeeded, after all we want to be certain that these signals are always handled.

Wed, Nov 14, 3:07 PM · KDevelop
aaronpuchert added a comment to D16218: [KDevelop/Core]: safe signal-handler implementation.

Maybe you can add an else branch where you re-raise the signal with the default handler.

If the goal is just to let a 2nd signal trigger the default reaction from the runtime then it can be even simpler.

Wed, Nov 14, 12:10 AM · KDevelop

Yesterday

rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Tue, Nov 13, 5:29 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

This adds a safety against a race-like condition I've seen happen once in KDevelop.
It may not be required to make m_mWin a QPointer but it seemed sensible to do.

Tue, Nov 13, 5:29 PM · KDevelop, KTextEditor, Kate
rjvbb added a comment to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Ah, yes, I'll have to remember to clean it up and keep only the LMDB backend.

Tue, Nov 13, 11:09 AM · KDevelop
brauch requested changes to D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).

Sorry, I don't see this going in in this or a similar form.

Tue, Nov 13, 10:50 AM · KDevelop
rjvbb retitled D4484: optional external viewer support (based on Qt Assistant) in the QtHelp plugin from external viewer support (based on Qt Assistant) in the QtHelp plugin (optional) (WIP) to optional external viewer support (based on Qt Assistant) in the QtHelp plugin.
Tue, Nov 13, 10:42 AM · KDevelop
rjvbb retitled D8289: IdealDockWidget : support detaching as regular standalone window (PoC) from IdealDockWidget : support detaching as regular standalone window (WIP) to IdealDockWidget : support detaching as regular standalone window (PoC).
Tue, Nov 13, 10:41 AM · KDevelop
rjvbb updated the test plan for D12746: KDevelop: alternative monolithic storage options for TopDUContexts (PoC).
Tue, Nov 13, 10:39 AM · KDevelop
rjvbb retitled D16218: [KDevelop/Core]: safe signal-handler implementation from [KDevelop/Core]: safe signal-handler implementation (WIP) to [KDevelop/Core]: safe signal-handler implementation.
Tue, Nov 13, 10:31 AM · KDevelop

Fri, Nov 9

rjvbb added a comment to D16779: kate-ctags plugin: support KDevelop (WIP).
I'm a bit confused... I thought KDevelop had much more advanced plugins/features for this? What does KDevelop need this old plugin for? Non-C/C++ languages or what?
Fri, Nov 9, 10:32 PM · KDevelop, KTextEditor, Kate
sars accepted D16779: kate-ctags plugin: support KDevelop (WIP).

I'm a bit confused... I thought KDevelop had much more advanced plugins/features for this? What does KDevelop need this old plugin for? Non-C/C++ languages or what?

Fri, Nov 9, 10:15 PM · KDevelop, KTextEditor, Kate
rjvbb set the repository for D16779: kate-ctags plugin: support KDevelop (WIP) to R40 Kate.
Fri, Nov 9, 4:27 PM · KDevelop, KTextEditor, Kate
rjvbb updated the diff for D16779: kate-ctags plugin: support KDevelop (WIP).

Merged in changes from an older attempt I forgot about (apologies!).

Fri, Nov 9, 4:26 PM · KDevelop, KTextEditor, Kate
rjvbb requested review of D16779: kate-ctags plugin: support KDevelop (WIP).
Fri, Nov 9, 3:58 PM · KDevelop, KTextEditor, Kate
amhndu added a reviewer for D16484: Add scratchpad plugin: KDevelop.
Fri, Nov 9, 11:05 AM · KDevelop
amhndu updated the diff for D16773: Don't add 'override' specifier for non-modern project settings.
  • Change test case and convert octal literal to decimal
Fri, Nov 9, 10:26 AM · KDevelop
amhndu requested review of D16773: Don't add 'override' specifier for non-modern project settings.
Fri, Nov 9, 7:28 AM · KDevelop

Sat, Nov 3

amhndu updated the diff for D16484: Add scratchpad plugin.
  • Add a message when the scratch list is empty
Sat, Nov 3, 1:46 PM · KDevelop
gregormi added a comment to D16484: Add scratchpad plugin.

Would something like this be worth adding ?

Sat, Nov 3, 12:31 PM · KDevelop

Thu, Nov 1

amhndu added a comment to D16484: Add scratchpad plugin.

Would something like this be worth adding ?

cpp
index 5c193432c9..1b5fb57352 100644
--- a/plugins/scratchpad/scratchpadview.cpp
+++ b/plugins/scratchpad/scratchpadview.cpp
@@ -37,6 +37,7 @@
 #include <QWidgetAction>
 #include <QLineEdit>
 #include <QInputDialog>
+#include <QPainter>
Thu, Nov 1, 9:44 AM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

Marking inline comments done.

Thu, Nov 1, 7:49 AM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.
  • Make commands per-config and new scratches use command set last for suffix. I could not use mime types, as I was having some problems with detecting them,
  • Removed dependency of a compiler
  • Some other minor improvements
Thu, Nov 1, 7:48 AM · KDevelop

Wed, Oct 31

apol accepted D16541: Increase timeout for duchain gcc compatibility test.
Wed, Oct 31, 3:51 PM · KDevelop
brauch added inline comments to D16484: Add scratchpad plugin.
Wed, Oct 31, 2:24 PM · KDevelop
buschinski requested review of D16541: Increase timeout for duchain gcc compatibility test.
Wed, Oct 31, 1:05 PM · KDevelop
buschinski closed D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
Wed, Oct 31, 12:42 PM · KDevelop
buschinski closed D16458: Fix memleaks in duchain unittests.
Wed, Oct 31, 12:40 PM · KDevelop
buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

Updated. Thanks! I will push it :)

Wed, Oct 31, 12:36 PM · KDevelop
mwolff accepted D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

please cleanup the test slightly and then push it directly (no need for another round of review)

Wed, Oct 31, 8:25 AM · KDevelop

Mon, Oct 29

buschinski updated the diff for D16458: Fix memleaks in duchain unittests.
  • changed as requested, will push tomorrow or so
Mon, Oct 29, 9:43 PM · KDevelop
buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
  • Initial test, works with the patch, fails without :)
Mon, Oct 29, 9:40 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.

Thanks for the feedback, I've updated with some of the requested changes.

Mon, Oct 29, 4:49 PM · KDevelop
amhndu added a comment to D16484: Add scratchpad plugin.

One thing comes to mind: you kind of require that there is a compiler, while 3 of the 4 languages KDevelop officially supports (PHP, Python and JS) do not use one. I think it would be nice if this plugin would also easily work for e.g. Python snippets.

That's one of the problems I've had, the command box coupled with your suggestion to have per-scratch config could help somewhat. Is there some kdev interface that would help here or some other solution ?

Mon, Oct 29, 4:14 PM · KDevelop
brauch added inline comments to D16484: Add scratchpad plugin.
Mon, Oct 29, 3:28 PM · KDevelop
brauch added a comment to D16484: Add scratchpad plugin.

I'd have to use this for a while to see whether it works well in practice, but in general it seems like a cool idea.

Mon, Oct 29, 3:11 PM · KDevelop
amhndu updated the diff for D16484: Add scratchpad plugin.

Some improvements

Mon, Oct 29, 3:00 PM · KDevelop
rjvbb added a comment to D9344: [KDevelop] : [fixed] consistent use of the project name allowing to create multiple projects in a single source tree.

... you want to add the feature

Mon, Oct 29, 9:41 AM · KDevelop
apol added a comment to D16495: Bump min dep versions of Qt & KF to 5.9 & 5.44.

+1
Yes please...

Mon, Oct 29, 12:43 AM · KDevelop

Sun, Oct 28

kossebau added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

Is there a chance those aspects could be split out into separate patches?
Also still hoping for a variant of the bug fix patch which does not need a string freeze break, if possible.

Hi, Friedrich, sorry for delay. I think we should push it as is. Since current (wrong) logic of plugin controller we can have execute plugin unloaded with heaptrack loaded in same time. But execute plugin is really needed for plugin work so to don't break strings freeze we can only silently stop heaptrack analysis which is wrong and ugly. I think user should receive normal feedback.

So I suggest wait for 5.3 release and push this after. The patch will be available at 5.3.1 correcting release. Your opinion?

String freeze holds for the full time in the release branch. What usually is done in such a case where a bug fix really needs to break string freeze, is to ask translators for an exception. Usually a formality, but done at least to show respect to translators and their work.

Cmp. e.g. https://marc.info/?l=kde-i18n-doc&m=151092571015821&w=2 . Once two or more representatives of language teams have okayed (and no-one objected), exception is granted (that is documented somewhere, but could not find that quickly).

So if you see no way around, ask the translators now by emailing such a request to kde-i18n-doc@kde.org Will see to start reviewing in parallel then this WE.

Sun, Oct 28, 11:37 PM · KDevelop
flherne accepted D16499: Bump min ECM/KF5 dep version to 5.18.

+1, as on IRC.

Sun, Oct 28, 9:53 PM · KDevelop
kossebau added a comment to D16499: Bump min ECM/KF5 dep version to 5.18.

This is for 5.3 branch.

Sun, Oct 28, 9:43 PM · KDevelop
kossebau requested review of D16499: Bump min ECM/KF5 dep version to 5.18.
Sun, Oct 28, 9:42 PM · KDevelop
flherne added a comment to D16495: Bump min dep versions of Qt & KF to 5.9 & 5.44.

Debian Stretch (current stable release) has Qt 5.7 and KF 5.28. Next stable release isn't until mid-2019.

Sun, Oct 28, 9:16 PM · KDevelop
rjvbb added a comment to D9344: [KDevelop] : [fixed] consistent use of the project name allowing to create multiple projects in a single source tree.
But do they change things behind our back after this method has been entered?
Sun, Oct 28, 8:59 PM · KDevelop
kossebau added a comment to D16495: Bump min dep versions of Qt & KF to 5.9 & 5.44.

Motivated by the recent code update of qmljs from QtCreator, which uses at least one feature that needs 5.8 (QT_CONFIG cpp macro), it might be time to consider an update of the min versions we require for Qt and KF.

Sun, Oct 28, 8:59 PM · KDevelop
kossebau requested review of D16495: Bump min dep versions of Qt & KF to 5.9 & 5.44.
Sun, Oct 28, 8:59 PM · KDevelop
mwolff added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

the test would go into clang's test_duchain.cpp, create a method in there with the three TestFiles with the appropriate contents. Then parse them all and finally query the functions declarations and verify that the appropriate function definition is returned always.

Sun, Oct 28, 7:39 PM · KDevelop
pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Sun, Oct 28, 7:04 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Add more checks to the if-statements

Sun, Oct 28, 7:02 PM · KDevelop
kfunk added inline comments to D16461: Fix syntax support for dynamic member access..
Sun, Oct 28, 6:09 PM · KDevelop
pprkut added inline comments to D16461: Fix syntax support for dynamic member access..
Sun, Oct 28, 6:00 PM · KDevelop
pprkut updated the diff for D16461: Fix syntax support for dynamic member access..

Restructure if-statements in visitStaticMember.
Remove commented code from unit tests.

Sun, Oct 28, 5:58 PM · KDevelop
kfunk requested changes to D16461: Fix syntax support for dynamic member access..
Sun, Oct 28, 5:39 PM · KDevelop
kfunk accepted D16458: Fix memleaks in duchain unittests.

Feel free to push to 5.3 branch after fixing my remarks.

Sun, Oct 28, 5:36 PM · KDevelop
amhndu requested review of D16484: Add scratchpad plugin.
Sun, Oct 28, 4:49 PM · KDevelop
kossebau added a comment to D9344: [KDevelop] : [fixed] consistent use of the project name allowing to create multiple projects in a single source tree.
In D9344#346281, @rjvbb wrote:
The current patch I still cannot oversee (though also due to the existing code), so I would have to grab the -1 sign for now if on the jury.

Question is: are you, and should the refactoring be done before or after this change? I'm quite sure I won't have time for a serious overhaul the coming few weeks.

Sun, Oct 28, 1:45 PM · KDevelop
kossebau abandoned D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.
Sun, Oct 28, 1:03 PM · KDevelop
kossebau added a comment to D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.

Abandoning for now given inactivity by the original author, for cleaning the to-review list. Still hoping one day someone/you will pick up this again.

Sun, Oct 28, 1:03 PM · KDevelop
kossebau commandeered D13444: Update to display the name of the session in the "Delete Session" confirmation dialogue box.
Sun, Oct 28, 1:03 PM · KDevelop
kossebau abandoned D380: Correctly remove stale next bucket links when items are removed.

Abandoning for now given inactivity by the original author, for cleaning the to-review list. Still hoping one day someone/you will pick up this again.

Sun, Oct 28, 12:54 PM · KDevelop
kossebau commandeered D380: Correctly remove stale next bucket links when items are removed.
Sun, Oct 28, 12:53 PM · KDevelop

Sat, Oct 27

pprkut requested review of D16461: Fix syntax support for dynamic member access..
Sat, Oct 27, 3:43 PM · KDevelop
buschinski requested review of D16458: Fix memleaks in duchain unittests.
Sat, Oct 27, 2:16 PM · KDevelop
buschinski added a comment to D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

I assume you ran the tests (esp. for clang?) and it all keeps passing? if so, then +1

+2 if you could write a proper test for the case you explained in your commit message

Sat, Oct 27, 1:33 PM · KDevelop
mkraus added a comment to D15899: Fix segfault on project reload with cmake.

How to proceed?

Sat, Oct 27, 11:07 AM · KDevelop

Fri, Oct 26

kfunk closed D16426: Remove redundant/outdated kate mode lines/files.
Fri, Oct 26, 6:46 AM · KDevelop
kfunk accepted D16426: Remove redundant/outdated kate mode lines/files.
Fri, Oct 26, 6:45 AM · KDevelop
kfunk added a comment to D16426: Remove redundant/outdated kate mode lines/files.

Ah, good point, indeed.

Fri, Oct 26, 6:20 AM · KDevelop

Thu, Oct 25

kossebau updated subscribers of D16426: Remove redundant/outdated kate mode lines/files.

@kfunk plugins/externalscripts would need an uncrustify run as well (currently 2 space indentation on all files). I anticipated in this patch you will do this next :)

Thu, Oct 25, 3:09 PM · KDevelop
kossebau requested review of D16426: Remove redundant/outdated kate mode lines/files.
Thu, Oct 25, 3:07 PM · KDevelop
brauch added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Any help on the Windows version is greatly appreciated, whenever you find the time for it. :)

Thu, Oct 25, 2:57 PM · KDevelop
Petross404 added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

@Petross404 If you want to reapply the registry-reading on top of that, feel free to do so. Sorry, but I dont think I'll have time to test that. :(

Thu, Oct 25, 2:56 PM · KDevelop

Tue, Oct 23

kossebau closed D16032: Generate all kdebugsettings .categories files automatically.
Tue, Oct 23, 7:03 PM · KDevelop
kossebau updated the summary of D16032: Generate all kdebugsettings .categories files automatically.
Tue, Oct 23, 7:02 PM · KDevelop
kfunk abandoned D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
Tue, Oct 23, 6:39 PM · KDevelop
kfunk commandeered D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..
Tue, Oct 23, 6:39 PM · KDevelop
kfunk added a comment to D15976: Fix KDevelop's detection for Visual Studio 2017 compiler and tools..

Superseded by https://phabricator.kde.org/D16123.

Tue, Oct 23, 6:39 PM · KDevelop
kfunk accepted D16032: Generate all kdebugsettings .categories files automatically.

Hm, still not entirely convinced of all the added CMake code..., but at least the uses of the macros look better now.

Tue, Oct 23, 6:37 PM · KDevelop
amhndu closed D16386: Place cursor after opening brace for function implementation.
Tue, Oct 23, 3:12 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Thanks!

Tue, Oct 23, 3:00 PM · KDevelop
brauch accepted D16386: Place cursor after opening brace for function implementation.

Well, I guess adding line offsets is just the level of abstraction our code gen works at, anyways. Which is good enough. In my opinion, go for it ;)

Tue, Oct 23, 2:48 PM · KDevelop
amhndu added a comment to D16386: Place cursor after opening brace for function implementation.

Yes, seems that way.
I also remember seeing that on bugzilla, but can't find now.

Tue, Oct 23, 2:23 PM · KDevelop
brauch added a comment to D16386: Place cursor after opening brace for function implementation.

Is the opening brace always on its own line, independent of the formatter selected?

Tue, Oct 23, 2:17 PM · KDevelop
amhndu requested review of D16386: Place cursor after opening brace for function implementation.
Tue, Oct 23, 2:14 PM · KDevelop
amhndu closed D16315: Offer completion after user types the scope resolution operator..
Tue, Oct 23, 9:38 AM · KDevelop
amhndu closed D16326: Replace leading typed text when completing function implementation.
Tue, Oct 23, 7:55 AM · KDevelop

Mon, Oct 22

mwolff accepted D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.

I assume you ran the tests (esp. for clang?) and it all keeps passing? if so, then +1

Mon, Oct 22, 6:22 PM · KDevelop
buschinski updated the diff for D16356: FunctionDefinition: only look for (new/other) function definition if we don't have one.
  • updated based on the suggestions from Milian Wolff
Mon, Oct 22, 5:41 PM · KDevelop
kfunk added a comment to D16326: Replace leading typed text when completing function implementation.

master sounds fine to me; after a bit of exposure we could backport to 5.3 branch, targeting 5.3.1.

Mon, Oct 22, 12:01 PM · KDevelop
mwolff updated subscribers of D16326: Replace leading typed text when completing function implementation.

I'd say master personally, but @brauch or @kfunk should decide that.

Mon, Oct 22, 11:10 AM · KDevelop
amhndu added a comment to D16326: Replace leading typed text when completing function implementation.

I do have push rights, I can land this tomorrow as I'll be travelling a bit today.
Which branch should this be landed against ?

Mon, Oct 22, 10:46 AM · KDevelop
mwolff accepted D16326: Replace leading typed text when completing function implementation.

thanks a lot! do you have commit rights, or should we push this for you?

Mon, Oct 22, 10:43 AM · KDevelop
kfunk closed D16064: Fix memleaks in unittests.
Mon, Oct 22, 6:40 AM · KDevelop
kfunk added a comment to D16064: Fix memleaks in unittests.

Many tests will fail because of LSAN (leak sanitizer), which is enabled (at least here) by default with ASAN.

Mon, Oct 22, 6:39 AM · KDevelop
brauch added a comment to D16315: Offer completion after user types the scope resolution operator..

I'm inclined to say this looks innocent enough to go into 5.3 ...

Mon, Oct 22, 6:12 AM · KDevelop