Feed Advanced Search

Today

rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.
"If you have inherited this class to access the formatter, you will need to add a method similar to getPeekStart() in the ASStreamIterator class in astyle_main.h." from http://astyle.sourceforge.net/news.html is the only info I have, which leaves lots of room.
Have you seen any docs for that method?
Fri, Sep 21, 12:36 PM · KDevelop
kossebau added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Would this be OK as a fix?

Fri, Sep 21, 11:59 AM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Fri, Sep 21, 10:33 AM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

Updated as suggested. No switch yet but a layout that looks more like one.

Fri, Sep 21, 10:33 AM · KDevelop
rjvbb added a comment to D15625: Sublime: Fix crash caused when all tool view items are small.

Looks good at first glance. The failsafe should work evidently but I'll have to test to be certain if the other fix prevents the situation I ran into. Maybe this afternoon, otherwise tomorrow.

Fri, Sep 21, 10:30 AM · KDevelop
rjvbb added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

You should probably also add a few lines to the custom-definesandincludes plugin.

Fri, Sep 21, 10:02 AM · KDevelop
rjvbb reopened D15605: kdev-astyle : upgrade libastyle to v3.1.

Would this be OK as a fix?

Fri, Sep 21, 9:50 AM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Is there some API dox what one should implement for getPeekStart(), especially which values are valid?

Fri, Sep 21, 8:58 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

We could activate -Wunreachable-code so the compiler tells you where break isn't needed.

Fri, Sep 21, 8:53 AM · KDevelop
kossebau added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

With asserts enabled, I get a crash with this on opening the settings or sometimes only when selecting Objective-C in the formatting settings

kdevelop: /home/koder/Kode/kdegit/kf5/extragear/kdevelop/kdevelop/plugins/astyle/3rdparty/libastyle/ASFormatter.cpp:3841: std::__cxx11::string astyle::ASFormatter::peekNextText(const string&, bool, std::shared_ptr<astyle::ASPeekStream>) const: Assertion `sourceIterator->getPeekStart() == 0 || streamArg != nullptr' failed.
Fri, Sep 21, 4:25 AM · KDevelop
kossebau added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Fri, Sep 21, 4:16 AM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
C is not a subset of C++ (let me point to Mr. Stroustrup who should know it :)

I wouldn't call it that either (it'd be degrading for C ;)), but C++ does inherit from C (and was a layer on top of C in its early days, IIRC with a sort of preprocessor).

In fact, Mr Stroustrup does say basically the same thing:

Except for a few examples [...], C++ is a superset of C.
Fri, Sep 21, 4:12 AM · KDevelop
aaronpuchert added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

You should probably also add a few lines to the custom-definesandincludes plugin.

Fri, Sep 21, 12:32 AM · KDevelop
aaronpuchert added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Fri, Sep 21, 12:09 AM · KDevelop

Yesterday

rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Thu, Sep 20, 8:52 PM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

A small additional change to the plugin json, and a request for a bit of help.

Thu, Sep 20, 8:51 PM · KDevelop
amhndu updated the diff for D15625: Sublime: Fix crash caused when all tool view items are small.

I *think* this should fix it, but I can't really reproduce the crash.

Thu, Sep 20, 7:35 PM · KDevelop
kossebau added a comment to D15625: Sublime: Fix crash caused when all tool view items are small.

Please also fix the possibly actual bug, which is

const int maximumWidth = rect.width() / _items.size();

and its counterpart not taking the button spacing into account.

Thu, Sep 20, 6:24 PM · KDevelop
amhndu added a reviewer for D15625: Sublime: Fix crash caused when all tool view items are small: KDevelop.
Thu, Sep 20, 6:16 PM · KDevelop
amhndu updated subscribers of D15625: Sublime: Fix crash caused when all tool view items are small.
Thu, Sep 20, 6:12 PM · KDevelop
amhndu requested review of D15625: Sublime: Fix crash caused when all tool view items are small.
Thu, Sep 20, 6:11 PM · KDevelop
kossebau closed D15621: Install qtlogo.svg as normal icon, so any QIconEngine can find it.
Thu, Sep 20, 2:01 PM · KDevelop
kfunk accepted D15621: Install qtlogo.svg as normal icon, so any QIconEngine can find it.

Thanks for looking into this!

Thu, Sep 20, 1:51 PM · KDevelop
kossebau requested review of D15621: Install qtlogo.svg as normal icon, so any QIconEngine can find it.
Thu, Sep 20, 1:48 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
C is not a subset of C++ (let me point to Mr. Stroustrup who should know it :)
Thu, Sep 20, 12:48 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
... shared-mime-info has this questionable inheritage for C++ and Objective-C from C.

I don't think that's so questionable; doesn't the C++ entry also inherit from C? That would be logical at least historically speaking (and properly written C can still be compiled as C++ AFAIK).

Thu, Sep 20, 12:30 PM · KDevelop
rjvbb closed D15532: [Astyle] Add Objective C to list of languages with formatters.
Thu, Sep 20, 12:12 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
... shared-mime-info has this questionable inheritage for C++ and Objective-C from C.
Thu, Sep 20, 12:10 PM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

For some reason the preview uses the "C" highlighting mode for me when ObjC is selected, so the preview has some highlighting issues. That seems a bug with KTextEditor I have to explore more.

Nope, this is actually some bug in KDevelop which should be fixed first, somewhere in`SourceFormatterStyle::modeForMimetype(...)` the wrong mode is chosen. Still digging.

Thu, Sep 20, 10:52 AM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Thu, Sep 20, 9:54 AM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

Updated as requested, waiting for final a-ok.

Thu, Sep 20, 9:53 AM · KDevelop
rjvbb added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Thu, Sep 20, 9:52 AM · KDevelop
rjvbb closed D15605: kdev-astyle : upgrade libastyle to v3.1.
Thu, Sep 20, 8:34 AM · KDevelop
kfunk requested changes to D15532: [Astyle] Add Objective C to list of languages with formatters.

Please update the Diff according to our requests, then I think this can still go into 5.3 branch. Friedrich, you still agree this could go into 5.3? :)

Thu, Sep 20, 6:51 AM · KDevelop
kfunk accepted D15605: kdev-astyle : upgrade libastyle to v3.1.

Go for it, please push to 5.3 branch.

Thu, Sep 20, 6:42 AM · KDevelop

Wed, Sep 19

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Possibly because Qt on macOS uses the macOS mimettype database
Wed, Sep 19, 11:23 PM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.
Not really: https://repology.org/metapackage/astyle/versions
Wed, Sep 19, 10:05 PM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.
Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.

What title do you propose?

Wed, Sep 19, 9:32 PM · KDevelop
pino added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Normally I'd agree, but here we're dealing with really a tiny amount of additional code and a project which isn't exactly being kept up-to-date by distributions either (on Linux I'd get 2.04 from the system, on Mac 2.05 from MacPorts).

Wed, Sep 19, 9:01 PM · KDevelop
rjvbb added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Normally I'd agree, but here we're dealing with really a tiny amount of additional code and a project which isn't exactly being kept up-to-date by distributions either (on Linux I'd get 2.04 from the system, on Mac 2.05 from MacPorts). Bundling the few files involved means that at least everyone gets the astyle plugin and with the same version.

Wed, Sep 19, 8:34 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.
Wed, Sep 19, 8:26 PM · KDevelop
kossebau requested changes to D15532: [Astyle] Add Objective C to list of languages with formatters.

For some reason the preview uses the "C" highlighting mode for me when ObjC is selected, so the preview has some highlighting issues. That seems a bug with KTextEditor I have to explore more.

Wed, Sep 19, 8:24 PM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

Code looks fine to me, modulo all the comments made, and works where I tested it. Please also update the summary text and title of the patch.

Wed, Sep 19, 8:02 PM · KDevelop
fvogt added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Yes, that was my starting patch, but then I got unsure about the great picture.
If going this route, any shell script wizard proposal how to change checkToolsInPath in kdevplatform_shell_environment.sh to check for both variants, without adding too much boilerplate code?

Wed, Sep 19, 7:32 PM · KDevelop
pino added inline comments to D15532: [Astyle] Add Objective C to list of languages with formatters.
Wed, Sep 19, 6:41 PM · KDevelop
pino added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

What about using the system version of libastyle, instead? I.e. look for libastyle, and if not found then do not build kdev-astyle.
This would avoid a code copy which clearly is not kept up-to-date, with almost no overhead on packagers (since astyle provides a shared library for a long time).
Since astyle 3.0 broke the ABI and changed its API a bit, using that version as minimum could be a reasonable idea.

Wed, Sep 19, 6:38 PM · KDevelop
apol added a comment to D15605: kdev-astyle : upgrade libastyle to v3.1.

Is there a reason why it can't be a proper dependency?

Wed, Sep 19, 6:36 PM · KDevelop
kossebau added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Wed, Sep 19, 6:33 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

BTW, this change is still marked as approved, is it?

Wed, Sep 19, 6:29 PM · KDevelop
fvogt added a comment to D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.

IMO it should just check for both and prefer qdbus-qt5 if available.

Wed, Sep 19, 6:29 PM · KDevelop
kossebau requested review of D15606: Fix calling qdbus by using qt5-current name qdbus-qt5.
Wed, Sep 19, 6:26 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

BTW, this change is still marked as approved, is it?

Wed, Sep 19, 6:09 PM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Wed, Sep 19, 6:08 PM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

The libastyle was split off as D15605, as requested.
(Fortunately the 2 changesets were orthogonal.)

Wed, Sep 19, 6:08 PM · KDevelop
rjvbb requested review of D15605: kdev-astyle : upgrade libastyle to v3.1.
Wed, Sep 19, 6:06 PM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

It's just that I use the 5.3 branch.

Wed, Sep 19, 1:04 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Can the upgrade at least be done in the 5.3 branch, or if not, merged/cherry-picked ASAP after committing to the main branch?

Wed, Sep 19, 11:55 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Yeah, I was expecting this, though I hoped it could just be separate commit, not a separate review.

Wed, Sep 19, 11:43 AM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

I added ObjC previews as requested, and doing so I noticed I had to make a few more changes, justifying a ticket name change. I did mention the change was going to be a bit more elaborate than one might have thought, didn't I? :)

Wed, Sep 19, 11:10 AM · KDevelop
rjvbb set the repository for D15532: [Astyle] Add Objective C to list of languages with formatters to R32 KDevelop.
Wed, Sep 19, 9:25 AM · KDevelop
rjvbb updated the diff for D15532: [Astyle] Add Objective C to list of languages with formatters.

I added ObjC previews as requested, and doing so I noticed I had to make a few more changes, justifying a ticket name change. I did mention the change was going to be a bit more elaborate than one might have thought, didn't I? :)

Wed, Sep 19, 9:22 AM · KDevelop

Tue, Sep 18

rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

seems to still lead us here into a situation where only "smallItems" exists?

I would suspect some rounding errors.
Tue, Sep 18, 2:19 PM · KDevelop
glebaccon added a watcher for KDevelop: glebaccon.
Tue, Sep 18, 1:35 PM
kossebau added inline comments to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Tue, Sep 18, 12:36 PM · KDevelop
kossebau added inline comments to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Tue, Sep 18, 12:34 PM · KDevelop
kossebau added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

I would like to first try to find the reason why the condition bool shrink = rect.width() < sizeHint().width(); seems to still lead us here into a situation where only "smallItems" exists?
I would suspect some rounding errors.

Tue, Sep 18, 12:13 PM · KDevelop
rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

No, I haven't pushed a fix, but I have one which seems to work just fine. Feel free to clean it up as you see fit (I see an accidental indentation change) and push it yourself.

Tue, Sep 18, 12:08 PM · KDevelop
amhndu added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

Oh, my bad.
I see you haven't pushed a fix. Should I make a new revision then ?

Tue, Sep 18, 11:51 AM · KDevelop
rjvbb added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

https://bugs.kde.org/show_bug.cgi?id=398790

Tue, Sep 18, 11:31 AM · KDevelop
rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

On it, but the changes go a bit further than I (and you?) might have guessed ([private] method renaming e.g.). I hope to have something by the end of day, but if you think it'd end up having to be split into a separate commit I could just as well hear that now ;)

Tue, Sep 18, 8:46 AM · KDevelop

Mon, Sep 17

kossebau added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

Given this is a bug fix and thus should also go to 5.3 branch. could you try a version with no new strings that need translation? Is there a chance existing strings can be reused (from the same catalog, thus used elsewhere in the plugin)?
Otherwise we need to ask the translators for a string freeze exception.

Mon, Sep 17, 11:31 AM · KDevelop
kossebau accepted D15532: [Astyle] Add Objective C to list of languages with formatters.

If you have a chance/time, please considerupdating the patch by adding some samples for the new language types to AStylePlugin::previewText(SourceFormatterStyle, QMimeType).
Currently that one uses C++ code for the preview, which surely is a non-pleasing experience.

Mon, Sep 17, 11:01 AM · KDevelop
pino added inline comments to D15140: Fix random order in "Analyze Current File/Project With" menus.
Mon, Sep 17, 6:01 AM · KDevelop
antonanikin added a comment to D15140: Fix random order in "Analyze Current File/Project With" menus.

Hi, Friedrich. Ok, we can skip the patch and wait for upstream KXmlGui fix. I should then abandon the revison?

Mon, Sep 17, 4:13 AM · KDevelop
antonanikin requested review of D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).
Mon, Sep 17, 4:04 AM · KDevelop

Sat, Sep 15

rjvbb added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.
Thanks. Learned about ObjC++ this way... the world is full of strange things :)
Sat, Sep 15, 12:53 PM · KDevelop
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Thanks. Learned about ObjC++ this way... the world is full of strange things :)
Saw some (possibly unrelated) principle issue in the formatting when giving a quick runtime test, need to inspect further before I feel good to give a +1, planned for tonight.

Sat, Sep 15, 12:34 PM · KDevelop
rjvbb set the repository for D15530: kdev-clang : somewhat more complete ObjC(++) support to R32 KDevelop.
Sat, Sep 15, 12:22 PM · KDevelop
rjvbb updated the diff for D15530: kdev-clang : somewhat more complete ObjC(++) support.

astye change split off as D15532

Sat, Sep 15, 12:21 PM · KDevelop
rjvbb requested review of D15532: [Astyle] Add Objective C to list of languages with formatters.
Sat, Sep 15, 12:20 PM · KDevelop
kossebau added inline comments to D15530: kdev-clang : somewhat more complete ObjC(++) support.
Sat, Sep 15, 12:10 PM · KDevelop
rjvbb requested review of D15530: kdev-clang : somewhat more complete ObjC(++) support.
Sat, Sep 15, 12:07 PM · KDevelop
amhndu closed D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Sat, Sep 15, 10:55 AM · KDevelop
amhndu updated the summary of D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Sat, Sep 15, 10:51 AM · KDevelop
amhndu updated the summary of D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Sat, Sep 15, 10:43 AM · KDevelop
amhndu closed D14618: Create action to jump to the current execution line in debug mode..
Sat, Sep 15, 10:01 AM · KDevelop
kossebau added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

Time to land this as well :)

Sat, Sep 15, 8:49 AM · KDevelop
kossebau added a comment to D14618: Create action to jump to the current execution line in debug mode..

@amhndu Time to apply your new KDE developer account abilities :)

Sat, Sep 15, 8:30 AM · KDevelop
amhndu updated the diff for D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

Remove stray new lines (hopefully final amend)

Sat, Sep 15, 6:38 AM · KDevelop
amhndu added inline comments to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.
Sat, Sep 15, 6:27 AM · KDevelop
amhndu updated the diff for D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

Final styling fixes.

Sat, Sep 15, 6:22 AM · KDevelop
antonanikin closed D15326: Fix segfaults in OutputWidget.
Sat, Sep 15, 12:35 AM · KDevelop
antonanikin updated the summary of D15326: Fix segfaults in OutputWidget.
Sat, Sep 15, 12:24 AM · KDevelop

Fri, Sep 14

kossebau added a comment to D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

And IMHO this can be considered a bug fix, which should go to the 5.3 branch (also has no new UI strings, so not breaking the string freeze).

Fri, Sep 14, 11:59 PM · KDevelop
kossebau accepted D15450: Sublime: Fix window growing larger by making tool view buttons shrinkable.

Some more nitpicks, but otherwise happy with this patch.
So with the nitpicks resolved, I vote for adding this.

Fri, Sep 14, 11:14 PM · KDevelop
kossebau accepted D15326: Fix segfaults in OutputWidget.

Patch looks good to me also on semantic reading. This should remove the crashes we have seen, and make the code less unusual when it comes to QWidget object handling.

Fri, Sep 14, 4:24 PM · KDevelop
kfunk added a comment to D15326: Fix segfaults in OutputWidget.

Incoming bug report: https://bugs.kde.org/show_bug.cgi?id=398615

Fri, Sep 14, 3:56 PM · KDevelop
antonanikin updated the diff for D15326: Fix segfaults in OutputWidget.
  • Drop last unrelated changes :)
Fri, Sep 14, 11:47 AM · KDevelop
antonanikin updated the diff for D15326: Fix segfaults in OutputWidget.
  • Drop another unrelated change
Fri, Sep 14, 11:41 AM · KDevelop
antonanikin updated the diff for D15326: Fix segfaults in OutputWidget.
  • Drop unrelated changes
Fri, Sep 14, 11:38 AM · KDevelop