• Enable Drag and drop for gcode and gco files

• Enable Drag and drop for gcode and gco files

Looks sane and works. Approve now or you will add the push_to_front thing?

In D12723#258825, @laysrodrigues wrote:

I have the impression if the user has more than one instance printing, you will show a notification for each one. I think that if at least one is true, one dialog will be enough.
You break the switch, not the for...
I was trying to test here, but Atelier isn't finding fake printer ports...

• Only warn once if multi instances are printing; Also warn if user tries to close a printing

instance

• Add file close. Works well under most cases

I have the impression if the user has more than one instance printing, you will show a notification for each one. I think that if at least one is true, one dialog will be enough.
You break the switch, not the for...
I was trying to test here, but Atelier isn't finding fake printer ports...

• remove unneeded line

• Reload openfiles instead of opening a new copy
• Add file close. Works well under most cases

• GCodeEditor::fileClosed emited when a file is closed in the view. This is then removed from the
• Close the files delete the document
• Merge branch 'loadone' into LOADCLOSE

This needs the D12690 to much so im going to add it to that diff

• C++11 for
• Mapping to better track open files.
• Remove creation of "New File". (this will confuse user can't save until you open a file in our set

up and cant print unless written to disk. We can redo this later in a better way when those are
solved)

• && view

• Debug info for testing . Disable creation of new file on no files

• close usl

• Reloaded file tab set as current

• File Ref

In D12691#257999, @cullmann wrote:

Hmm, of example in the

connect(gcodeEditor, &GCodeEditorWidget::updateClientFactory, this, [this](KTextEditor::View* view){
        guiFactory()->removeClient(m_currEditorView);
        guiFactory()->addClient(view);
        m_currEditorView = view;
    });

part: could m_currEditorView be there null at the start or later? must one guard that?

Beside that, I am not sure how you handle view deletes, isn't the current view pointer then dangling?

Hmm, of example in the

I have found a different way to fix the crash without removing the code here.. I will abandon this revision and use that one..

Hi, I think the reference to kateviewmanager.cpp is a good hint for how to implement it "correctly".
Unfortunately the proper xmlgui client handling is a bit hard.
You always need to add/remove the clients from your factory.
As you see, kate uses some class to disable updates during that process, to avoid nasty toolbar/menu flickering as comfort feature.
If you properly remove the stuff, no crashs shall happen. At least I am not aware of such issues.

In D12675#257835, @laysrodrigues wrote:

@patrickelectric Kate has a view manager, that changes the factory when something changes see https://github.com/KDE/kate/blob/master/kate/kateviewmanager.cpp#L610
As you can see to activate a new view it removes the previous one.

@patrickelectric Kate has a view manager, that changes the factory when something changes see https://github.com/KDE/kate/blob/master/kate/kateviewmanager.cpp#L610
As you can see to activate a new view it removes the previous one.

In D12675#257791, @laysrodrigues wrote:

@patrickelectric The problem is that since we dont remove the views, they start to have conflict and the files are not managed properly by KTextEditor and guiFactory(Main Window).
See the discussion on telegram.

@patrickelectric The problem is that since we dont remove the views, they start to have conflict and the files are not managed properly by KTextEditor and guiFactory(Main Window).
See the discussion on telegram.

@laysrodrigues What is the problem of this PR ?

@cullmann would you be able to give us a insight about this?
We are using KTextEditor, and the current code is crashing when Atelier closes if we have two or more files open.
Thanks

Planed Changed to address lays consern above.

• GCodeEditor: Allow user to close files.
• GCodeEditor: Prevent the user from opening the same file twice.
• MainWindow: Remove Closed files from file list.

• Open two files
• Edit the second file
• Save the edition on second file
• Open the second file again (You can close it or open as a third file)
• it will give to you that warning. The file wasn't properly saved because the views are messed up.

• rebase

• rebase

• Rebase

• adjust virtual

• update virtual

• Remove empty line

• use pepo's math instead of W width

• rebase / tomaz suggestion

• rebase / tomaz suggestion

• rebase / tomaz suggestions

Keep the destructor even if it does nothing (and add a virtual to it) to always call the destructor of the parent. besides that, +1.

• Remove un wanted line

• Remove empty lines

• Rebase, Remove uncheck

• Rebase