Why not make these separate KCMs? I don't know how usual it is to open just the fonts KCM (kcmshell5 fonts) or if the vast majority of users gets to that config page only via the systemsettings app. For those you don't need to implement a tab-like mode switch because systemsettings already provides that for different KCMs. And users who go through kcmshell5 can probably learn quite easily to modify their commandline.
This approach also means you don't have to worry about whether and how to implement mode persistence.

Thanks for spotting and fixing this.

You can't really do that in threads, you need to access the buffer, otherwise you can redo all things again in extra logic (like using the ranges for getting replacement ranges....)

Updated the diff to reflect just the relevant changes for this commit.

I would also advise against calling processEvents() to keep UIs responsive in all cases. It's tempting, but it is near impossible to get it right. What about conflicting actions, close/resize events, dbus calls, etc etc that are handled here?

4.10 as well please

Only master ot 4.10 too?

I started implementing the functionality of M120 on basis of the current master: D17493

• Simplify logic: SessionController already has a map

Um, the diff is now different, and it looks like the wrong patch was committed: https://cgit.kde.org/dolphin.git/commit/?id=55db38d5ecc1f13e17fecd7f3a5ea24421080b77

Semantically, this is the correct icon, though the actual imagery isn't super applicable. We can fix that with a better icon though.

Sorry for this, me and @mart did realize that this was pushed too early. If you prefer, we can revert Kirigami part.

Hmpf! Some googling didn't help. Just some thoughts.

• Fixed the issue that the last word goes out of the display area in vertical reading activity

I'd recommend alphabetising the list.

There is also https://userbase.kde.org/Tutorials/Install_KDE_software

This introduces a new dependency on KWin

In vertical reading activity, the last word goes out of the display area: https://pasteboard.co/HR6SkcO.png

Guys, code review doesn't make sense if one mobile dev opens a change for another mobile dev and the whole thing gets pushed in five minutes. This gives nobody else a chance to comment. If you want to operate like that you can just omit the review.

If we are doing markdown, it could make sense why such common markdown isn't working too, otherwise this is bound to happen anyway. I've actually never seen this ~~~ thing.

Good work. Works fine on my side. Once any other mentor cross-checks it, it will be committed. Thank you!

Maybe not applicable to this patch, but would we consider making the battery color in the progress bar to be green? Green seems to be very standard to mean charge. We are using blue.

Thanks Dave!