Feed All Stories

Sep 23 2018

smartins committed R74:285cd756cb46: tests: connect-3arg-lambda test will only run on clang >= 5.0 now (authored by smartins).
tests: connect-3arg-lambda test will only run on clang >= 5.0 now
Sep 23 2018, 3:39 PM
hindenburg added a comment to D13854: Refactor Profile and ColorScheme.

Can you rebase this please? It applies cleanly but won't land for some reason.

Sep 23 2018, 3:37 PM · Konsole
smartins committed R74:359a710f6e76: tests: Require Qt >= 5.8 for fully-qualified-moc-types (authored by smartins).
tests: Require Qt >= 5.8 for fully-qualified-moc-types
Sep 23 2018, 3:36 PM
hindenburg retitled D13854: Refactor Profile and ColorScheme from Return the default ColorScheme in case of a failure to Refactor Profile and ColorScheme.
Sep 23 2018, 3:33 PM · Konsole
hindenburg accepted D13854: Refactor Profile and ColorScheme.
Sep 23 2018, 3:31 PM · Konsole
smartins committed R74:9739e298abb6: tests: rule-of-three requires clang > 4.0 (authored by smartins).
tests: rule-of-three requires clang > 4.0
Sep 23 2018, 3:28 PM
smartins committed R74:3fdab1b05c86: docker: Fix llvm's 6 path (authored by smartins).
docker: Fix llvm's 6 path
Sep 23 2018, 3:25 PM
smartins committed R74:0f2b7ef19e8f: docker: Also test llvm 5.0 and llvm 4.0 (authored by smartins).
docker: Also test llvm 5.0 and llvm 4.0
Sep 23 2018, 3:25 PM
bellaperez committed R883:1525166: gui: Valencian works.
gui: Valencian works
Sep 23 2018, 3:21 PM
ltoscano committed R883:1525165: Extract peruse messages.
Extract peruse messages
Sep 23 2018, 3:21 PM
mludwig requested review of D15711: Allow KXmlGui UI files to be found more easily.
Sep 23 2018, 3:04 PM · Okular
kristofk committed R883:1525164: Hungarian translation of baloo_file5 updated.
Hungarian translation of baloo_file5 updated
Sep 23 2018, 2:49 PM
yurchor committed R342:b0b3b8ac616e: Port away from deprecated KNumInput (authored by yurchor).
Port away from deprecated KNumInput
Sep 23 2018, 2:47 PM
mpyne added a comment to T9506: kdesrc-build: Complete integration of Mojolicious web framework.

Still in action. Latest updates (in the make_it_mojo branch) significantly simplify the event-driven logic by moving the event handling in a big huge chain of promise->thens.

Sep 23 2018, 2:40 PM · kdesrc-build
scottpetrovic committed R37:9155a4775a5f: manually control the settings area size to figure out what is the biggest area (authored by scottpetrovic).
manually control the settings area size to figure out what is the biggest area
Sep 23 2018, 2:40 PM
scottpetrovic committed R37:5f85019faf60: condense auto brush tip settings in brush editor (authored by scottpetrovic).
condense auto brush tip settings in brush editor
Sep 23 2018, 2:40 PM
scottpetrovic committed R37:b0fecb121df4: condense the predefined brush tip options (authored by scottpetrovic).
condense the predefined brush tip options
Sep 23 2018, 2:40 PM
scottpetrovic committed R37:ddfbf81c6afb: clean up a few comments and collapse the curve preset icons (authored by scottpetrovic).
clean up a few comments and collapse the curve preset icons
Sep 23 2018, 2:40 PM
scottpetrovic committed R37:8b34df38147e: clean up the UI a bit for a few pen sensors (authored by scottpetrovic).
clean up the UI a bit for a few pen sensors
Sep 23 2018, 2:40 PM
scottpetrovic committed R37:ab8bbcb355f1: Convert sensor list to a drop-down in brush editor UI (authored by scottpetrovic).
Convert sensor list to a drop-down in brush editor UI
Sep 23 2018, 2:39 PM
mpyne moved T9506: kdesrc-build: Complete integration of Mojolicious web framework from Backlog to Doing on the kdesrc-build board.
Sep 23 2018, 2:38 PM · kdesrc-build
knauss committed R81:b3ce018aa46d: Use new messageviewer interface. (authored by knauss).
Use new messageviewer interface.
Sep 23 2018, 2:29 PM
aaronpuchert added a comment to D15694: Make implicit fallthroughs a compiler error, remove unneeded breaks.

Yes, needs to be included for such source file, because the min Qt dependency version is still 5.5, and Q_FALLTHROUGH was only introduced in 5.8 (see note at http://doc.qt.io/qt-5/qtglobal.html#Q_FALLTHROUGH)

Sep 23 2018, 2:24 PM · KDevelop
sandroandrade committed R907:ee01b6680399: Adjust talks description (authored by sandroandrade).
Adjust talks description
Sep 23 2018, 2:23 PM
kristofk committed R883:1525163: Hungarian translation of libkholidays5_qt updated.
Hungarian translation of libkholidays5_qt updated
Sep 23 2018, 2:21 PM
knauss committed R94:529936406790: bump version because of API changes. (authored by knauss).
bump version because of API changes.
Sep 23 2018, 2:14 PM
knauss committed R94:ff564eea7a47: use static methods instead of private methods. (authored by knauss).
use static methods instead of private methods.
Sep 23 2018, 2:14 PM
knauss committed R94:e6f82b5b2c03: GrantleeHeaderFormatter: Move list and date formatter into grantlee. (authored by knauss).
GrantleeHeaderFormatter: Move list and date formatter into grantlee.
Sep 23 2018, 2:14 PM
knauss closed D13039: GrantleeHeaderFormatter: Move list and date formatter into grantlee..
Sep 23 2018, 2:14 PM · KDE PIM
smartins committed R74:5b3a3464a2e0: Fix crash in old-style-connect fixits (authored by smartins).
Fix crash in old-style-connect fixits
Sep 23 2018, 2:12 PM
sandroandrade committed R907:af0c495722f6: Adjust schedule layout (authored by sandroandrade).
Adjust schedule layout
Sep 23 2018, 2:07 PM
mschiller requested review of D15535: Use KMainWindow instead of QMainWindow.
Sep 23 2018, 2:05 PM
mschiller updated the diff for D15463: Corrected behaviour on repeated pressing of operator buttons.

Sure. This patch was just something I've been using for a while now and found it very useful. So I just put it out there after seeing that rather old bug report from 2003.
Update: Made the bool field private and use getter/setter.

Sep 23 2018, 2:00 PM
knauss committed R81:1eeec3c97d31: Add test cases for enterpriseheaderstyleplugin. (authored by knauss).
Add test cases for enterpriseheaderstyleplugin.
Sep 23 2018, 2:00 PM
knauss committed R81:3f2028e7dc35: make enterpriseheaderstyle tests passing. (authored by knauss).
make enterpriseheaderstyle tests passing.
Sep 23 2018, 2:00 PM
knauss committed R81:9db03339a919: Add test cases for briefheaderstyleplugin. (authored by knauss).
Add test cases for briefheaderstyleplugin.
Sep 23 2018, 2:00 PM
knauss committed R81:0581d3e9f755: make FancyHeaderStyle test passing. (authored by knauss).
make FancyHeaderStyle test passing.
Sep 23 2018, 2:00 PM
knauss committed R81:492be839f5a4: Add test cases for fancyheaderstyleplugin. (authored by knauss).
Add test cases for fancyheaderstyleplugin.
Sep 23 2018, 2:00 PM
knauss committed R81:70f78d015ca1: fixup (authored by knauss).
fixup
Sep 23 2018, 2:00 PM
knauss committed R81:bbb1fad2402c: prepare messageviewerheaderplugins for real header tests. (authored by knauss).
prepare messageviewerheaderplugins for real header tests.
Sep 23 2018, 2:00 PM
mschiller abandoned D15710: pressing operator buttons twice fix.

Sry messed up with arc ;)

Sep 23 2018, 1:56 PM
mschiller requested review of D15710: pressing operator buttons twice fix.
Sep 23 2018, 1:55 PM
zzag requested review of D15709: [effects/morphingpopups] Use enumerators from the DataRole enum.
Sep 23 2018, 1:54 PM · KWin
ecuadra committed R883:1525162: Spanish translation update.
Spanish translation update
Sep 23 2018, 1:45 PM
ecuadra committed R883:1525161: Spanish translation update.
Spanish translation update
Sep 23 2018, 1:45 PM
psn committed R7:becb256931a9: Fix Tooltip event handling in viewtree (authored by psn).
Fix Tooltip event handling in viewtree
Sep 23 2018, 1:43 PM
psn committed R7:990e8793e128: Fix warings (authored by psn).
Fix warings
Sep 23 2018, 1:43 PM
psn committed R7:eeb20129fc33: Use QString::midRef where possible (authored by psn).
Use QString::midRef where possible
Sep 23 2018, 1:43 PM
sander updated the diff for D7962: Implement several new print scaling options.

I updated the diff. Apologies for the last version---it was really messed up.

Sep 23 2018, 1:42 PM · Okular
vreale committed R883:1525160: Translation updates.
Translation updates
Sep 23 2018, 1:09 PM
wojnilowicz committed R261:4ff4216fe41e: Fix previous patch (authored by wojnilowicz).
Fix previous patch
Sep 23 2018, 12:40 PM
fdekruijf committed R883:1525159: update.
update
Sep 23 2018, 12:39 PM
cgilles committed R850:5775e718eb6e: update krazy static analyzer report digiKam-master-rev-455e698917. (authored by cgilles).
update krazy static analyzer report digiKam-master-rev-455e698917.
Sep 23 2018, 12:31 PM
fdekruijf committed R883:1525158: update.
update
Sep 23 2018, 12:30 PM
fdekruijf committed R883:1525157: update.
update
Sep 23 2018, 12:28 PM
fdekruijf committed R883:1525156: update Jaap Woldringh.
update Jaap Woldringh
Sep 23 2018, 12:28 PM
fdekruijf committed R883:1525155: update Jaap Woldringh.
update Jaap Woldringh
Sep 23 2018, 12:28 PM
smartins committed R74:e644c4af0c3d: build-clazy.sh: Remove unneeded checks (authored by smartins).
build-clazy.sh: Remove unneeded checks
Sep 23 2018, 12:26 PM
ecuadra committed R883:1525154: Spanish translation update.
Spanish translation update
Sep 23 2018, 12:17 PM
rempt added a comment to T9722: Direct Transformation and Merge after Pasteing.

I'm not really enthusiastic about it -- it presupposes that the only goal of pasting is to transform the paste and merge it with the current layer. If we implement this, users would have to create a new layer and then do the paste and then cancel the transformation if the goal of pasting is to create a new layer.

Sep 23 2018, 12:08 PM · Krita: Abyss
mlaurent committed R324:998e49d38fcc: Use KDEFrameworkCompilerSettings + use nullptr (authored by mlaurent).
Use KDEFrameworkCompilerSettings + use nullptr
Sep 23 2018, 12:07 PM
zzag requested review of D15708: [effects/slide] Delete redundant checks.
Sep 23 2018, 12:06 PM · KWin
Arucard added a comment to D15385: Improve convergence info and include device types.

Thanks for reviewing. I've replied to some of the comments, and fixed the other ones.

Sep 23 2018, 12:05 PM · KDE Human Interface Guidelines
kossebau added a comment to D14530: Fix crash when save a QImage to the eps format file.

@zccrs Hi. Does D15405 fix things for you, so is this patch here no longer needed? If so, please close this review request by selecting and submitting the action "Abandon Revision", so it does no longer appear in our "Please review" list :)

Sep 23 2018, 12:04 PM · Frameworks
Arucard updated the diff for D15385: Improve convergence info and include device types.
  • Modified according to review feedback
Sep 23 2018, 12:04 PM · KDE Human Interface Guidelines
kossebau added a comment to D15530: kdev-clang : somewhat more complete ObjC(++) support.

As mentioned on https://phabricator.kde.org/D15532#330528, text/x-objchdr & text/x-objc++src are MIME types no-where defined from what I saw. Which makes things irritating for future code readers, as well as resulting in annpying warnings in the runtime log.
Please keep those MIME types out of this patch, until that has been resolved.

Sep 23 2018, 11:58 AM · KDevelop
zzag requested review of D15707: [effects/slide] Simplify logic that forces blur and background contrast.
Sep 23 2018, 11:58 AM · KWin
huftis committed R883:1525153: SVN_SILENT Updated Norwegian Nynorsk translations for ‘summit/messages’ in….
SVN_SILENT Updated Norwegian Nynorsk translations for ‘summit/messages’ in…
Sep 23 2018, 11:57 AM
huftis committed R883:1525152: SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in ‘trunk/l10n….
SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in ‘trunk/l10n…
Sep 23 2018, 11:57 AM
huftis committed R883:1525151: SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in….
SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in…
Sep 23 2018, 11:57 AM
huftis committed R883:1525149: SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in ‘trunk/l10n….
SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in ‘trunk/l10n…
Sep 23 2018, 11:57 AM
huftis committed R883:1525150: SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in….
SVN_SILENT Updated Norwegian Nynorsk translations for ‘messages’ in…
Sep 23 2018, 11:57 AM
psn committed R7:34950e8bdd9b: Call static functions correctly (authored by psn).
Call static functions correctly
Sep 23 2018, 11:57 AM
psn committed R7:d05280bd18fc: Use correct type of cast (authored by psn).
Use correct type of cast
Sep 23 2018, 11:57 AM
psn committed R7:34e7f892299c: Remove unused variables (authored by psn).
Remove unused variables
Sep 23 2018, 11:57 AM
mlaurent committed R326:0fed5ecba343: Use KDEFrameworkCompilerSettings + use nullptr (authored by mlaurent).
Use KDEFrameworkCompilerSettings + use nullptr
Sep 23 2018, 11:56 AM
kossebau abandoned D14710: Inject default environment group variables into debug process environment..

Closing this, as patch has been abandoned in favour of (landed) D14870

Sep 23 2018, 11:53 AM · KDevelop
bruns added a comment to D15704: increase test coverage of taglibwriter.

In general this looks good, but I would like two changes:

  1. Do the conversion to QTest first, and leave out the change for unicode testing (e.g. Title1 -> Title €)
  2. Add a third column like "stringsuffix", and then add another test (row) for each format. QStringLiteral("Title1") then becomes QStringLiteral("Title1") + stringsuffix
Sep 23 2018, 11:52 AM · Baloo, Frameworks
kossebau commandeered D14710: Inject default environment group variables into debug process environment..
Sep 23 2018, 11:52 AM · KDevelop
mlaurent committed R328:48009ef2e5d4: Use KDEFrameworkCompilerSettings + modernize + use nullptr (authored by mlaurent).
Use KDEFrameworkCompilerSettings + modernize + use nullptr
Sep 23 2018, 11:50 AM
huftis committed R883:1525148: Betre omsetting av «containg folder» («foreldermappe»).
Betre omsetting av «containg folder» («foreldermappe»)
Sep 23 2018, 11:45 AM
ilic committed R883:1525147: Summit gather..
Summit gather.
Sep 23 2018, 11:41 AM
yurchor committed R342:f8b88ccdc1f8: Get rid of unused argument warning (authored by yurchor).
Get rid of unused argument warning
Sep 23 2018, 11:28 AM
zepires committed R883:1525146: Finished HEAD for now.
Finished HEAD for now
Sep 23 2018, 11:27 AM
woltherav committed R157:f13b88ddbbe5: Ensure page areas do not go beyond the page boundaries. (authored by woltherav).
Ensure page areas do not go beyond the page boundaries.
Sep 23 2018, 11:26 AM
woltherav committed R157:cb7e41e3e9b1: Preserve file suffix when copying files into archive. (authored by woltherav).
Preserve file suffix when copying files into archive.
Sep 23 2018, 11:26 AM
woltherav committed R157:dd4363b8dd55: Ensure comicinfo/comet is only read when no acbf file was found. (authored by woltherav).
Ensure comicinfo/comet is only read when no acbf file was found.
Sep 23 2018, 11:26 AM
bellaperez committed R883:1525145: gui: Catalan works.
gui: Catalan works
Sep 23 2018, 11:18 AM
huftis committed R883:1525144: Omsett litt til på QtCurve.
Omsett litt til på QtCurve
Sep 23 2018, 11:16 AM
yurchor committed R342:abf950f02d49: Port away from deprecated KLibrary (authored by yurchor).
Port away from deprecated KLibrary
Sep 23 2018, 11:14 AM
kossebau added a comment to D15532: [Astyle] Add Objective C to list of languages with formatters.

Thanks. Learned about ObjC++ this way... the world is full of strange things :)

Sep 23 2018, 11:12 AM · KDevelop
lueck committed R883:1525143: remove quote tag.
remove quote tag
Sep 23 2018, 11:09 AM
zepires committed R883:1525142: Updates on KDE Frameworks 5 (Trunk) for now.
Updates on KDE Frameworks 5 (Trunk) for now
Sep 23 2018, 11:08 AM
knauss moved T3689: Add abi compliance checker to CI from Awaiting Response to Backlog on the build.kde.org board.

okay made KTextEditor built successfully with the patch D15706.

Sep 23 2018, 11:05 AM · build.kde.org
knauss added a project to D15706: add additional includes to abi-complience-checker.: Sysadmin.
Sep 23 2018, 11:03 AM · Sysadmin
knauss requested review of D15706: add additional includes to abi-complience-checker..
Sep 23 2018, 11:02 AM · Sysadmin
knauss added a revision to T3689: Add abi compliance checker to CI: D15706: add additional includes to abi-complience-checker..
Sep 23 2018, 11:02 AM · build.kde.org
broulik requested review of D15705: Also raise configuration window when reusing it.
Sep 23 2018, 11:01 AM · Frameworks
kossebau added a comment to D15565: Fix bug 389060 (Heaptrack analysis keeps firing /usr/bin/plasmoidviewer).

New version also checks launch configuration type and starts analysis only for native applications.

Sep 23 2018, 10:52 AM · KDevelop
drosca added inline comments to D14774: Add QML Extensions API.
Sep 23 2018, 10:50 AM · Falkon