- Queries
- All Stories
- Search
- Advanced Search
All Stories
Sep 23 2018
Can you rebase this please? It applies cleanly but won't land for some reason.
Still in action. Latest updates (in the make_it_mojo branch) significantly simplify the event-driven logic by moving the event handling in a big huge chain of promise->thens.
In D15694#330503, @kossebau wrote:Yes, needs to be included for such source file, because the min Qt dependency version is still 5.5, and Q_FALLTHROUGH was only introduced in 5.8 (see note at http://doc.qt.io/qt-5/qtglobal.html#Q_FALLTHROUGH)
Sure. This patch was just something I've been using for a while now and found it very useful. So I just put it out there after seeing that rather old bug report from 2003.
Update: Made the bool field private and use getter/setter.
Sry messed up with arc ;)
I updated the diff. Apologies for the last version---it was really messed up.
I'm not really enthusiastic about it -- it presupposes that the only goal of pasting is to transform the paste and merge it with the current layer. If we implement this, users would have to create a new layer and then do the paste and then cancel the transformation if the goal of pasting is to create a new layer.
Thanks for reviewing. I've replied to some of the comments, and fixed the other ones.
- Modified according to review feedback
As mentioned on https://phabricator.kde.org/D15532#330528, text/x-objchdr & text/x-objc++src are MIME types no-where defined from what I saw. Which makes things irritating for future code readers, as well as resulting in annpying warnings in the runtime log.
Please keep those MIME types out of this patch, until that has been resolved.
Closing this, as patch has been abandoned in favour of (landed) D14870
In general this looks good, but I would like two changes:
- Do the conversion to QTest first, and leave out the change for unicode testing (e.g. Title1 -> Title €)
- Add a third column like "stringsuffix", and then add another test (row) for each format. QStringLiteral("Title1") then becomes QStringLiteral("Title1") + stringsuffix
In D15532#326462, @kossebau wrote:Thanks. Learned about ObjC++ this way... the world is full of strange things :)
okay made KTextEditor built successfully with the patch D15706.
New version also checks launch configuration type and starts analysis only for native applications.