well done!

Don't start prompt animation, if user disable animations at all.

In T5382#159464, @filipesaraiva wrote:

For now it is not possible, so that is ok. Maybe we can to open some tasks in backlog column while there are not syntax definitions for it in KSyntaxHighlight.

Or we could create syntax datafile and send pull request. A think, we should mention this option in the tasks. I have spended some time on testing highlighting in this backends - they in good condition, so I think rewriting them on KSyntaxHighlighting is not very priority task (and not very easy: qalqulate use own block highlighting function and kalgebra use highlighter from analitza gui). So, wishlist priority, maybe.

In T5382#159457, @sirgienko wrote:

Well, good job, guys!

In T9564#159462, @filipesaraiva wrote:

In T9564#159448, @sirgienko wrote:

Sage support also another languages, not Python only, as I know. Should we add them highlighting too, or it's impossible?

Hi @sirgienko, I think it is possible because Sage uses R and Maxima (among others) as well, but I don't know if it uses the entire set of keywords/functions/etc of these languages or just a small subset.

Do you have any knowledge about this topic? In fact I am not a Sage user.

In T9564#159448, @sirgienko wrote:

Sage support also another languages, not Python only, as I know. Should we add them highlighting too, or it's impossible?

Well, good job, guys!
But, that we will do with Qalculate and Kalgebra backends? They haven't syntax file, as I see (but we don's support this backends very well, so maybe we could leave it as it is.
And another question: Are we will use KSyntaxHighlighting for the highlighting?
For example, we could use AbstractHighlighter::highlightLine from KSyntaxHighlighting inside DefaultHighlighter, especially in our DefaultHighlighter::highlightBlock function. In this case, hgihtlighting code supported from KSyntaxHighlighting team and we also fix one of our highlighting problem: we can't highlight multiline elements, like multiline strings, comments, etc. (actually, some backends highlighter do multiline hightlighting (MaximaHighlighter::highlightBlock, ScilabHighlighter::highlightBlock, some others backends), but DefaultHighlighter can't do it)

Hi, @filipesaraiva. I have checked your commit(R55:3798dfc44d824b8437bbfd91d047978a833f24ec) and found, that SageHighlighter uses Python keywords.
Sage support also another languages, not Python only, as I know. Should we add them highlighting too, or it's impossible?

@filipesaraiva, GSoC'2017 ended, but this task is still important, so maybe better remove info about GSoC and use the describtion from GSoC task (The main aim of this project...)?

Hi @filipesaraiva
As I see, python backends in this moment works on Python C API (pythonserver.cpp).
So, as I see, this task is duplicate of T6114, isn't it?

Finish this task by c44304870127ffea8f6191b44699bccbfce5a90c

But maybe more simple way is using native autocompletion tools from Python itself. Like we do it in Octave (octavecompletionobject.cpp::35).

As variant, we could use variable model: it alreay stored variable names, unique for each session, and we have api to acess to it from Cantor::Session.

Removed after R55:22fd4479ab02.

Thanks @sirgienko. When I ported to KSyntaxHighlighting the tab completion stopped to work for variables.

Hi, @fililesaraiva.

PythonKeywords::instance()->addVariable(variable);
}

don't good idea, because in this case we store all variables from all Python session in singliton PythonKeywords.
I think, keywords classes should store only session independent data, in our case, from KSyntaxHigligting

R syntax file in (r.xml) in KSyntaxHighlighter not very big, but now we use data from it.

By a151904026aab6b54516c9c6a25904fd73de6aa9

Change member name from isInternal to internal

Highlighting for user-defined variables don't work now, but the realization of this highlighting was wrong (highlighting shared between session). I investigate good way to implement this, and I don't think, that this is related with this task, so I mark this task as "Resolved".

I think, we have a small problem here: as I see, KSyntraxHighlighting don't support Scilab language.
So, we need create syntax file first.

I looked if cmake 3 was available in some stable Linux distribution and it is, so there is no problem for building Cantor for them.

Change flag name from isInternal to internal

This makes sense. But let's unify and simplify the parameter naming a bit and let's call the additional new parameter in the constructor simply "internal". The parameter is called "internal" and the functions to get and to set it are called isInternal() and setInternal(), respectively. This would also be similar to the current naming in Session::setInternal().

In D15012#315802, @asemke wrote:

Should we use system-run for "evaluate worksheet", build-run for "insert command entry" and media-playback-start for "evaluate entry"?

Change the "view-refresh" icon in command entry to "media-playback-start"

In D15012#315778, @filipesaraiva wrote:

In D15012#315092, @asemke wrote:

@filipesaraiva in 6b722430ec6120acef7b99c54a0ed5c607c56bae I set the icon for the "Insert Command Entry" item in the context menu to "run-build". Should we use the same icon, either system-run or run-build, in the context menu to insert an entry and in the action bar to execute it?

I think for this case we need use two different icons because there are two different actions: one action is add a command entry, the other action is run the command entry.

Makes sense.

Nice, it fix the problem while we don't delivery T9513.

In D15012#315092, @asemke wrote:

@filipesaraiva in 6b722430ec6120acef7b99c54a0ed5c607c56bae I set the icon for the "Insert Command Entry" item in the context menu to "run-build". Should we use the same icon, either system-run or run-build, in the context menu to insert an entry and in the action bar to execute it?

The commit R55:9bb6049e4670b3fa2dd0fdedf9802851a2cf01db ported Maxima backend to KSyntaxHighlighting.

A bit late but: thanks @asemke. :)

Update code