In D27035#603375, @davidre wrote:

The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

Tiny mistakes

The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

Whoops I say fixed-in 19.12.2 but that patch is only against master. That bug is probably also in stable and here it comes from straight porting. I will look into it and also submit a patch for 19.12

If it's still something we ship than I think it is better to just change the comment

Remove unrelated change

Fix typo

In D25273#600583, @ngraham wrote:

Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:

Bah we should fix it finally if possible

Also, gross, there are duplicates

In D26840#600618, @brauch wrote:

If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution.

Ping since system theme support is now in frameworks and plasma master can depend on frameworks master

• remove default color scheme, system theme support in kcolorschememanager, also display icons

In D26840#599974, @brauch wrote:

Then it seems like the line is not tagged correctly. Maybe try tagLines(note.position.line(), note.position.line())? I think the column being the same is not what the function being called expects.

Use qApp as context

In D26840#599152, @brauch wrote:

My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is tagged dirty, it gets repainted correctly, but too late.

It seems you're right but updateView doesn't help. The video above is with updateView() calls and slowed down.

In D26840#599082, @brauch wrote:

Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing.

Is it possible that the line (and thus the note) is not properly marked for repaint when the underMouse property changes?

I stumbled upon while doing https://invent.kde.org/kde/kdevelop/merge_requests/92

Now based on 5.18 branch

I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says

<xsd:element name="group" maxOccurs="unbounded" >
                   <xsd:complexType>
                       <xsd:sequence>
                           <xsd:element name="entry" maxOccurs="unbounded">

According to google default of minOccurs is 1 so empty files are indeed not allowed

Update comment

In D26579#596527, @ahmadsamir wrote:

In D26579#596499, @tbaumgart wrote:

Almost. It works on Qt < 5.10 only with the patch below on top of your change. Do you have write access to the KDE repo?

I'd checked the documentation and I know <KRecursiveFilterProxyModel> works with other apps, but indeed it doesn't work here; I tried to figure out why, then gave up after grep'ping in too many cmake files :)

Anyway, added your patch and updated the diff. And yes, I have write access to KDE repo.

arc diff so pending changes is reset

Well it seems I forgot to create the test.ui file...

CMake Error at /home/david/kde/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:56 (message):
   Cannot find ui file:

Doesn't seem right taking a closer look

Output of

cmake_minimum_required(VERSION 2.8.12)
find_package(ECM)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
find_package(Qt5Widgets)
find_package(KF5I18n)
ki18n_wrap_ui(var test.ui)
ki18n_wrap_ui(var test.uia)
ki18n_wrap_ui(${CMAKE_CURRENT_SOURCE_DIR}/test.ui)
ki18n_wrap_ui(/not/existing/path)

with existing test.ui next to CMakeLists.txt:

[...]
CMake Error at /home/david/kde/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:55 (message):
   Cannot find ui file:

Don't change whitespace

Remove debug message

So much easier, thanks Christoph

D26440 introduced state config

target_or_source_var

Sorry for removing you, I had accidentally opened the change subscribers lineedit

For context as I'm not very proficient in CMake this is mostly a copy of D22698

scheme().isEmpty()

In D26555#591131, @The-Feren-OS-Dev wrote:

In D26555#591126, @davidre wrote:

I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes

This is a fix to it happening in real-time in Plasmashell me making this patch is not related to a potential issue with Widget Explorer. However, I could easily edit this patch to retain the nepomuk icons alongside the renamed ones if needed.

I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes