Feed Advanced Search

Jan 30 2020

davidre added a dependency for D27038: [KMessageWidget] Allow the style to change our palette: D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Jan 30 2020, 3:49 PM · Frameworks
davidre added a dependent revision for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet: D27038: [KMessageWidget] Allow the style to change our palette.
Jan 30 2020, 3:49 PM · Frameworks
davidre added a dependency for D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme: D27038: [KMessageWidget] Allow the style to change our palette.
Jan 30 2020, 3:49 PM · Frameworks
davidre added a dependent revision for D27038: [KMessageWidget] Allow the style to change our palette: D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme.
Jan 30 2020, 3:49 PM · Frameworks
davidre updated the test plan for D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme.
Jan 30 2020, 3:49 PM · Frameworks
davidre requested review of D27039: [KStyle] Set the color of KMessageWidgets to the correct one from the current color scheme.
Jan 30 2020, 3:47 PM · Frameworks
davidre requested review of D27038: [KMessageWidget] Allow the style to change our palette.
Jan 30 2020, 3:40 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

Jan 30 2020, 2:55 PM · Frameworks
davidre updated the test plan for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Jan 30 2020, 2:54 PM · Frameworks
davidre updated the diff for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

Tiny mistakes

Jan 30 2020, 2:54 PM · Frameworks
davidre added a comment to D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.

The border radius is slightly different because I copied what Kirigami does for the inner rect but I can also go back to radius 4

Jan 30 2020, 2:48 PM · Frameworks
davidre updated the test plan for D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Jan 30 2020, 2:39 PM · Frameworks
davidre requested review of D27035: [KMessageWidget] Draw it with QPainter instead of using stylesheet.
Jan 30 2020, 2:39 PM · Frameworks
davidre added a comment to D26929: Take screenshot with currently selected options.

Whoops I say fixed-in 19.12.2 but that patch is only against master. That bug is probably also in stable and here it comes from straight porting. I will look into it and also submit a patch for 19.12

Jan 30 2020, 7:55 AM · Spectacle

Jan 29 2020

davidre committed R265:a33675fdb3e4: Don't assume the manager and menu have the same lifetime (authored by davidre).
Don't assume the manager and menu have the same lifetime
Jan 29 2020, 2:39 PM
davidre closed D26848: Don't assume the manager and menu have the same lifetime.
Jan 29 2020, 2:39 PM · Frameworks
davidre committed R166:c2d30612b696: Correctly handle defaultSaveLocation without scheme (authored by davidre).
Correctly handle defaultSaveLocation without scheme
Jan 29 2020, 2:35 PM
davidre closed D26619: Correctly handle defaultSaveLocation without scheme.
Jan 29 2020, 2:35 PM · Spectacle
davidre committed R265:e9ca0991da32: [KColorSchemeManager] Don't list duplicates (authored by davidre).
[KColorSchemeManager] Don't list duplicates
Jan 29 2020, 2:29 PM
davidre closed D26948: [KColorSchemeManager] Don't list duplicates.
Jan 29 2020, 2:29 PM · Frameworks

Jan 27 2020

davidre added a comment to D26951: Remove old code that is not used anymore.

If it's still something we ship than I think it is better to just change the comment

Jan 27 2020, 6:44 PM · Frameworks
davidre requested review of D26951: Remove old code that is not used anymore.
Jan 27 2020, 5:35 PM · Frameworks
davidre committed R118:2d8d17a7b4e6: Enable selecting all installed color schemes in Cuttlefish (authored by davidre).
Enable selecting all installed color schemes in Cuttlefish
Jan 27 2020, 5:08 PM
davidre closed D25273: Enable selecting all installed color schemes in Cuttlefish.
Jan 27 2020, 5:08 PM · Plasma
davidre added a reviewer for D26948: [KColorSchemeManager] Don't list duplicates: Frameworks.
Jan 27 2020, 4:35 PM · Frameworks
davidre requested review of D26948: [KColorSchemeManager] Don't list duplicates.
Jan 27 2020, 4:34 PM · Frameworks
davidre committed R32:9331c48d1044: Use "Color Scheme" instead of "Color Theme" for the menu title (authored by davidre).
Use "Color Scheme" instead of "Color Theme" for the menu title
Jan 27 2020, 9:58 AM
davidre committed R32:4667bac04cfb: Merge branch '5.5' (authored by davidre).
Merge branch '5.5'
Jan 27 2020, 9:55 AM
davidre committed R32:5634d3a8a9f8: Use default scheme option of KColorSchemeManager if available (authored by davidre).
Use default scheme option of KColorSchemeManager if available
Jan 27 2020, 9:53 AM
davidre committed R32:b27d565a85a3: Merge branch '5.5' (authored by davidre).
Merge branch '5.5'
Jan 27 2020, 9:47 AM
davidre committed R32:03bed527b45a: Read the global color scheme name from its file (authored by davidre).
Read the global color scheme name from its file
Jan 27 2020, 9:47 AM

Jan 26 2020

davidre updated the diff for D26929: Take screenshot with currently selected options.

Remove unrelated change

Jan 26 2020, 3:43 PM · Spectacle
davidre requested review of D26929: Take screenshot with currently selected options.
Jan 26 2020, 3:42 PM · Spectacle

Jan 25 2020

davidre updated the diff for D25273: Enable selecting all installed color schemes in Cuttlefish.

Fix typo

Jan 25 2020, 12:26 PM · Plasma
davidre added a comment to D25273: Enable selecting all installed color schemes in Cuttlefish.

Bad combobox width strikes again (https://bugs.kde.org/show_bug.cgi?id=403153), worsened by adding an icon:

Bah we should fix it finally if possible

Also, gross, there are duplicates

Jan 25 2020, 12:24 PM · Plasma
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

If you want I can integrate these changes and submit your patch, should I? Thanks a lot for your contribution.

Jan 25 2020, 8:32 AM · Frameworks, Kate

Jan 24 2020

davidre added a comment to D25273: Enable selecting all installed color schemes in Cuttlefish.

Ping since system theme support is now in frameworks and plasma master can depend on frameworks master

Jan 24 2020, 8:42 PM · Plasma
davidre updated the test plan for D25273: Enable selecting all installed color schemes in Cuttlefish.
Jan 24 2020, 8:37 PM · Plasma
davidre updated the diff for D25273: Enable selecting all installed color schemes in Cuttlefish.
  • remove default color scheme, system theme support in kcolorschememanager, also display icons
Jan 24 2020, 8:36 PM · Plasma
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

Then it seems like the line is not tagged correctly. Maybe try tagLines(note.position.line(), note.position.line())? I think the column being the same is not what the function being called expects.

Jan 24 2020, 6:49 PM · Frameworks, Kate

Jan 23 2020

davidre updated the diff for D26848: Don't assume the manager and menu have the same lifetime.

Use qApp as context

Jan 23 2020, 8:02 PM · Frameworks
davidre added inline comments to D26848: Don't assume the manager and menu have the same lifetime.
Jan 23 2020, 4:06 PM · Frameworks
davidre added inline comments to D26848: Don't assume the manager and menu have the same lifetime.
Jan 23 2020, 3:56 PM · Frameworks
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

My guess is right now the view updates when the cursor blinks, so that's why it updates after a short moment (of varying length, though, if you look at the video). Since the line is tagged dirty, it gets repainted correctly, but too late.


It seems you're right but updateView doesn't help. The video above is with updateView() calls and slowed down.

Jan 23 2020, 2:15 PM · Frameworks, Kate
davidre committed R249:f56f3b211cf9: ki18n_wrap_ui: error when file doesn't exist (authored by davidre).
ki18n_wrap_ui: error when file doesn't exist
Jan 23 2020, 9:59 AM
davidre closed D26670: ki18n_wrap_ui: error when file doesn't exist.
Jan 23 2020, 9:59 AM · Frameworks
davidre committed R166:0cb5e7499c5f: Pass only the path to the file dialog (authored by davidre).
Pass only the path to the file dialog
Jan 23 2020, 9:54 AM
davidre committed R236:2e2f06acac60: [KMessageWidget] Subtract the correct margin (authored by davidre).
[KMessageWidget] Subtract the correct margin
Jan 23 2020, 9:47 AM
davidre closed D26767: [KMessageWidget] Subtract the correct margin.
Jan 23 2020, 9:47 AM · Frameworks

Jan 22 2020

davidre added a reviewer for D26848: Don't assume the manager and menu have the same lifetime: Frameworks.
Jan 22 2020, 6:50 PM · Frameworks
davidre requested review of D26848: Don't assume the manager and menu have the same lifetime.
Jan 22 2020, 6:49 PM · Frameworks
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

Is the video the new behaviour? It still looks a bit weird to me, there is a slight delay between the mouse entering the area and the highlight changing.

Is it possible that the line (and thus the note) is not properly marked for repaint when the underMouse property changes?

Jan 22 2020, 6:19 PM · Frameworks, Kate
davidre added a comment to D26840: Correctly set underMouse() for inline notes.

I stumbled upon while doing https://invent.kde.org/kde/kdevelop/merge_requests/92

Jan 22 2020, 5:41 PM · Frameworks, Kate
davidre added a reviewer for D26840: Correctly set underMouse() for inline notes: KTextEditor.
Jan 22 2020, 1:16 PM · Frameworks, Kate
davidre requested review of D26840: Correctly set underMouse() for inline notes.
Jan 22 2020, 1:14 PM · Frameworks, Kate

Jan 20 2020

davidre committed R103:3a92a573db81: Merge branch 'Plasma/5.18' (authored by davidre).
Merge branch 'Plasma/5.18'
Jan 20 2020, 2:16 PM
davidre committed R103:92bbc4735cbc: Correctly save shortcuts of new Items (authored by davidre).
Correctly save shortcuts of new Items
Jan 20 2020, 2:12 PM
davidre closed D26765: Correctly save shortcuts of new Items.
Jan 20 2020, 2:12 PM · Plasma
davidre updated the diff for D26765: Correctly save shortcuts of new Items.

Now based on 5.18 branch

Jan 20 2020, 1:51 PM · Plasma
davidre updated the summary of D26765: Correctly save shortcuts of new Items.
Jan 20 2020, 1:50 PM · Plasma

Jan 19 2020

davidre added a comment to D26202: Refactor KConfigXT.

I checked https://cgit.kde.org/kconfig.git/tree/src/kconfig_compiler/kcfg.xsd and it says

<xsd:element name="group" maxOccurs="unbounded" >
                   <xsd:complexType>
                       <xsd:sequence>
                           <xsd:element name="entry" maxOccurs="unbounded">

According to google default of minOccurs is 1 so empty files are indeed not allowed

Jan 19 2020, 7:09 PM · Frameworks
davidre updated the task description for T12147: KConfigWidgets.
Jan 19 2020, 4:01 PM · KF6
davidre updated the diff for D26767: [KMessageWidget] Subtract the correct margin.

Update comment

Jan 19 2020, 2:47 PM · Frameworks
davidre edited reviewers for D26767: [KMessageWidget] Subtract the correct margin, added: SGOrava; removed: svuorela.
Jan 19 2020, 2:46 PM · Frameworks
davidre added reviewers for D26767: [KMessageWidget] Subtract the correct margin: Frameworks, svuorela.
Jan 19 2020, 2:45 PM · Frameworks
davidre requested review of D26767: [KMessageWidget] Subtract the correct margin.
Jan 19 2020, 2:44 PM · Frameworks
davidre added reviewers for D26765: Correctly save shortcuts of new Items: Plasma, rikmills.
Jan 19 2020, 1:35 PM · Plasma
davidre requested review of D26765: Correctly save shortcuts of new Items.
Jan 19 2020, 1:35 PM · Plasma

Jan 18 2020

davidre added a comment to D26579: Port KRecursiveFilterProxyModel to QSortFilterProxyModel.

Almost. It works on Qt < 5.10 only with the patch below on top of your change. Do you have write access to the KDE repo?

I'd checked the documentation and I know <KRecursiveFilterProxyModel> works with other apps, but indeed it doesn't work here; I tried to figure out why, then gave up after grep'ping in too many cmake files :)

Anyway, added your patch and updated the diff. And yes, I have write access to KDE repo.

Jan 18 2020, 3:47 PM

Jan 17 2020

davidre updated the diff for D26670: ki18n_wrap_ui: error when file doesn't exist.

arc diff so pending changes is reset

Jan 17 2020, 8:34 PM · Frameworks
davidre added a comment to D26670: ki18n_wrap_ui: error when file doesn't exist.

Well it seems I forgot to create the test.ui file...


Output:

CMake Error at /home/david/kde/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:56 (message):
   Cannot find ui file:
Jan 17 2020, 8:04 PM · Frameworks
davidre planned changes to D26670: ki18n_wrap_ui: error when file doesn't exist.

Doesn't seem right taking a closer look

Jan 17 2020, 7:57 PM · Frameworks
davidre added a comment to D26670: ki18n_wrap_ui: error when file doesn't exist.

Output of

cmake_minimum_required(VERSION 2.8.12)
find_package(ECM)
set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} ${ECM_MODULE_PATH})
find_package(Qt5Widgets)
find_package(KF5I18n)
ki18n_wrap_ui(var test.ui)
ki18n_wrap_ui(var test.uia)
ki18n_wrap_ui(${CMAKE_CURRENT_SOURCE_DIR}/test.ui)
ki18n_wrap_ui(/not/existing/path)

with existing test.ui next to CMakeLists.txt:

[...]
CMake Error at /home/david/kde/lib/x86_64-linux-gnu/cmake/KF5I18n/KF5I18nMacros.cmake:55 (message):
   Cannot find ui file:
Jan 17 2020, 7:55 PM · Frameworks
davidre updated the diff for D26670: ki18n_wrap_ui: error when file doesn't exist.

Don't change whitespace

Jan 17 2020, 7:47 PM · Frameworks
davidre updated the diff for D26670: ki18n_wrap_ui: error when file doesn't exist.

Remove debug message

Jan 17 2020, 7:45 PM · Frameworks
davidre updated the diff for D26670: ki18n_wrap_ui: error when file doesn't exist.

So much easier, thanks Christoph

Jan 17 2020, 7:33 PM · Frameworks

Jan 16 2020

davidre committed R265:a9e1079eba40: [KColorschemeManager] Add option to reenable following global theme (authored by davidre).
[KColorschemeManager] Add option to reenable following global theme
Jan 16 2020, 7:22 PM
davidre closed D25877: [KColorschemeManager] Add option to reenable following global theme.
Jan 16 2020, 7:22 PM · Frameworks
davidre added a comment to T12549: Remove cache data from config files.

D26440 introduced state config

Jan 16 2020, 4:54 PM · KF6

Jan 14 2020

davidre updated the summary of D26670: ki18n_wrap_ui: error when file doesn't exist.
Jan 14 2020, 7:47 PM · Frameworks
davidre added reviewers for D26670: ki18n_wrap_ui: error when file doesn't exist: Framework: Syntax Highlighting, Localization, Build System.
Jan 14 2020, 7:40 PM · Frameworks
davidre requested review of D26670: ki18n_wrap_ui: error when file doesn't exist.
Jan 14 2020, 7:39 PM · Frameworks
davidre committed R166:271644adc93b: Check never by default in rembering region settings (authored by davidre).
Check never by default in rembering region settings
Jan 14 2020, 12:07 PM

Jan 13 2020

davidre committed R237:a601ac563d33: Add since for target variant of kconfig_add_kcfg_files (authored by davidre).
Add since for target variant of kconfig_add_kcfg_files
Jan 13 2020, 7:33 PM
davidre committed R237:82de1ba23483: Include CMakeParseArguments (authored by davidre).
Include CMakeParseArguments
Jan 13 2020, 7:24 PM
davidre committed R237:215986603c0f: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES (authored by davidre).
Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES
Jan 13 2020, 7:20 PM
davidre closed D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.
Jan 13 2020, 7:20 PM · Frameworks
davidre updated the diff for D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.

target_or_source_var

Jan 13 2020, 7:20 PM · Frameworks
davidre updated subscribers of D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.

Sorry for removing you, I had accidentally opened the change subscribers lineedit

Jan 13 2020, 3:21 PM · Frameworks
davidre updated subscribers of D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.

For context as I'm not very proficient in CMake this is mostly a copy of D22698

Jan 13 2020, 3:20 PM · Frameworks
davidre added reviewers for D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES: Frameworks, Build System.
Jan 13 2020, 3:05 PM · Frameworks
davidre requested review of D26626: Allow to also pass a target instead of list of sources to KCONFIG_ADD_KCFG_FILES.
Jan 13 2020, 2:16 PM · Frameworks
davidre updated the diff for D26619: Correctly handle defaultSaveLocation without scheme.

scheme().isEmpty()

Jan 13 2020, 10:07 AM · Spectacle
davidre requested review of D26619: Correctly handle defaultSaveLocation without scheme.
Jan 13 2020, 10:05 AM · Spectacle

Jan 10 2020

davidre committed R119:fc1449991459: [Colors KCM] Only move to next scheme if the selected one is marked for… (authored by davidre).
[Colors KCM] Only move to next scheme if the selected one is marked for…
Jan 10 2020, 1:45 PM
davidre closed D26522: [Colors KCM] Only move to next scheme if the selected one is marked for deletion.
Jan 10 2020, 1:45 PM · Plasma
davidre committed R119:2cac05134dc0: [Colors KCM] Correctly report whether saving is needed (authored by davidre).
[Colors KCM] Correctly report whether saving is needed
Jan 10 2020, 1:44 PM
davidre closed D26526: [Colors KCM] Correctly report whether saving is needed.
Jan 10 2020, 1:44 PM · Plasma

Jan 9 2020

davidre added a comment to D26555: Rename 'nepomuk' Plasma Theme icons to 'search'.

I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes

This is a fix to it happening in real-time in Plasmashell me making this patch is not related to a potential issue with Widget Explorer. However, I could easily edit this patch to retain the nepomuk icons alongside the renamed ones if needed.

Jan 9 2020, 11:14 PM · Frameworks
davidre added a comment to D26555: Rename 'nepomuk' Plasma Theme icons to 'search'.

I still think the proper fix was to investigate why the widget explorer didn't show an icon instead of randomly changing the icon it uses which can have potential impact on other themes

Jan 9 2020, 11:11 PM · Frameworks