Forgot to save file
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Jan 9 2020
Jan 8 2020
@since 5.67
Also provide defaults for the other overloads
In D25883#590433, @kossebau wrote:Do I correctly understand from the previous patches that spectacle should now be single instance application? In that case it might really make more sense to investigate to use the official D-Bus Activation part of the desktop file specification instead of manual D-Bus message sending hackery. That part had been designed for such use cases from what I can tell.
Jan 7 2020
Couldn't we just use wrap the folders from the single image case in a code tag?
<code>QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)</code>
Jan 4 2020
Can we read the correct value manually using the current locale?
Jan 2 2020
Default values
Dec 31 2019
In D23316#585442, @ltoscano wrote:In D23316#583552, @davidre wrote:Landing it now - it's after christmas and I should have time in the next days/week to fix issues that we find.
But then the commit message is incorrect, as it's not FIXED-IN 19.12.
I pushed a few follow-up fixes to the strings introduced by this change here: https://commits.kde.org/spectacle/befcb1748b2a770bce28d3aed0f0b4addd06d622
Dec 29 2019
- note the version in which behavior was changed in the documentation
- constexpr variable for default scheme row
- more comments
Fix test
typo
- Remove function
- Select system scheme on invalid model index
- fix and expand comment
Dec 28 2019
I'm a bit confused. After reading the github issue I thought he meant he couldn't increase the angle to more than 45°. But I understand your request to have a bigger radius. Is that correct?
Dec 27 2019
Landing it now - it's after christmas and I should have time in the next days/week to fix issues that we find.
- Use "Default" as string
- index.row() == 0
Dec 23 2019
Diff against master, somehow this branch is screwed up when using arc
- ervin's comments
- remove unused method declaration
Dec 22 2019
-> updating the title!!!!! !???!!
It's not that wtf like it reads at first. It doesn't read its own name property but of another window that is being screenshotted
In D25877#581355, @kossebau wrote:D15645 tried something similar from what I understood without looking at details, you might want to compare at least :) Sorry, no time myself to look at things currently beyond this comment.
Thanks for the pointer! Looking at that diff what it tried to do was reading the currently active color scheme from kdeglobals. That approach has two problems imo. First it only is correct on Plasma, secondly it sets the wrong scheme when the global color scheme changes. To fix the second issue one could listen to the settings changed signal on DBus but that also only works on Plasma. Just using the standardPalette() is much simpler and more reliable.
But it's not only about Plasma right? KColorScheme can also be used by applications. For example the complementary colors are especially targeted at applications if you read the documentation.
Complementary: I don't think any of these are used.
Quick lxr search, for example:
kdeconnect uses Kirigami.Theme.complementaryTextColor
ktouch uses it
as does kdenlive
Dec 21 2019
remove qdebug
Remove stuff that was just for testing and included in the diff by mistake
remove comment
Nevermind confused myself, I was not changing the UserRole data but the data of the actions of the menu. For that there are no guarantees documented.
Changing the UserRole is not the best
In T12400#214555, @ngraham wrote:Perhaps the solution here is for the Release Service to take care of the Snap and Flatpak packaging to ensure 100% coverage of our apps on both the Snap Store as well as Flathub so they're first-class citizens. Because right now, if I want to replace all my distro-packaged KDE apps with Snap or Flatpak versions, I cannot. The Snap store is missing Dolphin, Discover, Elisa, Filelight, Kamoso, KInfoCenter, Konsole, KSysGuard, and System Settings, and the ones that are there are out of date (there's no 19.12 release, and some are even older). Meanwhile, Flathub is missing Discover, Gwenview, Filelight, Kamoso, Kate, KInfoCenter, Konsole, KSysGuard, Skanlite, Spectacle, and System Settings. And many of the KDE apps on Flathub show the old Oxygen icon instead of the current Breeze icon.
Dec 20 2019
In D26121#580666, @ngraham wrote:Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided:
Not a -1, but I wonder how useful this will be in practice.
However big +1 on adding an "Open containing folder" menu item. Maybe that should be in a separate patch so it can go in quickly and we can discuss the subtitle separately>
In D23316#580467, @guoyunhe wrote:Saving option is broken on my system. Clicking "Save" button throws error "Invalid file name". The default pattern is not saved. I have to go to configuration dialog and click "OK" to save the file name pattern
Do you mean it's not saved in the config file? That's fine, the generated code doesn't write default values to the config file.
I can't reproduce the error with an empty or my spectaclerc. Can you reproduce it? With you current config file or with a new one? If yes, what's your value of saveFilenameFormat?
The default format combobox shows "BMP". But it was "PNG" before. For screenshots, I think "PNG" and "JPEG" are enough. More options bring confusion.
That's because I changed the key in the config file. See the update script
Dec 19 2019
Ping
Is there a way we can move forwards? Do other Applications that use KConfigDialog exhibit this problem, too? If yes maybe it's something to improve at that level. If not we can have a look what they do.
https://lxr.kde.org/ident?_i=KConfigDialog
For example in Okular I even get scrollbars with default settings.
In D26078#579676, @ngraham wrote:+1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead?
This should work for the users. Qt.resolvedUrl will return a url relative to the caller (https://doc.qt.io/qt-5/qml-qtqml-qt.html#resolvedUrl-method). The whole package is installed as is to the user system.
Ping
Dec 18 2019
- Only move to the next theme if the current selected one is marked for deletion
Dec 17 2019
I think this signal is not needed
Don't have a overly long line
- better string
Diff against master
- Reinstate isSaveNeeded
- Fix initial index and pendingDeletion
In D26039#579200, @crossi wrote:Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality.
- At initialization, the current theme is not selected in the grid view.
- When settings a theme for deletion, it does not activate the apply button and the theme is no longer greyed out in the grid view.
In D25807#579144, @trmdi wrote:In D25807#579125, @davidre wrote:I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not available isn't it but rather not available anymore? Maybe I'm understanding the approach taken here wrong?
availableScreenRect = screen_geometry - panels
The approach here is we have availablescreenrect of plasmashell, then latte send another one. The final result is the intersection of all availablescreenrects.
In T11637#214089, @davidedmundson wrote:What's the use-case of doing that?
I don't have a particular use case right now I thought of it during thinking about https://bugs.kde.org/show_bug.cgi?id=415173 . We surely don't want to display a gnome icon in systemsettings. But that can calso be solved by shipping the icon in the repo.
I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not available isn't it but rather not available anymore? Maybe I'm understanding the approach taken here wrong?
Dec 16 2019
One thing I thought about today. KIconLoader/Theme has MatchExact. Using this I can for example get an icon for "start-here-kde-plasma" without falling back to "start-here" which is a foot in Adwaita. I think this is not possible with QIcon
Dec 13 2019
So KConfigWatcher didn't work because the KCM doesn't write with the notify flag. Even if we did we can't depend on a specific version of plasma. Thinking a bit more about this:
Dec 12 2019
Also if then the color scheme is changed while the application is running it would display "Breeze (system default)" checked, breeze dark is unchecked but the app is dark because breeze dark is the global color scheme.
But isn't that going away from the problem that this is trying to solve? To have an option to go back from a fixed colorscheme to the system one.
Also I'm sure it can be done I just need to figure out how stuff works :D
In D25877#576205, @ngraham wrote:Is there actually a way for this to see the name of the system color scheme?
I think so. We can certainly see the name of the system color scheme at startup. The tricky thing is when it changes but I will try to do it.
fix diff
Really fix typo
Typo
Fix things, new api + documentation
Update
Abandoned in favor of D25915
Make it a standalone diff
Maybe a better place to do this would be plasma-integration?