Feed Advanced Search

Jan 9 2020

davidre added a reviewer for D26522: [Colors KCM] Only move to next scheme if the selected one is marked for deletion: Plasma.
Jan 9 2020, 8:53 PM · Plasma
davidre added a reviewer for D26526: [Colors KCM] Correctly report whether saving is needed: Plasma.
Jan 9 2020, 8:53 PM · Plasma

Jan 8 2020

davidre updated the summary of D26526: [Colors KCM] Correctly report whether saving is needed.
Jan 8 2020, 6:51 PM · Plasma
davidre updated the summary of D25877: [KColorschemeManager] Add option to reenable following global theme.
Jan 8 2020, 5:29 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Forgot to save file

Jan 8 2020, 5:05 PM · Frameworks
davidre updated the test plan for D25877: [KColorschemeManager] Add option to reenable following global theme.
Jan 8 2020, 5:04 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

@since 5.67

Jan 8 2020, 5:01 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Also provide defaults for the other overloads

Jan 8 2020, 4:50 PM · Frameworks
davidre added a comment to D25883: Find qdbus command correctly.

Do I correctly understand from the previous patches that spectacle should now be single instance application? In that case it might really make more sense to investigate to use the official D-Bus Activation part of the desktop file specification instead of manual D-Bus message sending hackery. That part had been designed for such use cases from what I can tell.

Jan 8 2020, 4:41 PM · Spectacle
davidre requested review of D26526: [Colors KCM] Correctly report whether saving is needed.
Jan 8 2020, 3:52 PM · Plasma
davidre requested review of D26522: [Colors KCM] Only move to next scheme if the selected one is marked for deletion.
Jan 8 2020, 2:28 PM · Plasma
davidre added inline comments to D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow.
Jan 8 2020, 9:41 AM · Plasma

Jan 7 2020

davidre added a comment to D26483: [wallpapers/image] Add default XDG wallpaper locations for slideshow.

Couldn't we just use wrap the folders from the single image case in a code tag?
<code>QStandardPaths::locateAll(QStandardPaths::GenericDataLocation, QStringLiteral("wallpapers/"), QStandardPaths::LocateDirectory)</code>

Jan 7 2020, 1:54 PM · Plasma

Jan 4 2020

davidre added a comment to T12197: Move KLanguageButton from KConfig -> QSettings.

Can we read the correct value manually using the current locale?

Jan 4 2020, 6:35 PM · KF6

Jan 2 2020

davidre added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Jan 2 2020, 3:32 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Default values

Jan 2 2020, 3:32 PM · Frameworks

Dec 31 2019

davidre added a comment to D23316: Port towards KConfig XT.

Landing it now - it's after christmas and I should have time in the next days/week to fix issues that we find.

But then the commit message is incorrect, as it's not FIXED-IN 19.12.

I pushed a few follow-up fixes to the strings introduced by this change here: https://commits.kde.org/spectacle/befcb1748b2a770bce28d3aed0f0b4addd06d622

Dec 31 2019, 2:48 PM · Spectacle

Dec 29 2019

davidre added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 29 2019, 5:33 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.
  • note the version in which behavior was changed in the documentation
  • constexpr variable for default scheme row
  • more comments
Dec 29 2019, 5:32 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Fix test

Dec 29 2019, 4:04 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

typo

Dec 29 2019, 3:55 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.
  • Remove function
  • Select system scheme on invalid model index
  • fix and expand comment
Dec 29 2019, 3:51 PM · Frameworks
davidre added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 29 2019, 2:02 PM · Frameworks
davidre added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 29 2019, 1:59 PM · Frameworks

Dec 28 2019

davidre added a comment to T12442: Plasma Themes with BIG rounded corners, is it possible?.

I'm a bit confused. After reading the github issue I thought he meant he couldn't increase the angle to more than 45°. But I understand your request to have a bigger radius. Is that correct?

Dec 28 2019, 5:16 PM · Plasma

Dec 27 2019

davidre committed R166:9658891adf82: Port towards KConfig XT (authored by davidre).
Port towards KConfig XT
Dec 27 2019, 2:49 PM
davidre closed D23316: Port towards KConfig XT.
Dec 27 2019, 2:49 PM · Spectacle
davidre added a comment to D23316: Port towards KConfig XT.

Landing it now - it's after christmas and I should have time in the next days/week to fix issues that we find.

Dec 27 2019, 2:49 PM · Spectacle
davidre added inline comments to D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 27 2019, 2:29 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.
  • Use "Default" as string
  • index.row() == 0
Dec 27 2019, 2:29 PM · Frameworks
davidre committed R264:816abe85ad6a: Display fully qualified class/namespace name as page header (authored by davidre).
Display fully qualified class/namespace name as page header
Dec 27 2019, 2:00 PM
davidre closed D26197: Display fully qualified class/namespace name as page header.
Dec 27 2019, 2:00 PM · Documentation, Frameworks

Dec 23 2019

davidre updated the summary of D26197: Display fully qualified class/namespace name as page header.
Dec 23 2019, 8:51 PM · Documentation, Frameworks
davidre updated the test plan for D26197: Display fully qualified class/namespace name as page header.
Dec 23 2019, 8:51 PM · Documentation, Frameworks
davidre updated the test plan for D26197: Display fully qualified class/namespace name as page header.
Dec 23 2019, 8:50 PM · Documentation, Frameworks
davidre requested review of D26197: Display fully qualified class/namespace name as page header.
Dec 23 2019, 8:42 PM · Documentation, Frameworks
davidre closed D26039: [Plasma Style KCM] Add search filter.
Dec 23 2019, 5:28 PM · Plasma
davidre committed R119:b25a0d41985e: [Plasma Style KCM] Add search filter (authored by davidre).
[Plasma Style KCM] Add search filter
Dec 23 2019, 5:28 PM
davidre added inline comments to D26039: [Plasma Style KCM] Add search filter.
Dec 23 2019, 3:06 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.

Diff against master, somehow this branch is screwed up when using arc

Dec 23 2019, 3:06 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.
  • ervin's comments
  • remove unused method declaration
Dec 23 2019, 3:05 PM · Plasma

Dec 22 2019

davidre added a comment to T12413: RFC: Split KWindowSystem into KX11 and KHighLevelWindowStuff.

-> updating the title!!!!! !???!!

It's not that wtf like it reads at first. It doesn't read its own name property but of another window that is being screenshotted

Dec 22 2019, 7:13 PM · KF6
davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

D15645 tried something similar from what I understood without looking at details, you might want to compare at least :) Sorry, no time myself to look at things currently beyond this comment.

Thanks for the pointer! Looking at that diff what it tried to do was reading the currently active color scheme from kdeglobals. That approach has two problems imo. First it only is correct on Plasma, secondly it sets the wrong scheme when the global color scheme changes. To fix the second issue one could listen to the settings changed signal on DBus but that also only works on Plasma. Just using the standardPalette() is much simpler and more reliable.

Dec 22 2019, 2:09 PM · Frameworks
davidre added a comment to T11713: Reorganize colorscheme colors and use them in a logical manner.

But it's not only about Plasma right? KColorScheme can also be used by applications. For example the complementary colors are especially targeted at applications if you read the documentation.

Complementary: I don't think any of these are used.

Quick lxr search, for example:
kdeconnect uses Kirigami.Theme.complementaryTextColor
ktouch uses it
as does kdenlive

Dec 22 2019, 1:44 PM · KDE Human Interface Guidelines, Plasma, Goal: Consistency, VDG, Breeze

Dec 21 2019

davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

remove qdebug

Dec 21 2019, 9:37 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Remove stuff that was just for testing and included in the diff by mistake

Dec 21 2019, 9:35 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

remove comment

Dec 21 2019, 9:33 PM · Frameworks
davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

Nevermind confused myself, I was not changing the UserRole data but the data of the actions of the menu. For that there are no guarantees documented.

Dec 21 2019, 9:32 PM · Frameworks
davidre planned changes to D25877: [KColorschemeManager] Add option to reenable following global theme.

Changing the UserRole is not the best

Dec 21 2019, 9:18 PM · Frameworks
davidre added a comment to T12400: Consider what position KDE Neon should take regarding Flatpak, Snaps, and packages future.

Perhaps the solution here is for the Release Service to take care of the Snap and Flatpak packaging to ensure 100% coverage of our apps on both the Snap Store as well as Flathub so they're first-class citizens. Because right now, if I want to replace all my distro-packaged KDE apps with Snap or Flatpak versions, I cannot. The Snap store is missing Dolphin, Discover, Elisa, Filelight, Kamoso, KInfoCenter, Konsole, KSysGuard, and System Settings, and the ones that are there are out of date (there's no 19.12 release, and some are even older). Meanwhile, Flathub is missing Discover, Gwenview, Filelight, Kamoso, Kate, KInfoCenter, Konsole, KSysGuard, Skanlite, Spectacle, and System Settings. And many of the KDE apps on Flathub show the old Oxygen icon instead of the current Breeze icon.

Dec 21 2019, 7:07 PM · Neon
davidre committed R135:69b756e274cb: Don't set a new palette if the application has a custom color scheme set (authored by davidre).
Don't set a new palette if the application has a custom color scheme set
Dec 21 2019, 2:56 PM
davidre closed D25915: Don't set a new palette if the application has a custom color scheme set.
Dec 21 2019, 2:56 PM · Plasma
davidre committed R124:957c5cf9e44e: Ship plasma-logo in repo (authored by davidre).
Ship plasma-logo in repo
Dec 21 2019, 2:55 PM
davidre closed D26078: Ship plasma-logo in repo.
Dec 21 2019, 2:55 PM · Plasma

Dec 20 2019

davidre added a comment to D26121: Kicker/RecentDocument display file path as decoration.

Hmm, as your screenshot indicates, the subtitle is not very useful because it usually gets elided:

Not a -1, but I wonder how useful this will be in practice.

However big +1 on adding an "Open containing folder" menu item. Maybe that should be in a separate patch so it can go in quickly and we can discuss the subtitle separately>

Dec 20 2019, 5:42 PM · Plasma
davidre added a comment to D23316: Port towards KConfig XT.

Saving option is broken on my system. Clicking "Save" button throws error "Invalid file name". The default pattern is not saved. I have to go to configuration dialog and click "OK" to save the file name pattern

Do you mean it's not saved in the config file? That's fine, the generated code doesn't write default values to the config file.
I can't reproduce the error with an empty or my spectaclerc. Can you reproduce it? With you current config file or with a new one? If yes, what's your value of saveFilenameFormat?

The default format combobox shows "BMP". But it was "PNG" before. For screenshots, I think "PNG" and "JPEG" are enough. More options bring confusion.

That's because I changed the key in the config file. See the update script

Dec 20 2019, 12:55 PM · Spectacle

Dec 19 2019

davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

Ping

Dec 19 2019, 12:52 PM · Frameworks
davidre added a comment to D23316: Port towards KConfig XT.

Is there a way we can move forwards? Do other Applications that use KConfigDialog exhibit this problem, too? If yes maybe it's something to improve at that level. If not we can have a look what they do.
https://lxr.kde.org/ident?_i=KConfigDialog
For example in Okular I even get scrollbars with default settings.

Dec 19 2019, 12:51 PM · Spectacle
davidre added a comment to D26078: Ship plasma-logo in repo.

+1 for the concept, but will this implementation work for users? Should we maybe use the QRC mechanism instead?

This should work for the users. Qt.resolvedUrl will return a url relative to the caller (https://doc.qt.io/qt-5/qml-qtqml-qt.html#resolvedUrl-method). The whole package is installed as is to the user system.

Dec 19 2019, 12:31 PM · Plasma
davidre added a comment to D25915: Don't set a new palette if the application has a custom color scheme set.

Ping

Dec 19 2019, 12:28 PM · Plasma

Dec 18 2019

davidre added reviewers for D26078: Ship plasma-logo in repo: Plasma, GB_2.
Dec 18 2019, 9:19 AM · Plasma
davidre requested review of D26078: Ship plasma-logo in repo.
Dec 18 2019, 9:18 AM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.
  • Only move to the next theme if the current selected one is marked for deletion
Dec 18 2019, 8:40 AM · Plasma

Dec 17 2019

davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.

I think this signal is not needed

Dec 17 2019, 2:03 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.

Don't have a overly long line

Dec 17 2019, 1:59 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.
  • better string
Dec 17 2019, 1:54 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.

Diff against master

Dec 17 2019, 1:52 PM · Plasma
davidre updated the diff for D26039: [Plasma Style KCM] Add search filter.
  • Reinstate isSaveNeeded
  • Fix initial index and pendingDeletion
Dec 17 2019, 1:50 PM · Plasma
davidre added a comment to D26039: [Plasma Style KCM] Add search filter.

Some concern here as I tested the patch. The filter is working but the implementation breaks some functionality.

  • At initialization, the current theme is not selected in the grid view.
  • When settings a theme for deletion, it does not activate the apply button and the theme is no longer greyed out in the grid view.
Dec 17 2019, 1:07 PM · Plasma
davidre added a comment to D25807: Allow to set the available screen rect/region from outside through dbus.

I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not available isn't it but rather not available anymore? Maybe I'm understanding the approach taken here wrong?

availableScreenRect = screen_geometry - panels

https://api.kde.org/frameworks/plasma-framework/html/classPlasma_1_1Corona.html#ad8ffd115128a128efd830540eeba5dd1

The approach here is we have availablescreenrect of plasmashell, then latte send another one. The final result is the intersection of all availablescreenrects.

Dec 17 2019, 10:26 AM · Plasma
davidre added a comment to T11637: KIconThemes Cleanups.

What's the use-case of doing that?

I don't have a particular use case right now I thought of it during thinking about https://bugs.kde.org/show_bug.cgi?id=415173 . We surely don't want to display a gnome icon in systemsettings. But that can calso be solved by shipping the icon in the repo.

Dec 17 2019, 10:21 AM · KF6
davidre added a comment to D25807: Allow to set the available screen rect/region from outside through dbus.

I have a question about naming. If I had an application like panel or latte I would call setAvailableScreenRect? That seems kinda backwards to me? That part of the screen is not available isn't it but rather not available anymore? Maybe I'm understanding the approach taken here wrong?

Dec 17 2019, 8:34 AM · Plasma

Dec 16 2019

davidre added a comment to T11637: KIconThemes Cleanups.

One thing I thought about today. KIconLoader/Theme has MatchExact. Using this I can for example get an icon for "start-here-kde-plasma" without falling back to "start-here" which is a foot in Adwaita. I think this is not possible with QIcon

Dec 16 2019, 9:50 PM · KF6
davidre accepted D26013: [KeySequenceHelper] Grab actual window when embedded.
Dec 16 2019, 12:58 PM · Frameworks
davidre updated the test plan for D26039: [Plasma Style KCM] Add search filter.
Dec 16 2019, 8:42 AM · Plasma
davidre requested review of D26039: [Plasma Style KCM] Add search filter.
Dec 16 2019, 8:42 AM · Plasma

Dec 13 2019

davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

So KConfigWatcher didn't work because the KCM doesn't write with the notify flag. Even if we did we can't depend on a specific version of plasma. Thinking a bit more about this:

Dec 13 2019, 2:11 PM · Frameworks

Dec 12 2019

davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

Also if then the color scheme is changed while the application is running it would display "Breeze (system default)" checked, breeze dark is unchecked but the app is dark because breeze dark is the global color scheme.

Dec 12 2019, 3:49 PM · Frameworks
davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

But isn't that going away from the problem that this is trying to solve? To have an option to go back from a fixed colorscheme to the system one.
Also I'm sure it can be done I just need to figure out how stuff works :D

Dec 12 2019, 3:46 PM · Frameworks
davidre added a comment to D25877: [KColorschemeManager] Add option to reenable following global theme.

Is there actually a way for this to see the name of the system color scheme?

I think so. We can certainly see the name of the system color scheme at startup. The tricky thing is when it changes but I will try to do it.

Dec 12 2019, 2:33 PM · Frameworks
davidre added a task to D25877: [KColorschemeManager] Add option to reenable following global theme: T12147: KConfigWidgets.
Dec 12 2019, 2:11 PM · Frameworks
davidre added a revision to T12147: KConfigWidgets: D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 12 2019, 2:11 PM · KF6
davidre updated the diff for D25919: Add open containing folder action.

fix diff

Dec 12 2019, 2:07 PM · Plasma
davidre requested review of D25919: Add open containing folder action.
Dec 12 2019, 2:00 PM · Plasma
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Really fix typo

Dec 12 2019, 12:28 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Typo

Dec 12 2019, 12:22 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Fix things, new api + documentation

Dec 12 2019, 12:20 PM · Frameworks
davidre updated the diff for D25877: [KColorschemeManager] Add option to reenable following global theme.

Update

Dec 12 2019, 11:18 AM · Frameworks
davidre committed R252:f583ae9eed99: We don't need xcb anymore (authored by davidre).
We don't need xcb anymore
Dec 12 2019, 11:03 AM
davidre committed R252:9fc5bade9c26: Remove ColorSchemeFilter from KStyle (authored by davidre).
Remove ColorSchemeFilter from KStyle
Dec 12 2019, 10:41 AM
davidre closed D25914: Remove ColorSchemeFilter from KStyle.
Dec 12 2019, 10:41 AM · Frameworks
davidre updated the test plan for D25915: Don't set a new palette if the application has a custom color scheme set.
Dec 12 2019, 10:40 AM · Plasma
davidre abandoned D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.

Abandoned in favor of D25915

Dec 12 2019, 10:39 AM · Frameworks
davidre requested review of D25915: Don't set a new palette if the application has a custom color scheme set.
Dec 12 2019, 10:38 AM · Plasma
davidre requested review of D25914: Remove ColorSchemeFilter from KStyle.
Dec 12 2019, 10:24 AM · Frameworks
davidre planned changes to D25877: [KColorschemeManager] Add option to reenable following global theme.

Make it a standalone diff

Dec 12 2019, 10:20 AM · Frameworks
davidre updated the test plan for D25877: [KColorschemeManager] Add option to reenable following global theme.
Dec 12 2019, 10:20 AM · Frameworks
davidre updated the test plan for D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.
Dec 12 2019, 10:19 AM · Frameworks
davidre added a comment to D25875: [KColorschemeManager] Prevent changes to the palette if a custom one is set.

Maybe a better place to do this would be plasma-integration?

Dec 12 2019, 9:32 AM · Frameworks

Dec 11 2019

davidre committed R118:0749b511550b: Remove unused action (authored by davidre).
Remove unused action
Dec 11 2019, 3:20 PM