Don't start if we are in config mode

Disable selecting the wallpaper in slideshow configuration

I guess one drawback is that you have to reindex all the files when the sort mode is changed.

In D22121#491833, @davidedmundson wrote:

Nate's crash is due to data not code.

for (int i = 0; i < m_packages.size(); i++) {
    QString package = m_packages[i].path();
    if (package.at(package.length() - 1) == QChar::fromLatin1('/')) {   <--- you know you crash on this line

we're calling .at(length -1) unconditionally

For an empty string our index will be -1.

This hints towards an insertion bug rather than saying we should just add a guard here.

Yes, I briefly thought about something like a whitelist myself. But of course having an idea and realizing it are two different things. And this solution would probably also come with its own difficulties. But it would be awesome if we could do something similar.

In D22121#490983, @ngraham wrote:

I still get the same crash. :(

• Sort case insensitive

I couldm't crash it by clicking apply but noticed some type errors because the proxymodel
din't have all the functionality of the underlying model.

Weird. I can't get it to crash at all but I will look at and think about it.

• Bool is now other way around

• Don't invalidate if we are in the config view and the mode is set to random

• Use the same condition

• remove unused includes
• Use an enum

• restore window title

• minor comments

I never did this before, but let's try it.

I understand and accept your points

But there are ways to circumvent this. For example if I were a malicious program I could just call the variant that doesn't take a file descriptor and saves to /tmp and then read the file from there.

Yes

Same when trying to build spectacle with libkimageannotator. I guess I'm doing something wrong?

Hmm I can only get libkimageannotator to build when kcolorpicker is installed to /usr/local not into my prefix. Otherwise cmake finds it but the headers aren't found during the build. Maybe we would have to invest time into bringing it's cmake files up to par?

In D22148#488089, @nicolasfella wrote:

It works for me.

Why don't we support timeouts on Wayland? Is there anything fundamental blocking it?

Ah I forgot a word there.
I wanted to say don't change the current order if the sort order is switched to random. And when opened and the current mode is random whatever.
Displaying the order for the other modes is quite good I think.

In D22121#488479, @ngraham wrote:

That fixed my crash, yay!

I see a UX issues with the Random mode though: since the list re-sorts itself randomly, it becomes harder to locale any given wallpaper in there (say, for the purposes of unchecking it). Also, when you scroll all the way to the bottom and then back up to the top, the order has changed to a new random order. While you're scrolling, the delegates are visible changing before your eyes. It's all a bit odd.

I wonder if in the Random mode, we should just keep the view sorted alphabetically?

In D21651#488255, @felixernst wrote:

I would agree with that but the UI only allows for integer values as a timeout right now.

You can type in non-integer values

Looks good to me. I have just one more idea.
When you were to configure 4.5 seconds it would show 5 for half a second then 4.
Maybe we could something like min(int(timeout), ceil(...)).
@felixernst What do you think?

In D22033#488123, @zzag wrote:

It seems like that's intentional

This allows to pick a point on the screen which we need to screenshot the screen under the mouse cursor and in future for color picking.

f9f7b84cb4361522c8fef7a32187df1751bc0860

• add my copyright

• String changes and remove debug statement

Sort only if a sortmode has been specified

ExortManager::defaultSaveLocation() is used in formatFilename() where the QString is used to create a QDir from it. In formatFilename() the placeholders are replaced by the respective values. For doing the counting of filenames we check if their are already files in the directory we save to that look like the current filename format. Because toString() includes the protocol this didn't work. If you set your filename template to image%1d.png and press save twice these are the resulting filenames:

• Without this patch: image1.png, image1-1.png (Because the lookup didn't work and to avoid overwriting a file a "-1" is appended)
• WIth this patch image1.png, image2.png

Friendly ping my change is now pushed

In D19310#484762, @siddharthasahu wrote:

No problem! I noticed 2 other things:

• All shortcuts for "Spectacle" in "Application Launchers" section appear twice.

If you don't delete the spectacle.khotkeys inside /usr/share/khotkeys/ (depends on your distro) I think you would have entries inside both KDE Daemon and Spectacle categories.
But it could also be related because GlobalAccel can't map the actions to the desktop file.

• Starting "Capture Rectangular Region" using the assigned shortcut does perform the action, but capturing the screenshot silently saves the file and exits. Before, it used to give a notification.

I will have a look, there was a recent refactor that changed how that mode workes maybe that broke. But anyways it shouldn't be to hard to fix.

Are these potentially related? I can do a git bisect at a later time.

Thanks again for your time.

In D19310#484701, @siddharthasahu wrote:

Looks like a copy-paste bug.

What about the systray? Quick hack: