Feed Advanced Search

Jan 4 2022

gjditchfield closed T12270: Use hierarchical dptrs in KCalendarCore::Incidence classes as Resolved.
Jan 4 2022, 8:37 PM · KF6
gjditchfield moved T12270: Use hierarchical dptrs in KCalendarCore::Incidence classes from In Progress to Done on the KF6 board.
Jan 4 2022, 7:40 PM · KF6

Nov 22 2021

gjditchfield moved T12270: Use hierarchical dptrs in KCalendarCore::Incidence classes from Waiting on KF6 Branching to In Progress on the KF6 board.
Nov 22 2021, 9:43 PM · KF6

Nov 13 2021

gjditchfield updated the task description for T14217: Clean up KCalendarCore::Calendar.
Nov 13 2021, 10:57 PM · KF6

Nov 11 2021

gjditchfield added a comment to T12270: Use hierarchical dptrs in KCalendarCore::Incidence classes.

See https://invent.kde.org/frameworks/kcalendarcore/-/merge_requests/60

Nov 11 2021, 10:18 PM · KF6

Sep 27 2021

gjditchfield updated the task description for T14217: Clean up KCalendarCore::Calendar.
Sep 27 2021, 7:33 PM · KF6

Sep 26 2021

gjditchfield added a comment to T14217: Clean up KCalendarCore::Calendar.
In T14217#263949, @alex wrote:

Would there be reasons why one would want to have an unsigned int?

Sep 26 2021, 3:52 PM · KF6
gjditchfield removed a project from T14217: Clean up KCalendarCore::Calendar: Heaptrack.
Sep 26 2021, 3:17 PM · KF6

Sep 25 2021

gjditchfield added a project to T14217: Clean up KCalendarCore::Calendar: Heaptrack.
Sep 25 2021, 9:17 PM · KF6

Sep 24 2021

gjditchfield added a comment to T14217: Clean up KCalendarCore::Calendar.

"Hoping" would be a better word than "planning".

Sep 24 2021, 3:50 PM · KF6

Apr 25 2021

gjditchfield added a project to T1018: Replace QRegExp by QRegularExpression.: KDE PIM: Junior Jobs.
Apr 25 2021, 4:53 PM · KDE PIM: Junior Jobs, KDE PIM
gjditchfield closed T14202: Deleting recurring instances that have dissociated instances causes errors as Resolved.
Apr 25 2021, 4:18 PM · KDE PIM

Mar 22 2021

gjditchfield created T14217: Clean up KCalendarCore::Calendar.
Mar 22 2021, 3:49 PM · KF6

Mar 21 2021

gjditchfield added a comment to T14202: Deleting recurring instances that have dissociated instances causes errors.

Note:

Mar 21 2021, 2:39 AM · KDE PIM

Mar 16 2021

gjditchfield created T14202: Deleting recurring instances that have dissociated instances causes errors.
Mar 16 2021, 2:48 PM · KDE PIM

Jun 11 2020

gjditchfield committed R172:9253ee6bb884: Merge branch 'iconName' into 'master' (authored by gjditchfield).
Merge branch 'iconName' into 'master'
Jun 11 2020, 5:59 AM
gjditchfield committed R173:d32198b13186: Merge branch 'toolTipStr' into 'master' (authored by gjditchfield).
Merge branch 'toolTipStr' into 'master'
Jun 11 2020, 3:57 AM

Jun 10 2020

gjditchfield committed R172:be69f7991b14: Merge branch 'fix345498' into 'master' (authored by gjditchfield).
Merge branch 'fix345498' into 'master'
Jun 10 2020, 9:05 PM
gjditchfield committed R172:dc7b1865c3bf: Fix serialization of recurring to-do's start date (authored by gjditchfield).
Fix serialization of recurring to-do's start date
Jun 10 2020, 9:05 PM
gjditchfield committed R172:6a08cbff8c08: Merge branch 'iconName' into 'master' (authored by gjditchfield).
Merge branch 'iconName' into 'master'
Jun 10 2020, 9:05 PM
gjditchfield committed R172:d02df83adce0: Add more tests for Recurrence::getNextDayTime(QDateTime) (authored by gjditchfield).
Add more tests for Recurrence::getNextDayTime(QDateTime)
Jun 10 2020, 2:53 PM
gjditchfield committed R172:2a1ffb657f48: Fix serialization of recurring to-do's start date (authored by gjditchfield).
Fix serialization of recurring to-do's start date
Jun 10 2020, 2:53 PM
gjditchfield committed R172:2727f9308094: Correct icon names for recurring to-dos (authored by gjditchfield).
Correct icon names for recurring to-dos
Jun 10 2020, 2:53 PM
gjditchfield committed R172:14b12d999b8c: Add more tests for Recurrence::getNextDayTime(QDateTime) (authored by gjditchfield).
Add more tests for Recurrence::getNextDayTime(QDateTime)
Jun 10 2020, 2:53 PM
gjditchfield committed R172:317276737b3a: Merge branch 'getNextDayTime' into 'master' (authored by gjditchfield).
Merge branch 'getNextDayTime' into 'master'
Jun 10 2020, 2:53 PM
gjditchfield committed R172:26fd0dbfe784: Merge branch 'fix345498' into 'master' (authored by gjditchfield).
Merge branch 'fix345498' into 'master'
Jun 10 2020, 2:53 PM
gjditchfield committed R172:de38c04885a5: Fix serialization of recurring to-do's start date (authored by gjditchfield).
Fix serialization of recurring to-do's start date
Jun 10 2020, 2:53 PM
gjditchfield committed R172:61b5c0fe69dd: Merge branch 'iconName' into 'master' (authored by gjditchfield).
Merge branch 'iconName' into 'master'
Jun 10 2020, 2:53 PM
gjditchfield committed R172:eb348406c973: Correct icon names for recurring to-dos (authored by gjditchfield).
Correct icon names for recurring to-dos
Jun 10 2020, 2:53 PM
gjditchfield committed R173:4a3b0c634c8a: Merge branch 'allday' into 'master' (authored by gjditchfield).
Merge branch 'allday' into 'master'
Jun 10 2020, 2:02 PM
gjditchfield committed R173:83e65f646f3e: Remove time-of-day from Event Viewer display of all-day to-dos. (authored by gjditchfield).
Remove time-of-day from Event Viewer display of all-day to-dos.
Jun 10 2020, 2:02 PM
gjditchfield committed R173:e8bed3de2ae3: Merge branch 'allday' into 'release/20.04' (authored by gjditchfield).
Merge branch 'allday' into 'release/20.04'
Jun 10 2020, 2:02 PM
gjditchfield committed R173:4c8984945aa8: Remove time-of-day from Event Viewer display of all-day to-dos (authored by gjditchfield).
Remove time-of-day from Event Viewer display of all-day to-dos
Jun 10 2020, 2:02 PM
gjditchfield committed R173:d3961cd7bed3: Merge branch 'toolTipStr' into 'master' (authored by gjditchfield).
Merge branch 'toolTipStr' into 'master'
Jun 10 2020, 2:02 PM
gjditchfield committed R173:51fc4cc8e4a4: Merge branch 'release/20.04' into 'master' (authored by gjditchfield).
Merge branch 'release/20.04' into 'master'
Jun 10 2020, 2:02 PM
gjditchfield committed R173:3eb42a7f72fb: Merge Request feddback: better i18n for RTL languages; coding style (authored by gjditchfield).
Merge Request feddback: better i18n for RTL languages; coding style
Jun 10 2020, 2:02 PM
gjditchfield committed R173:1ae4d55c51e7: Improve tool tips for to-dos (authored by gjditchfield).
Improve tool tips for to-dos
Jun 10 2020, 2:02 PM
gjditchfield committed R173:41b06e4747b7: Change include name to one Jenkins may understand (authored by gjditchfield).
Change include name to one Jenkins may understand
Jun 10 2020, 2:02 PM

May 28 2020

gjditchfield committed R173:dfb902db7dd0: Merge remote-tracking branch 'remotes/origin/release/20.04' (authored by gjditchfield).
Merge remote-tracking branch 'remotes/origin/release/20.04'
May 28 2020, 4:34 PM
gjditchfield committed R173:715a0b0cf09d: Merge branch 'master' of https://invent.kde.org/pim/kcalutils (authored by gjditchfield).
Merge branch 'master' of https://invent.kde.org/pim/kcalutils
May 28 2020, 4:34 PM

May 27 2020

gjditchfield committed R173:c12e9b3709d3: Remove time-of-day from Event Viewer display of all-day to-dos (authored by gjditchfield).
Remove time-of-day from Event Viewer display of all-day to-dos
May 27 2020, 5:15 PM

May 22 2020

gjditchfield abandoned D29698: Fix autotest koeventpopupmenutest.
May 22 2020, 6:21 PM · KDE PIM

May 13 2020

gjditchfield added inline comments to D29698: Fix autotest koeventpopupmenutest.
May 13 2020, 8:27 PM · KDE PIM
gjditchfield updated the summary of D29698: Fix autotest koeventpopupmenutest.
May 13 2020, 4:54 PM · KDE PIM
gjditchfield added inline comments to D29698: Fix autotest koeventpopupmenutest.
May 13 2020, 3:48 PM · KDE PIM
gjditchfield requested review of D29698: Fix autotest koeventpopupmenutest.
May 13 2020, 2:01 AM · KDE PIM

May 9 2020

gjditchfield committed R94:528d6d69d9bc: Replace QRegExp with QRegularExpression (authored by gjditchfield).
Replace QRegExp with QRegularExpression
May 9 2020, 8:07 PM
gjditchfield closed D29241: Replace QRegExp with QRegularExpression.
May 9 2020, 8:07 PM · KDE PIM

May 2 2020

gjditchfield closed D29298: Clean up kmime README.md.
May 2 2020, 11:46 PM · KDE PIM
gjditchfield committed R180:7f42d8b9bf58: Clean up kmime README.md (authored by gjditchfield).
Clean up kmime README.md
May 2 2020, 11:46 PM

Apr 30 2020

gjditchfield requested review of D29298: Clean up kmime README.md.
Apr 30 2020, 2:13 PM · KDE PIM

Apr 27 2020

gjditchfield requested review of D29241: Replace QRegExp with QRegularExpression.
Apr 27 2020, 10:18 PM · KDE PIM

Dec 21 2019

gjditchfield added inline comments to D26119: Port QRegExp to QRegularExpression.
Dec 21 2019, 8:39 PM · KDE PIM

Oct 27 2019

gjditchfield committed R94:ff67fd851586: Remove some warnings about unused return values. (authored by gjditchfield).
Remove some warnings about unused return values.
Oct 27 2019, 4:30 PM
gjditchfield closed D24709: Remove some warnings about unused return values..
Oct 27 2019, 4:30 PM · KDE PIM

Oct 25 2019

gjditchfield updated the diff for D24709: Remove some warnings about unused return values..

Changes based on review comments

Oct 25 2019, 8:03 PM · KDE PIM

Oct 23 2019

gjditchfield accepted D24891: Fix nullptr dereference when replying to emails without a CC header.
Oct 23 2019, 7:05 PM · KDE PIM

Oct 16 2019

gjditchfield added a comment to D24709: Remove some warnings about unused return values..

I don't know the rules for changing interfaces.

Oct 16 2019, 8:31 PM · KDE PIM
gjditchfield committed R94:7763a47b49fc: Add Mail-Reply-To and Mail-Followup-To support to the ReplyAll strategy (authored by gjditchfield).
Add Mail-Reply-To and Mail-Followup-To support to the ReplyAll strategy
Oct 16 2019, 7:27 PM
gjditchfield closed D24624: Add Mail-Reply-To and Mail-Followup-To support to the ReplyAll strategy.
Oct 16 2019, 7:27 PM · KDE PIM
gjditchfield requested review of D24709: Remove some warnings about unused return values..
Oct 16 2019, 7:24 PM · KDE PIM

Oct 14 2019

gjditchfield updated the summary of D24624: Add Mail-Reply-To and Mail-Followup-To support to the ReplyAll strategy.
Oct 14 2019, 2:50 AM · KDE PIM
gjditchfield requested review of D24624: Add Mail-Reply-To and Mail-Followup-To support to the ReplyAll strategy.
Oct 14 2019, 2:26 AM · KDE PIM

Oct 11 2019

gjditchfield abandoned D24504: Add Mail-Reply-To and reply-to-self support to the ReplyAll strategy.

I'm going to add Mail-Followup-To handling to ReplyAll, and the changes are bigger than I expected. This isn't worth reviewing.

Oct 11 2019, 4:46 PM · KDE PIM

Oct 8 2019

gjditchfield requested review of D24504: Add Mail-Reply-To and reply-to-self support to the ReplyAll strategy.
Oct 8 2019, 8:28 PM · KDE PIM
gjditchfield committed R180:aa13f0d66db0: Remove warnings about ignoring return value of removeHeader() (authored by gjditchfield).
Remove warnings about ignoring return value of removeHeader()
Oct 8 2019, 2:06 PM
gjditchfield closed D24484: Remove warnings about ignoring return value of removeHeader().
Oct 8 2019, 2:06 PM · KDE PIM
gjditchfield requested review of D24484: Remove warnings about ignoring return value of removeHeader().
Oct 8 2019, 2:54 AM · KDE PIM
gjditchfield closed D24481: Add Mail-Reply-To support to the ReplyAuthor and ReplySmart strategies.
Oct 8 2019, 12:02 AM · KDE PIM
gjditchfield committed R94:76adc30c4754: Add Mail-Reply-To support to the ReplyAuthor and ReplySmart strategies (authored by gjditchfield).
Add Mail-Reply-To support to the ReplyAuthor and ReplySmart strategies
Oct 8 2019, 12:02 AM

Oct 7 2019

gjditchfield requested review of D24481: Add Mail-Reply-To support to the ReplyAuthor and ReplySmart strategies.
Oct 7 2019, 9:36 PM · KDE PIM

Oct 2 2019

gjditchfield added a comment to M155: KMail revamped.

Bugzilla has a number of wishlist requests for a tabbed view; see https://bugs.kde.org/show_bug.cgi?id=117808. I was surprised to find out that KMail already has one! I'd bet I'm not alone. It is accessed through View →Message List → Create New Tab, which is somewhat obscure. Could a new design make the feature's existence more obvious?

Oct 2 2019, 2:03 PM · KDE PIM

Sep 30 2019

gjditchfield committed R94:c42d6ef2dbab: Ignore Reply-To when replying to your own messages (authored by gjditchfield).
Ignore Reply-To when replying to your own messages
Sep 30 2019, 10:31 PM
gjditchfield closed D24302: Ignore Reply-To when replying to your own messages.
Sep 30 2019, 10:31 PM · KDE PIM
gjditchfield added a comment to D24302: Ignore Reply-To when replying to your own messages.

I agree that KMail should support Mail-Reply-To, and it is on my to-do list.

Sep 30 2019, 8:32 PM · KDE PIM
gjditchfield updated the summary of D24302: Ignore Reply-To when replying to your own messages.
Sep 30 2019, 8:28 PM · KDE PIM

Sep 29 2019

gjditchfield requested review of D24302: Ignore Reply-To when replying to your own messages.
Sep 29 2019, 9:15 PM · KDE PIM

Sep 28 2019

gjditchfield added a comment to D24035: Fix reported bug about replies to self.

No, I don't have commit access, and given my likely commit rate and weak understanding of your work flow (should I wait for mlaurent?), I'm comfortable with that. Whatever keeps your workload lowest...

Sep 28 2019, 10:11 PM · KDE PIM

Sep 25 2019

gjditchfield added inline comments to D24035: Fix reported bug about replies to self.
Sep 25 2019, 4:22 PM · KDE PIM

Sep 23 2019

gjditchfield added an inline comment to M155: KMail revamped.
Sep 23 2019, 2:11 PM · KDE PIM
gjditchfield added an inline comment to M155: KMail revamped.
Sep 23 2019, 1:45 PM · KDE PIM

Sep 18 2019

gjditchfield updated the diff for D24035: Fix reported bug about replies to self.

In ReplyStrategyTest:

  • initTestCase() deletes emailidentities and emaildefaults, not .qttest.
  • uses reference parameters.
  • corrected coding style.
Sep 18 2019, 6:14 PM · KDE PIM

Sep 17 2019

gjditchfield requested review of D24035: Fix reported bug about replies to self.
Sep 17 2019, 8:20 PM · KDE PIM

Aug 26 2019

gjditchfield added a comment to D23396: fix(mimetreeparser): Make it possible to distinguish different encrypted/signed message parts..

Oh, joy.
I ran "ctest -R rendertest -V | grep FAIL" a bunch of times. I always get 5 failures of testRenderSmart, testRenderInlined, testRenderIconic, testRenderHidden, and testRenderHeaderOnly when they process openpgp-inline-multiple.mbox. Sometimes those tests fail when processing openpgp-encrypted-no-text-attachment.mbox.

Aug 26 2019, 1:32 AM · KDE PIM

Aug 25 2019

gjditchfield added a comment to D23396: fix(mimetreeparser): Make it possible to distinguish different encrypted/signed message parts..

This doesn't fix rendertest in my kdepim docker. With the patch applied, RenderTest::testRenderIconic(openpgp-encrypted-no-text-attachment.mbox) now passes. However, RenderTest::testRenderInlined(openpgp-encrypted-no-text-attachment.mbox), which used to pass, now fails.

Aug 25 2019, 8:18 PM · KDE PIM

Aug 23 2019

gjditchfield abandoned D23167: Test grantleeheaderstyle's formatting of spamassassin headers.

Yay!

Aug 23 2019, 2:20 PM · KDE PIM
gjditchfield abandoned D23165: Fix CI failure in autotest grantleeheaderstyletest.

Yay!

Aug 23 2019, 2:19 PM · KDE PIM

Aug 19 2019

gjditchfield requested review of D23252: Fix kdepim-addons autotest EnterpriseHeaderStylePluginTest.
Aug 19 2019, 2:54 AM · KDE PIM

Aug 15 2019

gjditchfield requested review of D23167: Test grantleeheaderstyle's formatting of spamassassin headers.
Aug 15 2019, 1:41 AM · KDE PIM
gjditchfield requested review of D23165: Fix CI failure in autotest grantleeheaderstyletest.
Aug 15 2019, 1:29 AM · KDE PIM

Aug 8 2019

gjditchfield requested review of D23017: Fix another failure in autotest rendertest.
Aug 8 2019, 1:01 AM · KDE PIM

Aug 6 2019

gjditchfield requested review of D22959: Fix some failures in autotest rendertest.
Aug 6 2019, 1:48 AM · KDE PIM

Aug 5 2019

gjditchfield requested review of D22938: Fix segmentation fault in autotest ViewerGrantleeThemeSupportTest.
Aug 5 2019, 2:21 AM · KDE PIM
gjditchfield requested review of D22937: Fix failing autotest FollowupReminderSelectDateDialogTest.
Aug 5 2019, 1:47 AM · KDE PIM

Aug 2 2019

gjditchfield requested review of D22900: Fix failing autotest grantleeheaderformattertest.
Aug 2 2019, 4:39 PM · KDE PIM
gjditchfield requested review of D22892: Fix failing autotest grantleeheaderstyletest.
Aug 2 2019, 1:31 PM · KDE PIM

Aug 1 2019

gjditchfield added a comment to D22779: Fix a segmentation fault in autotest messagefactoryngtest.

I don't have a developer account. Could someone else land this?

Aug 1 2019, 3:56 PM · KDE PIM

Jul 30 2019

gjditchfield requested review of D22828: Fix failures in autotest templateparserjobtest.
Jul 30 2019, 1:54 PM · KDE PIM

Jul 27 2019

gjditchfield requested review of D22779: Fix a segmentation fault in autotest messagefactoryngtest.
Jul 27 2019, 2:44 PM · KDE PIM