Really there is something wrong with Qt5::Keychain libraries => no need to write (Findo2.cmake)module for finding o2 package, by default, it is able to find it(since o2 libraries are built with cmake only) and our cmake is unable to link qt5Keychain which is dependency of o2

• Make OAuth as optional

• Create Findo2.cmake file

• Modify code acrdg to comments

• Add 'o2' static library path as Item

/usr/bin/ld: cannot find -lQt5::Keychain

• Modify the code (D10154)
• Take o2 as external lib

when I try to build Qt5::Keychain doesn't link properly and I'm getting errors...!

• Modify the code according to comments in Revision and now 'Login with Google' button is working perfectly
• Try to add o2 as external lib

I'm getting error like TypeError: Property 'setLoginType' of object [object Object] is not a function :( in login.qml file...!

• Add button in login.qml for OAuth

Libraries at github.com/pipcas/o2 are used

Did you know this !! Google stopped OAuth for embedded webViews

Yeah, I've tried by handling browser and you can see the implementation of it in our authentication.cpp class in the first diff(https://phabricator.kde.org/D10154?id=26094) in this revision only!!

Anyway we definitely need a QWidget (like a dialog box) to take input from user from google prompt (entering google email and password) or

Yeah, I've tried it and you can see the implementation of it in our authentication.cpp class in the first diff(https://phabricator.kde.org/D10154?id=26094) in this revision only!!

Still, Login Dialog box doesn't appear on the screen :(

• using ICS libraries compiling well
• Dialog box probelm
• make modification according to comments in arc Revision

I need one more clarity that https://rocket.chat/docs/developer-guides/realtime-api/method-calls/login/ (here) under OAuth authentication section, they gave "credential_token" and "credential_secret" to pass in the method .

Try to create Webview in authenticatin class

Use ICS Qt libraries for Google OAuth API

In kdirwatch_qfswatch_unittest KDirWatch_UnitTest::benchNotifyWatcher() fails before and after changes in kdirwatch_unittest.cpp file

• Compare license file correctly

Sry for the late patch :))

• use QLating1String
• compile commenting remove_definition(DQT_NO_CAST_FROM_ASCII
• Make necessary changes according to comments in D9420
• Use QString::fromUtf8(..) to decode an escape sequence like \x21
• Merge with origin/master
• Rewrite strings using QLatin1String() and QString::fromLatin1()

Done

• use isEmpty() instead QString()

• GIT_SILENT

• Use QFileDialog

• Remove extra code

• GIT_SILENT

Modify the code for dialogBox

• change dir to ":/" from "qrc:/" in add qml file

Please kindly check, our ruqolaRegisterEngine is not initializing , were are getting errors :/ already mentioned those in prev. comments

• Add all qml files present in current dir

In cmakeLists.txt also I think there is no need to target_link_libreries link QT5::widget

I'm getting the following error when I try to log the warning in RUQOLA_LOG although it is defined in ruqola_debug.h

Write else case if engine not initialized

Check the file whether it is present in qrc:/ directory

I'm getting following errors:

Initialize ruqolaRegisterEngine

Modify the code according to commemts

• Undo the changes for qmlTestApp

• Remove () after RUQOLA_LOG in qCDebug()

Yeah, I have rebuilt it !! NO ERRORS compiling well. I'm not getting any errors like that :/

Use () for qCDebug(RUQOLA_LOG) in roomModel.cpp

currently, we are getting errors like ..

StringEncodings doc helped me to understand encoding and decoding.

• Use QString::fromUtf8(..) to decode an escape sequence like \x21

Fixed

• Fix minor errors

• write non-default test cases for data method in roomModel

rewrite QCOMPARE() properly in userTest.cpp
log the print statments in roomModel to RUQOLA_LIB through qCDebug
change the findRoom method to return nullptr if it doesn't find room!

• Add test for data in roomModel

• Fix parseUpdateRoom method in room.cpp

clarity on updateRoom(QJsonObject)

• can you please tell me exactly what updateRoom should do in roomModel.cpp?
• It should update the existing values or It should update the existing values and add new values passed through arguments.

• Modify the code

• Add more tests to user and roomModel

• Add test cases for user

• clarity on updateRoom(QJsonObject)

can you please tell me exactly what updateRoom should do in roomModel.cpp?
It should update the existing values or It should update the existing values and add new values passed through arguments.

• Change updateRoom method in roomModel and add tests for roomModel

previous updateRomm method in roomModel(QJsonObject) was changing with name, now roomId is considered for change.

• The order of the tests is in such a manner that, if in any currentTest Method another method is used that will be tested earlier to currentTest Method.

Code updated. Please let me know any changes are there yet to be done

• Make necessary changes according to comments in D9420

Use QLatin1Char for char

patch created for all the changes from starting

I'm getting errors in processtest!!

Update the code using QStringLiteral

Changes are made using QStringLiteral

• use QLating1String