Relative commit is here https://invent.kde.org/multimedia/subtitlecomposer/-/commit/4a8df2a16c929f179fe69f1c3e867c03780874c5

In T11808#283949, @ognarb wrote:

An appimage can surely be added. Just need to add an artifact to the release section: https://invent.kde.org/graphics/krita/-/blob/master/krita/org.kde.krita.appdata.xml#L604

Does this add possibility for other Linux download links too? Like AppImage url? Per distribution .deb, .rpm, .pkg.tar.*, ... ?

Initial work on replacing Kross with QJSEngine is completed in SubtitleComposer on branch here: https://invent.kde.org/multimedia/subtitlecomposer/-/tree/work/scripting.

Thanks. Have uploaded corrected files to ftp://upload.kde.org/incoming/

In T14922#264383, @nalvarez wrote:

I can't find the directory where it should be moved. Where are the previous releases?

@alex there isn't - will remove kross dependency for the next SC release.

Kross won't be ported to use QJSEngine?

What's wrong with kross?
I assume it won't be ported to use QJSEngine?

Reverted QML install path back to PREFIX/qml

• libs/qtav: moved to cmake build

In D28600#642572, @vonreth wrote:

As it looks like the install script sucks... and I expect it to just copy the binaries and some headers...
Can we just do it with our functions?

In D28545#641805, @vonreth wrote:

Well if the patch works...
Else pls motivate the maintainers if mingw to provide a new binary release.

In D28545#641749, @vonreth wrote:

I’d the fortran part used at all? Can we just disable it?

Removed useless dependency to dev-utils/mingw-w64 on lapack

Changed liblapack on windows builds to produce only static library (because libgfortran 8.1 in mingw provides only static lib and dll linking fails)
Fixed pocketsphinx/sphinxbase build to work against both static and dynamic liblapack and co.
Tested on windows mingw and linux.

In D28543#640974, @vonreth wrote:

Hm maybe put it into an if msvc?

Added isWin check

• libs/qtav: fixed windows install

Moved include/lib search paths to qmake config patch

Removed bin/ lib path on windows

In D28536#640738, @vonreth wrote:

Hm yes sounds like we should fix our ffmpeg blueprint with a post install step.

Created patch here: https://phabricator.kde.org/D28543

libs/qtav: fixed build

• openssl: fixed installation to lib64

• openssl: fixed lib/lib64 handling

In D28533#640611, @vonreth wrote:

Is the dynamic lib also in the lib64 folder?
If so we should find out how to disable that....

• openssl: fixed lib/lib64 handling

Changed streams to use text mode

@vonreth I'm done doing the changes here. Would appreciate if you can review this when you have time.

Cleaned up build script. Added correct dependencies.

replaced sed command with python regexp code

libs/sphinxbase: switched to tarball, included autogen.sh
libs/pocketsphinx: switched to tarball, included autogen.sh

In D27970#625383, @vonreth wrote:

In general we should try to use tarballs instead of unstable branches

libs/lapack: added patch origin

libs/lapack requires gfortran compiler, am not sure whether additional steps are required or if it's there by default.

Have just noticed that there is qt-libs dir. Should I create another patch and move this from libs/qtav to qt-libs/qtav?

Removed duplicate code (postInstall method)

Have added check that file exists in https://phabricator.kde.org/D25799
It still works on linux... don't know how/where to test on windows

I don't have permissions to land it

ok then... thanks for the info.
Have updated the diff.

Replaced $KDEROOT with CraftCore.standardDirs.craftRoot()

Isn't prebuilt binary package downloaded from KDE cache?
In that case will it have hardcoded craft path from those build machines?

@vonreth I can't replace second parameter $KDEROOT with CraftCore.standardDirs.craftRoot() as that will just hardcode different path.
Should I replace $KDEROOT with $(realpath "$(dirname "$0")/..") if KDEROOT is not good?

Using os.path.join and buildprefix instead of env var.

@vonreth added summary.. hope this describes the issue better.

@vonreth I believe I don't have permissions to land this patch.

oops

corrected return value

bin/icu-config had prefix variable hardcoded like this:

default_prefix="/home/appimage/Craft/BinaryCache/linux-64-gcc"