@aasthachauhan Can you make a few changes to this task:
- Update the task title as GSoC 2022( Aastha)
- Link both the activities you're going to work on as child tasks.
@aasthachauhan Can you make a few changes to this task:
@samarthraj11 Can you also link the task as a child task over here?
@timotheegiet @jjazeix As discussed we need to separate the Admin Mode with the multiple dataset mode. So, do we need to keep both the DialogChooseLevelConfig and DialogActivityConfig(this option just to select the admin mode) option?
In T13105#236799, @timotheegiet wrote:Maybe for large grids we can have 7x7 ?
Else it looks ok for me. Waiting for @echarruau 's opinion on this.
@echarruau @timotheegiet Can you please review the datasets if the the defined grid size is okay?
@timotheegiet @echarruau Please review the multiple datasets description if its all good.
@jjazeix Can you please review this diff as the application crashed issue comes only after multiple datasets to Division memory games with Tux after a fresh clone in new directory as suggested by allon, I have used the same datasets for without Tux and it works fine.
In T13125#234749, @echarruau wrote:Difficulty are ok for me.
If we would really stick to french school program we would have to put everything to 4 stars as 8 years old children have to know their multiplication tables until 10 (and division is the inverse of multiplication).
But keep it like this
1-5 (4 stars)
5-10 (5 stars)
as this allows to have two difficulties level and in real life pupils only knowi their mutiplication tables around 9-10 years old.
@timotheegiet @echarruau I have updated the description. Please review it.
In T13125#234380, @timotheegiet wrote:Difficulty levels are ok too, but let's see if @echarruau confirm it.
@timotheegiet What about the difficulty levels?
@echarruau @timotheegiet Please review the datasets description if it's fine I can go with it.
In T13122#234076, @timotheegiet wrote:I think for the dataset description, it would be better and simpler to just say "addition table of 1", "addition table of 2", .... And it would be consistent with the other activities ( same as it is for subtraction memory, for example).
In T13124#234077, @timotheegiet wrote:Actually for datasets description, for consistency I think it's better to use "multiplication table of ... " instead of just "table of ..." (same as you did for subtraction memory).
Maybe only for memory activities that mix operations we should use "table of ...".
In T13122#233743, @echarruau wrote:I agree with this dataset
In T13124#233744, @echarruau wrote:Here are my corrections
MultipleData 1: 4 star
Goal: Table of 1.
Level 1: Find equivalent cards up to 10 with multiplication of 1.MultipleData 9: 5 stars
Goal: Table of 9.
Level 1: Find equivalent cards up to 90 with multiplication of 9.
MultipleData 10: 5 stars
Goal: Table of 10.
Level 1: Find equivalent cards up to 100 with multiplication of 10.
@echarruau I have updated the diffculty levels please review it once and let me know if it's all good.
@echarruau I have updated the difficulty levels. Please review it and let me know if it's all good.
In T13122#233623, @echarruau wrote:Description is not correct, again the stars are wrong. Please change them to follow the rules I gave you.
@Supermanu Hi, Please update your diff and add the reviewers.
@timotheegiet I have updated the difficulty levels.
updated difficulty levels
In D29853#675400, @timotheegiet wrote:As explained in the task comments: change the number of stars for the datasets.
In T13123#233424, @timotheegiet wrote:@dekumar : ok, after discussing about it with @echarruau , we concluded to keep current dataset content.
But you need to change the number of stars for the datasets (I think we'll have only 4 and maybe 5 stars then).