Adding comments

But whoever made the change that made Ekos not change the state to guiding, should check to make sure that my change to make that work again doesn't break whatever that person was trying to fix. . .unfortunately I don't know who changed it, when it changed, or why it was changed. . .

One of the major fixes in this diff, the case when PHD2 starts guiding remotely and it wasn't changing the state to guiding in Ekos, used to work perfectly about a year ago after my first big round of PHD2 changes. I'm not sure exactly when it broke, but somebody must have made a change (me or somebody else) in the meantime that broke it.

Improving Translations

Improving interface for config file editor and index file downloader.
Providing details about folder permissions.
Adding dialog to ask if user really wants to download copies of index files

The three items should now be fixed

Removing unnecessary option, fixing local conf file setup, making conf editor load automatically, and consolidating conf file creation methods to one file.

Should now be default true on all systems

I changed the name as suggested

Fixing name problem

Too many graphs were on the histogram due to blue and green getting created without being deleted

Fixing a crash

Jasem said we can't use QOverload because it doesn't exist in QT 5.6

Sorry, here is the citation:

According to QT, it looks like trying to make the others work in the new style would require a syntax like this:

Fixing another one

Updating Signal-Slot to new structure

Fixing Translation concerns

Forgot an if statement

Fixing a another bug in StarProfileWidget display and a better solution for the previous issue

Fixing Preview issue

Adding a Hide Saturation Spike feature to the histogram
Also preventing moving the max/min cut sliders further out since
this does not make sense unless we can undo the cut.

Expanding histogram range just slightly to include saturation spikes

Making precision uniform in the Histogram

Making Histogram panel work better for decimals.
Removing Intensity and Frequency report and putting them in tooltips.
Improving the layout of the Histogram panel.

Fixing a build error in FitsView

Nope, I just tried, making it QWidget didn't help, and making it QWindow introduced more issues

Also note it was not QPointer before. I changed that to QPointer in the hopes that it might help, but it did not.

Fixing QPointer

Fixing issue with QSharedPointer

Assuming you were talking about his changes here of course, I might misunderstand what you mean

According to the document Yuri posted, I think he got it right. The arg method appears to be the old way to do it.

I'm still new to Phabricator so am having some troubles still. Sorry about the issues.

Taking it back since Jasem accidentally did this :-)

Fixed

Fixing Translations issues

• Using for not foreach

• Fixing text

Jasem's solution to this one worked

• Converting complex date structure into ISO 8601.

Ok guys, I think this is about done unless there is anything else. Its now much snappier and responsive due to some slight tweaks I made today

• Oops removing debug statement

• XPlanet Speed improvements

• I just found that sometimes the temp directory doesn't exist yet.

Making for the xplanet fifo if it doesn't.

• Improving responsiveness and efficiency by eliminating duplicate calls

• Making some minor XPlanet interface improvements.

Making the slider only update the view when finished scrolling,
rather than trying to update too often.
Making the value of the slider display the result in the spin box,
so the user has feedback on the position before letting go of the mouse.
Giving more ability in the time edit spinbox to set the timeshift above or below the
limits of the slider.

• Making more xplanet fixes. UInt options, case corrections, i18n, labels, fd rename, contractions, timer, qbound, fileDialog, enum, and initialization

• Updating XPlanet with Jasem's Comments: Using uint for timeout' const for string using m_ for member objects changing obj to objectIndex

• More recommended xplanet changes: changing timeout from string to int in config Making the QFutureWatcher simpler by using the signal

never mind, I see it is explained in the link

Ah, I see, that is simpler. Does it not work the other way, or is this just easier to read?