In D19591#448126, @davidre wrote:

I looked into Qt and it actually uses compression. It just falls back to quality if compression is not set. See: https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/image/qpnghandler.cpp#n1075
I did a quick test P367 and it seems to work. The question now is do we want to special case this for png to not accidentally break another format (would be a quick fix) or to enable it for all formats that support it. In my opinion if we do the latter we should now do testing (maybe automated?) to not run into weird quality/compression interactions for other formats.
@nrother Do you want to fix it for 19.04.1?

In D19591#442756, @davidre wrote:

It seems for the png implementation setQuality also sets the Compression instead of setCompression:
https://bugreports.qt.io/browse/QTBUG-43618

In D19591#442740, @cfeck wrote:

Where is the check that this is done only for lossy formats? Here, PNG is saved uncompressed after this change.

In D19591#426835, @ngraham wrote:

Now that you're familiar with how to do this, would you like to take a crack at doing the same for Gwenview?

https://bugs.kde.org/show_bug.cgi?id=277996

Adjust codestyle

Use lambda expression to update quality label so it doesn't need to be a member variable

In D19591#426725, @ngraham wrote:

Oh I see what you mean. It's very subtle. Probably an issue in Qt unfortunately. :(

...Which is good for this patch, since it means there's probably nothing we can do here. Please do file a bug though: https://bugreports.qt.io/secure/CreateIssue!default.jspa

In D19591#426704, @ngraham wrote:

I can't reproduce the washed-out image effect. Here's the same image saved four times at various different file formats and compression levels:

Add help-text for quality-slider

Adjust slider position

In D19591#426629, @davidre wrote:

Something like this (quick copy & paste job):

In D19591#426582, @davidre wrote:

I think the slider looks a bit disconnected to the file format maybe putting it below the Filename and format would work.

I'm not sure I understand where exactly you mean? I feel the current position makes sense because the other two fields are both
related to WHERE the file is saved, whereas this new option is about HOW this file is saved, so it should be separate from those two.

In D19525#426027, @ngraham wrote:

Since I know you use a dual screen setup, for your next trick would you like to have a crack at https://bugs.kde.org/show_bug.cgi?id=385885?

Adjust help-text to be more contextual and improve the new settings' description

Okay, here's the new option text:

In D19525#424877, @ngraham wrote:

Yep, that one. When accept-on-click-and-release is being used, and one of the "remember the region" modes is NOT being used, we should make the text just say something like "Click and drag to select the desired region", because everything else pertains to manipulating the region. But when accept-on-click-and-release and one of the "remember the region" modes IS being used, then we should just change "Enter, double-click:" to "Click and drag, Enter, double-click:"

Does that make sense?

In D19525#424810, @ngraham wrote:

Sweet, that was fast!

Let's make sure to update the explanatory text appropriately when this mode is being used--including in conjunction with remembered regions.

In D19515#424543, @ngraham wrote:

Only when you use the arc command-line tool to submit the patch, I'm afraid. For more information, see https://community.kde.org/Infrastructure/Phabricator#Using_Arcanist_to_post_patches

In D19515#424465, @ngraham wrote:

Thanks, this is perfect!

Can you provide your full name and email address so I can land this patch with correct authorship information?