In D20868#615357, @aacid wrote:Please move as a Merge Request in https://invent.kde.org/kde/okular
We have pre-commit CI and lots of checks including clazy and clang-tidy there so it's a much better place for doing the review/approval/merge of the code.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Sep 9 2020
Sep 9 2020
Jun 5 2020
Jun 5 2020
michaelweghorn committed R838:67344e9f52ed: FileChooser: Handle 'options' - 'choices' (authored by michaelweghorn).
FileChooser: Handle 'options' - 'choices'
Jul 25 2019
Jul 25 2019
In T11080#192988, @jglogowski wrote:IMHO most of your stuff is DE agnostic. And we implemented that with our config framework in Munich.
Jul 24 2019
Jul 24 2019
A few more thoughts on what large deployments may need or care about. Some of those have been mentioned already, some things already work just fine anyway and some others are outside of KDE scope IMHO:
Jul 19 2019
Jul 19 2019
In D9341#482119, @aacid wrote:kprinter maybe/probably/potentially does things that the qt print dialog doesn't, but yes, it'd be much better if those were upstreamed rather than having another tool you have to learn how to use besides the print dialog of apps
Jun 14 2019
Jun 14 2019
In D9341#479680, @ngraham wrote:Is this still relevant?
May 22 2019
May 22 2019
In D20197#443689, @hoffmannrobert wrote:Thanks, I've learned that QFileDialog only creates a well behaving directory chooser, if the QFileDialog::ShowDirsOnly option is set to true _after_ having set the fileMode to QFileDialog::Directory. If you do it the other way around, it doesn't add directories to the selection.
Apr 27 2019
Apr 27 2019
michaelweghorn requested review of D20868: Support '#page=<pagenum>' fragment to open at page <pagenum>.
Apr 15 2019
Apr 15 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
In D18179#450252, @ngraham wrote:OK, let's go for it!
@michaelweghorn I hope you know this means you're on the hook to fix any bugs that crop up, right? :)
Apr 4 2019
Apr 4 2019
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
Changes in this revision:
Apr 3 2019
Apr 3 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
In D18179#442948, @ngraham wrote:Never mind, removing the dependency made it work. Stupid Arc. :( Testing now...
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#442825, @ngraham wrote:Do you really not have commit access yet? You should apply. :) https://techbase.kde.org/Contribute/Get_a_Contributor_Account
Meanwhile, I'll land this for you.
michaelweghorn removed a dependent revision for D10974: Add option to ignore print margins for non-PDF generators: D18179: PDF: Implement scaling options for non-rasterized printing.
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#442598, @aacid wrote:If someone wants to test it and approve it and Michael says he'll fix any bug that arises from here i'm happy enough
Apr 2 2019
Apr 2 2019
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#442381, @ngraham wrote:I'm still not thrilled about the {nav Force Rasterization} situation (I think it should be implicitly turned on when the user chooses an option that requires it) but the combobox is good.
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
Is there anything I can still do right now or do I just need to wait for the review?
Feb 14 2019
Feb 14 2019
michaelweghorn added a comment to D18744: Add action in Edit menu to select the text on current page.
In D18744#412409, @michaelweghorn wrote:The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accordingly?
michaelweghorn added a comment to D18744: Add action in Edit menu to select the text on current page.
The test plan still says that Ctrl+P will select the page ("or press combination of CTRL and P to select the entire page"). As far as I understand the previous comments, this is Alt+P now, isn't it? (I didn't do any tests.) Can you update the description accordingly?
Feb 2 2019
Feb 2 2019
Thanks a lot! I'll take a look at these links.
(accidently closed the revision, so reopending it now)
Thanks for the super-quick review!
Feb 1 2019
Feb 1 2019
Jan 17 2019
Jan 17 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
In D18179#394712, @aacid wrote:The only way i can think of is making the long form not havve default values
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
Changes in this revision:
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#394709, @aacid wrote:I don't really have the time to spend print stuff to check if this does what it says it does, so i'm just doing code review from the pure formal way.
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
Adapted according to Albert's feedback:
Jan 16 2019
Jan 16 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
If you have any other idea on how to avoid that issue with the printFiles() methods, I'd be thankful to hear about this.
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
In D18179#394030, @aacid wrote:We would need a @since marker for the enum and for the new methods and a
// TODO merge with function above when a BIC change happens somehwere else
would also make sense
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
- Adapt order of ScaleMode enum values as implicitly suggested in Albert's comment (I missed that at first)
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
Changes in this revision:
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
Changes in this revision:
Jan 15 2019
Jan 15 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
Thanks for the feedback and info. I've update the change accordingly now.
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
Undo accidental whitespace changes
michaelweghorn updated the diff for D18179: PDF: Implement scaling options for non-rasterized printing.
Implement improvements suggested by Albert:
michaelweghorn updated the summary of D10974: Add option to ignore print margins for non-PDF generators.
michaelweghorn added inline comments to D10974: Add option to ignore print margins for non-PDF generators.
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
Adapt according to Albert's feedback:
Jan 12 2019
Jan 12 2019
michaelweghorn added a comment to D18179: PDF: Implement scaling options for non-rasterized printing.
In D18179#391664, @aacid wrote:Maybe an enum is better than a bool so if in the future more scaling options are implemented we don't need to change the signature again?
Jan 11 2019
Jan 11 2019
michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
OK, I understand. I don't have any strong opinion on this then.
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#388761, @ngraham wrote:I agree that the current UI that makes you click "Force Rasterization" first is not ideal. Kudos if you find a technically acceptable way to improve that! :)
michaelweghorn requested review of D18179: PDF: Implement scaling options for non-rasterized printing.
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
Changes in this version:
michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
In D18118#391100, @sander wrote:Do you speak for both mouse clicks and touch screen 'clicks'? Because the original wish is really only about touch screens, and the effects of this patch on mouse clicks was at least partially caused by my laziness (it's currently easier to treat them both the same).
michaelweghorn added a comment to D18118: Presentation mode: go to previous page when left-clicking on left half of the page.
I'd also prefer to leave the current behaviour of a left-click as it is, regardless of the exact position. That is also in line with what e.g. LibreOffice Impress does. Allowing to go back by doing a single-finger swipe sounds great.
Jan 8 2019
Jan 8 2019
Thanks for the explanation!
Jan 5 2019
Jan 5 2019
I find the approach interesting at least. However, I currently don't know enough of the different Poppler backends to really assess the situation properly. My thought was that it might possibly make sense to add an experimental option to enable this and https://git.reviewboard.kde.org/r/130235/ if the Arthur backend has general advantages over Splash and there was the plan to get it "production-ready". Can anybody quickly explain what the situation and plan with those backends is or is that too complex?
Jan 4 2019
Jan 4 2019
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#384499, @ngraham wrote:Is this even still necessary now that we have D7962? The new scaling combobox has an option to "Fit to full page" which ignores the margins (To respect them, you use "Fit to Printable area")
Dec 25 2018
Dec 25 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#381075, @ngraham wrote:D7962 just landed! :)
Sep 21 2018
Sep 21 2018
Thanks for your helpful feedback. Given the last comments, I agree that having text selection mode is probably not particularly useful for touch displays. I'm thus abandoning this change.
In D9336#329040, @ngraham wrote:Doesn't this make Okular much less touch-friendly by default?
Jul 20 2018
Jul 20 2018
While testing, the options did not seem to have any effect for me; changing them did not affect the printout.
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#290190, @michaelweghorn wrote:
In D7949#295165, @sander wrote:The patch should not influence the behavior of rasterized printing. The code used QPrinter with the poppler splash backend before, and it should still do that.
Jul 10 2018
Jul 10 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
@arthurpeters: Thanks for your ideas on this. For now, I'd like to stick with the two options that have been discussed so far in this change (see reasoning in D10974#217969) and suggest to handle potential further improvements separately.
In general, I really like the idea of providing this new option.
Jun 29 2018
Jun 29 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
I might have missed something, but I'm not yet sure what the "correct" wording for the two options in the radio button or combobox would be. :-)
Jun 7 2018
Jun 7 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
@aacid , @ngraham : Any chance we can reach a concensus here?
I personally don't have a strong opinion on what the best term to use in the dialog is and could live with all suggestions made so far.
Looking at the Firefox screenshot, the option "Ignore print margins and scale to full page" came to my mind in addition (which is quite long, but might be clear on what is happening?).
May 25 2018
May 25 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
I'm not really sure by myself yet, but does it help to say "print area" instead of "printable area" (i.e. "Fit to print area") to take into account that the margins being used are not necessarily the hardware margins of the printer (which define the "printable area")? Would it be clear for users what this refers to?
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#268014, @ngraham wrote:[...]
Another option is to use a radio button:Scaling: (o) None ( ) Auto-fit within printable area[...]
May 24 2018
May 24 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#267891, @aacid wrote:In D10974#267814, @michaelweghorn wrote:@aacid: What's the right way to properly indicate that an important part of this
was actually done by you (add you in the copyright, mention in the commit message,...)?Just add a line to the commit message and it's fine for me
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#267887, @ngraham wrote:From a user perspective, I'm not sure I would know what "Ignore printer margins" means. What's a printer margin? If I turn this on or off, what will happen? It's not very clear at the moment, IMHO.
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#267814, @michaelweghorn wrote:[....]
(Side note: I missed this at first, since values for the margins in the Qt print
dialog currently don't seem to be initialized with the PPD default values.)
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
Changes to previous version:
May 18 2018
May 18 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#264672, @aacid wrote:[...]
The feature it's not really "Fit to printable area", it's more "Take Margins into account" or if we negate it "Ignore printer margins", because "printable area" is the area of the page where the printer can print, but what we're doing here is ignore the printer margins, that default to the printable area but the user can change at will.What do you think?
Apr 19 2018
Apr 19 2018
Mar 9 2018
Mar 9 2018
michaelweghorn updated the test plan for D10974: Add option to ignore print margins for non-PDF generators.
michaelweghorn updated the diff for D10974: Add option to ignore print margins for non-PDF generators.
(Don't) Set margins based on QPrinter::fullPage()
Mar 4 2018
Mar 4 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In D10974#217646, @aacid wrote:so you worded point 4 and point 6 (second point 5) differently "the document is not scaled at all now." vs "The document is scaled to the full page size", i would not expect Force Rasterize to cause different behaviour.
Is it just that you wrote it differently or does Force Rasterize actually change the behaviour of "Fit to printable area"?
Mar 2 2018
Mar 2 2018
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
Once https://phabricator.kde.org/D7962 should make it to Okular, it might make sense to reconsider using the combobox for the scaling options that this adds for the PDF generator case (or how to properly merge the two approaches for the QPrinter and the lpr approaches).
michaelweghorn added a comment to D10974: Add option to ignore print margins for non-PDF generators.
In general, this option is not only relevant for the PDF generator, but (as Albert mentioned on the bug report) for all generators that use FilePrinter.
This change currently only addresses the PDF case.
michaelweghorn requested review of D10974: Add option to ignore print margins for non-PDF generators.
Jan 21 2018
Jan 21 2018
As mentioned in https://bugs.kde.org/show_bug.cgi?id=389224#c2 , there is the following new commit for Purpose that should fix the build when the "old" name is used for the dependency: https://cgit.kde.org/purpose.git/commit/?id=20a304236100b29014403a894cbda2d93ab28e41
Dec 16 2017
Dec 16 2017
michaelweghorn added a comment to D9328: Add support for cancellable image rendering and text extraction.
In D9328#179915, @aacid wrote:@michaelweghorn can you give it a try with the new version of the patch? This should make it better.
Dec 15 2017
Dec 15 2017
michaelweghorn added a comment to D9328: Add support for cancellable image rendering and text extraction.
I tested this a bit and find it really nice that rendering of the actual page (rather than the thumbnail) usually starts at once when re-rendering is needed (e.g. when zoom level is changed).
Also, closing Okular now works fast, even if rendering is still in progress. (The shell prompt is shown almost immediately after closing Okular when it was started from the command line.)
The 2 suggested improvements are now implemented.
Rename to "kprinter5", update includes
Dec 14 2017
Dec 14 2017
Dec 6 2017
Dec 6 2017
michaelweghorn added a comment to T4151: Finish and merge the dont-use-docdata-for-annots-and-forms branch.
In T4151#116690, @aacid wrote:
Nov 13 2017
Nov 13 2017
In D8642#167020, @aacid wrote:In D8642#165611, @michaelweghorn wrote:Open pdf file, add anotation, close app
You get dialog about losing changes, check that save, discard, cancel all do what they sayThis works as described. One additional thought on that:
Some users may want to save the modified version to a new file instead of overwriting the existing one. While this is already possible via "File" -> "Save As" (or Ctrl+Shift+S), I think it might be helpful to add an additional button "Save as" in that dialog as well. This would also help avoid users accidently overwriting the original file. (Evince, for example only offers a "Save As" option and users switching between the two programs might not be aware of the difference at once.)I disagree, does libreoffice suggest "Save As" when you do open an existing file, do some changes and close the app? Do you know of any program that does offer "Save As" in that situation?
Nov 8 2017
Nov 8 2017
Open pdf file, add anotation, close app
You get dialog about losing changes, check that save, discard, cancel all do what they say
Oct 17 2017
Oct 17 2017
In D7949#154764, @sander wrote:Background: [...] and we plan to have some features implemented in the print dialog (for Qt/Okular).
Can I learn more about this somewhere?
Oct 12 2017
Oct 12 2017
In D7949#154351, @sander wrote:large filesize (5x), because of letters being vectors instead of fontsYeah, I know about this one. There's nothing really do be done about this on the Okular side, this is Qt's doing.
On the other hand one could argue that this is what "printing to a file" actually means: you lose all semantic
information like letters, annotations, tags, etc.