V0.5. Combobox is expanded. MiddleEmulation string is changed.

V0.4. Combobox is always visible. Combobox manual resizing is removed.

Tapping strings are changed. Natural scrolling string is added. If there is only 1 touchpad, device combobox set to insvisible. ScrollablePage is changed with Page.

In D13141#269989, @ngraham wrote:

Here's another idea for the multi-tapping radio button to reduce the string length:

Two-finger tap: (o) Right-click (three-finger tap to middle-click)
                ( ) Middle-click (three-finger tap to right-click)

Elegant! I was looking for something like this. Done :)

In D13141#269402, @ngraham wrote:

Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html

So until and unless we can change Libinput itself, this has to stay as a radio button.

"NoScroll" setting is removed. Feedbacks are applied.

In D13141#269312, @esedgh wrote:

Sorry guys I'm not sure if this is the appropriate place to report this as I'm not involved in the development.

But now that you're at it, I may give you a bit of feedback in here.

Touchpad settings has "Two Finger Scrolling" and "Edge Scrolling" as a radio button: You can choose only one.

But why? I'm used to having both enabled. Is that not doable in the new stack?

@romangg There are some "TODO"s in the code. Please tell me if they still need to be applied so I'll do them, if they are not, I'll remove them.

In D13141#268853, @ngraham wrote:

Is the user-facing control for the click method (areas or clickfinger) going to come in a separate patch? It might make sense to add that feature first and then we can do all the UI review in a single patch.

Yes it'll be nice to having the feature with this patch. I'll implement it.

Comment correction.

.qrc file is cancelled.

resources.qrc is creator for better Qt Creator integration and explicit definition of resource files. workspaceoptions.cpp/.h are reformatted according to phab feedback. Save and load function are seperated to different functions. It is easier to manipulate now and the code is more clear. Comments are reformatted. Tested and everything works fine.

Comment correction.

State variable names are changed. Some formatting improvements.

In D12974#264920, @ngraham wrote:

While we're doing some formatting and style cleanup work, how about renaming some variables? For example m_ostateToolTip and m_ostateVisualFeedback aren't very descriptive IMHO. Maybe instead, they could be m_currentToolTipState and m_currentVisualFeedbackState.

Workspace KCM is redesigned by using Kirigami.

QDBus is reorganized. Implementation is clear now.

Qml padding added. Some small fixes.

QDBus is organized.

Single/Double click implementation is done. Tested. Everything
is working fine.

Bug fixed about checkbox check states.

kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and workspaceoptions.h to preserve the git history better.

kcm.cpp and kcm.h files are renamed as workspaceoptions.cpp and workspaceoptions.h to preserve the git history better.

Bracked style correction. Removed translation data in ".desktop" files.

In D12936#263969, @ngraham wrote:

Please follow standard KDE style for braces in new code:

void myFunction() {
    int stuff = 1;
}

Rewrite workspace KCM in QtQuick

In D12936#263939, @ngraham wrote:

In D12936#263907, @furkantokac wrote:

In D12936#263886, @davidedmundson wrote:

Can you change the title to something more specific.

There will be other options so that time it will make more sense I think (see the ss). Maybe we can change it to "General Workspace Settings". If you have any suggestion, you're welcome.

David meant the title of the patch, not the title of the KCM. :)

In D12936#263894, @ngraham wrote:

BTW, here are a couple of formatting rules you should follow: https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch